[INFO] crate capnp-futures 0.9.0 is already in cache [INFO] extracting crate capnp-futures 0.9.0 into work/ex/clippy-test-run/sources/stable/reg/capnp-futures/0.9.0 [INFO] extracting crate capnp-futures 0.9.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/capnp-futures/0.9.0 [INFO] validating manifest of capnp-futures-0.9.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of capnp-futures-0.9.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing capnp-futures-0.9.0 [INFO] finished frobbing capnp-futures-0.9.0 [INFO] frobbed toml for capnp-futures-0.9.0 written to work/ex/clippy-test-run/sources/stable/reg/capnp-futures/0.9.0/Cargo.toml [INFO] started frobbing capnp-futures-0.9.0 [INFO] finished frobbing capnp-futures-0.9.0 [INFO] frobbed toml for capnp-futures-0.9.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/capnp-futures/0.9.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting capnp-futures-0.9.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/capnp-futures/0.9.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6b67c474e6285f4c1f4ab2915e00b75a68ad88c8233fa7e8a1a7df8ae86794bd [INFO] running `"docker" "start" "-a" "6b67c474e6285f4c1f4ab2915e00b75a68ad88c8233fa7e8a1a7df8ae86794bd"` [INFO] [stderr] Checking capnp v0.9.4 [INFO] [stderr] Checking capnp-futures v0.9.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:174:33 [INFO] [stderr] | [INFO] [stderr] 174 | segment_count: segment_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:175:33 [INFO] [stderr] | [INFO] [stderr] 175 | first_segment_length: first_segment_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `first_segment_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:197:29 [INFO] [stderr] | [INFO] [stderr] 197 | segment_slices: segment_slices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_slices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:368:52 [INFO] [stderr] | [INFO] [stderr] 368 | InnerWriteState::OneWordSegmentTable { buf: buf, idx: 0 } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:371:60 [INFO] [stderr] | [INFO] [stderr] 371 | InnerWriteState::MoreThanOneWordSegmentTable { buf: buf, idx: 0 } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:458:13 [INFO] [stderr] | [INFO] [stderr] 458 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:459:13 [INFO] [stderr] | [INFO] [stderr] 459 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:460:13 [INFO] [stderr] | [INFO] [stderr] 460 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:499:13 [INFO] [stderr] | [INFO] [stderr] 499 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:500:13 [INFO] [stderr] | [INFO] [stderr] 500 | read_options: read_options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `read_options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:761:28 [INFO] [stderr] | [INFO] [stderr] 761 | BlockingRead { read: read, frequency: frequency, idx: 0 } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `read` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:761:40 [INFO] [stderr] | [INFO] [stderr] 761 | BlockingRead { read: read, frequency: frequency, idx: 0 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frequency` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:793:29 [INFO] [stderr] | [INFO] [stderr] 793 | BlockingWrite { writer: writer, frequency: frequency, idx: 0 } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:793:45 [INFO] [stderr] | [INFO] [stderr] 793 | BlockingWrite { writer: writer, frequency: frequency, idx: 0 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frequency` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/read_stream.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/write_queue.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:174:33 [INFO] [stderr] | [INFO] [stderr] 174 | segment_count: segment_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:175:33 [INFO] [stderr] | [INFO] [stderr] 175 | first_segment_length: first_segment_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `first_segment_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:197:29 [INFO] [stderr] | [INFO] [stderr] 197 | segment_slices: segment_slices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_slices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:368:52 [INFO] [stderr] | [INFO] [stderr] 368 | InnerWriteState::OneWordSegmentTable { buf: buf, idx: 0 } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:371:60 [INFO] [stderr] | [INFO] [stderr] 371 | InnerWriteState::MoreThanOneWordSegmentTable { buf: buf, idx: 0 } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:458:13 [INFO] [stderr] | [INFO] [stderr] 458 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:459:13 [INFO] [stderr] | [INFO] [stderr] 459 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:460:13 [INFO] [stderr] | [INFO] [stderr] 460 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:499:13 [INFO] [stderr] | [INFO] [stderr] 499 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:500:13 [INFO] [stderr] | [INFO] [stderr] 500 | read_options: read_options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `read_options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:761:28 [INFO] [stderr] | [INFO] [stderr] 761 | BlockingRead { read: read, frequency: frequency, idx: 0 } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `read` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:761:40 [INFO] [stderr] | [INFO] [stderr] 761 | BlockingRead { read: read, frequency: frequency, idx: 0 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frequency` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:793:29 [INFO] [stderr] | [INFO] [stderr] 793 | BlockingWrite { writer: writer, frequency: frequency, idx: 0 } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:793:45 [INFO] [stderr] | [INFO] [stderr] 793 | BlockingWrite { writer: writer, frequency: frequency, idx: 0 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frequency` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/read_stream.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/write_queue.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | return Ok(idx) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(idx)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | return Ok(idx) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize.rs:242:17 [INFO] [stderr] | [INFO] [stderr] 242 | / return Ok(Async::Ready(( [INFO] [stderr] 243 | | read, [INFO] [stderr] 244 | | result.map(|(words, slices)| { [INFO] [stderr] 245 | | message::Reader::new( [INFO] [stderr] ... | [INFO] [stderr] 249 | | }, [INFO] [stderr] 250 | | options)})))) [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 242 | Ok(Async::Ready(( [INFO] [stderr] 243 | read, [INFO] [stderr] 244 | result.map(|(words, slices)| { [INFO] [stderr] 245 | message::Reader::new( [INFO] [stderr] 246 | OwnedSegments { [INFO] [stderr] 247 | segment_slices: slices, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | return Ok(idx) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(idx)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | return Ok(idx) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize.rs:242:17 [INFO] [stderr] | [INFO] [stderr] 242 | / return Ok(Async::Ready(( [INFO] [stderr] 243 | | read, [INFO] [stderr] 244 | | result.map(|(words, slices)| { [INFO] [stderr] 245 | | message::Reader::new( [INFO] [stderr] ... | [INFO] [stderr] 249 | | }, [INFO] [stderr] 250 | | options)})))) [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 242 | Ok(Async::Ready(( [INFO] [stderr] 243 | read, [INFO] [stderr] 244 | result.map(|(words, slices)| { [INFO] [stderr] 245 | message::Reader::new( [INFO] [stderr] 246 | OwnedSegments { [INFO] [stderr] 247 | segment_slices: slices, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/serialize.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | / fn get_segment<'a>(&'a self, id: u32) -> Option<&'a [Word]> { [INFO] [stderr] 41 | | if id < self.segment_slices.len() as u32 { [INFO] [stderr] 42 | | let (a, b) = self.segment_slices[id as usize]; [INFO] [stderr] 43 | | Some(&self.owned_space[a..b]) [INFO] [stderr] ... | [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/serialize.rs:149:26 [INFO] [stderr] | [INFO] [stderr] 149 | -> Result, Vec<(usize, usize)>)>>> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serialize.rs:229:22 [INFO] [stderr] | [INFO] [stderr] 229 | let result = match &mut self.state { [INFO] [stderr] | ______________________^ [INFO] [stderr] 230 | | &mut ReadState::Empty => { [INFO] [stderr] 231 | | return Err(Error::failed("tried to read empty ReadState".to_string())) [INFO] [stderr] 232 | | } [INFO] [stderr] ... | [INFO] [stderr] 235 | | } [INFO] [stderr] 236 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 229 | let result = match *(&mut self.state) { [INFO] [stderr] 230 | ReadState::Empty => { [INFO] [stderr] 231 | return Err(Error::failed("tried to read empty ReadState".to_string())) [INFO] [stderr] 232 | } [INFO] [stderr] 233 | ReadState::Reading { ref mut read, ref options, ref mut inner } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/serialize.rs:430:5 [INFO] [stderr] | [INFO] [stderr] 430 | fn as_output_segments<'a>(&'a self) -> OutputSegments<'a>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/serialize.rs:434:5 [INFO] [stderr] | [INFO] [stderr] 434 | / fn as_output_segments<'a>(&'a self) -> OutputSegments<'a> { [INFO] [stderr] 435 | | self.get_segments_for_output() [INFO] [stderr] 436 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/serialize.rs:440:5 [INFO] [stderr] | [INFO] [stderr] 440 | / fn as_output_segments<'b>(&'b self) -> OutputSegments<'b> { [INFO] [stderr] 441 | | self.get_segments_for_output() [INFO] [stderr] 442 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/serialize.rs:446:5 [INFO] [stderr] | [INFO] [stderr] 446 | / fn as_output_segments<'a>(&'a self) -> OutputSegments<'a> { [INFO] [stderr] 447 | | self.get_segments_for_output() [INFO] [stderr] 448 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/serialize.rs:533:9 [INFO] [stderr] | [INFO] [stderr] 533 | / match self.write_state { [INFO] [stderr] 534 | | Some((ref mut m, ref mut state)) => { [INFO] [stderr] 535 | | match try!(state.write_helper(&mut self.stream, m)) { [INFO] [stderr] 536 | | Async::NotReady => return Ok(AsyncSink::NotReady(item)), [INFO] [stderr] ... | [INFO] [stderr] 540 | | None => (), [INFO] [stderr] 541 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 533 | if let Some((ref mut m, ref mut state)) = self.write_state { [INFO] [stderr] 534 | match try!(state.write_helper(&mut self.stream, m)) { [INFO] [stderr] 535 | Async::NotReady => return Ok(AsyncSink::NotReady(item)), [INFO] [stderr] 536 | Async::Ready(()) => (), [INFO] [stderr] 537 | } [INFO] [stderr] 538 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: item `write_queue::Sender` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/write_queue.rs:106:1 [INFO] [stderr] | [INFO] [stderr] 106 | / impl Sender where M: AsOutputSegments + 'static { [INFO] [stderr] 107 | | /// Enqueues a message to be written. [INFO] [stderr] 108 | | pub fn send(&mut self, message: M) -> Box> { [INFO] [stderr] 109 | | let (complete, oneshot) = oneshot::channel(); [INFO] [stderr] ... | [INFO] [stderr] 163 | | } [INFO] [stderr] 164 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/write_queue.rs:120:17 [INFO] [stderr] | [INFO] [stderr] 120 | / match rc_inner.borrow_mut().task.take() { [INFO] [stderr] 121 | | Some(t) => t.notify(), [INFO] [stderr] 122 | | None => (), [INFO] [stderr] 123 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Some(t) = rc_inner.borrow_mut().task.take() { t.notify() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/write_queue.rs:153:17 [INFO] [stderr] | [INFO] [stderr] 153 | / match rc_inner.borrow_mut().task.take() { [INFO] [stderr] 154 | | Some(t) => t.notify(), [INFO] [stderr] 155 | | None => (), [INFO] [stderr] 156 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Some(t) = rc_inner.borrow_mut().task.take() { t.notify() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/serialize.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | / fn get_segment<'a>(&'a self, id: u32) -> Option<&'a [Word]> { [INFO] [stderr] 41 | | if id < self.segment_slices.len() as u32 { [INFO] [stderr] 42 | | let (a, b) = self.segment_slices[id as usize]; [INFO] [stderr] 43 | | Some(&self.owned_space[a..b]) [INFO] [stderr] ... | [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/serialize.rs:149:26 [INFO] [stderr] | [INFO] [stderr] 149 | -> Result, Vec<(usize, usize)>)>>> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serialize.rs:229:22 [INFO] [stderr] | [INFO] [stderr] 229 | let result = match &mut self.state { [INFO] [stderr] | ______________________^ [INFO] [stderr] 230 | | &mut ReadState::Empty => { [INFO] [stderr] 231 | | return Err(Error::failed("tried to read empty ReadState".to_string())) [INFO] [stderr] 232 | | } [INFO] [stderr] ... | [INFO] [stderr] 235 | | } [INFO] [stderr] 236 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 229 | let result = match *(&mut self.state) { [INFO] [stderr] 230 | ReadState::Empty => { [INFO] [stderr] 231 | return Err(Error::failed("tried to read empty ReadState".to_string())) [INFO] [stderr] 232 | } [INFO] [stderr] 233 | ReadState::Reading { ref mut read, ref options, ref mut inner } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/serialize.rs:430:5 [INFO] [stderr] | [INFO] [stderr] 430 | fn as_output_segments<'a>(&'a self) -> OutputSegments<'a>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/serialize.rs:434:5 [INFO] [stderr] | [INFO] [stderr] 434 | / fn as_output_segments<'a>(&'a self) -> OutputSegments<'a> { [INFO] [stderr] 435 | | self.get_segments_for_output() [INFO] [stderr] 436 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/serialize.rs:440:5 [INFO] [stderr] | [INFO] [stderr] 440 | / fn as_output_segments<'b>(&'b self) -> OutputSegments<'b> { [INFO] [stderr] 441 | | self.get_segments_for_output() [INFO] [stderr] 442 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/serialize.rs:446:5 [INFO] [stderr] | [INFO] [stderr] 446 | / fn as_output_segments<'a>(&'a self) -> OutputSegments<'a> { [INFO] [stderr] 447 | | self.get_segments_for_output() [INFO] [stderr] 448 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/serialize.rs:533:9 [INFO] [stderr] | [INFO] [stderr] 533 | / match self.write_state { [INFO] [stderr] 534 | | Some((ref mut m, ref mut state)) => { [INFO] [stderr] 535 | | match try!(state.write_helper(&mut self.stream, m)) { [INFO] [stderr] 536 | | Async::NotReady => return Ok(AsyncSink::NotReady(item)), [INFO] [stderr] ... | [INFO] [stderr] 540 | | None => (), [INFO] [stderr] 541 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 533 | if let Some((ref mut m, ref mut state)) = self.write_state { [INFO] [stderr] 534 | match try!(state.write_helper(&mut self.stream, m)) { [INFO] [stderr] 535 | Async::NotReady => return Ok(AsyncSink::NotReady(item)), [INFO] [stderr] 536 | Async::Ready(()) => (), [INFO] [stderr] 537 | } [INFO] [stderr] 538 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/serialize.rs:734:9 [INFO] [stderr] | [INFO] [stderr] 734 | / fn as_output_segments<'a>(&'a self) -> OutputSegments<'a> { [INFO] [stderr] 735 | | if self.len() == 0 { [INFO] [stderr] 736 | | OutputSegments::SingleSegment([&[]]) [INFO] [stderr] 737 | | } else if self.len() == 1 { [INFO] [stderr] ... | [INFO] [stderr] 743 | | } [INFO] [stderr] 744 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/serialize.rs:735:16 [INFO] [stderr] | [INFO] [stderr] 735 | if self.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/serialize.rs:821:16 [INFO] [stderr] | [INFO] [stderr] 821 | if segments.len() == 0 || read_block_frequency == 0 || write_block_frequency == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `segments.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: item `write_queue::Sender` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/write_queue.rs:106:1 [INFO] [stderr] | [INFO] [stderr] 106 | / impl Sender where M: AsOutputSegments + 'static { [INFO] [stderr] 107 | | /// Enqueues a message to be written. [INFO] [stderr] 108 | | pub fn send(&mut self, message: M) -> Box> { [INFO] [stderr] 109 | | let (complete, oneshot) = oneshot::channel(); [INFO] [stderr] ... | [INFO] [stderr] 163 | | } [INFO] [stderr] 164 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/write_queue.rs:120:17 [INFO] [stderr] | [INFO] [stderr] 120 | / match rc_inner.borrow_mut().task.take() { [INFO] [stderr] 121 | | Some(t) => t.notify(), [INFO] [stderr] 122 | | None => (), [INFO] [stderr] 123 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Some(t) = rc_inner.borrow_mut().task.take() { t.notify() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/write_queue.rs:153:17 [INFO] [stderr] | [INFO] [stderr] 153 | / match rc_inner.borrow_mut().task.take() { [INFO] [stderr] 154 | | Some(t) => t.notify(), [INFO] [stderr] 155 | | None => (), [INFO] [stderr] 156 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Some(t) = rc_inner.borrow_mut().task.take() { t.notify() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.79s [INFO] running `"docker" "inspect" "6b67c474e6285f4c1f4ab2915e00b75a68ad88c8233fa7e8a1a7df8ae86794bd"` [INFO] running `"docker" "rm" "-f" "6b67c474e6285f4c1f4ab2915e00b75a68ad88c8233fa7e8a1a7df8ae86794bd"` [INFO] [stdout] 6b67c474e6285f4c1f4ab2915e00b75a68ad88c8233fa7e8a1a7df8ae86794bd