[INFO] crate capnp 0.9.3 is already in cache [INFO] extracting crate capnp 0.9.3 into work/ex/clippy-test-run/sources/stable/reg/capnp/0.9.3 [INFO] extracting crate capnp 0.9.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/capnp/0.9.3 [INFO] validating manifest of capnp-0.9.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of capnp-0.9.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing capnp-0.9.3 [INFO] finished frobbing capnp-0.9.3 [INFO] frobbed toml for capnp-0.9.3 written to work/ex/clippy-test-run/sources/stable/reg/capnp/0.9.3/Cargo.toml [INFO] started frobbing capnp-0.9.3 [INFO] finished frobbing capnp-0.9.3 [INFO] frobbed toml for capnp-0.9.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/capnp/0.9.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting capnp-0.9.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/capnp/0.9.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fd34756d02eddec75e6bc8657c93de9b7b4b1eb9aa06bbfa1611309cff627457 [INFO] running `"docker" "start" "-a" "fd34756d02eddec75e6bc8657c93de9b7b4b1eb9aa06bbfa1611309cff627457"` [INFO] [stderr] Checking capnp v0.9.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/any_pointer.rs:50:18 [INFO] [stderr] | [INFO] [stderr] 50 | Reader { reader: reader } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/any_pointer.rs:117:19 [INFO] [stderr] | [INFO] [stderr] 117 | Builder { builder: builder } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `builder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/any_pointer.rs:176:19 [INFO] [stderr] | [INFO] [stderr] 176 | Builder { builder: builder } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `builder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/any_pointer.rs:179:22 [INFO] [stderr] | [INFO] [stderr] 179 | Ok(Builder { builder: builder }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `builder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/any_pointer.rs:198:20 [INFO] [stderr] | [INFO] [stderr] 198 | Pipeline { hook: hook, ops: Vec::new() } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hook` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/capability.rs:108:41 [INFO] [stderr] | [INFO] [stderr] 108 | Response { marker: PhantomData, hook: hook } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hook` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/capability.rs:125:19 [INFO] [stderr] | [INFO] [stderr] 125 | Request { hook: hook, marker: PhantomData } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hook` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/capability.rs:162:39 [INFO] [stderr] | [INFO] [stderr] 162 | Params { marker: PhantomData, hook: hook } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hook` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/capability.rs:181:40 [INFO] [stderr] | [INFO] [stderr] 181 | Results { marker: PhantomData, hook: hook } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hook` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/capability.rs:209:18 [INFO] [stderr] | [INFO] [stderr] 209 | Client { hook : hook } [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `hook` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/capability_list.rs:55:27 [INFO] [stderr] | [INFO] [stderr] 55 | Reader::<'b, T> { reader : reader, marker : PhantomData } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/capability_list.rs:99:19 [INFO] [stderr] | [INFO] [stderr] 99 | Builder { builder: builder, marker: PhantomData } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `builder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data_list.rs:43:18 [INFO] [stderr] | [INFO] [stderr] 43 | Reader { reader: reader } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data_list.rs:79:19 [INFO] [stderr] | [INFO] [stderr] 79 | Builder { builder: builder } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `builder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/enum_list.rs:49:27 [INFO] [stderr] | [INFO] [stderr] 49 | Reader::<'b, T> { reader: reader, marker: PhantomData } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/enum_list.rs:88:19 [INFO] [stderr] | [INFO] [stderr] 88 | Builder { builder: builder, marker: PhantomData } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `builder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/list_list.rs:45:27 [INFO] [stderr] | [INFO] [stderr] 45 | Reader::<'b, T> { reader: reader, marker: ::std::marker::PhantomData } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/list_list.rs:90:19 [INFO] [stderr] | [INFO] [stderr] 90 | Builder { builder: builder, marker: ::std::marker::PhantomData } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `builder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message.rs:112:24 [INFO] [stderr] | [INFO] [stderr] 112 | SegmentArray { segments: segments } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `segments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message.rs:224:13 [INFO] [stderr] | [INFO] [stderr] 224 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message.rs:449:24 [INFO] [stderr] | [INFO] [stderr] 449 | ScratchSpace { slice: slice, in_use: false } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `slice` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message.rs:460:37 [INFO] [stderr] | [INFO] [stderr] 460 | ScratchSpaceHeapAllocator { scratch_space: scratch_space, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `scratch_space` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/primitive_list.rs:49:27 [INFO] [stderr] | [INFO] [stderr] 49 | Reader::<'b, T> { reader: reader, marker: marker::PhantomData } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/primitive_list.rs:87:19 [INFO] [stderr] | [INFO] [stderr] 87 | Builder { builder: builder, marker: marker::PhantomData } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `builder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/arena.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | segments: segments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `segments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/arena.rs:156:17 [INFO] [stderr] | [INFO] [stderr] 156 | allocator: allocator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `allocator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:844:13 [INFO] [stderr] | [INFO] [stderr] 844 | arena: arena, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arena` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:845:13 [INFO] [stderr] | [INFO] [stderr] 845 | segment_id: segment_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:846:13 [INFO] [stderr] | [INFO] [stderr] 846 | cap_table: cap_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cap_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:913:17 [INFO] [stderr] | [INFO] [stderr] 913 | arena: arena, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arena` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:914:17 [INFO] [stderr] | [INFO] [stderr] 914 | segment_id: segment_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:915:17 [INFO] [stderr] | [INFO] [stderr] 915 | cap_table: cap_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cap_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:923:17 [INFO] [stderr] | [INFO] [stderr] 923 | arena: arena, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arena` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:925:17 [INFO] [stderr] | [INFO] [stderr] 925 | cap_table: cap_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cap_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:955:13 [INFO] [stderr] | [INFO] [stderr] 955 | arena: arena, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arena` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:956:13 [INFO] [stderr] | [INFO] [stderr] 956 | segment_id: segment_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:957:13 [INFO] [stderr] | [INFO] [stderr] 957 | cap_table: cap_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cap_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:959:13 [INFO] [stderr] | [INFO] [stderr] 959 | step: step, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `step` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:960:13 [INFO] [stderr] | [INFO] [stderr] 960 | element_count: element_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `element_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:961:13 [INFO] [stderr] | [INFO] [stderr] 961 | element_size: element_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `element_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:995:13 [INFO] [stderr] | [INFO] [stderr] 995 | arena: arena, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arena` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:996:13 [INFO] [stderr] | [INFO] [stderr] 996 | segment_id: segment_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:997:13 [INFO] [stderr] | [INFO] [stderr] 997 | cap_table: cap_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cap_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1000:13 [INFO] [stderr] | [INFO] [stderr] 1000 | element_count: element_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `element_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1090:17 [INFO] [stderr] | [INFO] [stderr] 1090 | arena: arena, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arena` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1091:17 [INFO] [stderr] | [INFO] [stderr] 1091 | segment_id: segment_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1092:17 [INFO] [stderr] | [INFO] [stderr] 1092 | cap_table: cap_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cap_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1113:17 [INFO] [stderr] | [INFO] [stderr] 1113 | arena: arena, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arena` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1114:17 [INFO] [stderr] | [INFO] [stderr] 1114 | segment_id: segment_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1115:17 [INFO] [stderr] | [INFO] [stderr] 1115 | cap_table: cap_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cap_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1117:17 [INFO] [stderr] | [INFO] [stderr] 1117 | step: step, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `step` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1174:21 [INFO] [stderr] | [INFO] [stderr] 1174 | arena: arena, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arena` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1176:21 [INFO] [stderr] | [INFO] [stderr] 1176 | cap_table: cap_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cap_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1178:21 [INFO] [stderr] | [INFO] [stderr] 1178 | element_count: element_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `element_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1230:17 [INFO] [stderr] | [INFO] [stderr] 1230 | arena: arena, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arena` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1232:17 [INFO] [stderr] | [INFO] [stderr] 1232 | cap_table: cap_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cap_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1234:17 [INFO] [stderr] | [INFO] [stderr] 1234 | element_count: element_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `element_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1311:21 [INFO] [stderr] | [INFO] [stderr] 1311 | arena: arena, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arena` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1313:21 [INFO] [stderr] | [INFO] [stderr] 1313 | cap_table: cap_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cap_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1315:21 [INFO] [stderr] | [INFO] [stderr] 1315 | element_count: element_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `element_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1343:13 [INFO] [stderr] | [INFO] [stderr] 1343 | segment_id: segment_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1416:22 [INFO] [stderr] | [INFO] [stderr] 1416 | SegmentAnd { segment_id: segment_id, value: data::new_builder(ptr as *mut _, size) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1534:25 [INFO] [stderr] | [INFO] [stderr] 1534 | Ok(SegmentAnd { segment_id: segment_id, value: ptr }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1606:29 [INFO] [stderr] | [INFO] [stderr] 1606 | Ok(SegmentAnd { segment_id: segment_id, value: ptr }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1675:29 [INFO] [stderr] | [INFO] [stderr] 1675 | Ok(SegmentAnd { segment_id: segment_id, value: ptr }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1765:29 [INFO] [stderr] | [INFO] [stderr] 1765 | element_count: element_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `element_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1766:29 [INFO] [stderr] | [INFO] [stderr] 1766 | element_size: element_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `element_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1798:29 [INFO] [stderr] | [INFO] [stderr] 1798 | element_count: element_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `element_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1799:29 [INFO] [stderr] | [INFO] [stderr] 1799 | element_size: element_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `element_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1800:29 [INFO] [stderr] | [INFO] [stderr] 1800 | step: step, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `step` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1868:13 [INFO] [stderr] | [INFO] [stderr] 1868 | arena: arena, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arena` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1869:13 [INFO] [stderr] | [INFO] [stderr] 1869 | segment_id: segment_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1870:13 [INFO] [stderr] | [INFO] [stderr] 1870 | cap_table: cap_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cap_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1997:21 [INFO] [stderr] | [INFO] [stderr] 1997 | arena: arena, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arena` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1998:21 [INFO] [stderr] | [INFO] [stderr] 1998 | segment_id: segment_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1999:21 [INFO] [stderr] | [INFO] [stderr] 1999 | cap_table: cap_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cap_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:2002:21 [INFO] [stderr] | [INFO] [stderr] 2002 | element_size: element_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `element_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:2051:21 [INFO] [stderr] | [INFO] [stderr] 2051 | arena: arena, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arena` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:2052:21 [INFO] [stderr] | [INFO] [stderr] 2052 | segment_id: segment_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:2053:21 [INFO] [stderr] | [INFO] [stderr] 2053 | cap_table: cap_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cap_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:2055:21 [INFO] [stderr] | [INFO] [stderr] 2055 | element_count: element_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `element_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:2056:21 [INFO] [stderr] | [INFO] [stderr] 2056 | element_size: element_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `element_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:2057:21 [INFO] [stderr] | [INFO] [stderr] 2057 | step: step, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `step` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:2280:13 [INFO] [stderr] | [INFO] [stderr] 2280 | arena: arena, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arena` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:2281:13 [INFO] [stderr] | [INFO] [stderr] 2281 | segment_id: segment_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:2284:13 [INFO] [stderr] | [INFO] [stderr] 2284 | nesting_limit: nesting_limit, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `nesting_limit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:2442:13 [INFO] [stderr] | [INFO] [stderr] 2442 | arena: arena, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arena` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:2444:13 [INFO] [stderr] | [INFO] [stderr] 2444 | segment_id: segment_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:66:49 [INFO] [stderr] | [INFO] [stderr] 66 | Ok(message::Reader::new(SliceSegments { words: words, segment_slices: offsets }, options)) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `words` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:170:35 [INFO] [stderr] | [INFO] [stderr] 170 | let segments = OwnedSegments {segment_slices: segment_slices, owned_space: owned_space}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_slices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:170:67 [INFO] [stderr] | [INFO] [stderr] 170 | let segments = OwnedSegments {segment_slices: segment_slices, owned_space: owned_space}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `owned_space` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/struct_list.rs:56:27 [INFO] [stderr] | [INFO] [stderr] 56 | Reader::<'b, T> { reader : reader, marker : PhantomData } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/struct_list.rs:100:19 [INFO] [stderr] | [INFO] [stderr] 100 | Builder { builder: builder, marker: PhantomData } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `builder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:65:22 [INFO] [stderr] | [INFO] [stderr] 65 | Ok(Builder { bytes: bytes, pos: pos as usize }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text_list.rs:43:24 [INFO] [stderr] | [INFO] [stderr] 43 | Reader::<'b> { reader : reader } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text_list.rs:79:19 [INFO] [stderr] | [INFO] [stderr] 79 | Builder { builder : builder } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `builder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/traits.rs:123:20 [INFO] [stderr] | [INFO] [stderr] 123 | ListIter { list: list, index: 0, size: size, marker: PhantomData } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `list` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/traits.rs:123:42 [INFO] [stderr] | [INFO] [stderr] 123 | ListIter { list: list, index: 0, size: size, marker: PhantomData } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:220:17 [INFO] [stderr] | [INFO] [stderr] 220 | Error { description: description, kind: ErrorKind::Failed } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:223:17 [INFO] [stderr] | [INFO] [stderr] 223 | Error { description: description, kind: ErrorKind::Overloaded } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:226:17 [INFO] [stderr] | [INFO] [stderr] 226 | Error { description: description, kind: ErrorKind::Disconnected } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:229:17 [INFO] [stderr] | [INFO] [stderr] 229 | Error { description: description, kind: ErrorKind::Unimplemented } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:245:50 [INFO] [stderr] | [INFO] [stderr] 245 | Error { description: format!("{}", err), kind: kind } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/any_pointer.rs:50:18 [INFO] [stderr] | [INFO] [stderr] 50 | Reader { reader: reader } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/any_pointer.rs:117:19 [INFO] [stderr] | [INFO] [stderr] 117 | Builder { builder: builder } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `builder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/any_pointer.rs:176:19 [INFO] [stderr] | [INFO] [stderr] 176 | Builder { builder: builder } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `builder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/any_pointer.rs:179:22 [INFO] [stderr] | [INFO] [stderr] 179 | Ok(Builder { builder: builder }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `builder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/any_pointer.rs:198:20 [INFO] [stderr] | [INFO] [stderr] 198 | Pipeline { hook: hook, ops: Vec::new() } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hook` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/capability.rs:108:41 [INFO] [stderr] | [INFO] [stderr] 108 | Response { marker: PhantomData, hook: hook } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hook` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/capability.rs:125:19 [INFO] [stderr] | [INFO] [stderr] 125 | Request { hook: hook, marker: PhantomData } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hook` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/capability.rs:162:39 [INFO] [stderr] | [INFO] [stderr] 162 | Params { marker: PhantomData, hook: hook } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hook` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/capability.rs:181:40 [INFO] [stderr] | [INFO] [stderr] 181 | Results { marker: PhantomData, hook: hook } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hook` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/capability.rs:209:18 [INFO] [stderr] | [INFO] [stderr] 209 | Client { hook : hook } [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `hook` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/capability_list.rs:55:27 [INFO] [stderr] | [INFO] [stderr] 55 | Reader::<'b, T> { reader : reader, marker : PhantomData } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/capability_list.rs:99:19 [INFO] [stderr] | [INFO] [stderr] 99 | Builder { builder: builder, marker: PhantomData } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `builder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data_list.rs:43:18 [INFO] [stderr] | [INFO] [stderr] 43 | Reader { reader: reader } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data_list.rs:79:19 [INFO] [stderr] | [INFO] [stderr] 79 | Builder { builder: builder } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `builder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/enum_list.rs:49:27 [INFO] [stderr] | [INFO] [stderr] 49 | Reader::<'b, T> { reader: reader, marker: PhantomData } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/enum_list.rs:88:19 [INFO] [stderr] | [INFO] [stderr] 88 | Builder { builder: builder, marker: PhantomData } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `builder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/list_list.rs:45:27 [INFO] [stderr] | [INFO] [stderr] 45 | Reader::<'b, T> { reader: reader, marker: ::std::marker::PhantomData } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/list_list.rs:90:19 [INFO] [stderr] | [INFO] [stderr] 90 | Builder { builder: builder, marker: ::std::marker::PhantomData } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `builder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message.rs:112:24 [INFO] [stderr] | [INFO] [stderr] 112 | SegmentArray { segments: segments } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `segments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message.rs:224:13 [INFO] [stderr] | [INFO] [stderr] 224 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message.rs:449:24 [INFO] [stderr] | [INFO] [stderr] 449 | ScratchSpace { slice: slice, in_use: false } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `slice` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message.rs:460:37 [INFO] [stderr] | [INFO] [stderr] 460 | ScratchSpaceHeapAllocator { scratch_space: scratch_space, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `scratch_space` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/primitive_list.rs:49:27 [INFO] [stderr] | [INFO] [stderr] 49 | Reader::<'b, T> { reader: reader, marker: marker::PhantomData } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/primitive_list.rs:87:19 [INFO] [stderr] | [INFO] [stderr] 87 | Builder { builder: builder, marker: marker::PhantomData } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `builder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/arena.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | segments: segments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `segments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/arena.rs:156:17 [INFO] [stderr] | [INFO] [stderr] 156 | allocator: allocator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `allocator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:844:13 [INFO] [stderr] | [INFO] [stderr] 844 | arena: arena, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arena` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:845:13 [INFO] [stderr] | [INFO] [stderr] 845 | segment_id: segment_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:846:13 [INFO] [stderr] | [INFO] [stderr] 846 | cap_table: cap_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cap_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:913:17 [INFO] [stderr] | [INFO] [stderr] 913 | arena: arena, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arena` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:914:17 [INFO] [stderr] | [INFO] [stderr] 914 | segment_id: segment_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:915:17 [INFO] [stderr] | [INFO] [stderr] 915 | cap_table: cap_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cap_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:923:17 [INFO] [stderr] | [INFO] [stderr] 923 | arena: arena, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arena` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:925:17 [INFO] [stderr] | [INFO] [stderr] 925 | cap_table: cap_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cap_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:955:13 [INFO] [stderr] | [INFO] [stderr] 955 | arena: arena, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arena` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:956:13 [INFO] [stderr] | [INFO] [stderr] 956 | segment_id: segment_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:957:13 [INFO] [stderr] | [INFO] [stderr] 957 | cap_table: cap_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cap_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:959:13 [INFO] [stderr] | [INFO] [stderr] 959 | step: step, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `step` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:960:13 [INFO] [stderr] | [INFO] [stderr] 960 | element_count: element_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `element_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:961:13 [INFO] [stderr] | [INFO] [stderr] 961 | element_size: element_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `element_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:995:13 [INFO] [stderr] | [INFO] [stderr] 995 | arena: arena, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arena` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:996:13 [INFO] [stderr] | [INFO] [stderr] 996 | segment_id: segment_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:997:13 [INFO] [stderr] | [INFO] [stderr] 997 | cap_table: cap_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cap_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1000:13 [INFO] [stderr] | [INFO] [stderr] 1000 | element_count: element_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `element_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1090:17 [INFO] [stderr] | [INFO] [stderr] 1090 | arena: arena, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arena` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1091:17 [INFO] [stderr] | [INFO] [stderr] 1091 | segment_id: segment_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1092:17 [INFO] [stderr] | [INFO] [stderr] 1092 | cap_table: cap_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cap_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1113:17 [INFO] [stderr] | [INFO] [stderr] 1113 | arena: arena, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arena` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1114:17 [INFO] [stderr] | [INFO] [stderr] 1114 | segment_id: segment_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1115:17 [INFO] [stderr] | [INFO] [stderr] 1115 | cap_table: cap_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cap_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1117:17 [INFO] [stderr] | [INFO] [stderr] 1117 | step: step, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `step` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1174:21 [INFO] [stderr] | [INFO] [stderr] 1174 | arena: arena, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arena` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1176:21 [INFO] [stderr] | [INFO] [stderr] 1176 | cap_table: cap_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cap_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1178:21 [INFO] [stderr] | [INFO] [stderr] 1178 | element_count: element_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `element_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1230:17 [INFO] [stderr] | [INFO] [stderr] 1230 | arena: arena, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arena` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1232:17 [INFO] [stderr] | [INFO] [stderr] 1232 | cap_table: cap_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cap_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1234:17 [INFO] [stderr] | [INFO] [stderr] 1234 | element_count: element_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `element_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1311:21 [INFO] [stderr] | [INFO] [stderr] 1311 | arena: arena, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arena` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1313:21 [INFO] [stderr] | [INFO] [stderr] 1313 | cap_table: cap_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cap_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1315:21 [INFO] [stderr] | [INFO] [stderr] 1315 | element_count: element_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `element_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1343:13 [INFO] [stderr] | [INFO] [stderr] 1343 | segment_id: segment_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1416:22 [INFO] [stderr] | [INFO] [stderr] 1416 | SegmentAnd { segment_id: segment_id, value: data::new_builder(ptr as *mut _, size) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1534:25 [INFO] [stderr] | [INFO] [stderr] 1534 | Ok(SegmentAnd { segment_id: segment_id, value: ptr }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1606:29 [INFO] [stderr] | [INFO] [stderr] 1606 | Ok(SegmentAnd { segment_id: segment_id, value: ptr }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1675:29 [INFO] [stderr] | [INFO] [stderr] 1675 | Ok(SegmentAnd { segment_id: segment_id, value: ptr }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1765:29 [INFO] [stderr] | [INFO] [stderr] 1765 | element_count: element_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `element_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1766:29 [INFO] [stderr] | [INFO] [stderr] 1766 | element_size: element_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `element_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1798:29 [INFO] [stderr] | [INFO] [stderr] 1798 | element_count: element_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `element_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1799:29 [INFO] [stderr] | [INFO] [stderr] 1799 | element_size: element_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `element_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1800:29 [INFO] [stderr] | [INFO] [stderr] 1800 | step: step, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `step` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1868:13 [INFO] [stderr] | [INFO] [stderr] 1868 | arena: arena, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arena` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1869:13 [INFO] [stderr] | [INFO] [stderr] 1869 | segment_id: segment_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1870:13 [INFO] [stderr] | [INFO] [stderr] 1870 | cap_table: cap_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cap_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1997:21 [INFO] [stderr] | [INFO] [stderr] 1997 | arena: arena, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arena` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1998:21 [INFO] [stderr] | [INFO] [stderr] 1998 | segment_id: segment_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:1999:21 [INFO] [stderr] | [INFO] [stderr] 1999 | cap_table: cap_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cap_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:2002:21 [INFO] [stderr] | [INFO] [stderr] 2002 | element_size: element_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `element_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:2051:21 [INFO] [stderr] | [INFO] [stderr] 2051 | arena: arena, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arena` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:2052:21 [INFO] [stderr] | [INFO] [stderr] 2052 | segment_id: segment_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:2053:21 [INFO] [stderr] | [INFO] [stderr] 2053 | cap_table: cap_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cap_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:2055:21 [INFO] [stderr] | [INFO] [stderr] 2055 | element_count: element_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `element_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:2056:21 [INFO] [stderr] | [INFO] [stderr] 2056 | element_size: element_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `element_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:2057:21 [INFO] [stderr] | [INFO] [stderr] 2057 | step: step, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `step` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:2280:13 [INFO] [stderr] | [INFO] [stderr] 2280 | arena: arena, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arena` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:2281:13 [INFO] [stderr] | [INFO] [stderr] 2281 | segment_id: segment_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:2284:13 [INFO] [stderr] | [INFO] [stderr] 2284 | nesting_limit: nesting_limit, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `nesting_limit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:2442:13 [INFO] [stderr] | [INFO] [stderr] 2442 | arena: arena, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arena` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/layout.rs:2444:13 [INFO] [stderr] | [INFO] [stderr] 2444 | segment_id: segment_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:66:49 [INFO] [stderr] | [INFO] [stderr] 66 | Ok(message::Reader::new(SliceSegments { words: words, segment_slices: offsets }, options)) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `words` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:170:35 [INFO] [stderr] | [INFO] [stderr] 170 | let segments = OwnedSegments {segment_slices: segment_slices, owned_space: owned_space}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_slices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize.rs:170:67 [INFO] [stderr] | [INFO] [stderr] 170 | let segments = OwnedSegments {segment_slices: segment_slices, owned_space: owned_space}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `owned_space` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/struct_list.rs:56:27 [INFO] [stderr] | [INFO] [stderr] 56 | Reader::<'b, T> { reader : reader, marker : PhantomData } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/struct_list.rs:100:19 [INFO] [stderr] | [INFO] [stderr] 100 | Builder { builder: builder, marker: PhantomData } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `builder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:65:22 [INFO] [stderr] | [INFO] [stderr] 65 | Ok(Builder { bytes: bytes, pos: pos as usize }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text_list.rs:43:24 [INFO] [stderr] | [INFO] [stderr] 43 | Reader::<'b> { reader : reader } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text_list.rs:79:19 [INFO] [stderr] | [INFO] [stderr] 79 | Builder { builder : builder } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `builder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/traits.rs:123:20 [INFO] [stderr] | [INFO] [stderr] 123 | ListIter { list: list, index: 0, size: size, marker: PhantomData } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `list` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/traits.rs:123:42 [INFO] [stderr] | [INFO] [stderr] 123 | ListIter { list: list, index: 0, size: size, marker: PhantomData } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:220:17 [INFO] [stderr] | [INFO] [stderr] 220 | Error { description: description, kind: ErrorKind::Failed } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:223:17 [INFO] [stderr] | [INFO] [stderr] 223 | Error { description: description, kind: ErrorKind::Overloaded } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:226:17 [INFO] [stderr] | [INFO] [stderr] 226 | Error { description: description, kind: ErrorKind::Disconnected } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:229:17 [INFO] [stderr] | [INFO] [stderr] 229 | Error { description: description, kind: ErrorKind::Unimplemented } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:245:50 [INFO] [stderr] | [INFO] [stderr] 245 | Error { description: format!("{}", err), kind: kind } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/message.rs:337:59 [INFO] [stderr] | [INFO] [stderr] 337 | self.arena.as_reader(), 0, segment_start, 0x7fffffff)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/private/layout.rs:196:34 [INFO] [stderr] | [INFO] [stderr] 196 | self.offset_and_kind.set(0xfffffffc); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fffc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/private/layout.rs:235:35 [INFO] [stderr] | [INFO] [stderr] 235 | (self.upper32bits.get() & 0xffffffff) as WordCount16 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/private/layout.rs:2267:28 [INFO] [stderr] | [INFO] [stderr] 2267 | nesting_limit: 0x7fffffff } [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/private/layout.rs:2298:28 [INFO] [stderr] | [INFO] [stderr] 2298 | nesting_limit: 0x7fffffff } [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/private/layout.rs:2624:28 [INFO] [stderr] | [INFO] [stderr] 2624 | nesting_limit: 0x7fffffff [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/private/layout.rs:2651:28 [INFO] [stderr] | [INFO] [stderr] 2651 | nesting_limit: 0x7fffffff} [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/private/layout.rs:2820:28 [INFO] [stderr] | [INFO] [stderr] 2820 | nesting_limit: 0x7fffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/private/layout.rs:2991:28 [INFO] [stderr] | [INFO] [stderr] 2991 | nesting_limit: 0x7fffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/private/layout.rs:3181:28 [INFO] [stderr] | [INFO] [stderr] 3181 | nesting_limit: 0x7fffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/private/layout.rs:3306:56 [INFO] [stderr] | [INFO] [stderr] 3306 | fn get(_list: &ListReader, _index: ElementCount32) -> () { () } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/private/layout.rs:3306:64 [INFO] [stderr] | [INFO] [stderr] 3306 | fn get(_list: &ListReader, _index: ElementCount32) -> () { () } [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/private/layout.rs:3309:70 [INFO] [stderr] | [INFO] [stderr] 3309 | fn get_from_builder(_list: &ListBuilder, _index: ElementCount32) -> () { () } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/private/layout.rs:3309:78 [INFO] [stderr] | [INFO] [stderr] 3309 | fn get_from_builder(_list: &ListBuilder, _index: ElementCount32) -> () { () } [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/any_pointer.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / pub fn new<'b>(reader: PointerReader<'b>) -> Reader<'b> { [INFO] [stderr] 50 | | Reader { reader: reader } [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/any_pointer.rs:116:16 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn new<'b>(builder: PointerBuilder<'a>) -> Builder<'a> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/any_pointer.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | / pub fn reborrow<'b>(&'b mut self) -> Builder<'b> { [INFO] [stderr] 121 | | Builder { builder: self.builder.borrow() } [INFO] [stderr] 122 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/any_pointer.rs:161:22 [INFO] [stderr] | [INFO] [stderr] 161 | pub fn as_reader(self) -> Reader<'a> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/message.rs:337:59 [INFO] [stderr] | [INFO] [stderr] 337 | self.arena.as_reader(), 0, segment_start, 0x7fffffff)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/capability.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | / pub fn get<'a>(&'a mut self) -> >::Builder { [INFO] [stderr] 129 | | self.hook.get().get_as().unwrap() [INFO] [stderr] 130 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/capability.rs:184:5 [INFO] [stderr] | [INFO] [stderr] 184 | / pub fn get<'a>(&'a mut self) -> >::Builder { [INFO] [stderr] 185 | | self.hook.get().unwrap().get_as().unwrap() [INFO] [stderr] 186 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/private/layout.rs:196:34 [INFO] [stderr] | [INFO] [stderr] 196 | self.offset_and_kind.set(0xfffffffc); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fffc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: item `capability_list::Reader<'a, T>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/capability_list.rs:53:1 [INFO] [stderr] | [INFO] [stderr] 53 | / impl <'a, T> Reader<'a, T> where T: FromClientHook { [INFO] [stderr] 54 | | pub fn new<'b>(reader : ListReader<'b>) -> Reader<'b, T> { [INFO] [stderr] 55 | | Reader::<'b, T> { reader : reader, marker : PhantomData } [INFO] [stderr] 56 | | } [INFO] [stderr] ... | [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] [INFO] [stderr] --> src/private/layout.rs:235:35 [INFO] [stderr] | [INFO] [stderr] 235 | (self.upper32bits.get() & 0xffffffff) as WordCount16 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/capability_list.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | / pub fn reborrow<'b>(&'b self) -> Reader<'b, T> { [INFO] [stderr] 68 | | Reader { reader: self.reader, marker: PhantomData } [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: item `capability_list::Builder<'a, T>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/capability_list.rs:97:1 [INFO] [stderr] | [INFO] [stderr] 97 | / impl <'a, T> Builder<'a, T> where T: FromClientHook { [INFO] [stderr] 98 | | pub fn new(builder : ListBuilder<'a>) -> Builder<'a, T> { [INFO] [stderr] 99 | | Builder { builder: builder, marker: PhantomData } [INFO] [stderr] 100 | | } [INFO] [stderr] ... | [INFO] [stderr] 119 | | } [INFO] [stderr] 120 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/capability_list.rs:105:22 [INFO] [stderr] | [INFO] [stderr] 105 | pub fn as_reader(self) -> Reader<'a, T> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/capability_list.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | / pub fn reborrow<'b>(&'b mut self) -> Builder<'b, T> { [INFO] [stderr] 124 | | Builder { builder: self.builder, marker: PhantomData } [INFO] [stderr] 125 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/data.rs:38:43 [INFO] [stderr] | [INFO] [stderr] 38 | unsafe { ::std::slice::from_raw_parts(p, len as usize) } [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/data.rs:50:47 [INFO] [stderr] | [INFO] [stderr] 50 | unsafe { ::std::slice::from_raw_parts_mut(p, len as usize) } [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: item `data_list::Reader<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/data_list.rs:41:1 [INFO] [stderr] | [INFO] [stderr] 41 | / impl <'a> Reader<'a> { [INFO] [stderr] 42 | | pub fn new<'b>(reader: ListReader<'b>) -> Reader<'b> { [INFO] [stderr] 43 | | Reader { reader: reader } [INFO] [stderr] 44 | | } [INFO] [stderr] ... | [INFO] [stderr] 51 | | } [INFO] [stderr] 52 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/data_list.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / pub fn new<'b>(reader: ListReader<'b>) -> Reader<'b> { [INFO] [stderr] 43 | | Reader { reader: reader } [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: item `data_list::Builder<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/data_list.rs:77:1 [INFO] [stderr] | [INFO] [stderr] 77 | / impl <'a> Builder<'a> { [INFO] [stderr] 78 | | pub fn new(builder: ListBuilder<'a>) -> Builder<'a> { [INFO] [stderr] 79 | | Builder { builder: builder } [INFO] [stderr] 80 | | } [INFO] [stderr] ... | [INFO] [stderr] 100 | | } [INFO] [stderr] 101 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/private/layout.rs:2267:28 [INFO] [stderr] | [INFO] [stderr] 2267 | nesting_limit: 0x7fffffff } [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/private/layout.rs:2298:28 [INFO] [stderr] | [INFO] [stderr] 2298 | nesting_limit: 0x7fffffff } [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/data_list.rs:85:22 [INFO] [stderr] | [INFO] [stderr] 85 | pub fn as_reader(self) -> Reader<'a> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/data_list.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | / pub fn reborrow<'b>(&'b mut self) -> Builder<'b> { [INFO] [stderr] 99 | | Builder {builder: self.builder.borrow()} [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/private/layout.rs:2624:28 [INFO] [stderr] | [INFO] [stderr] 2624 | nesting_limit: 0x7fffffff [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/private/layout.rs:2651:28 [INFO] [stderr] | [INFO] [stderr] 2651 | nesting_limit: 0x7fffffff} [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/private/layout.rs:2820:28 [INFO] [stderr] | [INFO] [stderr] 2820 | nesting_limit: 0x7fffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/private/layout.rs:2991:28 [INFO] [stderr] | [INFO] [stderr] 2991 | nesting_limit: 0x7fffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: item `enum_list::Reader<'a, T>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/enum_list.rs:47:1 [INFO] [stderr] | [INFO] [stderr] 47 | / impl <'a, T: FromU16> Reader<'a, T> { [INFO] [stderr] 48 | | pub fn new<'b>(reader: ListReader<'b>) -> Reader<'b, T> { [INFO] [stderr] 49 | | Reader::<'b, T> { reader: reader, marker: PhantomData } [INFO] [stderr] 50 | | } [INFO] [stderr] ... | [INFO] [stderr] 57 | | } [INFO] [stderr] 58 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/private/layout.rs:3181:28 [INFO] [stderr] | [INFO] [stderr] 3181 | nesting_limit: 0x7fffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/private/layout.rs:3306:56 [INFO] [stderr] | [INFO] [stderr] 3306 | fn get(_list: &ListReader, _index: ElementCount32) -> () { () } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/private/layout.rs:3306:64 [INFO] [stderr] | [INFO] [stderr] 3306 | fn get(_list: &ListReader, _index: ElementCount32) -> () { () } [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/private/layout.rs:3309:70 [INFO] [stderr] | [INFO] [stderr] 3309 | fn get_from_builder(_list: &ListBuilder, _index: ElementCount32) -> () { () } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/private/layout.rs:3309:78 [INFO] [stderr] | [INFO] [stderr] 3309 | fn get_from_builder(_list: &ListBuilder, _index: ElementCount32) -> () { () } [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/private/layout_test.rs:35:16 [INFO] [stderr] | [INFO] [stderr] 35 | assert_eq!(0xefcdab8967452301u64, reader.get_data_field::(0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0xefcd_ab89_6745_2301u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/private/layout_test.rs:38:16 [INFO] [stderr] | [INFO] [stderr] 38 | assert_eq!(0x67452301u32, reader.get_data_field::(0)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x6745_2301u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/private/layout_test.rs:39:16 [INFO] [stderr] | [INFO] [stderr] 39 | assert_eq!(0xefcdab89u32, reader.get_data_field::(1)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xefcd_ab89u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: item `enum_list::Builder<'a, T>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/enum_list.rs:86:1 [INFO] [stderr] | [INFO] [stderr] 86 | / impl <'a, T : ToU16 + FromU16> Builder<'a, T> { [INFO] [stderr] 87 | | pub fn new(builder: ListBuilder<'a>) -> Builder<'a, T> { [INFO] [stderr] 88 | | Builder { builder: builder, marker: PhantomData } [INFO] [stderr] 89 | | } [INFO] [stderr] ... | [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/enum_list.rs:94:22 [INFO] [stderr] | [INFO] [stderr] 94 | pub fn as_reader(self) -> Reader<'a, T> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/enum_list.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | / pub fn reborrow<'b>(&'b self) -> Builder<'b, T> { [INFO] [stderr] 127 | | Builder { .. *self } [INFO] [stderr] 128 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: item `list_list::Reader<'a, T>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/list_list.rs:43:1 [INFO] [stderr] | [INFO] [stderr] 43 | / impl <'a, T> Reader<'a, T> where T: for<'b> ::traits::Owned<'b> { [INFO] [stderr] 44 | | pub fn new<'b>(reader: ListReader<'b>) -> Reader<'b, T> { [INFO] [stderr] 45 | | Reader::<'b, T> { reader: reader, marker: ::std::marker::PhantomData } [INFO] [stderr] 46 | | } [INFO] [stderr] ... | [INFO] [stderr] 51 | | } [INFO] [stderr] 52 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `list_list::Builder<'a, T>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/list_list.rs:88:1 [INFO] [stderr] | [INFO] [stderr] 88 | / impl <'a, T> Builder<'a, T> where T: for<'b> ::traits::Owned<'b> { [INFO] [stderr] 89 | | pub fn new(builder: ListBuilder<'a>) -> Builder<'a, T> { [INFO] [stderr] 90 | | Builder { builder: builder, marker: ::std::marker::PhantomData } [INFO] [stderr] 91 | | } [INFO] [stderr] ... | [INFO] [stderr] 102 | | } [INFO] [stderr] 103 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/list_list.rs:96:22 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn as_reader(self) -> Reader<'a, T> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/list_list.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | / pub fn reborrow<'b>(&'b mut self) -> Builder<'b, T> { [INFO] [stderr] 113 | | Builder {builder: self.builder.borrow(), marker: ::std::marker::PhantomData} [INFO] [stderr] 114 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/message.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | / pub fn nesting_limit<'a>(&'a mut self, value: i32) -> &'a mut ReaderOptions { [INFO] [stderr] 79 | | self.nesting_limit = value; [INFO] [stderr] 80 | | self [INFO] [stderr] 81 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/message.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | / pub fn traversal_limit_in_words<'a>(&'a mut self, value: u64) -> &'a mut ReaderOptions { [INFO] [stderr] 84 | | self.traversal_limit_in_words = value; [INFO] [stderr] 85 | | self [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: trait `ReaderSegments` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stderr] --> src/message.rs:90:1 [INFO] [stderr] | [INFO] [stderr] 90 | / pub trait ReaderSegments { [INFO] [stderr] 91 | | /// Gets the segment with index `idx`. Returns `None` if `idx` is out of range. [INFO] [stderr] 92 | | fn get_segment<'a>(&'a self, idx: u32) -> Option<&'a [Word]>; [INFO] [stderr] 93 | | [INFO] [stderr] ... | [INFO] [stderr] 102 | | } [INFO] [stderr] 103 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/message.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | fn get_segment<'a>(&'a self, idx: u32) -> Option<&'a [Word]>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/message.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | / fn get_segment<'a>(&'a self, id: u32) -> Option<&'a [Word]> { [INFO] [stderr] 118 | | self.segments.get(id as usize).map(|slice| *slice) [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/message.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | self.segments.get(id as usize).map(|slice| *slice) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.segments.get(id as usize).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/message.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | / fn get_segment<'a>(&'a self, id: u32) -> Option<&'a[Word]> { [INFO] [stderr] 128 | | self.get(id as usize).map(|slice| *slice) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/message.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | self.get(id as usize).map(|slice| *slice) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.get(id as usize).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/message.rs:306:5 [INFO] [stderr] | [INFO] [stderr] 306 | / fn get_root_internal<'a>(&'a mut self) -> any_pointer::Builder<'a> { [INFO] [stderr] 307 | | if self.arena.len() == 0 { [INFO] [stderr] 308 | | self.arena.allocate_segment(1).expect("allocate root pointer"); [INFO] [stderr] 309 | | self.arena.allocate(0, 1).expect("allocate root pointer"); [INFO] [stderr] ... | [INFO] [stderr] 316 | | layout::PointerBuilder::get_root(arena, 0, location)) [INFO] [stderr] 317 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/message.rs:364:5 [INFO] [stderr] | [INFO] [stderr] 364 | / pub fn get_segments_for_output<'a>(&'a self) -> OutputSegments<'a> { [INFO] [stderr] 365 | | self.arena.get_segments_for_output() [INFO] [stderr] 366 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/message.rs:377:5 [INFO] [stderr] | [INFO] [stderr] 377 | / fn get_segment<'a>(&'a self, id: u32) -> Option<&'a [Word]> { [INFO] [stderr] 378 | | self.get_segments_for_output().get(id as usize).map(|x| *x) [INFO] [stderr] 379 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/message.rs:378:9 [INFO] [stderr] | [INFO] [stderr] 378 | self.get_segments_for_output().get(id as usize).map(|x| *x) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.get_segments_for_output().get(id as usize).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `message::HeapAllocator` [INFO] [stderr] --> src/message.rs:403:5 [INFO] [stderr] | [INFO] [stderr] 403 | / pub fn new() -> HeapAllocator { [INFO] [stderr] 404 | | HeapAllocator { owned_memory: Vec::new(), [INFO] [stderr] 405 | | next_size: SUGGESTED_FIRST_SEGMENT_WORDS, [INFO] [stderr] 406 | | allocation_strategy: SUGGESTED_ALLOCATION_STRATEGY } [INFO] [stderr] 407 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 402 | impl Default for message::HeapAllocator { [INFO] [stderr] 403 | fn default() -> Self { [INFO] [stderr] 404 | Self::new() [INFO] [stderr] 405 | } [INFO] [stderr] 406 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/message.rs:427:9 [INFO] [stderr] | [INFO] [stderr] 427 | / match self.allocation_strategy { [INFO] [stderr] 428 | | AllocationStrategy::GrowHeuristically => { self.next_size += size; } [INFO] [stderr] 429 | | _ => { } [INFO] [stderr] 430 | | } [INFO] [stderr] | |_________^ help: try this: `if let AllocationStrategy::GrowHeuristically = self.allocation_strategy { self.next_size += size; }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: item `primitive_list::Reader<'a, T>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/primitive_list.rs:47:1 [INFO] [stderr] | [INFO] [stderr] 47 | / impl <'a, T: PrimitiveElement> Reader<'a, T> { [INFO] [stderr] 48 | | pub fn new<'b>(reader: ListReader<'b>) -> Reader<'b, T> { [INFO] [stderr] 49 | | Reader::<'b, T> { reader: reader, marker: marker::PhantomData } [INFO] [stderr] 50 | | } [INFO] [stderr] ... | [INFO] [stderr] 57 | | } [INFO] [stderr] 58 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `primitive_list::Builder<'a, T>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/primitive_list.rs:85:1 [INFO] [stderr] | [INFO] [stderr] 85 | / impl <'a, T> Builder<'a, T> where T: PrimitiveElement { [INFO] [stderr] 86 | | pub fn new(builder: ListBuilder<'a>) -> Builder<'a, T> { [INFO] [stderr] 87 | | Builder { builder: builder, marker: marker::PhantomData } [INFO] [stderr] 88 | | } [INFO] [stderr] ... | [INFO] [stderr] 106 | | } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/primitive_list.rs:93:22 [INFO] [stderr] | [INFO] [stderr] 93 | pub fn as_reader(self) -> Reader<'a, T> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/primitive_list.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | / pub fn reborrow<'b>(&'b self) -> Builder<'b, T> { [INFO] [stderr] 127 | | Builder { .. *self } [INFO] [stderr] 128 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/private/arena.rs:45:31 [INFO] [stderr] | [INFO] [stderr] 45 | Err(Error::failed(format!("read limit exceeded"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"read limit exceeded".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/private/arena.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | / fn get_segment<'a>(&'a self, id: u32) -> Result<(*const Word, u32)> { [INFO] [stderr] 88 | | match self.segments.get_segment(id) { [INFO] [stderr] 89 | | Some(seg) => Ok((seg.as_ptr(), seg.len() as u32)), [INFO] [stderr] 90 | | None => Err(Error::failed(format!("Invalid segment id: {}", id))), [INFO] [stderr] 91 | | } [INFO] [stderr] 92 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/private/arena.rs:103:25 [INFO] [stderr] | [INFO] [stderr] 103 | unsafe { Ok(start.offset(offset_in_words as isize)) } [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/private/arena.rs:98:27 [INFO] [stderr] | [INFO] [stderr] 98 | let offset: i64 = offset_in_words as i64 * BYTES_PER_WORD as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(offset_in_words)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/private/arena.rs:101:31 [INFO] [stderr] | [INFO] [stderr] 101 | Err(Error::failed(format!("message contained out-of-bounds pointer"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"message contained out-of-bounds pointer".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/private/arena.rs:115:31 [INFO] [stderr] | [INFO] [stderr] 115 | Err(Error::failed(format!("message contained out-of-bounds pointer"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"message contained out-of-bounds pointer".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/private/arena.rs:137:5 [INFO] [stderr] | [INFO] [stderr] 137 | fn as_reader<'a>(&'a self) -> &'a ReaderArena; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: item `private::arena::BuilderArenaImpl` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/private/arena.rs:152:1 [INFO] [stderr] | [INFO] [stderr] 152 | / impl BuilderArenaImpl where A: Allocator { [INFO] [stderr] 153 | | pub fn new(allocator: A) -> Self { [INFO] [stderr] 154 | | BuilderArenaImpl { [INFO] [stderr] 155 | | inner: RefCell::new(BuilderArenaImplInner { [INFO] [stderr] ... | [INFO] [stderr] 192 | | } [INFO] [stderr] 193 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/private/arena.rs:167:5 [INFO] [stderr] | [INFO] [stderr] 167 | / pub fn get_segments_for_output<'a>(&'a self) -> OutputSegments<'a> { [INFO] [stderr] 168 | | let reff = self.inner.borrow(); [INFO] [stderr] 169 | | if reff.allocated.len() == 1 { [INFO] [stderr] 170 | | let seg = reff.segments[0]; [INFO] [stderr] ... | [INFO] [stderr] 187 | | } [INFO] [stderr] 188 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/private/arena.rs:203:21 [INFO] [stderr] | [INFO] [stderr] 203 | unsafe { Ok(start.offset(offset_in_words as isize)) } [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/private/arena.rs:237:13 [INFO] [stderr] | [INFO] [stderr] 237 | / match self.allocate(segment_id, amount) { [INFO] [stderr] 238 | | Some(idx) => return (segment_id, idx), [INFO] [stderr] 239 | | None => (), [INFO] [stderr] 240 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(idx) = self.allocate(segment_id, amount) { return (segment_id, idx) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/private/arena.rs:269:5 [INFO] [stderr] | [INFO] [stderr] 269 | / fn as_reader<'a>(&'a self) -> &'a ReaderArena { [INFO] [stderr] 270 | | self [INFO] [stderr] 271 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/private/arena.rs:276:12 [INFO] [stderr] | [INFO] [stderr] 276 | if self.allocated.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.allocated.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/private/arena.rs:286:27 [INFO] [stderr] | [INFO] [stderr] 286 | Err(Error::failed(format!("tried to read from null arena"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"tried to read from null arena".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/private/arena.rs:290:21 [INFO] [stderr] | [INFO] [stderr] 290 | unsafe { Ok(start.offset(offset_in_words as isize)) } [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/private/arena.rs:315:5 [INFO] [stderr] | [INFO] [stderr] 315 | / fn as_reader<'a>(&'a self) -> &'a ReaderArena { [INFO] [stderr] 316 | | self [INFO] [stderr] 317 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/private/capability.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | fn get<'a>(&'a mut self) -> any_pointer::Builder<'a>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/private/capability.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | fn send<'a>(self: Box) -> RemotePromise; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/private/capability.rs:35:21 [INFO] [stderr] | [INFO] [stderr] 35 | -> Option<(u32, ::capability::Promise<(), ::Error>, Box)>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/private/endian.rs:87:18 [INFO] [stderr] | [INFO] [stderr] 87 | unsafe { mem::transmute(mem::transmute::(*self).to_le()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(mem::transmute::(*self).to_le())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_float)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/private/endian.rs:90:26 [INFO] [stderr] | [INFO] [stderr] 90 | *self = unsafe { mem::transmute(mem::transmute::(value).to_le()) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(mem::transmute::(value).to_le())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u64` to a `f64` [INFO] [stderr] --> src/private/endian.rs:96:18 [INFO] [stderr] | [INFO] [stderr] 96 | unsafe { mem::transmute(mem::transmute::(*self).to_le()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits(mem::transmute::(*self).to_le())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u64` to a `f64` [INFO] [stderr] --> src/private/endian.rs:99:26 [INFO] [stderr] | [INFO] [stderr] 99 | *self = unsafe { mem::transmute(mem::transmute::(value).to_le()) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits(mem::transmute::(value).to_le())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/private/layout.rs:94:18 [INFO] [stderr] | [INFO] [stderr] 94 | pub fn total(&self) -> WordCount32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | self.data as WordCount32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:96:15 [INFO] [stderr] | [INFO] [stderr] 96 | + self.pointers as WordCount32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.pointers)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: casting from `*const private::layout::WirePointer` to a more-strictly-aligned pointer (`*const Word`) [INFO] [stderr] --> src/private/layout.rs:154:38 [INFO] [stderr] | [INFO] [stderr] 154 | let this_addr: *const Word = self as *const _ as *const _; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const private::layout::WirePointer` to a more-strictly-aligned pointer (`*const Word`) [INFO] [stderr] --> src/private/layout.rs:160:38 [INFO] [stderr] | [INFO] [stderr] 160 | let this_addr: *const Word = self as *const _ as *const _; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut private::layout::WirePointer` to a more-strictly-aligned pointer (`*mut Word`) [INFO] [stderr] --> src/private/layout.rs:167:36 [INFO] [stderr] | [INFO] [stderr] 167 | let this_addr: *mut Word = self as *mut _ as *mut _; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `self.upper32bits.get()` [INFO] [stderr] --> src/private/layout.rs:235:9 [INFO] [stderr] | [INFO] [stderr] 235 | (self.upper32bits.get() & 0xffffffff) as WordCount16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:245:9 [INFO] [stderr] | [INFO] [stderr] 245 | self.struct_data_size() as WordCount32 + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.struct_data_size())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:246:13 [INFO] [stderr] | [INFO] [stderr] 246 | self.struct_ptr_count() as WordCount32 * WORDS_PER_POINTER as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.struct_ptr_count())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:251:30 [INFO] [stderr] | [INFO] [stderr] 251 | self.upper32bits.set(size.data as u32 | ((size.pointers as u32) << 16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(size.data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:251:50 [INFO] [stderr] | [INFO] [stderr] 251 | self.upper32bits.set(size.data as u32 | ((size.pointers as u32) << 16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(size.pointers)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: casting from `*mut private::layout::WirePointer` to a more-strictly-aligned pointer (`*mut Word`) [INFO] [stderr] --> src/private/layout.rs:383:21 [INFO] [stderr] | [INFO] [stderr] 383 | return (reff as *mut _, reff, segment_id); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:407:28 [INFO] [stderr] | [INFO] [stderr] 407 | let ptr1 = ptr.offset(POINTER_SIZE_IN_WORDS as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(POINTER_SIZE_IN_WORDS)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:560:52 [INFO] [stderr] | [INFO] [stderr] 560 | round_bits_up_to_words(( [INFO] [stderr] | ____________________________________________________^ [INFO] [stderr] 561 | | (*tag).list_element_count() * [INFO] [stderr] 562 | | data_bits_per_element( [INFO] [stderr] 563 | | (*tag).list_element_size())) as u64) as usize) [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 560 | round_bits_up_to_words(u64::from( [INFO] [stderr] 561 | (*tag).list_element_count() * [INFO] [stderr] 562 | data_bits_per_element( [INFO] [stderr] 563 | (*tag).list_element_size()))) as usize) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:643:38 [INFO] [stderr] | [INFO] [stderr] 643 | result.word_count += (*reff).struct_word_size() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from((*reff).struct_word_size())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:657:29 [INFO] [stderr] | [INFO] [stderr] 657 | (*reff).list_element_count() as u64 * [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from((*reff).list_element_count())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:658:33 [INFO] [stderr] | [INFO] [stderr] 658 | data_bits_per_element((*reff).list_element_size()) as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(data_bits_per_element((*reff).list_element_size()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:661:46 [INFO] [stderr] | [INFO] [stderr] 661 | result.word_count += total_words as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(total_words)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:669:46 [INFO] [stderr] | [INFO] [stderr] 669 | result.word_count += count as u64 * WORDS_PER_POINTER as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:692:43 [INFO] [stderr] | [INFO] [stderr] 692 | let actual_size = (*element_tag).struct_word_size() as u64 * count as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from((*element_tag).struct_word_size())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:692:86 [INFO] [stderr] | [INFO] [stderr] 692 | let actual_size = (*element_tag).struct_word_size() as u64 * count as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:693:42 [INFO] [stderr] | [INFO] [stderr] 693 | if actual_size > word_count as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(word_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:706:56 [INFO] [stderr] | [INFO] [stderr] 706 | let mut pos: *const Word = ptr.offset(POINTER_SIZE_IN_WORDS as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(POINTER_SIZE_IN_WORDS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:714:43 [INFO] [stderr] | [INFO] [stderr] 714 | pos = pos.offset(POINTER_SIZE_IN_WORDS as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `pos.add(POINTER_SIZE_IN_WORDS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/private/layout.rs:828:5 [INFO] [stderr] | [INFO] [stderr] 828 | / pub unsafe fn init_struct_pointer<'a>( [INFO] [stderr] 829 | | arena: &'a BuilderArena, [INFO] [stderr] 830 | | reff: *mut WirePointer, [INFO] [stderr] 831 | | segment_id: u32, [INFO] [stderr] ... | [INFO] [stderr] 851 | | } [INFO] [stderr] 852 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:848:23 [INFO] [stderr] | [INFO] [stderr] 848 | pointers: ptr.offset((size.data as usize) as isize) as *mut _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add((size.data as usize))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:849:24 [INFO] [stderr] | [INFO] [stderr] 849 | data_size: size.data as WordCount32 * (BITS_PER_WORD as BitCount32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(size.data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:891:30 [INFO] [stderr] | [INFO] [stderr] 891 | let total_size = new_data_size as u32 + new_pointer_count as u32 * WORDS_PER_POINTER as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(new_data_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:891:53 [INFO] [stderr] | [INFO] [stderr] 891 | let total_size = new_data_size as u32 + new_pointer_count as u32 * WORDS_PER_POINTER as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(new_pointer_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:918:28 [INFO] [stderr] | [INFO] [stderr] 918 | data_size: new_data_size as u32 * BITS_PER_WORD as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(new_data_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:928:28 [INFO] [stderr] | [INFO] [stderr] 928 | data_size: old_data_size as u32 * BITS_PER_WORD as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(old_data_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/private/layout.rs:935:5 [INFO] [stderr] | [INFO] [stderr] 935 | / pub unsafe fn init_list_pointer<'a>( [INFO] [stderr] 936 | | arena: &'a BuilderArena, [INFO] [stderr] 937 | | reff: *mut WirePointer, [INFO] [stderr] 938 | | segment_id: u32, [INFO] [stderr] ... | [INFO] [stderr] 964 | | } [INFO] [stderr] 965 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:949:49 [INFO] [stderr] | [INFO] [stderr] 949 | let word_count = round_bits_up_to_words(element_count as ElementCount64 * (step as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(element_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:949:83 [INFO] [stderr] | [INFO] [stderr] 949 | let word_count = round_bits_up_to_words(element_count as ElementCount64 * (step as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(step)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/private/layout.rs:968:5 [INFO] [stderr] | [INFO] [stderr] 968 | / pub unsafe fn init_struct_list_pointer<'a>( [INFO] [stderr] 969 | | arena: &'a BuilderArena, [INFO] [stderr] 970 | | reff: *mut WirePointer, [INFO] [stderr] 971 | | segment_id: u32, [INFO] [stderr] ... | [INFO] [stderr] 1004 | | } [INFO] [stderr] 1005 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:992:20 [INFO] [stderr] | [INFO] [stderr] 992 | let ptr1 = ptr.offset(POINTER_SIZE_IN_WORDS as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(POINTER_SIZE_IN_WORDS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1002:31 [INFO] [stderr] | [INFO] [stderr] 1002 | struct_data_size: element_size.data as u32 * (BITS_PER_WORD as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(element_size.data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:1058:19 [INFO] [stderr] | [INFO] [stderr] 1058 | ptr = ptr.offset(POINTER_SIZE_IN_WORDS as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(POINTER_SIZE_IN_WORDS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1097:35 [INFO] [stderr] | [INFO] [stderr] 1097 | struct_data_size: data_size as u32 * BITS_PER_WORD as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(data_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:1160:23 [INFO] [stderr] | [INFO] [stderr] 1160 | old_ptr = old_ptr.offset(POINTER_SIZE_IN_WORDS as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `old_ptr.add(POINTER_SIZE_IN_WORDS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1168:28 [INFO] [stderr] | [INFO] [stderr] 1168 | let old_step = old_data_size as u32 + old_pointer_count as u32 * WORDS_PER_POINTER as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(old_data_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1168:51 [INFO] [stderr] | [INFO] [stderr] 1168 | let old_step = old_data_size as u32 + old_pointer_count as u32 * WORDS_PER_POINTER as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(old_pointer_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1181:39 [INFO] [stderr] | [INFO] [stderr] 1181 | struct_data_size: old_data_size as u32 * BITS_PER_WORD as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(old_data_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1191:28 [INFO] [stderr] | [INFO] [stderr] 1191 | let new_step = new_data_size as u32 + new_pointer_count as u32 * WORDS_PER_POINTER as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(new_data_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1191:51 [INFO] [stderr] | [INFO] [stderr] 1191 | let new_step = new_data_size as u32 + new_pointer_count as u32 * WORDS_PER_POINTER as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(new_pointer_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:1205:23 [INFO] [stderr] | [INFO] [stderr] 1205 | new_ptr = new_ptr.offset(POINTER_SIZE_IN_WORDS as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `new_ptr.add(POINTER_SIZE_IN_WORDS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1227:31 [INFO] [stderr] | [INFO] [stderr] 1227 | (old_step as u64 * element_count as u64) as usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(old_step)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1227:49 [INFO] [stderr] | [INFO] [stderr] 1227 | (old_step as u64 * element_count as u64) as usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(element_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1237:35 [INFO] [stderr] | [INFO] [stderr] 1237 | struct_data_size: new_data_size as u32 * BITS_PER_WORD as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(new_data_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1271:32 [INFO] [stderr] | [INFO] [stderr] 1271 | let new_step = new_data_size as u32 + new_pointer_count as u32 * WORDS_PER_POINTER as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(new_data_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1271:55 [INFO] [stderr] | [INFO] [stderr] 1271 | let new_step = new_data_size as u32 + new_pointer_count as u32 * WORDS_PER_POINTER as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(new_pointer_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:1285:27 [INFO] [stderr] | [INFO] [stderr] 1285 | new_ptr = new_ptr.offset(POINTER_SIZE_IN_WORDS as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `new_ptr.add(POINTER_SIZE_IN_WORDS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1308:57 [INFO] [stderr] | [INFO] [stderr] 1308 | round_bits_up_to_bytes(old_step as u64 * element_count as u64) as usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(old_step)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1308:75 [INFO] [stderr] | [INFO] [stderr] 1308 | round_bits_up_to_bytes(old_step as u64 * element_count as u64) as usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(element_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1318:39 [INFO] [stderr] | [INFO] [stderr] 1318 | struct_data_size: new_data_size as u32 * BITS_PER_WORD as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(new_data_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/private/layout.rs:1393:12 [INFO] [stderr] | [INFO] [stderr] 1393 | if count <= 0 || *cptr.offset((count - 1) as isize) != 0 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using count == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut Word`) [INFO] [stderr] --> src/private/layout.rs:1446:42 [INFO] [stderr] | [INFO] [stderr] 1446 | builder.as_mut_ptr() as *mut _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1474:65 [INFO] [stderr] | [INFO] [stderr] 1474 | let mut data_size: ByteCount32 = round_bits_up_to_bytes(value.data_size as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(value.data_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/private/layout.rs:1496:24 [INFO] [stderr] | [INFO] [stderr] 1496 | if last_word == &[0; 8] { [INFO] [stderr] | ^^^^^^^^^^^^^------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `[0; 8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1510:52 [INFO] [stderr] | [INFO] [stderr] 1510 | let total_size: WordCount32 = data_words + ptr_count as u32 * WORDS_PER_POINTER as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(ptr_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1556:49 [INFO] [stderr] | [INFO] [stderr] 1556 | let total_size = round_bits_up_to_words((value.element_count * value.step) as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(value.element_count * value.step)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const private::layout::WirePointer`) [INFO] [stderr] --> src/private/layout.rs:1571:39 [INFO] [stderr] | [INFO] [stderr] 1571 | (value.ptr as *const WirePointer).offset(i), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1593:39 [INFO] [stderr] | [INFO] [stderr] 1593 | let whole_byte_size = value.element_count as u64 * value.step as u64 / BITS_PER_BYTE as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(value.element_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1593:68 [INFO] [stderr] | [INFO] [stderr] 1593 | let whole_byte_size = value.element_count as u64 * value.step as u64 / BITS_PER_BYTE as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(value.step)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1597:37 [INFO] [stderr] | [INFO] [stderr] 1597 | let leftover_bits = value.element_count as u64 * value.step as u64 % BITS_PER_BYTE as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(value.element_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1597:66 [INFO] [stderr] | [INFO] [stderr] 1597 | let leftover_bits = value.element_count as u64 * value.step as u64 % BITS_PER_BYTE as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(value.step)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/private/layout.rs:1615:13 [INFO] [stderr] | [INFO] [stderr] 1615 | / let mut total_size = total_size; [INFO] [stderr] 1616 | | [INFO] [stderr] 1617 | | if canonicalize { [INFO] [stderr] 1618 | | for ec in 0..value.element_count { [INFO] [stderr] ... | [INFO] [stderr] 1646 | | ptr_count = decl_pointer_count; [INFO] [stderr] 1647 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let total_size = if canonicalize { ..; (data_size as u32 + ptr_count as u32) * value.element_count as u32 } else { ..; total_size };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/private/layout.rs:1626:28 [INFO] [stderr] | [INFO] [stderr] 1626 | if last_word != &[0; 8] { [INFO] [stderr] | ^^^^^^^^^^^^^------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `[0; 8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1643:50 [INFO] [stderr] | [INFO] [stderr] 1643 | total_size = (data_size as u32 + ptr_count as u32) * value.element_count as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(ptr_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:1657:27 [INFO] [stderr] | [INFO] [stderr] 1657 | let mut dst = ptr.offset(POINTER_SIZE_IN_WORDS as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(POINTER_SIZE_IN_WORDS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const Word`) [INFO] [stderr] --> src/private/layout.rs:1659:40 [INFO] [stderr] | [INFO] [stderr] 1659 | let mut src: *const Word = value.ptr as *const _; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:1669:27 [INFO] [stderr] | [INFO] [stderr] 1669 | dst = dst.offset(POINTER_SIZE_IN_WORDS as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dst.add(POINTER_SIZE_IN_WORDS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:1670:27 [INFO] [stderr] | [INFO] [stderr] 1670 | src = src.offset(POINTER_SIZE_IN_WORDS as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `src.add(POINTER_SIZE_IN_WORDS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/private/layout.rs:1679:5 [INFO] [stderr] | [INFO] [stderr] 1679 | / pub unsafe fn copy_pointer( [INFO] [stderr] 1680 | | dst_arena: &BuilderArena, [INFO] [stderr] 1681 | | dst_segment_id: u32, dst_cap_table: CapTableBuilder, [INFO] [stderr] 1682 | | dst: *mut WirePointer, [INFO] [stderr] ... | [INFO] [stderr] 1829 | | } [INFO] [stderr] 1830 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1716:36 [INFO] [stderr] | [INFO] [stderr] 1716 | data_size: (*src).struct_data_size() as u32 * BITS_PER_WORD as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((*src).struct_data_size())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:1732:27 [INFO] [stderr] | [INFO] [stderr] 1732 | ptr = ptr.offset(POINTER_SIZE_IN_WORDS as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(POINTER_SIZE_IN_WORDS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1746:24 [INFO] [stderr] | [INFO] [stderr] 1746 | if words_per_element as u64 * element_count as u64 > word_count as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(words_per_element)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1746:51 [INFO] [stderr] | [INFO] [stderr] 1746 | if words_per_element as u64 * element_count as u64 > word_count as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(element_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1746:74 [INFO] [stderr] | [INFO] [stderr] 1746 | if words_per_element as u64 * element_count as u64 > word_count as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(word_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1754:56 [INFO] [stderr] | [INFO] [stderr] 1754 | try!(amplified_read(src_arena, element_count as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(element_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1768:47 [INFO] [stderr] | [INFO] [stderr] 1768 | struct_data_size: (*tag).struct_data_size() as u32 * BITS_PER_WORD as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((*tag).struct_data_size())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1778:61 [INFO] [stderr] | [INFO] [stderr] 1778 | let word_count = round_bits_up_to_words(element_count as u64 * step as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(element_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1778:84 [INFO] [stderr] | [INFO] [stderr] 1778 | let word_count = round_bits_up_to_words(element_count as u64 * step as u64); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(step)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1787:56 [INFO] [stderr] | [INFO] [stderr] 1787 | try!(amplified_read(src_arena, element_count as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(element_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1873:24 [INFO] [stderr] | [INFO] [stderr] 1873 | data_size: data_size_words as u32 * BITS_PER_WORD as BitCount32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(data_size_words)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/private/layout.rs:1937:47 [INFO] [stderr] | [INFO] [stderr] 1937 | let tag: *const WirePointer = mem::transmute(ptr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `ptr as *const private::layout::WirePointer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1955:20 [INFO] [stderr] | [INFO] [stderr] 1955 | if size as u64 * words_per_element as u64 > word_count as u64 { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1955:34 [INFO] [stderr] | [INFO] [stderr] 1955 | if size as u64 * words_per_element as u64 > word_count as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(words_per_element)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1955:61 [INFO] [stderr] | [INFO] [stderr] 1955 | if size as u64 * words_per_element as u64 > word_count as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(word_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1963:48 [INFO] [stderr] | [INFO] [stderr] 1963 | try!(amplified_read(arena, size as u64)); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/private/layout.rs:1989:28 [INFO] [stderr] | [INFO] [stderr] 1989 | if ptr_count <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using ptr_count == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:2004:39 [INFO] [stderr] | [INFO] [stderr] 2004 | struct_data_size: data_size as u32 * (BITS_PER_WORD as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(data_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:2018:57 [INFO] [stderr] | [INFO] [stderr] 2018 | let word_count = round_bits_up_to_words(element_count as u64 * step as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(element_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:2018:80 [INFO] [stderr] | [INFO] [stderr] 2018 | let word_count = round_bits_up_to_words(element_count as u64 * step as u64); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(step)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:2025:48 [INFO] [stderr] | [INFO] [stderr] 2025 | try!(amplified_read(arena, element_count as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(element_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/private/layout.rs:2099:12 [INFO] [stderr] | [INFO] [stderr] 2099 | if size <= 0 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using size == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/private/layout.rs:2168:24 [INFO] [stderr] | [INFO] [stderr] 2168 | pub fn extract_cap(&self, index: usize) -> Option> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/private/layout.rs:2206:24 [INFO] [stderr] | [INFO] [stderr] 2206 | pub fn extract_cap(&self, index: usize) -> Option> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/private/layout.rs:2288:5 [INFO] [stderr] | [INFO] [stderr] 2288 | / pub fn borrow<'b>(&'b self) -> PointerReader<'b> { [INFO] [stderr] 2289 | | PointerReader { arena: self.arena, .. *self } [INFO] [stderr] 2290 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/private/layout.rs:2322:47 [INFO] [stderr] | [INFO] [stderr] 2322 | default_value, self.nesting_limit) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/private/layout.rs:2335:17 [INFO] [stderr] | [INFO] [stderr] 2335 | default_value, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/private/layout.rs:2356:80 [INFO] [stderr] | [INFO] [stderr] 2356 | wire_helpers::read_text_pointer(self.arena, self.segment_id, reff, default_value, default_size) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/private/layout.rs:2363:80 [INFO] [stderr] | [INFO] [stderr] 2363 | wire_helpers::read_data_pointer(self.arena, self.segment_id, reff, default_value, default_size) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/private/layout.rs:2385:41 [INFO] [stderr] | [INFO] [stderr] 2385 | Err(::Error::failed(format!("Unexpected FAR pointer"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Unexpected FAR pointer".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/private/layout.rs:2392:45 [INFO] [stderr] | [INFO] [stderr] 2392 | Err(::Error::failed(format!("Unknown pointer type"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Unknown pointer type".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: casting from `*const private::layout::WirePointer` to a more-strictly-aligned pointer (`*const Word`) [INFO] [stderr] --> src/private/layout.rs:2411:24 [INFO] [stderr] | [INFO] [stderr] 2411 | Ok(self.pointer as *const _ == st.get_location()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/private/layout.rs:2449:5 [INFO] [stderr] | [INFO] [stderr] 2449 | / pub fn borrow<'b>(&'b mut self) -> PointerBuilder<'b> { [INFO] [stderr] 2450 | | PointerBuilder { arena: self.arena, .. *self } [INFO] [stderr] 2451 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/private/layout.rs:2469:17 [INFO] [stderr] | [INFO] [stderr] 2469 | default_value) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/private/layout.rs:2478:90 [INFO] [stderr] | [INFO] [stderr] 2478 | self.arena, self.pointer, self.segment_id, self.cap_table, element_size, default_value) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/private/layout.rs:2487:90 [INFO] [stderr] | [INFO] [stderr] 2487 | self.arena, self.pointer, self.segment_id, self.cap_table, element_size, default_value) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/private/layout.rs:2497:48 [INFO] [stderr] | [INFO] [stderr] 2497 | self.pointer, self.segment_id, default_value, default_size) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/private/layout.rs:2506:60 [INFO] [stderr] | [INFO] [stderr] 2506 | self.arena, self.pointer, self.segment_id, default_value, default_size) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:2676:19 [INFO] [stderr] | [INFO] [stderr] 2676 | (*dwv.offset(offset as isize)).get() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dwv.add(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:2688:36 [INFO] [stderr] | [INFO] [stderr] 2688 | let b: *const u8 = self.data.offset((boffset as usize / BITS_PER_BYTE) as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.data.add((boffset as usize / BITS_PER_BYTE))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:2717:35 [INFO] [stderr] | [INFO] [stderr] 2717 | pointer: unsafe { self.pointers.offset(ptr_index as isize) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.pointers.add(ptr_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:2727:25 [INFO] [stderr] | [INFO] [stderr] 2727 | word_count: wire_helpers::round_bits_up_to_words(self.data_size as u64) as u64 + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(wire_helpers::round_bits_up_to_words(self.data_size as u64))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:2727:62 [INFO] [stderr] | [INFO] [stderr] 2727 | word_count: wire_helpers::round_bits_up_to_words(self.data_size as u64) as u64 + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.data_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:2728:17 [INFO] [stderr] | [INFO] [stderr] 2728 | self.pointer_count as u64 * WORDS_PER_POINTER as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.pointer_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const Word`) [INFO] [stderr] --> src/private/layout.rs:2745:9 [INFO] [stderr] | [INFO] [stderr] 2745 | self.data as * const _ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:2832:15 [INFO] [stderr] | [INFO] [stderr] 2832 | (*ptr.offset(offset as isize)).set(value) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:2848:15 [INFO] [stderr] | [INFO] [stderr] 2848 | (*ptr.offset(offset as isize)).get() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:2865:26 [INFO] [stderr] | [INFO] [stderr] 2865 | let b = unsafe { self.data.offset((boffset / BITS_PER_BYTE) as isize)}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.data.add((boffset / BITS_PER_BYTE))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:2881:26 [INFO] [stderr] | [INFO] [stderr] 2881 | let b = unsafe { self.data.offset((boffset / BITS_PER_BYTE) as isize) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.data.add((boffset / BITS_PER_BYTE))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:2899:31 [INFO] [stderr] | [INFO] [stderr] 2899 | pointer: unsafe { self.pointers.offset(ptr_index as isize) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.pointers.add(ptr_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/private/layout.rs:2915:44 [INFO] [stderr] | [INFO] [stderr] 2915 | return Err(::Error::failed(format!("Only one of the section pointers is pointing to ourself"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Only one of the section pointers is pointing to ourself".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: item `private::layout::ListReader<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/private/layout.rs:2979:1 [INFO] [stderr] | [INFO] [stderr] 2979 | / impl <'a> ListReader<'a> { [INFO] [stderr] 2980 | | pub fn new_default<'b>() -> ListReader<'b> { [INFO] [stderr] 2981 | | ListReader { [INFO] [stderr] 2982 | | arena: &NULL_ARENA, [INFO] [stderr] ... | [INFO] [stderr] 3132 | | } [INFO] [stderr] 3133 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3005:15 [INFO] [stderr] | [INFO] [stderr] 3005 | ((index as ElementCount64 * (self.step as BitCount64)) / BITS_PER_BYTE as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3005:41 [INFO] [stderr] | [INFO] [stderr] 3005 | ((index as ElementCount64 * (self.step as BitCount64)) / BITS_PER_BYTE as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.step)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const private::layout::WirePointer`) [INFO] [stderr] --> src/private/layout.rs:3010:13 [INFO] [stderr] | [INFO] [stderr] 3010 | struct_data.offset((self.struct_data_size as usize / BITS_PER_BYTE) as isize) as *const _ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:3010:13 [INFO] [stderr] | [INFO] [stderr] 3010 | struct_data.offset((self.struct_data_size as usize / BITS_PER_BYTE) as isize) as *const _ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `struct_data.add((self.struct_data_size as usize / BITS_PER_BYTE))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3027:23 [INFO] [stderr] | [INFO] [stderr] 3027 | let offset = (index as u64 * self.step as u64 / BITS_PER_BYTE as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3027:38 [INFO] [stderr] | [INFO] [stderr] 3027 | let offset = (index as u64 * self.step as u64 / BITS_PER_BYTE as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(self.step)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*mut private::layout::WirePointer`) [INFO] [stderr] --> src/private/layout.rs:3032:31 [INFO] [stderr] | [INFO] [stderr] 3032 | pointer: unsafe { self.ptr.offset(offset as isize) as *mut _ }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/private/layout.rs:3054:45 [INFO] [stderr] | [INFO] [stderr] 3054 | let word_count = unsafe { (*reff).list_inline_composite_word_count() }; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const Word`) [INFO] [stderr] --> src/private/layout.rs:3046:20 [INFO] [stderr] | [INFO] [stderr] 3046 | if self.ptr as *const _ != read_head.get() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3053:21 [INFO] [stderr] | [INFO] [stderr] 3053 | self.struct_pointer_count as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.struct_pointer_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const Word`) [INFO] [stderr] --> src/private/layout.rs:3083:20 [INFO] [stderr] | [INFO] [stderr] 3083 | if self.ptr as *const _ != read_head.get() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3099:32 [INFO] [stderr] | [INFO] [stderr] 3099 | let bit_size = self.element_count as u64 * data_bits_per_element(element_size) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.element_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3099:60 [INFO] [stderr] | [INFO] [stderr] 3099 | let bit_size = self.element_count as u64 * data_bits_per_element(element_size) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(data_bits_per_element(element_size))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: item `private::layout::ListBuilder<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/private/layout.rs:3148:1 [INFO] [stderr] | [INFO] [stderr] 3148 | / impl <'a> ListBuilder<'a> { [INFO] [stderr] 3149 | | [INFO] [stderr] 3150 | | #[inline] [INFO] [stderr] 3151 | | pub fn new_default<'b>() -> ListBuilder<'b> { [INFO] [stderr] ... | [INFO] [stderr] 3223 | | } [INFO] [stderr] 3224 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/private/layout.rs:3185:5 [INFO] [stderr] | [INFO] [stderr] 3185 | / pub fn borrow<'b>(&'b mut self) -> ListBuilder<'b> { [INFO] [stderr] 3186 | | ListBuilder { arena: self.arena, ..*self } [INFO] [stderr] 3187 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3198:28 [INFO] [stderr] | [INFO] [stderr] 3198 | let index_byte = ((index as u64 * self.step as u64) / BITS_PER_BYTE as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3198:43 [INFO] [stderr] | [INFO] [stderr] 3198 | let index_byte = ((index as u64 * self.step as u64) / BITS_PER_BYTE as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(self.step)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut private::layout::WirePointer`) [INFO] [stderr] --> src/private/layout.rs:3201:13 [INFO] [stderr] | [INFO] [stderr] 3201 | struct_data.offset(((self.struct_data_size as usize) / BITS_PER_BYTE) as isize) as *mut _ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:3201:13 [INFO] [stderr] | [INFO] [stderr] 3201 | struct_data.offset(((self.struct_data_size as usize) / BITS_PER_BYTE) as isize) as *mut _ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `struct_data.add(((self.struct_data_size as usize) / BITS_PER_BYTE))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3216:23 [INFO] [stderr] | [INFO] [stderr] 3216 | let offset = (index as u64 * self.step as u64 / BITS_PER_BYTE as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3216:38 [INFO] [stderr] | [INFO] [stderr] 3216 | let offset = (index as u64 * self.step as u64 / BITS_PER_BYTE as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(self.step)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut private::layout::WirePointer`) [INFO] [stderr] --> src/private/layout.rs:3221:22 [INFO] [stderr] | [INFO] [stderr] 3221 | pointer: unsafe { self.ptr.offset(offset as isize) } as *mut _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3230:23 [INFO] [stderr] | [INFO] [stderr] 3230 | let offset = (index as u64 * list_reader.step as u64 / BITS_PER_BYTE as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3230:38 [INFO] [stderr] | [INFO] [stderr] 3230 | let offset = (index as u64 * list_reader.step as u64 / BITS_PER_BYTE as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(list_reader.step)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3239:23 [INFO] [stderr] | [INFO] [stderr] 3239 | let offset = (index as u64 * list_builder.step as u64 / BITS_PER_BYTE as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3239:38 [INFO] [stderr] | [INFO] [stderr] 3239 | let offset = (index as u64 * list_builder.step as u64 / BITS_PER_BYTE as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(list_builder.step)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3248:23 [INFO] [stderr] | [INFO] [stderr] 3248 | let offset = (index as u64 * list_builder.step as u64 / BITS_PER_BYTE as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3248:38 [INFO] [stderr] | [INFO] [stderr] 3248 | let offset = (index as u64 * list_builder.step as u64 / BITS_PER_BYTE as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(list_builder.step)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3281:22 [INFO] [stderr] | [INFO] [stderr] 3281 | let bindex = index as u64 * list.step as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3281:37 [INFO] [stderr] | [INFO] [stderr] 3281 | let bindex = index as u64 * list.step as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(list.step)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3289:22 [INFO] [stderr] | [INFO] [stderr] 3289 | let bindex = index as u64 * list.step as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3289:37 [INFO] [stderr] | [INFO] [stderr] 3289 | let bindex = index as u64 * list.step as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(list.step)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3295:22 [INFO] [stderr] | [INFO] [stderr] 3295 | let bindex = index as u64 * list.step as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3295:37 [INFO] [stderr] | [INFO] [stderr] 3295 | let bindex = index as u64 * list.step as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(list.step)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/private/mask.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | mem::transmute(v ^ mask) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(v ^ mask)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u64` to a `f64` [INFO] [stderr] --> src/private/mask.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | mem::transmute(v ^ mask) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits(v ^ mask)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/serialize.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / fn get_segment<'b>(&'b self, id: u32) -> Option<&'b [Word]> { [INFO] [stderr] 40 | | if id < self.segment_slices.len() as u32 { [INFO] [stderr] 41 | | let (a, b) = self.segment_slices[id as usize]; [INFO] [stderr] 42 | | Some(&self.words[a..b]) [INFO] [stderr] ... | [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/serialize.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | / fn get_segment<'a>(&'a self, id: u32) -> Option<&'a [Word]> { [INFO] [stderr] 77 | | if id < self.segment_slices.len() as u32 { [INFO] [stderr] 78 | | let (a, b) = self.segment_slices[id as usize]; [INFO] [stderr] 79 | | Some(&self.owned_space[a..b]) [INFO] [stderr] ... | [INFO] [stderr] 82 | | } [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the loop variable `idx` is only used to index `segment`. [INFO] [stderr] --> src/serialize.rs:201:20 [INFO] [stderr] | [INFO] [stderr] 201 | for idx in 0..segment.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 201 | for in &segment { [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `idx` is only used to index `buf`. [INFO] [stderr] --> src/serialize.rs:250:28 [INFO] [stderr] | [INFO] [stderr] 250 | for idx in 4..8 { buf[idx] = 0 } [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 250 | for in buf.iter_mut().skip(4) { buf[idx] = 0 } [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `idx` is only used to index `buf`. [INFO] [stderr] --> src/serialize.rs:260:28 [INFO] [stderr] | [INFO] [stderr] 260 | for idx in (buf.len() - 4)..(buf.len()) { buf[idx] = 0 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 260 | for in buf.iter_mut().skip((buf.len() - 4)) { buf[idx] = 0 } [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/serialize_packed.rs:156:27 [INFO] [stderr] | [INFO] [stderr] 156 | out = out.offset(run_length as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `out.add(run_length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/serialize_packed.rs:174:31 [INFO] [stderr] | [INFO] [stderr] 174 | out = out.offset(run_length as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `out.add(run_length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/serialize_packed.rs:175:34 [INFO] [stderr] | [INFO] [stderr] 175 | in_ptr = in_ptr.offset(run_length as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `in_ptr.add(run_length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/serialize_packed.rs:179:31 [INFO] [stderr] | [INFO] [stderr] 179 | out = out.offset(in_remaining as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `out.add(in_remaining)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/serialize_packed.rs:188:31 [INFO] [stderr] | [INFO] [stderr] 188 | out = out.offset(run_length as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `out.add(run_length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `bit0` [INFO] [stderr] --> src/serialize_packed.rs:290:31 [INFO] [stderr] | [INFO] [stderr] 290 | let tag: u8 = (bit0 << 0) | (bit1 << 1) | (bit2 << 2) | (bit3 << 3) [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u64`) [INFO] [stderr] --> src/serialize_packed.rs:302:52 [INFO] [stderr] | [INFO] [stderr] 302 | let mut in_word : *const u64 = in_ptr as *const u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u64`) [INFO] [stderr] --> src/serialize_packed.rs:303:50 [INFO] [stderr] | [INFO] [stderr] 303 | let mut limit : *const u64 = in_end as *const u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u64`) [INFO] [stderr] --> src/serialize_packed.rs:311:72 [INFO] [stderr] | [INFO] [stderr] 311 | *buf.get_unchecked_mut(buf_idx) = ptr_sub(in_word, in_ptr as *const u64) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: item `struct_list::Reader<'a, T>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/struct_list.rs:54:1 [INFO] [stderr] | [INFO] [stderr] 54 | / impl <'a, T> Reader<'a, T> where T: for<'b> ::traits::OwnedStruct<'b> { [INFO] [stderr] 55 | | pub fn new<'b>(reader : ListReader<'b>) -> Reader<'b, T> { [INFO] [stderr] 56 | | Reader::<'b, T> { reader : reader, marker : PhantomData } [INFO] [stderr] 57 | | } [INFO] [stderr] ... | [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/struct_list.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | / pub fn reborrow<'b>(&'b self) -> Reader<'b, T> { [INFO] [stderr] 68 | | Reader { reader: self.reader, marker: PhantomData } [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: item `struct_list::Builder<'a, T>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/struct_list.rs:98:1 [INFO] [stderr] | [INFO] [stderr] 98 | / impl <'a, T> Builder<'a, T> where T: for<'b> ::traits::OwnedStruct<'b> { [INFO] [stderr] 99 | | pub fn new(builder : ListBuilder<'a>) -> Builder<'a, T> { [INFO] [stderr] 100 | | Builder { builder: builder, marker: PhantomData } [INFO] [stderr] 101 | | } [INFO] [stderr] ... | [INFO] [stderr] 127 | | } [INFO] [stderr] 128 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/struct_list.rs:106:22 [INFO] [stderr] | [INFO] [stderr] 106 | pub fn as_reader(self) -> Reader<'a, T> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/struct_list.rs:131:5 [INFO] [stderr] | [INFO] [stderr] 131 | / pub fn reborrow<'b>(&'b mut self) -> Builder<'b, T> { [INFO] [stderr] 132 | | Builder { builder: self.builder, marker: PhantomData } [INFO] [stderr] 133 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the loop variable `ii` is used to index `bytes` [INFO] [stderr] --> src/text.rs:76:19 [INFO] [stderr] | [INFO] [stderr] 76 | for ii in 0..bytes.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 76 | for (ii, ) in bytes.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/text.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | / fn deref<'b>(&'b self) -> &'b str { [INFO] [stderr] 93 | | str::from_utf8(self.bytes) [INFO] [stderr] 94 | | .expect("text::Builder contents are checked for utf8-validity upon construction") [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/text.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | / fn as_ref<'b>(&'b self) -> &'b str { [INFO] [stderr] 100 | | str::from_utf8(self.bytes) [INFO] [stderr] 101 | | .expect("text::Builder contents are checked for utf8-validity upon construction") [INFO] [stderr] 102 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: item `text_list::Reader<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/text_list.rs:41:1 [INFO] [stderr] | [INFO] [stderr] 41 | / impl <'a> Reader<'a> { [INFO] [stderr] 42 | | pub fn new<'b>(reader : ListReader<'b>) -> Reader<'b> { [INFO] [stderr] 43 | | Reader::<'b> { reader : reader } [INFO] [stderr] 44 | | } [INFO] [stderr] ... | [INFO] [stderr] 51 | | } [INFO] [stderr] 52 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `text_list::Builder<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/text_list.rs:77:1 [INFO] [stderr] | [INFO] [stderr] 77 | / impl <'a> Builder<'a> { [INFO] [stderr] 78 | | pub fn new(builder : ListBuilder<'a>) -> Builder<'a> { [INFO] [stderr] 79 | | Builder { builder : builder } [INFO] [stderr] 80 | | } [INFO] [stderr] ... | [INFO] [stderr] 100 | | } [INFO] [stderr] 101 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/text_list.rs:90:22 [INFO] [stderr] | [INFO] [stderr] 90 | pub fn as_reader(self) -> Reader<'a> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/traits.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | fn set_pointer_builder<'a>(PointerBuilder<'a>, Self, canonicalize: bool) -> Result<()>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/traits.rs:91:25 [INFO] [stderr] | [INFO] [stderr] 91 | fn imbue(&mut self, &'a CapTable); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | / pub unsafe fn bytes_to_words<'a>(bytes: &'a [u8]) -> &'a [Word] { [INFO] [stderr] 116 | | ::std::slice::from_raw_parts(bytes.as_ptr() as *const Word, bytes.len() / 8) [INFO] [stderr] 117 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const Word`) [INFO] [stderr] --> src/lib.rs:116:38 [INFO] [stderr] | [INFO] [stderr] 116 | ::std::slice::from_raw_parts(bytes.as_ptr() as *const Word, bytes.len() / 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | / pub unsafe fn bytes_to_words_mut<'a>(bytes: &'a mut [u8]) -> &'a mut [Word] { [INFO] [stderr] 124 | | ::std::slice::from_raw_parts_mut(bytes.as_ptr() as *mut Word, bytes.len() / 8) [INFO] [stderr] 125 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*mut Word`) [INFO] [stderr] --> src/lib.rs:124:42 [INFO] [stderr] | [INFO] [stderr] 124 | ::std::slice::from_raw_parts_mut(bytes.as_ptr() as *mut Word, bytes.len() / 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | / pub fn words_to_bytes<'a>(words: &'a [Word]) -> &'a [u8] { [INFO] [stderr] 128 | | unsafe { [INFO] [stderr] 129 | | ::std::slice::from_raw_parts(words.as_ptr() as *const u8, words.len() * 8) [INFO] [stderr] 130 | | } [INFO] [stderr] 131 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:133:5 [INFO] [stderr] | [INFO] [stderr] 133 | / pub fn words_to_bytes_mut<'a>(words: &'a mut [Word]) -> &'a mut [u8] { [INFO] [stderr] 134 | | unsafe { [INFO] [stderr] 135 | | ::std::slice::from_raw_parts_mut(words.as_mut_ptr() as *mut u8, words.len() * 8) [INFO] [stderr] 136 | | } [INFO] [stderr] 137 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:174:5 [INFO] [stderr] | [INFO] [stderr] 174 | / fn description<'a>(&'a self) -> &'a str { [INFO] [stderr] 175 | | "Enum value or union disriminant was not present in schema." [INFO] [stderr] 176 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:312:5 [INFO] [stderr] | [INFO] [stderr] 312 | / fn get_segment<'a>(&'a self, id: u32) -> Option<&'a [Word]> { [INFO] [stderr] 313 | | match *self { [INFO] [stderr] 314 | | OutputSegments::SingleSegment(ref s) => { [INFO] [stderr] 315 | | s.get(id as usize).map(|slice| *slice) [INFO] [stderr] ... | [INFO] [stderr] 320 | | } [INFO] [stderr] 321 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:315:17 [INFO] [stderr] | [INFO] [stderr] 315 | s.get(id as usize).map(|slice| *slice) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `s.get(id as usize).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:318:17 [INFO] [stderr] | [INFO] [stderr] 318 | v.get(id as usize).map(|slice| *slice) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `v.get(id as usize).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] error: aborting due to 38 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `capnp`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/any_pointer.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / pub fn new<'b>(reader: PointerReader<'b>) -> Reader<'b> { [INFO] [stderr] 50 | | Reader { reader: reader } [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/any_pointer.rs:116:16 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn new<'b>(builder: PointerBuilder<'a>) -> Builder<'a> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/any_pointer.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | / pub fn reborrow<'b>(&'b mut self) -> Builder<'b> { [INFO] [stderr] 121 | | Builder { builder: self.builder.borrow() } [INFO] [stderr] 122 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/any_pointer.rs:161:22 [INFO] [stderr] | [INFO] [stderr] 161 | pub fn as_reader(self) -> Reader<'a> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: The function/method `::serialize::write_message` doesn't need a mutable reference [INFO] [stderr] --> src/any_pointer.rs:242:45 [INFO] [stderr] | [INFO] [stderr] 242 | ::serialize::write_message(&mut output, &mut message).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/capability.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | / pub fn get<'a>(&'a mut self) -> >::Builder { [INFO] [stderr] 129 | | self.hook.get().get_as().unwrap() [INFO] [stderr] 130 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/capability.rs:184:5 [INFO] [stderr] | [INFO] [stderr] 184 | / pub fn get<'a>(&'a mut self) -> >::Builder { [INFO] [stderr] 185 | | self.hook.get().unwrap().get_as().unwrap() [INFO] [stderr] 186 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: item `capability_list::Reader<'a, T>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/capability_list.rs:53:1 [INFO] [stderr] | [INFO] [stderr] 53 | / impl <'a, T> Reader<'a, T> where T: FromClientHook { [INFO] [stderr] 54 | | pub fn new<'b>(reader : ListReader<'b>) -> Reader<'b, T> { [INFO] [stderr] 55 | | Reader::<'b, T> { reader : reader, marker : PhantomData } [INFO] [stderr] 56 | | } [INFO] [stderr] ... | [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/capability_list.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | / pub fn reborrow<'b>(&'b self) -> Reader<'b, T> { [INFO] [stderr] 68 | | Reader { reader: self.reader, marker: PhantomData } [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: item `capability_list::Builder<'a, T>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/capability_list.rs:97:1 [INFO] [stderr] | [INFO] [stderr] 97 | / impl <'a, T> Builder<'a, T> where T: FromClientHook { [INFO] [stderr] 98 | | pub fn new(builder : ListBuilder<'a>) -> Builder<'a, T> { [INFO] [stderr] 99 | | Builder { builder: builder, marker: PhantomData } [INFO] [stderr] 100 | | } [INFO] [stderr] ... | [INFO] [stderr] 119 | | } [INFO] [stderr] 120 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/capability_list.rs:105:22 [INFO] [stderr] | [INFO] [stderr] 105 | pub fn as_reader(self) -> Reader<'a, T> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/capability_list.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | / pub fn reborrow<'b>(&'b mut self) -> Builder<'b, T> { [INFO] [stderr] 124 | | Builder { builder: self.builder, marker: PhantomData } [INFO] [stderr] 125 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/data.rs:38:43 [INFO] [stderr] | [INFO] [stderr] 38 | unsafe { ::std::slice::from_raw_parts(p, len as usize) } [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/data.rs:50:47 [INFO] [stderr] | [INFO] [stderr] 50 | unsafe { ::std::slice::from_raw_parts_mut(p, len as usize) } [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: item `data_list::Reader<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/data_list.rs:41:1 [INFO] [stderr] | [INFO] [stderr] 41 | / impl <'a> Reader<'a> { [INFO] [stderr] 42 | | pub fn new<'b>(reader: ListReader<'b>) -> Reader<'b> { [INFO] [stderr] 43 | | Reader { reader: reader } [INFO] [stderr] 44 | | } [INFO] [stderr] ... | [INFO] [stderr] 51 | | } [INFO] [stderr] 52 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/data_list.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / pub fn new<'b>(reader: ListReader<'b>) -> Reader<'b> { [INFO] [stderr] 43 | | Reader { reader: reader } [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: item `data_list::Builder<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/data_list.rs:77:1 [INFO] [stderr] | [INFO] [stderr] 77 | / impl <'a> Builder<'a> { [INFO] [stderr] 78 | | pub fn new(builder: ListBuilder<'a>) -> Builder<'a> { [INFO] [stderr] 79 | | Builder { builder: builder } [INFO] [stderr] 80 | | } [INFO] [stderr] ... | [INFO] [stderr] 100 | | } [INFO] [stderr] 101 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/data_list.rs:85:22 [INFO] [stderr] | [INFO] [stderr] 85 | pub fn as_reader(self) -> Reader<'a> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/data_list.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | / pub fn reborrow<'b>(&'b mut self) -> Builder<'b> { [INFO] [stderr] 99 | | Builder {builder: self.builder.borrow()} [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: item `enum_list::Reader<'a, T>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/enum_list.rs:47:1 [INFO] [stderr] | [INFO] [stderr] 47 | / impl <'a, T: FromU16> Reader<'a, T> { [INFO] [stderr] 48 | | pub fn new<'b>(reader: ListReader<'b>) -> Reader<'b, T> { [INFO] [stderr] 49 | | Reader::<'b, T> { reader: reader, marker: PhantomData } [INFO] [stderr] 50 | | } [INFO] [stderr] ... | [INFO] [stderr] 57 | | } [INFO] [stderr] 58 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `enum_list::Builder<'a, T>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/enum_list.rs:86:1 [INFO] [stderr] | [INFO] [stderr] 86 | / impl <'a, T : ToU16 + FromU16> Builder<'a, T> { [INFO] [stderr] 87 | | pub fn new(builder: ListBuilder<'a>) -> Builder<'a, T> { [INFO] [stderr] 88 | | Builder { builder: builder, marker: PhantomData } [INFO] [stderr] 89 | | } [INFO] [stderr] ... | [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/enum_list.rs:94:22 [INFO] [stderr] | [INFO] [stderr] 94 | pub fn as_reader(self) -> Reader<'a, T> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/enum_list.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | / pub fn reborrow<'b>(&'b self) -> Builder<'b, T> { [INFO] [stderr] 127 | | Builder { .. *self } [INFO] [stderr] 128 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: item `list_list::Reader<'a, T>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/list_list.rs:43:1 [INFO] [stderr] | [INFO] [stderr] 43 | / impl <'a, T> Reader<'a, T> where T: for<'b> ::traits::Owned<'b> { [INFO] [stderr] 44 | | pub fn new<'b>(reader: ListReader<'b>) -> Reader<'b, T> { [INFO] [stderr] 45 | | Reader::<'b, T> { reader: reader, marker: ::std::marker::PhantomData } [INFO] [stderr] 46 | | } [INFO] [stderr] ... | [INFO] [stderr] 51 | | } [INFO] [stderr] 52 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `list_list::Builder<'a, T>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/list_list.rs:88:1 [INFO] [stderr] | [INFO] [stderr] 88 | / impl <'a, T> Builder<'a, T> where T: for<'b> ::traits::Owned<'b> { [INFO] [stderr] 89 | | pub fn new(builder: ListBuilder<'a>) -> Builder<'a, T> { [INFO] [stderr] 90 | | Builder { builder: builder, marker: ::std::marker::PhantomData } [INFO] [stderr] 91 | | } [INFO] [stderr] ... | [INFO] [stderr] 102 | | } [INFO] [stderr] 103 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/list_list.rs:96:22 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn as_reader(self) -> Reader<'a, T> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/list_list.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | / pub fn reborrow<'b>(&'b mut self) -> Builder<'b, T> { [INFO] [stderr] 113 | | Builder {builder: self.builder.borrow(), marker: ::std::marker::PhantomData} [INFO] [stderr] 114 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/message.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | / pub fn nesting_limit<'a>(&'a mut self, value: i32) -> &'a mut ReaderOptions { [INFO] [stderr] 79 | | self.nesting_limit = value; [INFO] [stderr] 80 | | self [INFO] [stderr] 81 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/message.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | / pub fn traversal_limit_in_words<'a>(&'a mut self, value: u64) -> &'a mut ReaderOptions { [INFO] [stderr] 84 | | self.traversal_limit_in_words = value; [INFO] [stderr] 85 | | self [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: trait `ReaderSegments` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stderr] --> src/message.rs:90:1 [INFO] [stderr] | [INFO] [stderr] 90 | / pub trait ReaderSegments { [INFO] [stderr] 91 | | /// Gets the segment with index `idx`. Returns `None` if `idx` is out of range. [INFO] [stderr] 92 | | fn get_segment<'a>(&'a self, idx: u32) -> Option<&'a [Word]>; [INFO] [stderr] 93 | | [INFO] [stderr] ... | [INFO] [stderr] 102 | | } [INFO] [stderr] 103 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/message.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | fn get_segment<'a>(&'a self, idx: u32) -> Option<&'a [Word]>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/message.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | / fn get_segment<'a>(&'a self, id: u32) -> Option<&'a [Word]> { [INFO] [stderr] 118 | | self.segments.get(id as usize).map(|slice| *slice) [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/message.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | self.segments.get(id as usize).map(|slice| *slice) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.segments.get(id as usize).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/message.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | / fn get_segment<'a>(&'a self, id: u32) -> Option<&'a[Word]> { [INFO] [stderr] 128 | | self.get(id as usize).map(|slice| *slice) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/message.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | self.get(id as usize).map(|slice| *slice) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.get(id as usize).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/message.rs:306:5 [INFO] [stderr] | [INFO] [stderr] 306 | / fn get_root_internal<'a>(&'a mut self) -> any_pointer::Builder<'a> { [INFO] [stderr] 307 | | if self.arena.len() == 0 { [INFO] [stderr] 308 | | self.arena.allocate_segment(1).expect("allocate root pointer"); [INFO] [stderr] 309 | | self.arena.allocate(0, 1).expect("allocate root pointer"); [INFO] [stderr] ... | [INFO] [stderr] 316 | | layout::PointerBuilder::get_root(arena, 0, location)) [INFO] [stderr] 317 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/message.rs:364:5 [INFO] [stderr] | [INFO] [stderr] 364 | / pub fn get_segments_for_output<'a>(&'a self) -> OutputSegments<'a> { [INFO] [stderr] 365 | | self.arena.get_segments_for_output() [INFO] [stderr] 366 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/message.rs:377:5 [INFO] [stderr] | [INFO] [stderr] 377 | / fn get_segment<'a>(&'a self, id: u32) -> Option<&'a [Word]> { [INFO] [stderr] 378 | | self.get_segments_for_output().get(id as usize).map(|x| *x) [INFO] [stderr] 379 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/message.rs:378:9 [INFO] [stderr] | [INFO] [stderr] 378 | self.get_segments_for_output().get(id as usize).map(|x| *x) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.get_segments_for_output().get(id as usize).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `message::HeapAllocator` [INFO] [stderr] --> src/message.rs:403:5 [INFO] [stderr] | [INFO] [stderr] 403 | / pub fn new() -> HeapAllocator { [INFO] [stderr] 404 | | HeapAllocator { owned_memory: Vec::new(), [INFO] [stderr] 405 | | next_size: SUGGESTED_FIRST_SEGMENT_WORDS, [INFO] [stderr] 406 | | allocation_strategy: SUGGESTED_ALLOCATION_STRATEGY } [INFO] [stderr] 407 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 402 | impl Default for message::HeapAllocator { [INFO] [stderr] 403 | fn default() -> Self { [INFO] [stderr] 404 | Self::new() [INFO] [stderr] 405 | } [INFO] [stderr] 406 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/message.rs:427:9 [INFO] [stderr] | [INFO] [stderr] 427 | / match self.allocation_strategy { [INFO] [stderr] 428 | | AllocationStrategy::GrowHeuristically => { self.next_size += size; } [INFO] [stderr] 429 | | _ => { } [INFO] [stderr] 430 | | } [INFO] [stderr] | |_________^ help: try this: `if let AllocationStrategy::GrowHeuristically = self.allocation_strategy { self.next_size += size; }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: item `primitive_list::Reader<'a, T>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/primitive_list.rs:47:1 [INFO] [stderr] | [INFO] [stderr] 47 | / impl <'a, T: PrimitiveElement> Reader<'a, T> { [INFO] [stderr] 48 | | pub fn new<'b>(reader: ListReader<'b>) -> Reader<'b, T> { [INFO] [stderr] 49 | | Reader::<'b, T> { reader: reader, marker: marker::PhantomData } [INFO] [stderr] 50 | | } [INFO] [stderr] ... | [INFO] [stderr] 57 | | } [INFO] [stderr] 58 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `primitive_list::Builder<'a, T>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/primitive_list.rs:85:1 [INFO] [stderr] | [INFO] [stderr] 85 | / impl <'a, T> Builder<'a, T> where T: PrimitiveElement { [INFO] [stderr] 86 | | pub fn new(builder: ListBuilder<'a>) -> Builder<'a, T> { [INFO] [stderr] 87 | | Builder { builder: builder, marker: marker::PhantomData } [INFO] [stderr] 88 | | } [INFO] [stderr] ... | [INFO] [stderr] 106 | | } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/primitive_list.rs:93:22 [INFO] [stderr] | [INFO] [stderr] 93 | pub fn as_reader(self) -> Reader<'a, T> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/primitive_list.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | / pub fn reborrow<'b>(&'b self) -> Builder<'b, T> { [INFO] [stderr] 127 | | Builder { .. *self } [INFO] [stderr] 128 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/private/arena.rs:45:31 [INFO] [stderr] | [INFO] [stderr] 45 | Err(Error::failed(format!("read limit exceeded"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"read limit exceeded".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/private/arena.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | / fn get_segment<'a>(&'a self, id: u32) -> Result<(*const Word, u32)> { [INFO] [stderr] 88 | | match self.segments.get_segment(id) { [INFO] [stderr] 89 | | Some(seg) => Ok((seg.as_ptr(), seg.len() as u32)), [INFO] [stderr] 90 | | None => Err(Error::failed(format!("Invalid segment id: {}", id))), [INFO] [stderr] 91 | | } [INFO] [stderr] 92 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/private/arena.rs:103:25 [INFO] [stderr] | [INFO] [stderr] 103 | unsafe { Ok(start.offset(offset_in_words as isize)) } [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/private/arena.rs:98:27 [INFO] [stderr] | [INFO] [stderr] 98 | let offset: i64 = offset_in_words as i64 * BYTES_PER_WORD as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(offset_in_words)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/private/arena.rs:101:31 [INFO] [stderr] | [INFO] [stderr] 101 | Err(Error::failed(format!("message contained out-of-bounds pointer"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"message contained out-of-bounds pointer".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/private/arena.rs:115:31 [INFO] [stderr] | [INFO] [stderr] 115 | Err(Error::failed(format!("message contained out-of-bounds pointer"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"message contained out-of-bounds pointer".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/private/arena.rs:137:5 [INFO] [stderr] | [INFO] [stderr] 137 | fn as_reader<'a>(&'a self) -> &'a ReaderArena; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: item `private::arena::BuilderArenaImpl` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/private/arena.rs:152:1 [INFO] [stderr] | [INFO] [stderr] 152 | / impl BuilderArenaImpl where A: Allocator { [INFO] [stderr] 153 | | pub fn new(allocator: A) -> Self { [INFO] [stderr] 154 | | BuilderArenaImpl { [INFO] [stderr] 155 | | inner: RefCell::new(BuilderArenaImplInner { [INFO] [stderr] ... | [INFO] [stderr] 192 | | } [INFO] [stderr] 193 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/private/arena.rs:167:5 [INFO] [stderr] | [INFO] [stderr] 167 | / pub fn get_segments_for_output<'a>(&'a self) -> OutputSegments<'a> { [INFO] [stderr] 168 | | let reff = self.inner.borrow(); [INFO] [stderr] 169 | | if reff.allocated.len() == 1 { [INFO] [stderr] 170 | | let seg = reff.segments[0]; [INFO] [stderr] ... | [INFO] [stderr] 187 | | } [INFO] [stderr] 188 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/private/arena.rs:203:21 [INFO] [stderr] | [INFO] [stderr] 203 | unsafe { Ok(start.offset(offset_in_words as isize)) } [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/private/arena.rs:237:13 [INFO] [stderr] | [INFO] [stderr] 237 | / match self.allocate(segment_id, amount) { [INFO] [stderr] 238 | | Some(idx) => return (segment_id, idx), [INFO] [stderr] 239 | | None => (), [INFO] [stderr] 240 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(idx) = self.allocate(segment_id, amount) { return (segment_id, idx) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/private/arena.rs:269:5 [INFO] [stderr] | [INFO] [stderr] 269 | / fn as_reader<'a>(&'a self) -> &'a ReaderArena { [INFO] [stderr] 270 | | self [INFO] [stderr] 271 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/private/arena.rs:276:12 [INFO] [stderr] | [INFO] [stderr] 276 | if self.allocated.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.allocated.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/private/arena.rs:286:27 [INFO] [stderr] | [INFO] [stderr] 286 | Err(Error::failed(format!("tried to read from null arena"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"tried to read from null arena".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/private/arena.rs:290:21 [INFO] [stderr] | [INFO] [stderr] 290 | unsafe { Ok(start.offset(offset_in_words as isize)) } [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/private/arena.rs:315:5 [INFO] [stderr] | [INFO] [stderr] 315 | / fn as_reader<'a>(&'a self) -> &'a ReaderArena { [INFO] [stderr] 316 | | self [INFO] [stderr] 317 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/private/capability.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | fn get<'a>(&'a mut self) -> any_pointer::Builder<'a>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/private/capability.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | fn send<'a>(self: Box) -> RemotePromise; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/private/capability.rs:35:21 [INFO] [stderr] | [INFO] [stderr] 35 | -> Option<(u32, ::capability::Promise<(), ::Error>, Box)>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/private/endian.rs:87:18 [INFO] [stderr] | [INFO] [stderr] 87 | unsafe { mem::transmute(mem::transmute::(*self).to_le()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(mem::transmute::(*self).to_le())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_float)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/private/endian.rs:90:26 [INFO] [stderr] | [INFO] [stderr] 90 | *self = unsafe { mem::transmute(mem::transmute::(value).to_le()) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(mem::transmute::(value).to_le())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u64` to a `f64` [INFO] [stderr] --> src/private/endian.rs:96:18 [INFO] [stderr] | [INFO] [stderr] 96 | unsafe { mem::transmute(mem::transmute::(*self).to_le()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits(mem::transmute::(*self).to_le())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u64` to a `f64` [INFO] [stderr] --> src/private/endian.rs:99:26 [INFO] [stderr] | [INFO] [stderr] 99 | *self = unsafe { mem::transmute(mem::transmute::(value).to_le()) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits(mem::transmute::(value).to_le())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/private/layout.rs:94:18 [INFO] [stderr] | [INFO] [stderr] 94 | pub fn total(&self) -> WordCount32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | self.data as WordCount32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:96:15 [INFO] [stderr] | [INFO] [stderr] 96 | + self.pointers as WordCount32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.pointers)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: casting from `*const private::layout::WirePointer` to a more-strictly-aligned pointer (`*const Word`) [INFO] [stderr] --> src/private/layout.rs:154:38 [INFO] [stderr] | [INFO] [stderr] 154 | let this_addr: *const Word = self as *const _ as *const _; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const private::layout::WirePointer` to a more-strictly-aligned pointer (`*const Word`) [INFO] [stderr] --> src/private/layout.rs:160:38 [INFO] [stderr] | [INFO] [stderr] 160 | let this_addr: *const Word = self as *const _ as *const _; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut private::layout::WirePointer` to a more-strictly-aligned pointer (`*mut Word`) [INFO] [stderr] --> src/private/layout.rs:167:36 [INFO] [stderr] | [INFO] [stderr] 167 | let this_addr: *mut Word = self as *mut _ as *mut _; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `self.upper32bits.get()` [INFO] [stderr] --> src/private/layout.rs:235:9 [INFO] [stderr] | [INFO] [stderr] 235 | (self.upper32bits.get() & 0xffffffff) as WordCount16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:245:9 [INFO] [stderr] | [INFO] [stderr] 245 | self.struct_data_size() as WordCount32 + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.struct_data_size())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:246:13 [INFO] [stderr] | [INFO] [stderr] 246 | self.struct_ptr_count() as WordCount32 * WORDS_PER_POINTER as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.struct_ptr_count())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:251:30 [INFO] [stderr] | [INFO] [stderr] 251 | self.upper32bits.set(size.data as u32 | ((size.pointers as u32) << 16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(size.data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:251:50 [INFO] [stderr] | [INFO] [stderr] 251 | self.upper32bits.set(size.data as u32 | ((size.pointers as u32) << 16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(size.pointers)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: casting from `*mut private::layout::WirePointer` to a more-strictly-aligned pointer (`*mut Word`) [INFO] [stderr] --> src/private/layout.rs:383:21 [INFO] [stderr] | [INFO] [stderr] 383 | return (reff as *mut _, reff, segment_id); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:407:28 [INFO] [stderr] | [INFO] [stderr] 407 | let ptr1 = ptr.offset(POINTER_SIZE_IN_WORDS as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(POINTER_SIZE_IN_WORDS)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:560:52 [INFO] [stderr] | [INFO] [stderr] 560 | round_bits_up_to_words(( [INFO] [stderr] | ____________________________________________________^ [INFO] [stderr] 561 | | (*tag).list_element_count() * [INFO] [stderr] 562 | | data_bits_per_element( [INFO] [stderr] 563 | | (*tag).list_element_size())) as u64) as usize) [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 560 | round_bits_up_to_words(u64::from( [INFO] [stderr] 561 | (*tag).list_element_count() * [INFO] [stderr] 562 | data_bits_per_element( [INFO] [stderr] 563 | (*tag).list_element_size()))) as usize) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:643:38 [INFO] [stderr] | [INFO] [stderr] 643 | result.word_count += (*reff).struct_word_size() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from((*reff).struct_word_size())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:657:29 [INFO] [stderr] | [INFO] [stderr] 657 | (*reff).list_element_count() as u64 * [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from((*reff).list_element_count())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:658:33 [INFO] [stderr] | [INFO] [stderr] 658 | data_bits_per_element((*reff).list_element_size()) as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(data_bits_per_element((*reff).list_element_size()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:661:46 [INFO] [stderr] | [INFO] [stderr] 661 | result.word_count += total_words as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(total_words)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:669:46 [INFO] [stderr] | [INFO] [stderr] 669 | result.word_count += count as u64 * WORDS_PER_POINTER as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:692:43 [INFO] [stderr] | [INFO] [stderr] 692 | let actual_size = (*element_tag).struct_word_size() as u64 * count as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from((*element_tag).struct_word_size())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:692:86 [INFO] [stderr] | [INFO] [stderr] 692 | let actual_size = (*element_tag).struct_word_size() as u64 * count as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:693:42 [INFO] [stderr] | [INFO] [stderr] 693 | if actual_size > word_count as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(word_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:706:56 [INFO] [stderr] | [INFO] [stderr] 706 | let mut pos: *const Word = ptr.offset(POINTER_SIZE_IN_WORDS as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(POINTER_SIZE_IN_WORDS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:714:43 [INFO] [stderr] | [INFO] [stderr] 714 | pos = pos.offset(POINTER_SIZE_IN_WORDS as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `pos.add(POINTER_SIZE_IN_WORDS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/private/layout.rs:828:5 [INFO] [stderr] | [INFO] [stderr] 828 | / pub unsafe fn init_struct_pointer<'a>( [INFO] [stderr] 829 | | arena: &'a BuilderArena, [INFO] [stderr] 830 | | reff: *mut WirePointer, [INFO] [stderr] 831 | | segment_id: u32, [INFO] [stderr] ... | [INFO] [stderr] 851 | | } [INFO] [stderr] 852 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:848:23 [INFO] [stderr] | [INFO] [stderr] 848 | pointers: ptr.offset((size.data as usize) as isize) as *mut _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add((size.data as usize))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:849:24 [INFO] [stderr] | [INFO] [stderr] 849 | data_size: size.data as WordCount32 * (BITS_PER_WORD as BitCount32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(size.data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:891:30 [INFO] [stderr] | [INFO] [stderr] 891 | let total_size = new_data_size as u32 + new_pointer_count as u32 * WORDS_PER_POINTER as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(new_data_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:891:53 [INFO] [stderr] | [INFO] [stderr] 891 | let total_size = new_data_size as u32 + new_pointer_count as u32 * WORDS_PER_POINTER as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(new_pointer_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:918:28 [INFO] [stderr] | [INFO] [stderr] 918 | data_size: new_data_size as u32 * BITS_PER_WORD as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(new_data_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:928:28 [INFO] [stderr] | [INFO] [stderr] 928 | data_size: old_data_size as u32 * BITS_PER_WORD as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(old_data_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/private/layout.rs:935:5 [INFO] [stderr] | [INFO] [stderr] 935 | / pub unsafe fn init_list_pointer<'a>( [INFO] [stderr] 936 | | arena: &'a BuilderArena, [INFO] [stderr] 937 | | reff: *mut WirePointer, [INFO] [stderr] 938 | | segment_id: u32, [INFO] [stderr] ... | [INFO] [stderr] 964 | | } [INFO] [stderr] 965 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:949:49 [INFO] [stderr] | [INFO] [stderr] 949 | let word_count = round_bits_up_to_words(element_count as ElementCount64 * (step as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(element_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:949:83 [INFO] [stderr] | [INFO] [stderr] 949 | let word_count = round_bits_up_to_words(element_count as ElementCount64 * (step as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(step)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/private/layout.rs:968:5 [INFO] [stderr] | [INFO] [stderr] 968 | / pub unsafe fn init_struct_list_pointer<'a>( [INFO] [stderr] 969 | | arena: &'a BuilderArena, [INFO] [stderr] 970 | | reff: *mut WirePointer, [INFO] [stderr] 971 | | segment_id: u32, [INFO] [stderr] ... | [INFO] [stderr] 1004 | | } [INFO] [stderr] 1005 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:992:20 [INFO] [stderr] | [INFO] [stderr] 992 | let ptr1 = ptr.offset(POINTER_SIZE_IN_WORDS as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(POINTER_SIZE_IN_WORDS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1002:31 [INFO] [stderr] | [INFO] [stderr] 1002 | struct_data_size: element_size.data as u32 * (BITS_PER_WORD as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(element_size.data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:1058:19 [INFO] [stderr] | [INFO] [stderr] 1058 | ptr = ptr.offset(POINTER_SIZE_IN_WORDS as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(POINTER_SIZE_IN_WORDS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1097:35 [INFO] [stderr] | [INFO] [stderr] 1097 | struct_data_size: data_size as u32 * BITS_PER_WORD as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(data_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:1160:23 [INFO] [stderr] | [INFO] [stderr] 1160 | old_ptr = old_ptr.offset(POINTER_SIZE_IN_WORDS as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `old_ptr.add(POINTER_SIZE_IN_WORDS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1168:28 [INFO] [stderr] | [INFO] [stderr] 1168 | let old_step = old_data_size as u32 + old_pointer_count as u32 * WORDS_PER_POINTER as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(old_data_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1168:51 [INFO] [stderr] | [INFO] [stderr] 1168 | let old_step = old_data_size as u32 + old_pointer_count as u32 * WORDS_PER_POINTER as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(old_pointer_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1181:39 [INFO] [stderr] | [INFO] [stderr] 1181 | struct_data_size: old_data_size as u32 * BITS_PER_WORD as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(old_data_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1191:28 [INFO] [stderr] | [INFO] [stderr] 1191 | let new_step = new_data_size as u32 + new_pointer_count as u32 * WORDS_PER_POINTER as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(new_data_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1191:51 [INFO] [stderr] | [INFO] [stderr] 1191 | let new_step = new_data_size as u32 + new_pointer_count as u32 * WORDS_PER_POINTER as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(new_pointer_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:1205:23 [INFO] [stderr] | [INFO] [stderr] 1205 | new_ptr = new_ptr.offset(POINTER_SIZE_IN_WORDS as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `new_ptr.add(POINTER_SIZE_IN_WORDS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1227:31 [INFO] [stderr] | [INFO] [stderr] 1227 | (old_step as u64 * element_count as u64) as usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(old_step)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1227:49 [INFO] [stderr] | [INFO] [stderr] 1227 | (old_step as u64 * element_count as u64) as usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(element_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1237:35 [INFO] [stderr] | [INFO] [stderr] 1237 | struct_data_size: new_data_size as u32 * BITS_PER_WORD as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(new_data_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1271:32 [INFO] [stderr] | [INFO] [stderr] 1271 | let new_step = new_data_size as u32 + new_pointer_count as u32 * WORDS_PER_POINTER as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(new_data_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1271:55 [INFO] [stderr] | [INFO] [stderr] 1271 | let new_step = new_data_size as u32 + new_pointer_count as u32 * WORDS_PER_POINTER as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(new_pointer_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:1285:27 [INFO] [stderr] | [INFO] [stderr] 1285 | new_ptr = new_ptr.offset(POINTER_SIZE_IN_WORDS as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `new_ptr.add(POINTER_SIZE_IN_WORDS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1308:57 [INFO] [stderr] | [INFO] [stderr] 1308 | round_bits_up_to_bytes(old_step as u64 * element_count as u64) as usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(old_step)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1308:75 [INFO] [stderr] | [INFO] [stderr] 1308 | round_bits_up_to_bytes(old_step as u64 * element_count as u64) as usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(element_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1318:39 [INFO] [stderr] | [INFO] [stderr] 1318 | struct_data_size: new_data_size as u32 * BITS_PER_WORD as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(new_data_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/private/layout.rs:1393:12 [INFO] [stderr] | [INFO] [stderr] 1393 | if count <= 0 || *cptr.offset((count - 1) as isize) != 0 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using count == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut Word`) [INFO] [stderr] --> src/private/layout.rs:1446:42 [INFO] [stderr] | [INFO] [stderr] 1446 | builder.as_mut_ptr() as *mut _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1474:65 [INFO] [stderr] | [INFO] [stderr] 1474 | let mut data_size: ByteCount32 = round_bits_up_to_bytes(value.data_size as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(value.data_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/private/layout.rs:1496:24 [INFO] [stderr] | [INFO] [stderr] 1496 | if last_word == &[0; 8] { [INFO] [stderr] | ^^^^^^^^^^^^^------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `[0; 8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1510:52 [INFO] [stderr] | [INFO] [stderr] 1510 | let total_size: WordCount32 = data_words + ptr_count as u32 * WORDS_PER_POINTER as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(ptr_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1556:49 [INFO] [stderr] | [INFO] [stderr] 1556 | let total_size = round_bits_up_to_words((value.element_count * value.step) as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(value.element_count * value.step)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const private::layout::WirePointer`) [INFO] [stderr] --> src/private/layout.rs:1571:39 [INFO] [stderr] | [INFO] [stderr] 1571 | (value.ptr as *const WirePointer).offset(i), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1593:39 [INFO] [stderr] | [INFO] [stderr] 1593 | let whole_byte_size = value.element_count as u64 * value.step as u64 / BITS_PER_BYTE as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(value.element_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1593:68 [INFO] [stderr] | [INFO] [stderr] 1593 | let whole_byte_size = value.element_count as u64 * value.step as u64 / BITS_PER_BYTE as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(value.step)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1597:37 [INFO] [stderr] | [INFO] [stderr] 1597 | let leftover_bits = value.element_count as u64 * value.step as u64 % BITS_PER_BYTE as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(value.element_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1597:66 [INFO] [stderr] | [INFO] [stderr] 1597 | let leftover_bits = value.element_count as u64 * value.step as u64 % BITS_PER_BYTE as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(value.step)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/private/layout.rs:1615:13 [INFO] [stderr] | [INFO] [stderr] 1615 | / let mut total_size = total_size; [INFO] [stderr] 1616 | | [INFO] [stderr] 1617 | | if canonicalize { [INFO] [stderr] 1618 | | for ec in 0..value.element_count { [INFO] [stderr] ... | [INFO] [stderr] 1646 | | ptr_count = decl_pointer_count; [INFO] [stderr] 1647 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let total_size = if canonicalize { ..; (data_size as u32 + ptr_count as u32) * value.element_count as u32 } else { ..; total_size };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/private/layout.rs:1626:28 [INFO] [stderr] | [INFO] [stderr] 1626 | if last_word != &[0; 8] { [INFO] [stderr] | ^^^^^^^^^^^^^------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `[0; 8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1643:50 [INFO] [stderr] | [INFO] [stderr] 1643 | total_size = (data_size as u32 + ptr_count as u32) * value.element_count as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(ptr_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:1657:27 [INFO] [stderr] | [INFO] [stderr] 1657 | let mut dst = ptr.offset(POINTER_SIZE_IN_WORDS as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(POINTER_SIZE_IN_WORDS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const Word`) [INFO] [stderr] --> src/private/layout.rs:1659:40 [INFO] [stderr] | [INFO] [stderr] 1659 | let mut src: *const Word = value.ptr as *const _; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:1669:27 [INFO] [stderr] | [INFO] [stderr] 1669 | dst = dst.offset(POINTER_SIZE_IN_WORDS as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dst.add(POINTER_SIZE_IN_WORDS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:1670:27 [INFO] [stderr] | [INFO] [stderr] 1670 | src = src.offset(POINTER_SIZE_IN_WORDS as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `src.add(POINTER_SIZE_IN_WORDS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/private/layout.rs:1679:5 [INFO] [stderr] | [INFO] [stderr] 1679 | / pub unsafe fn copy_pointer( [INFO] [stderr] 1680 | | dst_arena: &BuilderArena, [INFO] [stderr] 1681 | | dst_segment_id: u32, dst_cap_table: CapTableBuilder, [INFO] [stderr] 1682 | | dst: *mut WirePointer, [INFO] [stderr] ... | [INFO] [stderr] 1829 | | } [INFO] [stderr] 1830 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1716:36 [INFO] [stderr] | [INFO] [stderr] 1716 | data_size: (*src).struct_data_size() as u32 * BITS_PER_WORD as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((*src).struct_data_size())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:1732:27 [INFO] [stderr] | [INFO] [stderr] 1732 | ptr = ptr.offset(POINTER_SIZE_IN_WORDS as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(POINTER_SIZE_IN_WORDS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1746:24 [INFO] [stderr] | [INFO] [stderr] 1746 | if words_per_element as u64 * element_count as u64 > word_count as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(words_per_element)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1746:51 [INFO] [stderr] | [INFO] [stderr] 1746 | if words_per_element as u64 * element_count as u64 > word_count as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(element_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1746:74 [INFO] [stderr] | [INFO] [stderr] 1746 | if words_per_element as u64 * element_count as u64 > word_count as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(word_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1754:56 [INFO] [stderr] | [INFO] [stderr] 1754 | try!(amplified_read(src_arena, element_count as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(element_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1768:47 [INFO] [stderr] | [INFO] [stderr] 1768 | struct_data_size: (*tag).struct_data_size() as u32 * BITS_PER_WORD as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((*tag).struct_data_size())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1778:61 [INFO] [stderr] | [INFO] [stderr] 1778 | let word_count = round_bits_up_to_words(element_count as u64 * step as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(element_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1778:84 [INFO] [stderr] | [INFO] [stderr] 1778 | let word_count = round_bits_up_to_words(element_count as u64 * step as u64); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(step)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1787:56 [INFO] [stderr] | [INFO] [stderr] 1787 | try!(amplified_read(src_arena, element_count as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(element_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1873:24 [INFO] [stderr] | [INFO] [stderr] 1873 | data_size: data_size_words as u32 * BITS_PER_WORD as BitCount32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(data_size_words)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/private/layout.rs:1937:47 [INFO] [stderr] | [INFO] [stderr] 1937 | let tag: *const WirePointer = mem::transmute(ptr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `ptr as *const private::layout::WirePointer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1955:20 [INFO] [stderr] | [INFO] [stderr] 1955 | if size as u64 * words_per_element as u64 > word_count as u64 { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1955:34 [INFO] [stderr] | [INFO] [stderr] 1955 | if size as u64 * words_per_element as u64 > word_count as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(words_per_element)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1955:61 [INFO] [stderr] | [INFO] [stderr] 1955 | if size as u64 * words_per_element as u64 > word_count as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(word_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:1963:48 [INFO] [stderr] | [INFO] [stderr] 1963 | try!(amplified_read(arena, size as u64)); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/private/layout.rs:1989:28 [INFO] [stderr] | [INFO] [stderr] 1989 | if ptr_count <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using ptr_count == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:2004:39 [INFO] [stderr] | [INFO] [stderr] 2004 | struct_data_size: data_size as u32 * (BITS_PER_WORD as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(data_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:2018:57 [INFO] [stderr] | [INFO] [stderr] 2018 | let word_count = round_bits_up_to_words(element_count as u64 * step as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(element_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:2018:80 [INFO] [stderr] | [INFO] [stderr] 2018 | let word_count = round_bits_up_to_words(element_count as u64 * step as u64); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(step)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:2025:48 [INFO] [stderr] | [INFO] [stderr] 2025 | try!(amplified_read(arena, element_count as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(element_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/private/layout.rs:2099:12 [INFO] [stderr] | [INFO] [stderr] 2099 | if size <= 0 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using size == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/private/layout.rs:2168:24 [INFO] [stderr] | [INFO] [stderr] 2168 | pub fn extract_cap(&self, index: usize) -> Option> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/private/layout.rs:2206:24 [INFO] [stderr] | [INFO] [stderr] 2206 | pub fn extract_cap(&self, index: usize) -> Option> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/private/layout.rs:2288:5 [INFO] [stderr] | [INFO] [stderr] 2288 | / pub fn borrow<'b>(&'b self) -> PointerReader<'b> { [INFO] [stderr] 2289 | | PointerReader { arena: self.arena, .. *self } [INFO] [stderr] 2290 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/private/layout.rs:2322:47 [INFO] [stderr] | [INFO] [stderr] 2322 | default_value, self.nesting_limit) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/private/layout.rs:2335:17 [INFO] [stderr] | [INFO] [stderr] 2335 | default_value, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/private/layout.rs:2356:80 [INFO] [stderr] | [INFO] [stderr] 2356 | wire_helpers::read_text_pointer(self.arena, self.segment_id, reff, default_value, default_size) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/private/layout.rs:2363:80 [INFO] [stderr] | [INFO] [stderr] 2363 | wire_helpers::read_data_pointer(self.arena, self.segment_id, reff, default_value, default_size) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/private/layout.rs:2385:41 [INFO] [stderr] | [INFO] [stderr] 2385 | Err(::Error::failed(format!("Unexpected FAR pointer"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Unexpected FAR pointer".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/private/layout.rs:2392:45 [INFO] [stderr] | [INFO] [stderr] 2392 | Err(::Error::failed(format!("Unknown pointer type"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Unknown pointer type".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: casting from `*const private::layout::WirePointer` to a more-strictly-aligned pointer (`*const Word`) [INFO] [stderr] --> src/private/layout.rs:2411:24 [INFO] [stderr] | [INFO] [stderr] 2411 | Ok(self.pointer as *const _ == st.get_location()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/private/layout.rs:2449:5 [INFO] [stderr] | [INFO] [stderr] 2449 | / pub fn borrow<'b>(&'b mut self) -> PointerBuilder<'b> { [INFO] [stderr] 2450 | | PointerBuilder { arena: self.arena, .. *self } [INFO] [stderr] 2451 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/private/layout.rs:2469:17 [INFO] [stderr] | [INFO] [stderr] 2469 | default_value) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/private/layout.rs:2478:90 [INFO] [stderr] | [INFO] [stderr] 2478 | self.arena, self.pointer, self.segment_id, self.cap_table, element_size, default_value) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/private/layout.rs:2487:90 [INFO] [stderr] | [INFO] [stderr] 2487 | self.arena, self.pointer, self.segment_id, self.cap_table, element_size, default_value) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/private/layout.rs:2497:48 [INFO] [stderr] | [INFO] [stderr] 2497 | self.pointer, self.segment_id, default_value, default_size) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/private/layout.rs:2506:60 [INFO] [stderr] | [INFO] [stderr] 2506 | self.arena, self.pointer, self.segment_id, default_value, default_size) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:2676:19 [INFO] [stderr] | [INFO] [stderr] 2676 | (*dwv.offset(offset as isize)).get() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dwv.add(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:2688:36 [INFO] [stderr] | [INFO] [stderr] 2688 | let b: *const u8 = self.data.offset((boffset as usize / BITS_PER_BYTE) as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.data.add((boffset as usize / BITS_PER_BYTE))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:2717:35 [INFO] [stderr] | [INFO] [stderr] 2717 | pointer: unsafe { self.pointers.offset(ptr_index as isize) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.pointers.add(ptr_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:2727:25 [INFO] [stderr] | [INFO] [stderr] 2727 | word_count: wire_helpers::round_bits_up_to_words(self.data_size as u64) as u64 + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(wire_helpers::round_bits_up_to_words(self.data_size as u64))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:2727:62 [INFO] [stderr] | [INFO] [stderr] 2727 | word_count: wire_helpers::round_bits_up_to_words(self.data_size as u64) as u64 + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.data_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:2728:17 [INFO] [stderr] | [INFO] [stderr] 2728 | self.pointer_count as u64 * WORDS_PER_POINTER as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.pointer_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const Word`) [INFO] [stderr] --> src/private/layout.rs:2745:9 [INFO] [stderr] | [INFO] [stderr] 2745 | self.data as * const _ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:2832:15 [INFO] [stderr] | [INFO] [stderr] 2832 | (*ptr.offset(offset as isize)).set(value) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:2848:15 [INFO] [stderr] | [INFO] [stderr] 2848 | (*ptr.offset(offset as isize)).get() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:2865:26 [INFO] [stderr] | [INFO] [stderr] 2865 | let b = unsafe { self.data.offset((boffset / BITS_PER_BYTE) as isize)}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.data.add((boffset / BITS_PER_BYTE))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:2881:26 [INFO] [stderr] | [INFO] [stderr] 2881 | let b = unsafe { self.data.offset((boffset / BITS_PER_BYTE) as isize) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.data.add((boffset / BITS_PER_BYTE))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:2899:31 [INFO] [stderr] | [INFO] [stderr] 2899 | pointer: unsafe { self.pointers.offset(ptr_index as isize) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.pointers.add(ptr_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/private/layout.rs:2915:44 [INFO] [stderr] | [INFO] [stderr] 2915 | return Err(::Error::failed(format!("Only one of the section pointers is pointing to ourself"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Only one of the section pointers is pointing to ourself".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: item `private::layout::ListReader<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/private/layout.rs:2979:1 [INFO] [stderr] | [INFO] [stderr] 2979 | / impl <'a> ListReader<'a> { [INFO] [stderr] 2980 | | pub fn new_default<'b>() -> ListReader<'b> { [INFO] [stderr] 2981 | | ListReader { [INFO] [stderr] 2982 | | arena: &NULL_ARENA, [INFO] [stderr] ... | [INFO] [stderr] 3132 | | } [INFO] [stderr] 3133 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3005:15 [INFO] [stderr] | [INFO] [stderr] 3005 | ((index as ElementCount64 * (self.step as BitCount64)) / BITS_PER_BYTE as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3005:41 [INFO] [stderr] | [INFO] [stderr] 3005 | ((index as ElementCount64 * (self.step as BitCount64)) / BITS_PER_BYTE as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.step)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const private::layout::WirePointer`) [INFO] [stderr] --> src/private/layout.rs:3010:13 [INFO] [stderr] | [INFO] [stderr] 3010 | struct_data.offset((self.struct_data_size as usize / BITS_PER_BYTE) as isize) as *const _ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:3010:13 [INFO] [stderr] | [INFO] [stderr] 3010 | struct_data.offset((self.struct_data_size as usize / BITS_PER_BYTE) as isize) as *const _ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `struct_data.add((self.struct_data_size as usize / BITS_PER_BYTE))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3027:23 [INFO] [stderr] | [INFO] [stderr] 3027 | let offset = (index as u64 * self.step as u64 / BITS_PER_BYTE as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3027:38 [INFO] [stderr] | [INFO] [stderr] 3027 | let offset = (index as u64 * self.step as u64 / BITS_PER_BYTE as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(self.step)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*mut private::layout::WirePointer`) [INFO] [stderr] --> src/private/layout.rs:3032:31 [INFO] [stderr] | [INFO] [stderr] 3032 | pointer: unsafe { self.ptr.offset(offset as isize) as *mut _ }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/private/layout.rs:3054:45 [INFO] [stderr] | [INFO] [stderr] 3054 | let word_count = unsafe { (*reff).list_inline_composite_word_count() }; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const Word`) [INFO] [stderr] --> src/private/layout.rs:3046:20 [INFO] [stderr] | [INFO] [stderr] 3046 | if self.ptr as *const _ != read_head.get() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3053:21 [INFO] [stderr] | [INFO] [stderr] 3053 | self.struct_pointer_count as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.struct_pointer_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const Word`) [INFO] [stderr] --> src/private/layout.rs:3083:20 [INFO] [stderr] | [INFO] [stderr] 3083 | if self.ptr as *const _ != read_head.get() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3099:32 [INFO] [stderr] | [INFO] [stderr] 3099 | let bit_size = self.element_count as u64 * data_bits_per_element(element_size) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.element_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3099:60 [INFO] [stderr] | [INFO] [stderr] 3099 | let bit_size = self.element_count as u64 * data_bits_per_element(element_size) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(data_bits_per_element(element_size))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: item `private::layout::ListBuilder<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/private/layout.rs:3148:1 [INFO] [stderr] | [INFO] [stderr] 3148 | / impl <'a> ListBuilder<'a> { [INFO] [stderr] 3149 | | [INFO] [stderr] 3150 | | #[inline] [INFO] [stderr] 3151 | | pub fn new_default<'b>() -> ListBuilder<'b> { [INFO] [stderr] ... | [INFO] [stderr] 3223 | | } [INFO] [stderr] 3224 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/private/layout.rs:3185:5 [INFO] [stderr] | [INFO] [stderr] 3185 | / pub fn borrow<'b>(&'b mut self) -> ListBuilder<'b> { [INFO] [stderr] 3186 | | ListBuilder { arena: self.arena, ..*self } [INFO] [stderr] 3187 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3198:28 [INFO] [stderr] | [INFO] [stderr] 3198 | let index_byte = ((index as u64 * self.step as u64) / BITS_PER_BYTE as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3198:43 [INFO] [stderr] | [INFO] [stderr] 3198 | let index_byte = ((index as u64 * self.step as u64) / BITS_PER_BYTE as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(self.step)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut private::layout::WirePointer`) [INFO] [stderr] --> src/private/layout.rs:3201:13 [INFO] [stderr] | [INFO] [stderr] 3201 | struct_data.offset(((self.struct_data_size as usize) / BITS_PER_BYTE) as isize) as *mut _ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/private/layout.rs:3201:13 [INFO] [stderr] | [INFO] [stderr] 3201 | struct_data.offset(((self.struct_data_size as usize) / BITS_PER_BYTE) as isize) as *mut _ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `struct_data.add(((self.struct_data_size as usize) / BITS_PER_BYTE))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3216:23 [INFO] [stderr] | [INFO] [stderr] 3216 | let offset = (index as u64 * self.step as u64 / BITS_PER_BYTE as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3216:38 [INFO] [stderr] | [INFO] [stderr] 3216 | let offset = (index as u64 * self.step as u64 / BITS_PER_BYTE as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(self.step)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut private::layout::WirePointer`) [INFO] [stderr] --> src/private/layout.rs:3221:22 [INFO] [stderr] | [INFO] [stderr] 3221 | pointer: unsafe { self.ptr.offset(offset as isize) } as *mut _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3230:23 [INFO] [stderr] | [INFO] [stderr] 3230 | let offset = (index as u64 * list_reader.step as u64 / BITS_PER_BYTE as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3230:38 [INFO] [stderr] | [INFO] [stderr] 3230 | let offset = (index as u64 * list_reader.step as u64 / BITS_PER_BYTE as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(list_reader.step)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3239:23 [INFO] [stderr] | [INFO] [stderr] 3239 | let offset = (index as u64 * list_builder.step as u64 / BITS_PER_BYTE as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3239:38 [INFO] [stderr] | [INFO] [stderr] 3239 | let offset = (index as u64 * list_builder.step as u64 / BITS_PER_BYTE as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(list_builder.step)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3248:23 [INFO] [stderr] | [INFO] [stderr] 3248 | let offset = (index as u64 * list_builder.step as u64 / BITS_PER_BYTE as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3248:38 [INFO] [stderr] | [INFO] [stderr] 3248 | let offset = (index as u64 * list_builder.step as u64 / BITS_PER_BYTE as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(list_builder.step)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3281:22 [INFO] [stderr] | [INFO] [stderr] 3281 | let bindex = index as u64 * list.step as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3281:37 [INFO] [stderr] | [INFO] [stderr] 3281 | let bindex = index as u64 * list.step as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(list.step)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3289:22 [INFO] [stderr] | [INFO] [stderr] 3289 | let bindex = index as u64 * list.step as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3289:37 [INFO] [stderr] | [INFO] [stderr] 3289 | let bindex = index as u64 * list.step as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(list.step)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3295:22 [INFO] [stderr] | [INFO] [stderr] 3295 | let bindex = index as u64 * list.step as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/private/layout.rs:3295:37 [INFO] [stderr] | [INFO] [stderr] 3295 | let bindex = index as u64 * list.step as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(list.step)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/private/mask.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | mem::transmute(v ^ mask) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(v ^ mask)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u64` to a `f64` [INFO] [stderr] --> src/private/mask.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | mem::transmute(v ^ mask) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits(v ^ mask)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> src/private/layout_test.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | / fn simple_raw_data_struct() { [INFO] [stderr] 28 | | let data: &[Word] = &[ [INFO] [stderr] 29 | | capnp_word!(0x00, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00), [INFO] [stderr] 30 | | capnp_word!(0x01, 0x23, 0x45, 0x67, 0x89, 0xab, 0xcd, 0xef)]; [INFO] [stderr] ... | [INFO] [stderr] 69 | | assert_eq!(reader.get_bool_field(64), false); // past end of struct --> default value [INFO] [stderr] 70 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/serialize.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / fn get_segment<'b>(&'b self, id: u32) -> Option<&'b [Word]> { [INFO] [stderr] 40 | | if id < self.segment_slices.len() as u32 { [INFO] [stderr] 41 | | let (a, b) = self.segment_slices[id as usize]; [INFO] [stderr] 42 | | Some(&self.words[a..b]) [INFO] [stderr] ... | [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/serialize.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | / fn get_segment<'a>(&'a self, id: u32) -> Option<&'a [Word]> { [INFO] [stderr] 77 | | if id < self.segment_slices.len() as u32 { [INFO] [stderr] 78 | | let (a, b) = self.segment_slices[id as usize]; [INFO] [stderr] 79 | | Some(&self.owned_space[a..b]) [INFO] [stderr] ... | [INFO] [stderr] 82 | | } [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the loop variable `idx` is only used to index `segment`. [INFO] [stderr] --> src/serialize.rs:201:20 [INFO] [stderr] | [INFO] [stderr] 201 | for idx in 0..segment.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 201 | for in &segment { [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `idx` is only used to index `buf`. [INFO] [stderr] --> src/serialize.rs:250:28 [INFO] [stderr] | [INFO] [stderr] 250 | for idx in 4..8 { buf[idx] = 0 } [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 250 | for in buf.iter_mut().skip(4) { buf[idx] = 0 } [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `idx` is only used to index `buf`. [INFO] [stderr] --> src/serialize.rs:260:28 [INFO] [stderr] | [INFO] [stderr] 260 | for idx in (buf.len() - 4)..(buf.len()) { buf[idx] = 0 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 260 | for in buf.iter_mut().skip((buf.len() - 4)) { buf[idx] = 0 } [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/serialize.rs:313:63 [INFO] [stderr] | [INFO] [stderr] 313 | pub fn write_message_segments(write: &mut W, segments: &Vec>) where W: Write { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/serialize.rs:469:16 [INFO] [stderr] | [INFO] [stderr] 469 | if segments.len() == 0 { return TestResult::discard(); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `segments.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/serialize.rs:489:16 [INFO] [stderr] | [INFO] [stderr] 489 | if segments.len() == 0 { return TestResult::discard(); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `segments.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/serialize_packed.rs:156:27 [INFO] [stderr] | [INFO] [stderr] 156 | out = out.offset(run_length as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `out.add(run_length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/serialize_packed.rs:174:31 [INFO] [stderr] | [INFO] [stderr] 174 | out = out.offset(run_length as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `out.add(run_length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/serialize_packed.rs:175:34 [INFO] [stderr] | [INFO] [stderr] 175 | in_ptr = in_ptr.offset(run_length as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `in_ptr.add(run_length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/serialize_packed.rs:179:31 [INFO] [stderr] | [INFO] [stderr] 179 | out = out.offset(in_remaining as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `out.add(in_remaining)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/serialize_packed.rs:188:31 [INFO] [stderr] | [INFO] [stderr] 188 | out = out.offset(run_length as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `out.add(run_length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `bit0` [INFO] [stderr] --> src/serialize_packed.rs:290:31 [INFO] [stderr] | [INFO] [stderr] 290 | let tag: u8 = (bit0 << 0) | (bit1 << 1) | (bit2 << 2) | (bit3 << 3) [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u64`) [INFO] [stderr] --> src/serialize_packed.rs:302:52 [INFO] [stderr] | [INFO] [stderr] 302 | let mut in_word : *const u64 = in_ptr as *const u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u64`) [INFO] [stderr] --> src/serialize_packed.rs:303:50 [INFO] [stderr] | [INFO] [stderr] 303 | let mut limit : *const u64 = in_end as *const u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u64`) [INFO] [stderr] --> src/serialize_packed.rs:311:72 [INFO] [stderr] | [INFO] [stderr] 311 | *buf.get_unchecked_mut(buf_idx) = ptr_sub(in_word, in_ptr as *const u64) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/serialize_packed.rs:410:13 [INFO] [stderr] | [INFO] [stderr] 410 | packed_write.write(unpacked).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/serialize_packed.rs:451:16 [INFO] [stderr] | [INFO] [stderr] 451 | if segments.len() == 0 { return TestResult::discard(); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `segments.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: item `struct_list::Reader<'a, T>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/struct_list.rs:54:1 [INFO] [stderr] | [INFO] [stderr] 54 | / impl <'a, T> Reader<'a, T> where T: for<'b> ::traits::OwnedStruct<'b> { [INFO] [stderr] 55 | | pub fn new<'b>(reader : ListReader<'b>) -> Reader<'b, T> { [INFO] [stderr] 56 | | Reader::<'b, T> { reader : reader, marker : PhantomData } [INFO] [stderr] 57 | | } [INFO] [stderr] ... | [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/struct_list.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | / pub fn reborrow<'b>(&'b self) -> Reader<'b, T> { [INFO] [stderr] 68 | | Reader { reader: self.reader, marker: PhantomData } [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: item `struct_list::Builder<'a, T>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/struct_list.rs:98:1 [INFO] [stderr] | [INFO] [stderr] 98 | / impl <'a, T> Builder<'a, T> where T: for<'b> ::traits::OwnedStruct<'b> { [INFO] [stderr] 99 | | pub fn new(builder : ListBuilder<'a>) -> Builder<'a, T> { [INFO] [stderr] 100 | | Builder { builder: builder, marker: PhantomData } [INFO] [stderr] 101 | | } [INFO] [stderr] ... | [INFO] [stderr] 127 | | } [INFO] [stderr] 128 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/struct_list.rs:106:22 [INFO] [stderr] | [INFO] [stderr] 106 | pub fn as_reader(self) -> Reader<'a, T> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/struct_list.rs:131:5 [INFO] [stderr] | [INFO] [stderr] 131 | / pub fn reborrow<'b>(&'b mut self) -> Builder<'b, T> { [INFO] [stderr] 132 | | Builder { builder: self.builder, marker: PhantomData } [INFO] [stderr] 133 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the loop variable `ii` is used to index `bytes` [INFO] [stderr] --> src/text.rs:76:19 [INFO] [stderr] | [INFO] [stderr] 76 | for ii in 0..bytes.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 76 | for (ii, ) in bytes.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/text.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | / fn deref<'b>(&'b self) -> &'b str { [INFO] [stderr] 93 | | str::from_utf8(self.bytes) [INFO] [stderr] 94 | | .expect("text::Builder contents are checked for utf8-validity upon construction") [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/text.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | / fn as_ref<'b>(&'b self) -> &'b str { [INFO] [stderr] 100 | | str::from_utf8(self.bytes) [INFO] [stderr] 101 | | .expect("text::Builder contents are checked for utf8-validity upon construction") [INFO] [stderr] 102 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: item `text_list::Reader<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/text_list.rs:41:1 [INFO] [stderr] | [INFO] [stderr] 41 | / impl <'a> Reader<'a> { [INFO] [stderr] 42 | | pub fn new<'b>(reader : ListReader<'b>) -> Reader<'b> { [INFO] [stderr] 43 | | Reader::<'b> { reader : reader } [INFO] [stderr] 44 | | } [INFO] [stderr] ... | [INFO] [stderr] 51 | | } [INFO] [stderr] 52 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `text_list::Builder<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/text_list.rs:77:1 [INFO] [stderr] | [INFO] [stderr] 77 | / impl <'a> Builder<'a> { [INFO] [stderr] 78 | | pub fn new(builder : ListBuilder<'a>) -> Builder<'a> { [INFO] [stderr] 79 | | Builder { builder : builder } [INFO] [stderr] 80 | | } [INFO] [stderr] ... | [INFO] [stderr] 100 | | } [INFO] [stderr] 101 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/text_list.rs:90:22 [INFO] [stderr] | [INFO] [stderr] 90 | pub fn as_reader(self) -> Reader<'a> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/traits.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | fn set_pointer_builder<'a>(PointerBuilder<'a>, Self, canonicalize: bool) -> Result<()>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/traits.rs:91:25 [INFO] [stderr] | [INFO] [stderr] 91 | fn imbue(&mut self, &'a CapTable); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | / pub unsafe fn bytes_to_words<'a>(bytes: &'a [u8]) -> &'a [Word] { [INFO] [stderr] 116 | | ::std::slice::from_raw_parts(bytes.as_ptr() as *const Word, bytes.len() / 8) [INFO] [stderr] 117 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const Word`) [INFO] [stderr] --> src/lib.rs:116:38 [INFO] [stderr] | [INFO] [stderr] 116 | ::std::slice::from_raw_parts(bytes.as_ptr() as *const Word, bytes.len() / 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | / pub unsafe fn bytes_to_words_mut<'a>(bytes: &'a mut [u8]) -> &'a mut [Word] { [INFO] [stderr] 124 | | ::std::slice::from_raw_parts_mut(bytes.as_ptr() as *mut Word, bytes.len() / 8) [INFO] [stderr] 125 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*mut Word`) [INFO] [stderr] --> src/lib.rs:124:42 [INFO] [stderr] | [INFO] [stderr] 124 | ::std::slice::from_raw_parts_mut(bytes.as_ptr() as *mut Word, bytes.len() / 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | / pub fn words_to_bytes<'a>(words: &'a [Word]) -> &'a [u8] { [INFO] [stderr] 128 | | unsafe { [INFO] [stderr] 129 | | ::std::slice::from_raw_parts(words.as_ptr() as *const u8, words.len() * 8) [INFO] [stderr] 130 | | } [INFO] [stderr] 131 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:133:5 [INFO] [stderr] | [INFO] [stderr] 133 | / pub fn words_to_bytes_mut<'a>(words: &'a mut [Word]) -> &'a mut [u8] { [INFO] [stderr] 134 | | unsafe { [INFO] [stderr] 135 | | ::std::slice::from_raw_parts_mut(words.as_mut_ptr() as *mut u8, words.len() * 8) [INFO] [stderr] 136 | | } [INFO] [stderr] 137 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:174:5 [INFO] [stderr] | [INFO] [stderr] 174 | / fn description<'a>(&'a self) -> &'a str { [INFO] [stderr] 175 | | "Enum value or union disriminant was not present in schema." [INFO] [stderr] 176 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:312:5 [INFO] [stderr] | [INFO] [stderr] 312 | / fn get_segment<'a>(&'a self, id: u32) -> Option<&'a [Word]> { [INFO] [stderr] 313 | | match *self { [INFO] [stderr] 314 | | OutputSegments::SingleSegment(ref s) => { [INFO] [stderr] 315 | | s.get(id as usize).map(|slice| *slice) [INFO] [stderr] ... | [INFO] [stderr] 320 | | } [INFO] [stderr] 321 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:315:17 [INFO] [stderr] | [INFO] [stderr] 315 | s.get(id as usize).map(|slice| *slice) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `s.get(id as usize).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:318:17 [INFO] [stderr] | [INFO] [stderr] 318 | v.get(id as usize).map(|slice| *slice) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `v.get(id as usize).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] error: aborting due to 39 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `capnp`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "fd34756d02eddec75e6bc8657c93de9b7b4b1eb9aa06bbfa1611309cff627457"` [INFO] running `"docker" "rm" "-f" "fd34756d02eddec75e6bc8657c93de9b7b4b1eb9aa06bbfa1611309cff627457"` [INFO] [stdout] fd34756d02eddec75e6bc8657c93de9b7b4b1eb9aa06bbfa1611309cff627457