[INFO] crate capella 0.1.3 is already in cache
[INFO] extracting crate capella 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/capella/0.1.3
[INFO] extracting crate capella 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/capella/0.1.3
[INFO] validating manifest of capella-0.1.3 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of capella-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing capella-0.1.3
[INFO] finished frobbing capella-0.1.3
[INFO] frobbed toml for capella-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/capella/0.1.3/Cargo.toml
[INFO] started frobbing capella-0.1.3
[INFO] finished frobbing capella-0.1.3
[INFO] frobbed toml for capella-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/capella/0.1.3/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting capella-0.1.3 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/capella/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 0800210e0dfd73c943789fdceb577e17b18b6a0fd4347ddfd3699aa2d835adb4
[INFO] running `"docker" "start" "-a" "0800210e0dfd73c943789fdceb577e17b18b6a0fd4347ddfd3699aa2d835adb4"`
[INFO] [stderr]     Checking capella v0.1.3 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/cache.rs:159:13
[INFO] [stderr]     |
[INFO] [stderr] 159 |             value: value,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `value`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/cache.rs:159:13
[INFO] [stderr]     |
[INFO] [stderr] 159 |             value: value,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `value`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/graphite.rs:18:31
[INFO] [stderr]    |
[INFO] [stderr] 18 | const CAPELLA_METRICS_TOTAL: &'static str = "capella.total_metrics";
[INFO] [stderr]    |                              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/graphite.rs:19:35
[INFO] [stderr]    |
[INFO] [stderr] 19 | const CAPELLA_BAD_METRICS_TOTAL: &'static str = "capella.bad_metrics";
[INFO] [stderr]    |                                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/graphite.rs:20:22
[INFO] [stderr]    |
[INFO] [stderr] 20 | const COUNT_SUFFIX: &'static str = ".count";
[INFO] [stderr]    |                     -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/graphite.rs:18:31
[INFO] [stderr]    |
[INFO] [stderr] 18 | const CAPELLA_METRICS_TOTAL: &'static str = "capella.total_metrics";
[INFO] [stderr]    |                              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/graphite.rs:19:35
[INFO] [stderr]    |
[INFO] [stderr] 19 | const CAPELLA_BAD_METRICS_TOTAL: &'static str = "capella.bad_metrics";
[INFO] [stderr]    |                                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/graphite.rs:20:22
[INFO] [stderr]    |
[INFO] [stderr] 20 | const COUNT_SUFFIX: &'static str = ".count";
[INFO] [stderr]    |                     -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/cache.rs:37:69
[INFO] [stderr]    |
[INFO] [stderr] 37 |                 let values = self.timers.entry(metric.name.clone()).or_insert(Vec::new());
[INFO] [stderr]    |                                                                     ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/cache.rs:41:67
[INFO] [stderr]    |
[INFO] [stderr] 41 |                 let values = self.sets.entry(metric.name.clone()).or_insert(HashSet::new());
[INFO] [stderr]    |                                                                   ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/graphite.rs:35:53
[INFO] [stderr]    |
[INFO] [stderr] 35 |     fn make_metric_string(&self, name: &str, value: &f64, time: &str) -> String {
[INFO] [stderr]    |                                                     ^^^^ help: consider passing by value instead: `f64`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `parse::Metric`
[INFO] [stderr]   --> src/parse.rs:59:5
[INFO] [stderr]    |
[INFO] [stderr] 59 | /     pub fn new() -> Metric {
[INFO] [stderr] 60 | |         Metric {
[INFO] [stderr] 61 | |             name: Rc::new(String::new()),
[INFO] [stderr] 62 | |             value: 0.0,
[INFO] [stderr] ...  |
[INFO] [stderr] 65 | |         }
[INFO] [stderr] 66 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 57 | impl Default for parse::Metric {
[INFO] [stderr] 58 |     fn default() -> Self {
[INFO] [stderr] 59 |         Self::new()
[INFO] [stderr] 60 |     }
[INFO] [stderr] 61 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/server.rs:39:64
[INFO] [stderr]    |
[INFO] [stderr] 39 |             for m in buf.split(|c| *c == b'\n').filter(|chunk| chunk.len() > 0) {
[INFO] [stderr]    |                                                                ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!chunk.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/cache.rs:37:69
[INFO] [stderr]    |
[INFO] [stderr] 37 |                 let values = self.timers.entry(metric.name.clone()).or_insert(Vec::new());
[INFO] [stderr]    |                                                                     ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/cache.rs:41:67
[INFO] [stderr]    |
[INFO] [stderr] 41 |                 let values = self.sets.entry(metric.name.clone()).or_insert(HashSet::new());
[INFO] [stderr]    |                                                                   ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/cache.rs:183:18
[INFO] [stderr]     |
[INFO] [stderr] 183 |         assert!((cache.timer_data.get("test.min").unwrap() - 1.0).abs() < EPSILON);
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&cache.timer_data["test.min"]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/cache.rs:184:18
[INFO] [stderr]     |
[INFO] [stderr] 184 |         assert!((cache.timer_data.get("test.max").unwrap() - 5.0).abs() < EPSILON);
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&cache.timer_data["test.max"]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/cache.rs:185:18
[INFO] [stderr]     |
[INFO] [stderr] 185 |         assert!((cache.timer_data.get("test.count").unwrap() - 5.0).abs() < EPSILON);
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&cache.timer_data["test.count"]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/cache.rs:186:18
[INFO] [stderr]     |
[INFO] [stderr] 186 |         assert!((cache.timer_data.get("test.average").unwrap() - 3.0).abs() < EPSILON);
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&cache.timer_data["test.average"]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/cache.rs:187:18
[INFO] [stderr]     |
[INFO] [stderr] 187 |         assert!((cache.timer_data.get("test.std_dev").unwrap() - sqrt_two).abs() < EPSILON);
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&cache.timer_data["test.std_dev"]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/cache.rs:188:18
[INFO] [stderr]     |
[INFO] [stderr] 188 |         assert!((cache.timer_data.get("test.median").unwrap() - 3.0).abs() < EPSILON);
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&cache.timer_data["test.median"]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/cache.rs:189:18
[INFO] [stderr]     |
[INFO] [stderr] 189 |         assert!((cache.timer_data.get("test.upper_95").unwrap() - 5.0).abs() < EPSILON);
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&cache.timer_data["test.upper_95"]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/graphite.rs:35:53
[INFO] [stderr]    |
[INFO] [stderr] 35 |     fn make_metric_string(&self, name: &str, value: &f64, time: &str) -> String {
[INFO] [stderr]    |                                                     ^^^^ help: consider passing by value instead: `f64`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `parse::Metric`
[INFO] [stderr]   --> src/parse.rs:59:5
[INFO] [stderr]    |
[INFO] [stderr] 59 | /     pub fn new() -> Metric {
[INFO] [stderr] 60 | |         Metric {
[INFO] [stderr] 61 | |             name: Rc::new(String::new()),
[INFO] [stderr] 62 | |             value: 0.0,
[INFO] [stderr] ...  |
[INFO] [stderr] 65 | |         }
[INFO] [stderr] 66 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 57 | impl Default for parse::Metric {
[INFO] [stderr] 58 |     fn default() -> Self {
[INFO] [stderr] 59 |         Self::new()
[INFO] [stderr] 60 |     }
[INFO] [stderr] 61 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/server.rs:39:64
[INFO] [stderr]    |
[INFO] [stderr] 39 |             for m in buf.split(|c| *c == b'\n').filter(|chunk| chunk.len() > 0) {
[INFO] [stderr]    |                                                                ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!chunk.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 7.69s
[INFO] running `"docker" "inspect" "0800210e0dfd73c943789fdceb577e17b18b6a0fd4347ddfd3699aa2d835adb4"`
[INFO] running `"docker" "rm" "-f" "0800210e0dfd73c943789fdceb577e17b18b6a0fd4347ddfd3699aa2d835adb4"`
[INFO] [stdout] 0800210e0dfd73c943789fdceb577e17b18b6a0fd4347ddfd3699aa2d835adb4