[INFO] crate canvas 1.0.1 is already in cache [INFO] extracting crate canvas 1.0.1 into work/ex/clippy-test-run/sources/stable/reg/canvas/1.0.1 [INFO] extracting crate canvas 1.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/canvas/1.0.1 [INFO] validating manifest of canvas-1.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of canvas-1.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing canvas-1.0.1 [INFO] finished frobbing canvas-1.0.1 [INFO] frobbed toml for canvas-1.0.1 written to work/ex/clippy-test-run/sources/stable/reg/canvas/1.0.1/Cargo.toml [INFO] started frobbing canvas-1.0.1 [INFO] finished frobbing canvas-1.0.1 [INFO] frobbed toml for canvas-1.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/canvas/1.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting canvas-1.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/canvas/1.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7f212445bc4be29fedc05fec5d3dbc4b29634ed005608c8e326c36d680b1065f [INFO] running `"docker" "start" "-a" "7f212445bc4be29fedc05fec5d3dbc4b29634ed005608c8e326c36d680b1065f"` [INFO] [stderr] Checking canvas v1.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | return TextMetrics { width: text.parse().unwrap() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TextMetrics { width: text.parse().unwrap() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:195:16 [INFO] [stderr] | [INFO] [stderr] 195 | const HEADER: &'static str = include_str!("static/index.html"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:196:16 [INFO] [stderr] | [INFO] [stderr] 196 | const SCRIPT: &'static str = include_str!("static/script.js"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:206:5 [INFO] [stderr] | [INFO] [stderr] 206 | return (server, addr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(server, addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:213:5 [INFO] [stderr] | [INFO] [stderr] 213 | return (client, ip); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(client, ip)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:303:9 [INFO] [stderr] | [INFO] [stderr] 303 | return msg; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `msg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/api.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/api.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | return TextMetrics { width: text.parse().unwrap() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TextMetrics { width: text.parse().unwrap() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:195:16 [INFO] [stderr] | [INFO] [stderr] 195 | const HEADER: &'static str = include_str!("static/index.html"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:196:16 [INFO] [stderr] | [INFO] [stderr] 196 | const SCRIPT: &'static str = include_str!("static/script.js"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:206:5 [INFO] [stderr] | [INFO] [stderr] 206 | return (server, addr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(server, addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:213:5 [INFO] [stderr] | [INFO] [stderr] 213 | return (client, ip); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(client, ip)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:303:9 [INFO] [stderr] | [INFO] [stderr] 303 | return msg; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `msg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::*` [INFO] [stderr] --> src/lib.rs:309:9 [INFO] [stderr] | [INFO] [stderr] 309 | use super::*; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/api.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/http_server.rs:22:33 [INFO] [stderr] | [INFO] [stderr] 22 | let (status, content) = match req.method() { [INFO] [stderr] | _________________________________^ [INFO] [stderr] 23 | | &Method::Get => { [INFO] [stderr] 24 | | match req.uri().as_ref() { [INFO] [stderr] 25 | | "/" => (StatusCode::Ok, self.html.clone()), [INFO] [stderr] ... | [INFO] [stderr] 29 | | _ => (StatusCode::MethodNotAllowed, "502".to_string()), [INFO] [stderr] 30 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 22 | let (status, content) = match *req.method() { [INFO] [stderr] 23 | Method::Get => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/api.rs:86:37 [INFO] [stderr] | [INFO] [stderr] 86 | fn setLineDash(&mut self, dash: &Vec); [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:240:13 [INFO] [stderr] | [INFO] [stderr] 240 | / match message { [INFO] [stderr] 241 | | Ok(OwnedMessage::Text(text)) => { [INFO] [stderr] 242 | | println!("Received event: {}", text); [INFO] [stderr] 243 | | let mut toks = text.split(' '); [INFO] [stderr] ... | [INFO] [stderr] 279 | | _ => (), [INFO] [stderr] 280 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 240 | if let Ok(OwnedMessage::Text(text)) = message { [INFO] [stderr] 241 | println!("Received event: {}", text); [INFO] [stderr] 242 | let mut toks = text.split(' '); [INFO] [stderr] 243 | let command = toks.next().unwrap(); [INFO] [stderr] 244 | let event = match command { [INFO] [stderr] 245 | "onmousedown" => Some(Event::MouseDown( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:274:21 [INFO] [stderr] | [INFO] [stderr] 274 | / match event { [INFO] [stderr] 275 | | Some(event) => tx.send(event).unwrap(), [INFO] [stderr] 276 | | _ => (), [INFO] [stderr] 277 | | }; [INFO] [stderr] | |_____________________^ help: try this: `if let Some(event) = event { tx.send(event).unwrap() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/api.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/http_server.rs:22:33 [INFO] [stderr] | [INFO] [stderr] 22 | let (status, content) = match req.method() { [INFO] [stderr] | _________________________________^ [INFO] [stderr] 23 | | &Method::Get => { [INFO] [stderr] 24 | | match req.uri().as_ref() { [INFO] [stderr] 25 | | "/" => (StatusCode::Ok, self.html.clone()), [INFO] [stderr] ... | [INFO] [stderr] 29 | | _ => (StatusCode::MethodNotAllowed, "502".to_string()), [INFO] [stderr] 30 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 22 | let (status, content) = match *req.method() { [INFO] [stderr] 23 | Method::Get => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/api.rs:86:37 [INFO] [stderr] | [INFO] [stderr] 86 | fn setLineDash(&mut self, dash: &Vec); [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:240:13 [INFO] [stderr] | [INFO] [stderr] 240 | / match message { [INFO] [stderr] 241 | | Ok(OwnedMessage::Text(text)) => { [INFO] [stderr] 242 | | println!("Received event: {}", text); [INFO] [stderr] 243 | | let mut toks = text.split(' '); [INFO] [stderr] ... | [INFO] [stderr] 279 | | _ => (), [INFO] [stderr] 280 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 240 | if let Ok(OwnedMessage::Text(text)) = message { [INFO] [stderr] 241 | println!("Received event: {}", text); [INFO] [stderr] 242 | let mut toks = text.split(' '); [INFO] [stderr] 243 | let command = toks.next().unwrap(); [INFO] [stderr] 244 | let event = match command { [INFO] [stderr] 245 | "onmousedown" => Some(Event::MouseDown( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:274:21 [INFO] [stderr] | [INFO] [stderr] 274 | / match event { [INFO] [stderr] 275 | | Some(event) => tx.send(event).unwrap(), [INFO] [stderr] 276 | | _ => (), [INFO] [stderr] 277 | | }; [INFO] [stderr] | |_____________________^ help: try this: `if let Some(event) = event { tx.send(event).unwrap() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.76s [INFO] running `"docker" "inspect" "7f212445bc4be29fedc05fec5d3dbc4b29634ed005608c8e326c36d680b1065f"` [INFO] running `"docker" "rm" "-f" "7f212445bc4be29fedc05fec5d3dbc4b29634ed005608c8e326c36d680b1065f"` [INFO] [stdout] 7f212445bc4be29fedc05fec5d3dbc4b29634ed005608c8e326c36d680b1065f