[INFO] crate canparse 0.1.2 is already in cache
[INFO] extracting crate canparse 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/canparse/0.1.2
[INFO] extracting crate canparse 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/canparse/0.1.2
[INFO] validating manifest of canparse-0.1.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of canparse-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing canparse-0.1.2
[INFO] finished frobbing canparse-0.1.2
[INFO] frobbed toml for canparse-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/canparse/0.1.2/Cargo.toml
[INFO] started frobbing canparse-0.1.2
[INFO] finished frobbing canparse-0.1.2
[INFO] frobbed toml for canparse-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/canparse/0.1.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting canparse-0.1.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/canparse/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 4058f7e0f9e5f29697820aa558ab548cf67901a7b7fa39b977538b3447819ddd
[INFO] running `"docker" "start" "-a" "4058f7e0f9e5f29697820aa558ab548cf67901a7b7fa39b977538b3447819ddd"`
[INFO] [stderr]     Checking canparse v0.1.2 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/pgn.rs:44:33
[INFO] [stderr]    |
[INFO] [stderr] 44 |         PgnLibrary { last_id:0, pgns:pgns }
[INFO] [stderr]    |                                 ^^^^^^^^^ help: replace it with: `pgns`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pgn.rs:168:13
[INFO] [stderr]     |
[INFO] [stderr] 168 |             pgn: pgn,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `pgn`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pgn.rs:169:13
[INFO] [stderr]     |
[INFO] [stderr] 169 |             pgn_long: pgn_long,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `pgn_long`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pgn.rs:170:13
[INFO] [stderr]     |
[INFO] [stderr] 170 |             name_abbrev: name_abbrev,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `name_abbrev`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pgn.rs:171:13
[INFO] [stderr]     |
[INFO] [stderr] 171 |             description: description,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pgn.rs:172:13
[INFO] [stderr]     |
[INFO] [stderr] 172 |             length: length,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `length`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pgn.rs:173:13
[INFO] [stderr]     |
[INFO] [stderr] 173 |             spns: spns
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `spns`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pgn.rs:439:13
[INFO] [stderr]     |
[INFO] [stderr] 439 |             name: name,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/pgn.rs:44:33
[INFO] [stderr]    |
[INFO] [stderr] 44 |         PgnLibrary { last_id:0, pgns:pgns }
[INFO] [stderr]    |                                 ^^^^^^^^^ help: replace it with: `pgns`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pgn.rs:440:13
[INFO] [stderr]     |
[INFO] [stderr] 440 |             number: number,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `number`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pgn.rs:168:13
[INFO] [stderr]     |
[INFO] [stderr] 168 |             pgn: pgn,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `pgn`
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pgn.rs:441:13
[INFO] [stderr]     |
[INFO] [stderr] 441 |             id: id,
[INFO] [stderr]     |             ^^^^^^ help: replace it with: `id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pgn.rs:442:13
[INFO] [stderr]     |
[INFO] [stderr] 442 |             description: description,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pgn.rs:443:13
[INFO] [stderr]     |
[INFO] [stderr] 443 |             start_bit: start_bit,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_bit`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pgn.rs:169:13
[INFO] [stderr]     |
[INFO] [stderr] 169 |             pgn_long: pgn_long,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `pgn_long`
[INFO] [stderr] 
[INFO] [stderr]     |
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pgn.rs:444:13
[INFO] [stderr]     |
[INFO] [stderr] 444 |             bit_len: bit_len,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `bit_len`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pgn.rs:170:13
[INFO] [stderr]     |
[INFO] [stderr] 170 |             name_abbrev: name_abbrev,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `name_abbrev`
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pgn.rs:445:13
[INFO] [stderr]     |
[INFO] [stderr] 445 |             little_endian: little_endian,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `little_endian`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pgn.rs:446:13
[INFO] [stderr] 
[INFO] [stderr]     |
[INFO] [stderr] 446 |             signed: signed,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `signed`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pgn.rs:171:13
[INFO] [stderr]     |
[INFO] [stderr] 171 |             description: description,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description`
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pgn.rs:447:13
[INFO] [stderr]     |
[INFO] [stderr] 447 |             scale: scale,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `scale`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pgn.rs:448:13
[INFO] [stderr]     |
[INFO] [stderr] 448 |             offset: offset,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `offset`
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pgn.rs:172:13
[INFO] [stderr]    --> src/pgn.rs:449:13
[INFO] [stderr]     |
[INFO] [stderr] 172 |             length: length,
[INFO] [stderr]     |
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `length`
[INFO] [stderr] 449 |             min_value: min_value,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `min_value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr]     |
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]    --> src/pgn.rs:450:13
[INFO] [stderr]     |
[INFO] [stderr] 450 |             max_value: max_value,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pgn.rs:451:13
[INFO] [stderr]     |
[INFO] [stderr] 451 |             units: units
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `units`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pgn.rs:173:13
[INFO] [stderr]     |
[INFO] [stderr] 173 |             spns: spns
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `spns`
[INFO] [stderr] 
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pgn.rs:439:13
[INFO] [stderr]     |
[INFO] [stderr] 439 |             name: name,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pgn.rs:440:13
[INFO] [stderr]     |
[INFO] [stderr] 440 |             number: number,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `number`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pgn.rs:441:13
[INFO] [stderr]     |
[INFO] [stderr] 441 |             id: id,
[INFO] [stderr]     |             ^^^^^^ help: replace it with: `id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pgn.rs:442:13
[INFO] [stderr]     |
[INFO] [stderr] 442 |             description: description,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pgn.rs:443:13
[INFO] [stderr]     |
[INFO] [stderr] 443 |             start_bit: start_bit,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_bit`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pgn.rs:444:13
[INFO] [stderr]     |
[INFO] [stderr] 444 |             bit_len: bit_len,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `bit_len`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pgn.rs:445:13
[INFO] [stderr]     |
[INFO] [stderr] 445 |             little_endian: little_endian,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `little_endian`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pgn.rs:446:13
[INFO] [stderr]     |
[INFO] [stderr] 446 |             signed: signed,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `signed`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pgn.rs:447:13
[INFO] [stderr]     |
[INFO] [stderr] 447 |             scale: scale,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `scale`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pgn.rs:448:13
[INFO] [stderr]     |
[INFO] [stderr] 448 |             offset: offset,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `offset`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pgn.rs:449:13
[INFO] [stderr]     |
[INFO] [stderr] 449 |             min_value: min_value,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `min_value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pgn.rs:450:13
[INFO] [stderr]     |
[INFO] [stderr] 450 |             max_value: max_value,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pgn.rs:451:13
[INFO] [stderr]     |
[INFO] [stderr] 451 |             units: units
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `units`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array
[INFO] [stderr]    --> src/dbc.rs:224:57
[INFO] [stderr]     |
[INFO] [stderr] 224 | static ref Patterns: RegexSet = RegexSet::new(_patterns.into_iter()).unwrap();
[INFO] [stderr]     |                                                         ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::into_iter_on_array)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array
[INFO] [stderr] 
[INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stderr]    --> src/pgn.rs:121:9
[INFO] [stderr]     |
[INFO] [stderr] 121 | /         if self.pgns.contains_key(&pgn) {
[INFO] [stderr] 122 | |             (*self.pgns.get_mut(&pgn).unwrap()).merge_entry(entry).unwrap();
[INFO] [stderr] 123 | |         } else {
[INFO] [stderr] 124 | |             self.pgns.insert(pgn, PgnDefinition::from_entry(entry).unwrap());
[INFO] [stderr] 125 | |         }
[INFO] [stderr]     | |_________^ help: consider using: `self.pgns.entry(pgn)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_entry)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/pgn.rs:135:33
[INFO] [stderr]     |
[INFO] [stderr] 135 |     pub fn get_spn(&self, name: &String) -> Option<&SpnDefinition> {
[INFO] [stderr]     |                                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/pgn.rs:264:23
[INFO] [stderr]     |
[INFO] [stderr] 264 |             .and_then(|entry| Self::from_entry(entry))
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Self::from_entry`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `8`
[INFO] [stderr]    --> src/pgn.rs:365:45
[INFO] [stderr]     |
[INFO] [stderr] 365 | const SHIFT_BYTE_LOOKUP: [u64; 8] = [ 1, 1<<(1*8), 1<<(2*8), 1<<(3*8), 1<<(4*8), 1<<(5*8), 1<<(6*8), 1<<(7*8) ];
[INFO] [stderr]     |                                             ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/pgn.rs:369:101
[INFO] [stderr]     |
[INFO] [stderr] 369 | fn parse_array(bit_len: usize, start_bit: usize, little_endian: bool, scale: f32, offset: f32, msg: &[u8; 8]) -> Option<f32> {
[INFO] [stderr]     |                                                                                                     ^^^^^^^^ help: consider passing by value instead: `[u8; 8]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/pgn.rs:370:22
[INFO] [stderr]     |
[INFO] [stderr] 370 |       let msg64: u64 = match little_endian {
[INFO] [stderr]     |  ______________________^
[INFO] [stderr] 371 | |         true => LittleEndian::read_u64(msg),
[INFO] [stderr] 372 | |         false => BigEndian::read_u64(msg)
[INFO] [stderr] 373 | |     };
[INFO] [stderr]     | |_____^ help: consider using an if/else expression: `if little_endian { LittleEndian::read_u64(msg) } else { BigEndian::read_u64(msg) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/pgn.rs:393:22
[INFO] [stderr]     |
[INFO] [stderr] 393 |             val32 += ((n & 0xFF) as u32) * (SHIFT_BYTE_LOOKUP[i] as u32);
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(n & 0xFF)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `n`
[INFO] [stderr]    --> src/pgn.rs:393:23
[INFO] [stderr]     |
[INFO] [stderr] 393 |             val32 += ((n & 0xFF) as u32) * (SHIFT_BYTE_LOOKUP[i] as u32);
[INFO] [stderr]     |                       ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/pgn.rs:397:22
[INFO] [stderr]     |
[INFO] [stderr] 397 |             val32 += ((n & 0xFF) as u32) * (SHIFT_BYTE_LOOKUP[i] as u32);
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(n & 0xFF)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `n`
[INFO] [stderr]    --> src/pgn.rs:397:23
[INFO] [stderr]     |
[INFO] [stderr] 397 |             val32 += ((n & 0xFF) as u32) * (SHIFT_BYTE_LOOKUP[i] as u32);
[INFO] [stderr]     |                       ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (13/7)
[INFO] [stderr]    --> src/pgn.rs:425:5
[INFO] [stderr]     |
[INFO] [stderr] 425 | /     pub fn new(name: String,
[INFO] [stderr] 426 | |                number: usize,
[INFO] [stderr] 427 | |                id: String,
[INFO] [stderr] 428 | |                description: String,
[INFO] [stderr] ...   |
[INFO] [stderr] 452 | |         }
[INFO] [stderr] 453 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/pgn.rs:532:23
[INFO] [stderr]     |
[INFO] [stderr] 532 |             .and_then(|entry| Self::from_entry(entry))
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Self::from_entry`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `canparse`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array
[INFO] [stderr]    --> src/dbc.rs:224:57
[INFO] [stderr]     |
[INFO] [stderr] 224 | static ref Patterns: RegexSet = RegexSet::new(_patterns.into_iter()).unwrap();
[INFO] [stderr]     |                                                         ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::into_iter_on_array)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array
[INFO] [stderr] 
[INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stderr]    --> src/pgn.rs:121:9
[INFO] [stderr]     |
[INFO] [stderr] 121 | /         if self.pgns.contains_key(&pgn) {
[INFO] [stderr] 122 | |             (*self.pgns.get_mut(&pgn).unwrap()).merge_entry(entry).unwrap();
[INFO] [stderr] 123 | |         } else {
[INFO] [stderr] 124 | |             self.pgns.insert(pgn, PgnDefinition::from_entry(entry).unwrap());
[INFO] [stderr] 125 | |         }
[INFO] [stderr]     | |_________^ help: consider using: `self.pgns.entry(pgn)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_entry)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/pgn.rs:135:33
[INFO] [stderr]     |
[INFO] [stderr] 135 |     pub fn get_spn(&self, name: &String) -> Option<&SpnDefinition> {
[INFO] [stderr]     |                                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/pgn.rs:264:23
[INFO] [stderr]     |
[INFO] [stderr] 264 |             .and_then(|entry| Self::from_entry(entry))
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Self::from_entry`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `8`
[INFO] [stderr]    --> src/pgn.rs:365:45
[INFO] [stderr]     |
[INFO] [stderr] 365 | const SHIFT_BYTE_LOOKUP: [u64; 8] = [ 1, 1<<(1*8), 1<<(2*8), 1<<(3*8), 1<<(4*8), 1<<(5*8), 1<<(6*8), 1<<(7*8) ];
[INFO] [stderr]     |                                             ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/pgn.rs:369:101
[INFO] [stderr]     |
[INFO] [stderr] 369 | fn parse_array(bit_len: usize, start_bit: usize, little_endian: bool, scale: f32, offset: f32, msg: &[u8; 8]) -> Option<f32> {
[INFO] [stderr]     |                                                                                                     ^^^^^^^^ help: consider passing by value instead: `[u8; 8]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/pgn.rs:370:22
[INFO] [stderr]     |
[INFO] [stderr] 370 |       let msg64: u64 = match little_endian {
[INFO] [stderr]     |  ______________________^
[INFO] [stderr] 371 | |         true => LittleEndian::read_u64(msg),
[INFO] [stderr] 372 | |         false => BigEndian::read_u64(msg)
[INFO] [stderr] 373 | |     };
[INFO] [stderr]     | |_____^ help: consider using an if/else expression: `if little_endian { LittleEndian::read_u64(msg) } else { BigEndian::read_u64(msg) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/pgn.rs:393:22
[INFO] [stderr]     |
[INFO] [stderr] 393 |             val32 += ((n & 0xFF) as u32) * (SHIFT_BYTE_LOOKUP[i] as u32);
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(n & 0xFF)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `n`
[INFO] [stderr]    --> src/pgn.rs:393:23
[INFO] [stderr]     |
[INFO] [stderr] 393 |             val32 += ((n & 0xFF) as u32) * (SHIFT_BYTE_LOOKUP[i] as u32);
[INFO] [stderr]     |                       ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/pgn.rs:397:22
[INFO] [stderr]     |
[INFO] [stderr] 397 |             val32 += ((n & 0xFF) as u32) * (SHIFT_BYTE_LOOKUP[i] as u32);
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(n & 0xFF)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `n`
[INFO] [stderr]    --> src/pgn.rs:397:23
[INFO] [stderr]     |
[INFO] [stderr] 397 |             val32 += ((n & 0xFF) as u32) * (SHIFT_BYTE_LOOKUP[i] as u32);
[INFO] [stderr]     |                       ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (13/7)
[INFO] [stderr]    --> src/pgn.rs:425:5
[INFO] [stderr]     |
[INFO] [stderr] 425 | /     pub fn new(name: String,
[INFO] [stderr] 426 | |                number: usize,
[INFO] [stderr] 427 | |                id: String,
[INFO] [stderr] 428 | |                description: String,
[INFO] [stderr] ...   |
[INFO] [stderr] 452 | |         }
[INFO] [stderr] 453 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/pgn.rs:532:23
[INFO] [stderr]     |
[INFO] [stderr] 532 |             .and_then(|entry| Self::from_entry(entry))
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Self::from_entry`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/pgn.rs:646:9
[INFO] [stderr]     |
[INFO] [stderr] 646 | /         assert_eq!(
[INFO] [stderr] 647 | |         SPNDEF.parse_message(&MSG as &[u8; 8]).unwrap(),
[INFO] [stderr] 648 | |         2728.5
[INFO] [stderr] 649 | |         );
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/pgn.rs:646:9
[INFO] [stderr]     |
[INFO] [stderr] 646 | /         assert_eq!(
[INFO] [stderr] 647 | |         SPNDEF.parse_message(&MSG as &[u8; 8]).unwrap(),
[INFO] [stderr] 648 | |         2728.5
[INFO] [stderr] 649 | |         );
[INFO] [stderr]     | |__________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/pgn.rs:650:9
[INFO] [stderr]     |
[INFO] [stderr] 650 | /         assert_eq!(
[INFO] [stderr] 651 | |         SPNDEF_BE.parse_message(&MSG_BE as &[u8; 8]).unwrap(),
[INFO] [stderr] 652 | |         2728.5
[INFO] [stderr] 653 | |         );
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/pgn.rs:650:9
[INFO] [stderr]     |
[INFO] [stderr] 650 | /         assert_eq!(
[INFO] [stderr] 651 | |         SPNDEF_BE.parse_message(&MSG_BE as &[u8; 8]).unwrap(),
[INFO] [stderr] 652 | |         2728.5
[INFO] [stderr] 653 | |         );
[INFO] [stderr]     | |__________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/pgn.rs:658:9
[INFO] [stderr]     |
[INFO] [stderr] 658 | /         assert_eq!(
[INFO] [stderr] 659 | |             SPNDEF.parse_message(&MSG[..]).unwrap(),
[INFO] [stderr] 660 | |             2728.5
[INFO] [stderr] 661 | |         );
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/pgn.rs:658:9
[INFO] [stderr]     |
[INFO] [stderr] 658 | /         assert_eq!(
[INFO] [stderr] 659 | |             SPNDEF.parse_message(&MSG[..]).unwrap(),
[INFO] [stderr] 660 | |             2728.5
[INFO] [stderr] 661 | |         );
[INFO] [stderr]     | |__________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/pgn.rs:666:9
[INFO] [stderr]     |
[INFO] [stderr] 666 | /         assert_eq!(
[INFO] [stderr] 667 | |             SPNDEF.parser()(&MSG[..]).unwrap(),
[INFO] [stderr] 668 | |             2728.5
[INFO] [stderr] 669 | |         );
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/pgn.rs:666:9
[INFO] [stderr]     |
[INFO] [stderr] 666 | /         assert_eq!(
[INFO] [stderr] 667 | |             SPNDEF.parser()(&MSG[..]).unwrap(),
[INFO] [stderr] 668 | |             2728.5
[INFO] [stderr] 669 | |         );
[INFO] [stderr]     | |__________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 5 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `canparse`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "4058f7e0f9e5f29697820aa558ab548cf67901a7b7fa39b977538b3447819ddd"`
[INFO] running `"docker" "rm" "-f" "4058f7e0f9e5f29697820aa558ab548cf67901a7b7fa39b977538b3447819ddd"`
[INFO] [stdout] 4058f7e0f9e5f29697820aa558ab548cf67901a7b7fa39b977538b3447819ddd