[INFO] crate cannyls_rpc 0.1.0 is already in cache
[INFO] extracting crate cannyls_rpc 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/cannyls_rpc/0.1.0
[INFO] extracting crate cannyls_rpc 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cannyls_rpc/0.1.0
[INFO] validating manifest of cannyls_rpc-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of cannyls_rpc-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing cannyls_rpc-0.1.0
[INFO] finished frobbing cannyls_rpc-0.1.0
[INFO] frobbed toml for cannyls_rpc-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/cannyls_rpc/0.1.0/Cargo.toml
[INFO] started frobbing cannyls_rpc-0.1.0
[INFO] finished frobbing cannyls_rpc-0.1.0
[INFO] frobbed toml for cannyls_rpc-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cannyls_rpc/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting cannyls_rpc-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cannyls_rpc/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] d6fdc2e463084d87bd35f5278267ce86f3d1d2e9b1321ce901d67228be0e2dcb
[INFO] running `"docker" "start" "-a" "d6fdc2e463084d87bd35f5278267ce86f3d1d2e9b1321ce901d67228be0e2dcb"`
[INFO] [stderr]     Checking prometrics v0.1.11
[INFO] [stderr]     Checking bytecodec v0.4.11
[INFO] [stderr]     Checking tasque v0.1.4
[INFO] [stderr]     Checking cannyls v0.9.2
[INFO] [stderr]     Checking fibers_tasque v0.1.1
[INFO] [stderr]     Checking protobuf_codec v0.2.6
[INFO] [stderr]     Checking fibers_rpc v0.2.17
[INFO] [stderr]     Checking cannyls_rpc v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/protobuf.rs:6:45
[INFO] [stderr]   |
[INFO] [stderr] 6 | #![cfg_attr(feature = "cargo-clippy", allow(type_complexity))]
[INFO] [stderr]   |                                             ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(renamed_and_removed_lints)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/protobuf.rs:6:45
[INFO] [stderr]   |
[INFO] [stderr] 6 | #![cfg_attr(feature = "cargo-clippy", allow(type_complexity))]
[INFO] [stderr]   |                                             ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity`
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/protobuf.rs:6:45
[INFO] [stderr]   |
[INFO] [stderr] 6 | #![cfg_attr(feature = "cargo-clippy", allow(type_complexity))]
[INFO] [stderr]   |                                             ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(renamed_and_removed_lints)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/protobuf.rs:6:45
[INFO] [stderr]   |
[INFO] [stderr] 6 | #![cfg_attr(feature = "cargo-clippy", allow(type_complexity))]
[INFO] [stderr]   |                                             ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity`
[INFO] [stderr] 
[INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
[INFO] [stderr]    --> src/protobuf.rs:350:12
[INFO] [stderr]     |
[INFO] [stderr] 350 |         if track!(self.device_id.start_decoding(tag))? {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::block_in_if_condition_stmt)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
[INFO] [stderr]    --> src/protobuf.rs:353:19
[INFO] [stderr]     |
[INFO] [stderr] 353 |         } else if track!(self.lump_id.start_decoding(tag))? {
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
[INFO] [stderr]    --> src/protobuf.rs:356:19
[INFO] [stderr]     |
[INFO] [stderr] 356 |         } else if track!(self.lump_data.start_decoding(tag))? {
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
[INFO] [stderr]    --> src/protobuf.rs:359:19
[INFO] [stderr]     |
[INFO] [stderr] 359 |         } else if track!(self.options.start_decoding(tag))? {
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/protobuf.rs:414:28
[INFO] [stderr]     |
[INFO] [stderr] 414 |         self.device_hint = self.registry.get_device(device_id).ok().map(|d| d.clone());
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.registry.get_device(device_id).ok().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
[INFO] [stderr]    --> src/protobuf.rs:350:12
[INFO] [stderr]     |
[INFO] [stderr] 350 |         if track!(self.device_id.start_decoding(tag))? {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::block_in_if_condition_stmt)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
[INFO] [stderr]    --> src/protobuf.rs:353:19
[INFO] [stderr]     |
[INFO] [stderr] 353 |         } else if track!(self.lump_id.start_decoding(tag))? {
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
[INFO] [stderr]    --> src/protobuf.rs:356:19
[INFO] [stderr]     |
[INFO] [stderr] 356 |         } else if track!(self.lump_data.start_decoding(tag))? {
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
[INFO] [stderr]    --> src/protobuf.rs:359:19
[INFO] [stderr]     |
[INFO] [stderr] 359 |         } else if track!(self.options.start_decoding(tag))? {
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/protobuf.rs:414:28
[INFO] [stderr]     |
[INFO] [stderr] 414 |         self.device_hint = self.registry.get_device(device_id).ok().map(|d| d.clone());
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.registry.get_device(device_id).ok().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 28
[INFO] [stderr]    --> tests/rpc.rs:36:1
[INFO] [stderr]     |
[INFO] [stderr] 36  | / fn basic_rpc_works() {
[INFO] [stderr] 37  | |     fn device_id() -> DeviceId {
[INFO] [stderr] 38  | |         DeviceId::new("foo")
[INFO] [stderr] 39  | |     }
[INFO] [stderr] ...   |
[INFO] [stderr] 100 | |     assert_eq!(wait!(request.list_lumps(device_id())), vec![]);
[INFO] [stderr] 101 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 26.68s
[INFO] running `"docker" "inspect" "d6fdc2e463084d87bd35f5278267ce86f3d1d2e9b1321ce901d67228be0e2dcb"`
[INFO] running `"docker" "rm" "-f" "d6fdc2e463084d87bd35f5278267ce86f3d1d2e9b1321ce901d67228be0e2dcb"`
[INFO] [stdout] d6fdc2e463084d87bd35f5278267ce86f3d1d2e9b1321ce901d67228be0e2dcb