[INFO] crate candidateparser 0.2.0 is already in cache [INFO] extracting crate candidateparser 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/candidateparser/0.2.0 [INFO] extracting crate candidateparser 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/candidateparser/0.2.0 [INFO] validating manifest of candidateparser-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of candidateparser-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing candidateparser-0.2.0 [INFO] finished frobbing candidateparser-0.2.0 [INFO] frobbed toml for candidateparser-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/candidateparser/0.2.0/Cargo.toml [INFO] started frobbing candidateparser-0.2.0 [INFO] finished frobbing candidateparser-0.2.0 [INFO] frobbed toml for candidateparser-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/candidateparser/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting candidateparser-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/candidateparser/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 865e159a9c252cf451c868744604ea19f780a7de61609d731806f98ecf90c92d [INFO] running `"docker" "start" "-a" "865e159a9c252cf451c868744604ea19f780a7de61609d731806f98ecf90c92d"` [INFO] [stderr] Checking candidateparser v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers.rs:388:71 [INFO] [stderr] | [INFO] [stderr] 388 | assert_eq!(priority(&b"1234567890"[..]), IResult::Done(empty, 1234567890)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_234_567_890` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers.rs:458:37 [INFO] [stderr] | [INFO] [stderr] 458 | assert_eq!(parsed.priority, 41885439); [INFO] [stderr] | ^^^^^^^^ help: consider: `41_885_439` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:77:37 [INFO] [stderr] | [INFO] [stderr] 77 | assert_eq!(parsed.priority, 1686052607); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_686_052_607` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/parsers.rs:50:26 [INFO] [stderr] | [INFO] [stderr] 50 | |val: &[u8]| val.len() >= 1 && val.len() <= 32 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!val.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/parsers.rs:71:30 [INFO] [stderr] | [INFO] [stderr] 71 | |val: &[u8]| val.len() >= 1 && val.len() <= 5 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!val.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/parsers.rs:118:30 [INFO] [stderr] | [INFO] [stderr] 118 | |val: &[u8]| val.len() >= 1 && val.len() <= 10 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!val.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers.rs:222:1 [INFO] [stderr] | [INFO] [stderr] 222 | / named_attr!(#[doc = " [INFO] [stderr] 223 | | Parse an extension pair into a tuple. [INFO] [stderr] 224 | | [INFO] [stderr] 225 | | RFC5245 grammar: [INFO] [stderr] ... | [INFO] [stderr] 247 | | ) [INFO] [stderr] 248 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers.rs:222:1 [INFO] [stderr] | [INFO] [stderr] 222 | / named_attr!(#[doc = " [INFO] [stderr] 223 | | Parse an extension pair into a tuple. [INFO] [stderr] 224 | | [INFO] [stderr] 225 | | RFC5245 grammar: [INFO] [stderr] ... | [INFO] [stderr] 247 | | ) [INFO] [stderr] 248 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/types.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | / match self { [INFO] [stderr] 32 | | &Transport::Udp => write!(f, "udp"), [INFO] [stderr] 33 | | &Transport::Extension(ref e) => write!(f, "{}", e), [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 31 | match *self { [INFO] [stderr] 32 | Transport::Udp => write!(f, "udp"), [INFO] [stderr] 33 | Transport::Extension(ref e) => write!(f, "{}", e), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/types.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | / match self { [INFO] [stderr] 72 | | &CandidateType::Host => write!(f, "host"), [INFO] [stderr] 73 | | &CandidateType::Srflx => write!(f, "srflx"), [INFO] [stderr] 74 | | &CandidateType::Prflx => write!(f, "prflx"), [INFO] [stderr] 75 | | &CandidateType::Relay => write!(f, "relay"), [INFO] [stderr] 76 | | &CandidateType::Token(ref e) => write!(f, "{}", e), [INFO] [stderr] 77 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 71 | match *self { [INFO] [stderr] 72 | CandidateType::Host => write!(f, "host"), [INFO] [stderr] 73 | CandidateType::Srflx => write!(f, "srflx"), [INFO] [stderr] 74 | CandidateType::Prflx => write!(f, "prflx"), [INFO] [stderr] 75 | CandidateType::Relay => write!(f, "relay"), [INFO] [stderr] 76 | CandidateType::Token(ref e) => write!(f, "{}", e), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/parsers.rs:50:26 [INFO] [stderr] | [INFO] [stderr] 50 | |val: &[u8]| val.len() >= 1 && val.len() <= 32 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!val.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/parsers.rs:71:30 [INFO] [stderr] | [INFO] [stderr] 71 | |val: &[u8]| val.len() >= 1 && val.len() <= 5 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!val.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/parsers.rs:118:30 [INFO] [stderr] | [INFO] [stderr] 118 | |val: &[u8]| val.len() >= 1 && val.len() <= 10 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!val.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers.rs:222:1 [INFO] [stderr] | [INFO] [stderr] 222 | / named_attr!(#[doc = " [INFO] [stderr] 223 | | Parse an extension pair into a tuple. [INFO] [stderr] 224 | | [INFO] [stderr] 225 | | RFC5245 grammar: [INFO] [stderr] ... | [INFO] [stderr] 247 | | ) [INFO] [stderr] 248 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parsers.rs:222:1 [INFO] [stderr] | [INFO] [stderr] 222 | / named_attr!(#[doc = " [INFO] [stderr] 223 | | Parse an extension pair into a tuple. [INFO] [stderr] 224 | | [INFO] [stderr] 225 | | RFC5245 grammar: [INFO] [stderr] ... | [INFO] [stderr] 247 | | ) [INFO] [stderr] 248 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/types.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | / match self { [INFO] [stderr] 32 | | &Transport::Udp => write!(f, "udp"), [INFO] [stderr] 33 | | &Transport::Extension(ref e) => write!(f, "{}", e), [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 31 | match *self { [INFO] [stderr] 32 | Transport::Udp => write!(f, "udp"), [INFO] [stderr] 33 | Transport::Extension(ref e) => write!(f, "{}", e), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/types.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | / match self { [INFO] [stderr] 72 | | &CandidateType::Host => write!(f, "host"), [INFO] [stderr] 73 | | &CandidateType::Srflx => write!(f, "srflx"), [INFO] [stderr] 74 | | &CandidateType::Prflx => write!(f, "prflx"), [INFO] [stderr] 75 | | &CandidateType::Relay => write!(f, "relay"), [INFO] [stderr] 76 | | &CandidateType::Token(ref e) => write!(f, "{}", e), [INFO] [stderr] 77 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 71 | match *self { [INFO] [stderr] 72 | CandidateType::Host => write!(f, "host"), [INFO] [stderr] 73 | CandidateType::Srflx => write!(f, "srflx"), [INFO] [stderr] 74 | CandidateType::Prflx => write!(f, "prflx"), [INFO] [stderr] 75 | CandidateType::Relay => write!(f, "relay"), [INFO] [stderr] 76 | CandidateType::Token(ref e) => write!(f, "{}", e), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.95s [INFO] running `"docker" "inspect" "865e159a9c252cf451c868744604ea19f780a7de61609d731806f98ecf90c92d"` [INFO] running `"docker" "rm" "-f" "865e159a9c252cf451c868744604ea19f780a7de61609d731806f98ecf90c92d"` [INFO] [stdout] 865e159a9c252cf451c868744604ea19f780a7de61609d731806f98ecf90c92d