[INFO] crate candid_server 0.2.1 is already in cache [INFO] extracting crate candid_server 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/candid_server/0.2.1 [INFO] extracting crate candid_server 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/candid_server/0.2.1 [INFO] validating manifest of candid_server-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of candid_server-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing candid_server-0.2.1 [INFO] finished frobbing candid_server-0.2.1 [INFO] frobbed toml for candid_server-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/candid_server/0.2.1/Cargo.toml [INFO] started frobbing candid_server-0.2.1 [INFO] finished frobbing candid_server-0.2.1 [INFO] frobbed toml for candid_server-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/candid_server/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting candid_server-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/candid_server/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 87f643e5b0348406b4adf6ede9092aaddf88a997979047c2c7aa8f931c66dcce [INFO] running `"docker" "start" "-a" "87f643e5b0348406b4adf6ede9092aaddf88a997979047c2c7aa8f931c66dcce"` [INFO] [stderr] Checking socketcan v1.7.0 [INFO] [stderr] Checking candid_server v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/client_handler.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | handle [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/client_handler.rs:26:22 [INFO] [stderr] | [INFO] [stderr] 26 | let handle = thread::spawn(move || { [INFO] [stderr] | ______________________^ [INFO] [stderr] 27 | | loop { [INFO] [stderr] 28 | | // Get an incoming frame from the reader [INFO] [stderr] 29 | | let frame = handler.can_reader.recv().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | }); [INFO] [stderr] | |__________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: field is never used: `can_socket` [INFO] [stderr] --> src/client_handler.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | can_socket: Arc>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/can_reader.rs:29:21 [INFO] [stderr] | [INFO] [stderr] 29 | client.send(frame.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/can_reader.rs:29:33 [INFO] [stderr] | [INFO] [stderr] 29 | client.send(frame.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `frame` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/can_reader.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | &self.clients.lock().unwrap().push(channel); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.clients.lock().unwrap().push(channel);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/client_handler.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new( [INFO] [stderr] 16 | | connection: TcpStream, [INFO] [stderr] 17 | | can_socket: Arc>, [INFO] [stderr] 18 | | can_reader: mpsc::Receiver, [INFO] [stderr] ... | [INFO] [stderr] 39 | | handle [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/client_handler.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | handle [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/client_handler.rs:26:22 [INFO] [stderr] | [INFO] [stderr] 26 | let handle = thread::spawn(move || { [INFO] [stderr] | ______________________^ [INFO] [stderr] 27 | | loop { [INFO] [stderr] 28 | | // Get an incoming frame from the reader [INFO] [stderr] 29 | | let frame = handler.can_reader.recv().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | }); [INFO] [stderr] | |__________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: field is never used: `can_socket` [INFO] [stderr] --> src/client_handler.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | can_socket: Arc>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/can_reader.rs:29:21 [INFO] [stderr] | [INFO] [stderr] 29 | client.send(frame.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/can_reader.rs:29:33 [INFO] [stderr] | [INFO] [stderr] 29 | client.send(frame.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `frame` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/can_reader.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | &self.clients.lock().unwrap().push(channel); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.clients.lock().unwrap().push(channel);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/client_handler.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new( [INFO] [stderr] 16 | | connection: TcpStream, [INFO] [stderr] 17 | | can_socket: Arc>, [INFO] [stderr] 18 | | can_reader: mpsc::Receiver, [INFO] [stderr] ... | [INFO] [stderr] 39 | | handle [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> src/bin/vcan_rand.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(int_to_from_bytes)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `candid_server`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> src/bin/vcan_rand.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(int_to_from_bytes)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `candid_server`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "87f643e5b0348406b4adf6ede9092aaddf88a997979047c2c7aa8f931c66dcce"` [INFO] running `"docker" "rm" "-f" "87f643e5b0348406b4adf6ede9092aaddf88a997979047c2c7aa8f931c66dcce"` [INFO] [stdout] 87f643e5b0348406b4adf6ede9092aaddf88a997979047c2c7aa8f931c66dcce