[INFO] crate cancellation 0.1.0 is already in cache [INFO] extracting crate cancellation 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/cancellation/0.1.0 [INFO] extracting crate cancellation 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cancellation/0.1.0 [INFO] validating manifest of cancellation-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cancellation-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cancellation-0.1.0 [INFO] finished frobbing cancellation-0.1.0 [INFO] frobbed toml for cancellation-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/cancellation/0.1.0/Cargo.toml [INFO] started frobbing cancellation-0.1.0 [INFO] finished frobbing cancellation-0.1.0 [INFO] frobbed toml for cancellation-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cancellation/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cancellation-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cancellation/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 87245c6805bf5a0357b4e5e1ba94f036030fe8c875d039d9f9873bf451a677ed [INFO] running `"docker" "start" "-a" "87245c6805bf5a0357b4e5e1ba94f036030fe8c875d039d9f9873bf451a677ed"` [INFO] [stderr] Checking cancellation v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:345:33 [INFO] [stderr] | [INFO] [stderr] 345 | on_cancel: on_cancel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `on_cancel` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:345:33 [INFO] [stderr] | [INFO] [stderr] 345 | on_cancel: on_cancel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `on_cancel` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> lib.rs:174:5 [INFO] [stderr] | [INFO] [stderr] 174 | mem::transmute(r) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `r as *mut Registration<'_> as *mut Registration<'static>` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `CancellationTokenSource` [INFO] [stderr] --> lib.rs:194:5 [INFO] [stderr] | [INFO] [stderr] 194 | / pub fn new() -> CancellationTokenSource { [INFO] [stderr] 195 | | CancellationTokenSource { [INFO] [stderr] 196 | | token: Arc::new(CancellationToken { [INFO] [stderr] 197 | | status: AtomicUsize::new(STATUS_NOT_CANCELED), [INFO] [stderr] ... | [INFO] [stderr] 200 | | } [INFO] [stderr] 201 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 193 | impl Default for CancellationTokenSource { [INFO] [stderr] 194 | fn default() -> Self { [INFO] [stderr] 195 | Self::new() [INFO] [stderr] 196 | } [INFO] [stderr] 197 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicPtr instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> lib.rs:198:37 [INFO] [stderr] | [INFO] [stderr] 198 | registrations: Some(Mutex::new(ptr::null_mut())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> lib.rs:174:5 [INFO] [stderr] | [INFO] [stderr] 174 | mem::transmute(r) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `r as *mut Registration<'_> as *mut Registration<'static>` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `CancellationTokenSource` [INFO] [stderr] --> lib.rs:194:5 [INFO] [stderr] | [INFO] [stderr] 194 | / pub fn new() -> CancellationTokenSource { [INFO] [stderr] 195 | | CancellationTokenSource { [INFO] [stderr] 196 | | token: Arc::new(CancellationToken { [INFO] [stderr] 197 | | status: AtomicUsize::new(STATUS_NOT_CANCELED), [INFO] [stderr] ... | [INFO] [stderr] 200 | | } [INFO] [stderr] 201 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 193 | impl Default for CancellationTokenSource { [INFO] [stderr] 194 | fn default() -> Self { [INFO] [stderr] 195 | Self::new() [INFO] [stderr] 196 | } [INFO] [stderr] 197 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicPtr instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> lib.rs:198:37 [INFO] [stderr] | [INFO] [stderr] 198 | registrations: Some(Mutex::new(ptr::null_mut())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.53s [INFO] running `"docker" "inspect" "87245c6805bf5a0357b4e5e1ba94f036030fe8c875d039d9f9873bf451a677ed"` [INFO] running `"docker" "rm" "-f" "87245c6805bf5a0357b4e5e1ba94f036030fe8c875d039d9f9873bf451a677ed"` [INFO] [stdout] 87245c6805bf5a0357b4e5e1ba94f036030fe8c875d039d9f9873bf451a677ed