[INFO] crate calm 0.1.0 is already in cache
[INFO] extracting crate calm 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/calm/0.1.0
[INFO] extracting crate calm 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/calm/0.1.0
[INFO] validating manifest of calm-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of calm-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing calm-0.1.0
[INFO] finished frobbing calm-0.1.0
[INFO] frobbed toml for calm-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/calm/0.1.0/Cargo.toml
[INFO] started frobbing calm-0.1.0
[INFO] finished frobbing calm-0.1.0
[INFO] frobbed toml for calm-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/calm/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting calm-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/calm/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 5fbb3c36d94a8f2b7138b6eaf17c092a022bf99d48864febb67e707cfee0e21e
[INFO] running `"docker" "start" "-a" "5fbb3c36d94a8f2b7138b6eaf17c092a022bf99d48864febb67e707cfee0e21e"`
[INFO] [stderr]     Checking if_chain v0.1.3
[INFO] [stderr]     Checking which v1.0.5
[INFO] [stderr]     Checking clicolors-control v0.3.2
[INFO] [stderr]     Checking dotenv v0.10.1
[INFO] [stderr]     Checking indicatif v0.6.0
[INFO] [stderr]     Checking elementtree v0.5.0
[INFO] [stderr]     Checking console v0.5.0
[INFO] [stderr]     Checking calm v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: using `writeln!(&mut io::stderr(), "")`
[INFO] [stderr]    --> src/cli.rs:180:9
[INFO] [stderr]     |
[INFO] [stderr] 180 |         writeln!(&mut io::stderr(), "").ok();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(&mut io::stderr())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::writeln_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/config.rs:270:13
[INFO] [stderr]     |
[INFO] [stderr] 270 |             filename: filename,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/config.rs:271:13
[INFO] [stderr]     |
[INFO] [stderr] 271 |             config_dir: config_dir,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `config_dir`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/config.rs:272:13
[INFO] [stderr]     |
[INFO] [stderr] 272 |             cache_dir: cache_dir,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cache_dir`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/ctx.rs:70:13
[INFO] [stderr]    |
[INFO] [stderr] 70 |             config: config,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `config`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]   --> src/ctx.rs:91:9
[INFO] [stderr]    |
[INFO] [stderr] 91 | /         write!(&mut ::std::io::stderr(), "{} {}\n",
[INFO] [stderr] 92 | |                style(">").dim().bold(),
[INFO] [stderr] 93 | |                text).unwrap();
[INFO] [stderr]    | |____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/report.rs:168:13
[INFO] [stderr]     |
[INFO] [stderr] 168 |             ctx: ctx,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `ctx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/report.rs:286:17
[INFO] [stderr]     |
[INFO] [stderr] 286 |                 println!("");
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/rt/python.rs:35:13
[INFO] [stderr]    |
[INFO] [stderr] 35 |             ctx: ctx,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `ctx`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/rt/python.rs:37:13
[INFO] [stderr]    |
[INFO] [stderr] 37 |             config: config,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `config`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/rt/js.rs:30:13
[INFO] [stderr]    |
[INFO] [stderr] 30 |             ctx: ctx,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `ctx`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/rt/js.rs:32:13
[INFO] [stderr]    |
[INFO] [stderr] 32 |             config: config,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `config`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/tools.rs:41:13
[INFO] [stderr]    |
[INFO] [stderr] 41 |             ctx: ctx,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `ctx`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/tools.rs:43:13
[INFO] [stderr]    |
[INFO] [stderr] 43 |             spec: spec,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `spec`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/tools.rs:44:13
[INFO] [stderr]    |
[INFO] [stderr] 44 |             runtimes: runtimes,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `runtimes`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]   --> src/utils/cmd.rs:70:17
[INFO] [stderr]    |
[INFO] [stderr] 70 |                 write!(&mut ::std::io::stderr(), "  {}\n", text).unwrap();
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/utils/cmd.rs:92:13
[INFO] [stderr]    |
[INFO] [stderr] 92 |             cmd_name: cmd_name,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `cmd_name`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/utils/cmd.rs:94:13
[INFO] [stderr]    |
[INFO] [stderr] 94 |             child: child,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `child`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/utils/cmd.rs:165:13
[INFO] [stderr]     |
[INFO] [stderr] 165 |             cmd: cmd,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `cmd`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]   --> src/utils/hooks.rs:60:9
[INFO] [stderr]    |
[INFO] [stderr] 60 |         write!(&mut contents, "calm hook --exec-{} || exit 1\n", hook).unwrap();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(&mut io::stderr(), "")`
[INFO] [stderr]    --> src/cli.rs:180:9
[INFO] [stderr]     |
[INFO] [stderr] 180 |         writeln!(&mut io::stderr(), "").ok();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(&mut io::stderr())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::writeln_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/config.rs:270:13
[INFO] [stderr]     |
[INFO] [stderr] 270 |             filename: filename,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/config.rs:271:13
[INFO] [stderr]     |
[INFO] [stderr] 271 |             config_dir: config_dir,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `config_dir`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/config.rs:272:13
[INFO] [stderr]     |
[INFO] [stderr] 272 |             cache_dir: cache_dir,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cache_dir`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/ctx.rs:70:13
[INFO] [stderr]    |
[INFO] [stderr] 70 |             config: config,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `config`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]   --> src/ctx.rs:91:9
[INFO] [stderr]    |
[INFO] [stderr] 91 | /         write!(&mut ::std::io::stderr(), "{} {}\n",
[INFO] [stderr] 92 | |                style(">").dim().bold(),
[INFO] [stderr] 93 | |                text).unwrap();
[INFO] [stderr]    | |____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/report.rs:168:13
[INFO] [stderr]     |
[INFO] [stderr] 168 |             ctx: ctx,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `ctx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/report.rs:286:17
[INFO] [stderr]     |
[INFO] [stderr] 286 |                 println!("");
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/rt/python.rs:35:13
[INFO] [stderr]    |
[INFO] [stderr] 35 |             ctx: ctx,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `ctx`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/rt/python.rs:37:13
[INFO] [stderr]    |
[INFO] [stderr] 37 |             config: config,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `config`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/rt/js.rs:30:13
[INFO] [stderr]    |
[INFO] [stderr] 30 |             ctx: ctx,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `ctx`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/rt/js.rs:32:13
[INFO] [stderr]    |
[INFO] [stderr] 32 |             config: config,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `config`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/tools.rs:41:13
[INFO] [stderr]    |
[INFO] [stderr] 41 |             ctx: ctx,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `ctx`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/tools.rs:43:13
[INFO] [stderr]    |
[INFO] [stderr] 43 |             spec: spec,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `spec`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/tools.rs:44:13
[INFO] [stderr]    |
[INFO] [stderr] 44 |             runtimes: runtimes,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `runtimes`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]   --> src/utils/cmd.rs:70:17
[INFO] [stderr]    |
[INFO] [stderr] 70 |                 write!(&mut ::std::io::stderr(), "  {}\n", text).unwrap();
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/utils/cmd.rs:92:13
[INFO] [stderr]    |
[INFO] [stderr] 92 |             cmd_name: cmd_name,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `cmd_name`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/utils/cmd.rs:94:13
[INFO] [stderr]    |
[INFO] [stderr] 94 |             child: child,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `child`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/utils/cmd.rs:165:13
[INFO] [stderr]     |
[INFO] [stderr] 165 |             cmd: cmd,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `cmd`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]   --> src/utils/hooks.rs:60:9
[INFO] [stderr]    |
[INFO] [stderr] 60 |         write!(&mut contents, "calm hook --exec-{} || exit 1\n", hook).unwrap();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/cli.rs:16:15
[INFO] [stderr]    |
[INFO] [stderr] 16 | const ABOUT: &'static str = "
[INFO] [stderr]    |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/rt/python.rs:13:24
[INFO] [stderr]    |
[INFO] [stderr] 13 | const DEFAULT_FLAVOR: &'static str = "python3";
[INFO] [stderr]    |                       -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]    --> src/config.rs:256:29
[INFO] [stderr]     |
[INFO] [stderr] 256 |         let mut cache_dir = env::home_dir().ok_or(
[INFO] [stderr]     |                             ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/cli.rs:16:15
[INFO] [stderr]    |
[INFO] [stderr] 16 | const ABOUT: &'static str = "
[INFO] [stderr]    |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/rt/python.rs:13:24
[INFO] [stderr]    |
[INFO] [stderr] 13 | const DEFAULT_FLAVOR: &'static str = "python3";
[INFO] [stderr]    |                       -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]    --> src/config.rs:256:29
[INFO] [stderr]     |
[INFO] [stderr] 256 |         let mut cache_dir = env::home_dir().ok_or(
[INFO] [stderr]     |                             ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/tools.rs:134:50
[INFO] [stderr]     |
[INFO] [stderr] 134 |             if let Some(report) = opts.and_then(|mut x| x.report.as_mut()) {
[INFO] [stderr]     |                                                  ----^
[INFO] [stderr]     |                                                  |
[INFO] [stderr]     |                                                  help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/cli.rs:95:5
[INFO] [stderr]     |
[INFO] [stderr] 95  | /     let paths: Option<Vec<&Path>>;
[INFO] [stderr] 96  | |
[INFO] [stderr] 97  | |     if matches.is_present("changed_files") {
[INFO] [stderr] 98  | |         changed_files = get_changed_files()?;
[INFO] [stderr] ...   |
[INFO] [stderr] 105 | |             .map(|values| values.map(|x| Path::new(x)).collect::<Vec<_>>());
[INFO] [stderr] 106 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] help: it is more idiomatic to write
[INFO] [stderr]     |
[INFO] [stderr] 95  |     let paths = if matches.is_present("changed_files") { ..; Some(changed_files.iter().map(|x| x.as_path()).collect()) } else { matches.values_of("files")
[INFO] [stderr] 96  |             .map(|values| values.map(|x| Path::new(x)).collect::<Vec<_>>()) };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/cli.rs:168:5
[INFO] [stderr]     |
[INFO] [stderr] 168 | /     if let &ErrorKind::Clap(ref clap_err) = err.kind() {
[INFO] [stderr] 169 | |         clap_err.exit();
[INFO] [stderr] 170 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 168 |     if let ErrorKind::Clap(ref clap_err) = *err.kind() {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/cli.rs:189:13
[INFO] [stderr]     |
[INFO] [stderr] 189 | /             if let &ErrorKind::QuietExit(code) = err.kind() {
[INFO] [stderr] 190 | |                 process::exit(code);
[INFO] [stderr] 191 | |             } else {
[INFO] [stderr] 192 | |                 print_error(&err);
[INFO] [stderr] 193 | |                 process::exit(1);
[INFO] [stderr] 194 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 189 |             if let ErrorKind::QuietExit(code) = *err.kind() {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/config.rs:156:17
[INFO] [stderr]     |
[INFO] [stderr] 156 | /                 if let &Some(ref desc) = description {
[INFO] [stderr] 157 | |                     desc.to_string()
[INFO] [stderr] 158 | |                 } else {
[INFO] [stderr] 159 | |                     format!("Running {}", self.cmd_name())
[INFO] [stderr] 160 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 156 |                 if let Some(ref desc) = *description {
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^   ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/config.rs:163:17
[INFO] [stderr]     |
[INFO] [stderr] 163 | /                 if let &Some(ref desc) = description {
[INFO] [stderr] 164 | |                     desc.to_string()
[INFO] [stderr] 165 | |                 } else {
[INFO] [stderr] 166 | |                     format!("Linking {}", link.src.display())
[INFO] [stderr] 167 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 163 |                 if let Some(ref desc) = *description {
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^   ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/config.rs:175:17
[INFO] [stderr]     |
[INFO] [stderr] 175 | /                 match cmd {
[INFO] [stderr] 176 | |                     &ToolCommand::Shell(ref cmd) => cmd.split_whitespace().next(),
[INFO] [stderr] 177 | |                     &ToolCommand::Exec(ref cmd) => cmd.get(0).map(|x| x.as_str()),
[INFO] [stderr] 178 | |                 }.unwrap_or("command")
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 175 |                 match *cmd {
[INFO] [stderr] 176 |                     ToolCommand::Shell(ref cmd) => cmd.split_whitespace().next(),
[INFO] [stderr] 177 |                     ToolCommand::Exec(ref cmd) => cmd.get(0).map(|x| x.as_str()),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/config.rs:256:45
[INFO] [stderr]     |
[INFO] [stderr] 256 |           let mut cache_dir = env::home_dir().ok_or(
[INFO] [stderr]     |  _____________________________________________^
[INFO] [stderr] 257 | |             Error::from("could not find home folder"))?;
[INFO] [stderr]     | |______________________________________________________^ help: try this: `ok_or_else(|| Error::from("could not find home folder"))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/config.rs:295:5
[INFO] [stderr]     |
[INFO] [stderr] 295 | /     pub fn tool_dir_prefix<'a>(&'a self) -> Option<Cow<'a, Path>> {
[INFO] [stderr] 296 | |         if let Some(ref tool_dir) = self.tool_dir_base {
[INFO] [stderr] 297 | |             Some(if_chain! {
[INFO] [stderr] 298 | |                 if let Some(ref include) = self.include;
[INFO] [stderr] ...   |
[INFO] [stderr] 308 | |         }
[INFO] [stderr] 309 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/config.rs:317:17
[INFO] [stderr]     |
[INFO] [stderr] 317 | /                 if let &Some(ref path) = path {
[INFO] [stderr] 318 | |                     let path = Path::new(path);
[INFO] [stderr] 319 | |                     if let Ok(rest) = path.strip_prefix("/") {
[INFO] [stderr] 320 | |                         return Some(rest);
[INFO] [stderr] ...   |
[INFO] [stderr] 323 | |                     }
[INFO] [stderr] 324 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 317 |                 if let Some(ref path) = *path {
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/config.rs:351:17
[INFO] [stderr]     |
[INFO] [stderr] 351 | /                 if let &Some(ref rev) = rev {
[INFO] [stderr] 352 | |                     m.update(rev.as_bytes());
[INFO] [stderr] 353 | |                     m.update(b"\x00");
[INFO] [stderr] 354 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 351 |                 if let Some(ref rev) = *rev {
[INFO] [stderr]     |                        ^^^^^^^^^^^^^   ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/ctx.rs:45:17
[INFO] [stderr]    |
[INFO] [stderr] 45 | /                 if let &Some(ref rev) = rev {
[INFO] [stderr] 46 | |                     cmd.arg("-b").arg(rev);
[INFO] [stderr] 47 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 45 |                 if let Some(ref rev) = *rev {
[INFO] [stderr]    |                        ^^^^^^^^^^^^^   ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
[INFO] [stderr]    --> src/report.rs:101:37
[INFO] [stderr]     |
[INFO] [stderr] 101 |             if let Some(Ok(line)) = BufReader::new(sf).lines().skip(self.line as usize - 1).next();
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::iter_skip_next)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/report.rs:149:5
[INFO] [stderr]     |
[INFO] [stderr] 149 | /     pub fn simple_format<'a>(&'a self) -> LintResultSimpleFormat<'a> {
[INFO] [stderr] 150 | |         LintResultSimpleFormat {
[INFO] [stderr] 151 | |             lr: self,
[INFO] [stderr] 152 | |         }
[INFO] [stderr] 153 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/tools.rs:134:50
[INFO] [stderr]     |
[INFO] [stderr] 134 |             if let Some(report) = opts.and_then(|mut x| x.report.as_mut()) {
[INFO] [stderr]     |                                                  ----^
[INFO] [stderr]     |                                                  |
[INFO] [stderr]     |                                                  help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]   --> src/rt/python.rs:81:12
[INFO] [stderr]    |
[INFO] [stderr] 81 |         if !fs::metadata(path.join("bin").join("python")).is_ok() {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(path.join("bin").join("python")).is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]   --> src/rt/js.rs:77:12
[INFO] [stderr]    |
[INFO] [stderr] 77 |         if !fs::metadata(path.join("package.json")).is_ok() {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(path.join("package.json")).is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]   --> src/rt/js.rs:95:12
[INFO] [stderr]    |
[INFO] [stderr] 95 |         if !fs::metadata(path.join("node_modules/.bin/yarn")).is_ok() {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(path.join("node_modules/.bin/yarn")).is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> src/rt/js.rs:80:25
[INFO] [stderr]    |
[INFO] [stderr] 80 |               f.write_all(r#"
[INFO] [stderr]    |  _________________________^
[INFO] [stderr] 81 | |                 {
[INFO] [stderr] 82 | |                   "name": "calm-js-scratchpad",
[INFO] [stderr] 83 | |                   "version": "0.0.1",
[INFO] [stderr] ...  |
[INFO] [stderr] 90 | |                 }
[INFO] [stderr] 91 | |             "#.as_bytes())?;
[INFO] [stderr]    | |_________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] help: consider using a byte string literal instead
[INFO] [stderr]    |
[INFO] [stderr] 80 |             f.write_all(br#"
[INFO] [stderr] 81 |                 {
[INFO] [stderr] 82 |                   "name": "calm-js-scratchpad",
[INFO] [stderr] 83 |                   "version": "0.0.1",
[INFO] [stderr] 84 |                   "description": "",
[INFO] [stderr] 85 |                   "author": "",
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/tools.rs:52:5
[INFO] [stderr]    |
[INFO] [stderr] 52 | /     pub fn tool_dir<'b>(&'b self) -> Cow<'b, Path> {
[INFO] [stderr] 53 | |         if let Some(rv) = self.spec.tool_dir_prefix() {
[INFO] [stderr] 54 | |             rv
[INFO] [stderr] 55 | |         } else {
[INFO] [stderr] 56 | |             Cow::Borrowed(self.ctx.config().config_dir())
[INFO] [stderr] 57 | |         }
[INFO] [stderr] 58 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/tools.rs:99:13
[INFO] [stderr]     |
[INFO] [stderr] 99  | /             match tool_cmd {
[INFO] [stderr] 100 | |                 &ToolCommand::Shell(ref cmdline) => {
[INFO] [stderr] 101 | |                     cmd = CommandBuilder::new_shell(cmdline);
[INFO] [stderr] 102 | |                 }
[INFO] [stderr] ...   |
[INFO] [stderr] 111 | |                 }
[INFO] [stderr] 112 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 99  |             match *tool_cmd {
[INFO] [stderr] 100 |                 ToolCommand::Shell(ref cmdline) => {
[INFO] [stderr] 101 |                     cmd = CommandBuilder::new_shell(cmdline);
[INFO] [stderr] 102 |                 }
[INFO] [stderr] 103 |                 ToolCommand::Exec(ref args) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/tools.rs:204:31
[INFO] [stderr]     |
[INFO] [stderr] 204 |                 }).collect()).unwrap_or(vec![]),
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]   --> src/utils/cmd.rs:32:20
[INFO] [stderr]    |
[INFO] [stderr] 32 |     pub on_stdout: Option<Box<FnMut(&str) -> Result<Cow<'static, str>> + Send + Sync + 'a>>,
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]   --> src/utils/cmd.rs:33:20
[INFO] [stderr]    |
[INFO] [stderr] 33 |     pub on_stderr: Option<Box<FnMut(&str) -> Result<Cow<'static, str>> + Send + Sync + 'a>>,
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]   --> src/utils/cmd.rs:48:39
[INFO] [stderr]    |
[INFO] [stderr] 48 |                           mut f: Option<&mut Box<FnMut(&str)
[INFO] [stderr]    |  _______________________________________^
[INFO] [stderr] 49 | |                             -> Result<Cow<'static, str>> + Send + Sync + 'a>>,
[INFO] [stderr]    | |____________________________________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::borrowed_box)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 48 |                         mut f: Option<&mut FnMut(&str)
[INFO] [stderr] 49 |                             -> Result<Cow<'static, str>> + Send + Sync + 'a>,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]   --> src/utils/cmd.rs:48:32
[INFO] [stderr]    |
[INFO] [stderr] 48 |                           mut f: Option<&mut Box<FnMut(&str)
[INFO] [stderr]    |  ________________________________^
[INFO] [stderr] 49 | |                             -> Result<Cow<'static, str>> + Send + Sync + 'a>>,
[INFO] [stderr]    | |_____________________________________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: use of a blacklisted/placeholder name `bar`
[INFO] [stderr]   --> src/utils/cmd.rs:47:45
[INFO] [stderr]    |
[INFO] [stderr] 47 | fn process<'a, R: Read>(r: R, prefix: &str, bar: &ProgressBar,
[INFO] [stderr]    |                                             ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::blacklisted_name)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name
[INFO] [stderr] 
[INFO] [stderr] warning: use of a blacklisted/placeholder name `bar`
[INFO] [stderr]    --> src/utils/cmd.rs:114:13
[INFO] [stderr]     |
[INFO] [stderr] 114 |         let bar = &self.bar;
[INFO] [stderr]     |             ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/utils/cmd.rs:219:1
[INFO] [stderr]     |
[INFO] [stderr] 219 | / pub fn expand_vars<'a, F: Fn(&str) -> String>(s: &'a str, f: F) -> Cow<'a, str> {
[INFO] [stderr] 220 | |     lazy_static! {
[INFO] [stderr] 221 | |         static ref VAR_RE: Regex = Regex::new(
[INFO] [stderr] 222 | |             r"\$(\$|[a-zA-Z0-9_]+|\([^)]+\)|\{[^}]+\})").unwrap();
[INFO] [stderr] ...   |
[INFO] [stderr] 233 | |     })
[INFO] [stderr] 234 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/utils/serde.rs:62:12
[INFO] [stderr]    |
[INFO] [stderr] 62 |         }).unwrap_or(Cow::Borrowed(path))
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Cow::Borrowed(path))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/utils/serde.rs:55:39
[INFO] [stderr]    |
[INFO] [stderr] 55 |                         env::var(key).unwrap_or("".to_string())
[INFO] [stderr]    |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/utils/serde.rs:91:30
[INFO] [stderr]    |
[INFO] [stderr] 91 |                         .map(|re| Pattern::Regex(re))
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Pattern::Regex`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/utils/serde.rs:97:30
[INFO] [stderr]    |
[INFO] [stderr] 97 |                         .map(|pat| Pattern::Glob(pat))
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Pattern::Glob`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] error: for loop over `HOOK_RE.captures(&contents)`, which is an `Option`. This is more readably written as an `if let` statement.
[INFO] [stderr]   --> src/utils/hooks.rs:42:22
[INFO] [stderr]    |
[INFO] [stderr] 42 |             for m in HOOK_RE.captures(&contents) {
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::for_loop_over_option)] on by default
[INFO] [stderr]    = help: consider replacing `for m in HOOK_RE.captures(&contents)` with `if let Some(m) = HOOK_RE.captures(&contents)`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/cli.rs:95:5
[INFO] [stderr]     |
[INFO] [stderr] 95  | /     let paths: Option<Vec<&Path>>;
[INFO] [stderr] 96  | |
[INFO] [stderr] 97  | |     if matches.is_present("changed_files") {
[INFO] [stderr] 98  | |         changed_files = get_changed_files()?;
[INFO] [stderr] ...   |
[INFO] [stderr] 105 | |             .map(|values| values.map(|x| Path::new(x)).collect::<Vec<_>>());
[INFO] [stderr] 106 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] help: it is more idiomatic to write
[INFO] [stderr]     |
[INFO] [stderr] 95  |     let paths = if matches.is_present("changed_files") { ..; Some(changed_files.iter().map(|x| x.as_path()).collect()) } else { matches.values_of("files")
[INFO] [stderr] 96  |             .map(|values| values.map(|x| Path::new(x)).collect::<Vec<_>>()) };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/cli.rs:168:5
[INFO] [stderr]     |
[INFO] [stderr] 168 | /     if let &ErrorKind::Clap(ref clap_err) = err.kind() {
[INFO] [stderr] 169 | |         clap_err.exit();
[INFO] [stderr] 170 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 168 |     if let ErrorKind::Clap(ref clap_err) = *err.kind() {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `calm`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/cli.rs:189:13
[INFO] [stderr]     |
[INFO] [stderr] 189 | /             if let &ErrorKind::QuietExit(code) = err.kind() {
[INFO] [stderr] 190 | |                 process::exit(code);
[INFO] [stderr] 191 | |             } else {
[INFO] [stderr] 192 | |                 print_error(&err);
[INFO] [stderr] 193 | |                 process::exit(1);
[INFO] [stderr] 194 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 189 |             if let ErrorKind::QuietExit(code) = *err.kind() {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/config.rs:156:17
[INFO] [stderr]     |
[INFO] [stderr] 156 | /                 if let &Some(ref desc) = description {
[INFO] [stderr] 157 | |                     desc.to_string()
[INFO] [stderr] 158 | |                 } else {
[INFO] [stderr] 159 | |                     format!("Running {}", self.cmd_name())
[INFO] [stderr] 160 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 156 |                 if let Some(ref desc) = *description {
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^   ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/config.rs:163:17
[INFO] [stderr]     |
[INFO] [stderr] 163 | /                 if let &Some(ref desc) = description {
[INFO] [stderr] 164 | |                     desc.to_string()
[INFO] [stderr] 165 | |                 } else {
[INFO] [stderr] 166 | |                     format!("Linking {}", link.src.display())
[INFO] [stderr] 167 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 163 |                 if let Some(ref desc) = *description {
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^   ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/config.rs:175:17
[INFO] [stderr]     |
[INFO] [stderr] 175 | /                 match cmd {
[INFO] [stderr] 176 | |                     &ToolCommand::Shell(ref cmd) => cmd.split_whitespace().next(),
[INFO] [stderr] 177 | |                     &ToolCommand::Exec(ref cmd) => cmd.get(0).map(|x| x.as_str()),
[INFO] [stderr] 178 | |                 }.unwrap_or("command")
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 175 |                 match *cmd {
[INFO] [stderr] 176 |                     ToolCommand::Shell(ref cmd) => cmd.split_whitespace().next(),
[INFO] [stderr] 177 |                     ToolCommand::Exec(ref cmd) => cmd.get(0).map(|x| x.as_str()),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/config.rs:256:45
[INFO] [stderr]     |
[INFO] [stderr] 256 |           let mut cache_dir = env::home_dir().ok_or(
[INFO] [stderr]     |  _____________________________________________^
[INFO] [stderr] 257 | |             Error::from("could not find home folder"))?;
[INFO] [stderr]     | |______________________________________________________^ help: try this: `ok_or_else(|| Error::from("could not find home folder"))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/config.rs:295:5
[INFO] [stderr]     |
[INFO] [stderr] 295 | /     pub fn tool_dir_prefix<'a>(&'a self) -> Option<Cow<'a, Path>> {
[INFO] [stderr] 296 | |         if let Some(ref tool_dir) = self.tool_dir_base {
[INFO] [stderr] 297 | |             Some(if_chain! {
[INFO] [stderr] 298 | |                 if let Some(ref include) = self.include;
[INFO] [stderr] ...   |
[INFO] [stderr] 308 | |         }
[INFO] [stderr] 309 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/config.rs:317:17
[INFO] [stderr]     |
[INFO] [stderr] 317 | /                 if let &Some(ref path) = path {
[INFO] [stderr] 318 | |                     let path = Path::new(path);
[INFO] [stderr] 319 | |                     if let Ok(rest) = path.strip_prefix("/") {
[INFO] [stderr] 320 | |                         return Some(rest);
[INFO] [stderr] ...   |
[INFO] [stderr] 323 | |                     }
[INFO] [stderr] 324 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 317 |                 if let Some(ref path) = *path {
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/config.rs:351:17
[INFO] [stderr]     |
[INFO] [stderr] 351 | /                 if let &Some(ref rev) = rev {
[INFO] [stderr] 352 | |                     m.update(rev.as_bytes());
[INFO] [stderr] 353 | |                     m.update(b"\x00");
[INFO] [stderr] 354 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 351 |                 if let Some(ref rev) = *rev {
[INFO] [stderr]     |                        ^^^^^^^^^^^^^   ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/ctx.rs:45:17
[INFO] [stderr]    |
[INFO] [stderr] 45 | /                 if let &Some(ref rev) = rev {
[INFO] [stderr] 46 | |                     cmd.arg("-b").arg(rev);
[INFO] [stderr] 47 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 45 |                 if let Some(ref rev) = *rev {
[INFO] [stderr]    |                        ^^^^^^^^^^^^^   ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
[INFO] [stderr]    --> src/report.rs:101:37
[INFO] [stderr]     |
[INFO] [stderr] 101 |             if let Some(Ok(line)) = BufReader::new(sf).lines().skip(self.line as usize - 1).next();
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::iter_skip_next)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/report.rs:149:5
[INFO] [stderr]     |
[INFO] [stderr] 149 | /     pub fn simple_format<'a>(&'a self) -> LintResultSimpleFormat<'a> {
[INFO] [stderr] 150 | |         LintResultSimpleFormat {
[INFO] [stderr] 151 | |             lr: self,
[INFO] [stderr] 152 | |         }
[INFO] [stderr] 153 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]   --> src/rt/python.rs:81:12
[INFO] [stderr]    |
[INFO] [stderr] 81 |         if !fs::metadata(path.join("bin").join("python")).is_ok() {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(path.join("bin").join("python")).is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]   --> src/rt/js.rs:77:12
[INFO] [stderr]    |
[INFO] [stderr] 77 |         if !fs::metadata(path.join("package.json")).is_ok() {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(path.join("package.json")).is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]   --> src/rt/js.rs:95:12
[INFO] [stderr]    |
[INFO] [stderr] 95 |         if !fs::metadata(path.join("node_modules/.bin/yarn")).is_ok() {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(path.join("node_modules/.bin/yarn")).is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> src/rt/js.rs:80:25
[INFO] [stderr]    |
[INFO] [stderr] 80 |               f.write_all(r#"
[INFO] [stderr]    |  _________________________^
[INFO] [stderr] 81 | |                 {
[INFO] [stderr] 82 | |                   "name": "calm-js-scratchpad",
[INFO] [stderr] 83 | |                   "version": "0.0.1",
[INFO] [stderr] ...  |
[INFO] [stderr] 90 | |                 }
[INFO] [stderr] 91 | |             "#.as_bytes())?;
[INFO] [stderr]    | |_________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] help: consider using a byte string literal instead
[INFO] [stderr]    |
[INFO] [stderr] 80 |             f.write_all(br#"
[INFO] [stderr] 81 |                 {
[INFO] [stderr] 82 |                   "name": "calm-js-scratchpad",
[INFO] [stderr] 83 |                   "version": "0.0.1",
[INFO] [stderr] 84 |                   "description": "",
[INFO] [stderr] 85 |                   "author": "",
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/tools.rs:52:5
[INFO] [stderr]    |
[INFO] [stderr] 52 | /     pub fn tool_dir<'b>(&'b self) -> Cow<'b, Path> {
[INFO] [stderr] 53 | |         if let Some(rv) = self.spec.tool_dir_prefix() {
[INFO] [stderr] 54 | |             rv
[INFO] [stderr] 55 | |         } else {
[INFO] [stderr] 56 | |             Cow::Borrowed(self.ctx.config().config_dir())
[INFO] [stderr] 57 | |         }
[INFO] [stderr] 58 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/tools.rs:99:13
[INFO] [stderr]     |
[INFO] [stderr] 99  | /             match tool_cmd {
[INFO] [stderr] 100 | |                 &ToolCommand::Shell(ref cmdline) => {
[INFO] [stderr] 101 | |                     cmd = CommandBuilder::new_shell(cmdline);
[INFO] [stderr] 102 | |                 }
[INFO] [stderr] ...   |
[INFO] [stderr] 111 | |                 }
[INFO] [stderr] 112 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 99  |             match *tool_cmd {
[INFO] [stderr] 100 |                 ToolCommand::Shell(ref cmdline) => {
[INFO] [stderr] 101 |                     cmd = CommandBuilder::new_shell(cmdline);
[INFO] [stderr] 102 |                 }
[INFO] [stderr] 103 |                 ToolCommand::Exec(ref args) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/tools.rs:204:31
[INFO] [stderr]     |
[INFO] [stderr] 204 |                 }).collect()).unwrap_or(vec![]),
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]   --> src/utils/cmd.rs:32:20
[INFO] [stderr]    |
[INFO] [stderr] 32 |     pub on_stdout: Option<Box<FnMut(&str) -> Result<Cow<'static, str>> + Send + Sync + 'a>>,
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]   --> src/utils/cmd.rs:33:20
[INFO] [stderr]    |
[INFO] [stderr] 33 |     pub on_stderr: Option<Box<FnMut(&str) -> Result<Cow<'static, str>> + Send + Sync + 'a>>,
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]   --> src/utils/cmd.rs:48:39
[INFO] [stderr]    |
[INFO] [stderr] 48 |                           mut f: Option<&mut Box<FnMut(&str)
[INFO] [stderr]    |  _______________________________________^
[INFO] [stderr] 49 | |                             -> Result<Cow<'static, str>> + Send + Sync + 'a>>,
[INFO] [stderr]    | |____________________________________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::borrowed_box)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 48 |                         mut f: Option<&mut FnMut(&str)
[INFO] [stderr] 49 |                             -> Result<Cow<'static, str>> + Send + Sync + 'a>,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]   --> src/utils/cmd.rs:48:32
[INFO] [stderr]    |
[INFO] [stderr] 48 |                           mut f: Option<&mut Box<FnMut(&str)
[INFO] [stderr]    |  ________________________________^
[INFO] [stderr] 49 | |                             -> Result<Cow<'static, str>> + Send + Sync + 'a>>,
[INFO] [stderr]    | |_____________________________________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: use of a blacklisted/placeholder name `bar`
[INFO] [stderr]   --> src/utils/cmd.rs:47:45
[INFO] [stderr]    |
[INFO] [stderr] 47 | fn process<'a, R: Read>(r: R, prefix: &str, bar: &ProgressBar,
[INFO] [stderr]    |                                             ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::blacklisted_name)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name
[INFO] [stderr] 
[INFO] [stderr] warning: use of a blacklisted/placeholder name `bar`
[INFO] [stderr]    --> src/utils/cmd.rs:114:13
[INFO] [stderr]     |
[INFO] [stderr] 114 |         let bar = &self.bar;
[INFO] [stderr]     |             ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/utils/cmd.rs:219:1
[INFO] [stderr]     |
[INFO] [stderr] 219 | / pub fn expand_vars<'a, F: Fn(&str) -> String>(s: &'a str, f: F) -> Cow<'a, str> {
[INFO] [stderr] 220 | |     lazy_static! {
[INFO] [stderr] 221 | |         static ref VAR_RE: Regex = Regex::new(
[INFO] [stderr] 222 | |             r"\$(\$|[a-zA-Z0-9_]+|\([^)]+\)|\{[^}]+\})").unwrap();
[INFO] [stderr] ...   |
[INFO] [stderr] 233 | |     })
[INFO] [stderr] 234 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/utils/serde.rs:62:12
[INFO] [stderr]    |
[INFO] [stderr] 62 |         }).unwrap_or(Cow::Borrowed(path))
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Cow::Borrowed(path))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/utils/serde.rs:55:39
[INFO] [stderr]    |
[INFO] [stderr] 55 |                         env::var(key).unwrap_or("".to_string())
[INFO] [stderr]    |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/utils/serde.rs:91:30
[INFO] [stderr]    |
[INFO] [stderr] 91 |                         .map(|re| Pattern::Regex(re))
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Pattern::Regex`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/utils/serde.rs:97:30
[INFO] [stderr]    |
[INFO] [stderr] 97 |                         .map(|pat| Pattern::Glob(pat))
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Pattern::Glob`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] error: for loop over `HOOK_RE.captures(&contents)`, which is an `Option`. This is more readably written as an `if let` statement.
[INFO] [stderr]   --> src/utils/hooks.rs:42:22
[INFO] [stderr]    |
[INFO] [stderr] 42 |             for m in HOOK_RE.captures(&contents) {
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::for_loop_over_option)] on by default
[INFO] [stderr]    = help: consider replacing `for m in HOOK_RE.captures(&contents)` with `if let Some(m) = HOOK_RE.captures(&contents)`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `calm`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "5fbb3c36d94a8f2b7138b6eaf17c092a022bf99d48864febb67e707cfee0e21e"`
[INFO] running `"docker" "rm" "-f" "5fbb3c36d94a8f2b7138b6eaf17c092a022bf99d48864febb67e707cfee0e21e"`
[INFO] [stdout] 5fbb3c36d94a8f2b7138b6eaf17c092a022bf99d48864febb67e707cfee0e21e