[INFO] crate calendar_queue 0.0.1 is already in cache [INFO] extracting crate calendar_queue 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/calendar_queue/0.0.1 [INFO] extracting crate calendar_queue 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/calendar_queue/0.0.1 [INFO] validating manifest of calendar_queue-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of calendar_queue-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing calendar_queue-0.0.1 [INFO] finished frobbing calendar_queue-0.0.1 [INFO] frobbed toml for calendar_queue-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/calendar_queue/0.0.1/Cargo.toml [INFO] started frobbing calendar_queue-0.0.1 [INFO] finished frobbing calendar_queue-0.0.1 [INFO] frobbed toml for calendar_queue-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/calendar_queue/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting calendar_queue-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/calendar_queue/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bbb594fe0d70b48380ddb505879b2b7ca3b3580dd28e71ae098a274988ee138c [INFO] running `"docker" "start" "-a" "bbb594fe0d70b48380ddb505879b2b7ca3b3580dd28e71ae098a274988ee138c"` [INFO] [stderr] Checking calendar_queue v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `calendar_queue::CalendarQueue` [INFO] [stderr] --> src/calendar_queue.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn new() -> Self { [INFO] [stderr] 23 | | CalendarQueue { [INFO] [stderr] 24 | | sorter: VecDeque::new(), [INFO] [stderr] 25 | | flows: HashMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/calendar_queue.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / if self.flows.contains_key(&id) { [INFO] [stderr] 52 | | Err(Error::DuplicateFlowId) [INFO] [stderr] 53 | | } else { [INFO] [stderr] 54 | | let (sender, receiver) = channel(); [INFO] [stderr] ... | [INFO] [stderr] 59 | | Ok(sender) [INFO] [stderr] 60 | | } [INFO] [stderr] | |_________^ help: consider using: `self.flows.entry(id)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/calendar_queue.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / if self.flows.contains_key(&id) { [INFO] [stderr] 52 | | Err(Error::DuplicateFlowId) [INFO] [stderr] 53 | | } else { [INFO] [stderr] 54 | | let (sender, receiver) = channel(); [INFO] [stderr] ... | [INFO] [stderr] 59 | | Ok(sender) [INFO] [stderr] 60 | | } [INFO] [stderr] | |_________^ help: consider using: `self.flows.entry(id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/calendar_queue.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | / if self.flows.contains_key(&id) { [INFO] [stderr] 84 | | Err(Error::DuplicateFlowId) [INFO] [stderr] 85 | | } else { [INFO] [stderr] 86 | | self.flows.insert(id, channel); [INFO] [stderr] ... | [INFO] [stderr] 90 | | Ok(()) [INFO] [stderr] 91 | | } [INFO] [stderr] | |_________^ help: consider using: `self.flows.entry(id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a VecDeque. Using `[]` is more clear and more concise [INFO] [stderr] --> src/calendar_queue.rs:124:17 [INFO] [stderr] | [INFO] [stderr] 124 | self.sorter.get_mut(index).unwrap().1.push_back(id); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.sorter[index]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/calendar_queue.rs:168:24 [INFO] [stderr] | [INFO] [stderr] 168 | if slots.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!slots.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/calendar_queue.rs:174:37 [INFO] [stderr] | [INFO] [stderr] 174 | let next_time = self.conformance_times.get(&id).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.conformance_times.get(&id).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/calendar_queue.rs:174:37 [INFO] [stderr] | [INFO] [stderr] 174 | let next_time = self.conformance_times.get(&id).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.conformance_times[&id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `calendar_queue::CalendarQueue` [INFO] [stderr] --> src/calendar_queue.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn new() -> Self { [INFO] [stderr] 23 | | CalendarQueue { [INFO] [stderr] 24 | | sorter: VecDeque::new(), [INFO] [stderr] 25 | | flows: HashMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/calendar_queue.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / if self.flows.contains_key(&id) { [INFO] [stderr] 52 | | Err(Error::DuplicateFlowId) [INFO] [stderr] 53 | | } else { [INFO] [stderr] 54 | | let (sender, receiver) = channel(); [INFO] [stderr] ... | [INFO] [stderr] 59 | | Ok(sender) [INFO] [stderr] 60 | | } [INFO] [stderr] | |_________^ help: consider using: `self.flows.entry(id)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/calendar_queue.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / if self.flows.contains_key(&id) { [INFO] [stderr] 52 | | Err(Error::DuplicateFlowId) [INFO] [stderr] 53 | | } else { [INFO] [stderr] 54 | | let (sender, receiver) = channel(); [INFO] [stderr] ... | [INFO] [stderr] 59 | | Ok(sender) [INFO] [stderr] 60 | | } [INFO] [stderr] | |_________^ help: consider using: `self.flows.entry(id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/calendar_queue.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | / if self.flows.contains_key(&id) { [INFO] [stderr] 84 | | Err(Error::DuplicateFlowId) [INFO] [stderr] 85 | | } else { [INFO] [stderr] 86 | | self.flows.insert(id, channel); [INFO] [stderr] ... | [INFO] [stderr] 90 | | Ok(()) [INFO] [stderr] 91 | | } [INFO] [stderr] | |_________^ help: consider using: `self.flows.entry(id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a VecDeque. Using `[]` is more clear and more concise [INFO] [stderr] --> src/calendar_queue.rs:124:17 [INFO] [stderr] | [INFO] [stderr] 124 | self.sorter.get_mut(index).unwrap().1.push_back(id); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.sorter[index]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/calendar_queue.rs:168:24 [INFO] [stderr] | [INFO] [stderr] 168 | if slots.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!slots.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/calendar_queue.rs:174:37 [INFO] [stderr] | [INFO] [stderr] 174 | let next_time = self.conformance_times.get(&id).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.conformance_times.get(&id).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/calendar_queue.rs:174:37 [INFO] [stderr] | [INFO] [stderr] 174 | let next_time = self.conformance_times.get(&id).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.conformance_times[&id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/lib.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `calendar_queue`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "bbb594fe0d70b48380ddb505879b2b7ca3b3580dd28e71ae098a274988ee138c"` [INFO] running `"docker" "rm" "-f" "bbb594fe0d70b48380ddb505879b2b7ca3b3580dd28e71ae098a274988ee138c"` [INFO] [stdout] bbb594fe0d70b48380ddb505879b2b7ca3b3580dd28e71ae098a274988ee138c