[INFO] crate calcver 0.3.1 is already in cache [INFO] extracting crate calcver 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/calcver/0.3.1 [INFO] extracting crate calcver 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/calcver/0.3.1 [INFO] validating manifest of calcver-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of calcver-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing calcver-0.3.1 [INFO] finished frobbing calcver-0.3.1 [INFO] frobbed toml for calcver-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/calcver/0.3.1/Cargo.toml [INFO] started frobbing calcver-0.3.1 [INFO] finished frobbing calcver-0.3.1 [INFO] frobbed toml for calcver-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/calcver/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting calcver-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/calcver/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 73e3ab34b59b42608a29278596c1eb2630c2916a5f2fd3048f792176d7d526e3 [INFO] running `"docker" "start" "-a" "73e3ab34b59b42608a29278596c1eb2630c2916a5f2fd3048f792176d7d526e3"` [INFO] [stderr] Checking calcver v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config_file.rs:73:31 [INFO] [stderr] | [INFO] [stderr] 73 | const NO_ACTIONS_CONFIG: &'static str = "repository_type: git"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config_file.rs:74:24 [INFO] [stderr] | [INFO] [stderr] 74 | const MIN_CONFIG: &'static str = "cargo: .\\cargo.toml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config_file.rs:75:28 [INFO] [stderr] | [INFO] [stderr] 75 | const SCRIPTS_CONFIG: &'static str = r###" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config_file.rs:80:29 [INFO] [stderr] | [INFO] [stderr] 80 | const OVERRIDE_CONFIG: &'static str = r###"cargo: .\\cargo.toml [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/release.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / match self { [INFO] [stderr] 17 | | &ReleaseConfig::CargoToml(ref cargo_path) => { [INFO] [stderr] 18 | | // -- get path [INFO] [stderr] 19 | | let full_path = Path::new(path).join(cargo_path); [INFO] [stderr] ... | [INFO] [stderr] 43 | | } [INFO] [stderr] 44 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 16 | match *self { [INFO] [stderr] 17 | ReleaseConfig::CargoToml(ref cargo_path) => { [INFO] [stderr] 18 | // -- get path [INFO] [stderr] 19 | let full_path = Path::new(path).join(cargo_path); [INFO] [stderr] 20 | [INFO] [stderr] 21 | let mut buffer = String::new(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/release.rs:36:20 [INFO] [stderr] | [INFO] [stderr] 36 | if output.stderr.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!output.stderr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/release.rs:39:20 [INFO] [stderr] | [INFO] [stderr] 39 | if output.stdout.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!output.stdout.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/release.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / match self { [INFO] [stderr] 17 | | &ReleaseConfig::CargoToml(ref cargo_path) => { [INFO] [stderr] 18 | | // -- get path [INFO] [stderr] 19 | | let full_path = Path::new(path).join(cargo_path); [INFO] [stderr] ... | [INFO] [stderr] 43 | | } [INFO] [stderr] 44 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 16 | match *self { [INFO] [stderr] 17 | ReleaseConfig::CargoToml(ref cargo_path) => { [INFO] [stderr] 18 | // -- get path [INFO] [stderr] 19 | let full_path = Path::new(path).join(cargo_path); [INFO] [stderr] 20 | [INFO] [stderr] 21 | let mut buffer = String::new(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/release.rs:36:20 [INFO] [stderr] | [INFO] [stderr] 36 | if output.stderr.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!output.stderr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/release.rs:39:20 [INFO] [stderr] | [INFO] [stderr] 39 | if output.stdout.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!output.stdout.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config_file.rs:45:48 [INFO] [stderr] | [INFO] [stderr] 45 | scm_type: self.repository_type.unwrap_or("git".to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "git".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config_file.rs:46:33 [INFO] [stderr] | [INFO] [stderr] 46 | path: self.root.unwrap_or(".".to_owned()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| ".".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/config_file.rs:106:57 [INFO] [stderr] | [INFO] [stderr] 106 | let cargo = parsed.release.into_iter().find(|i| match i { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 107 | | &release::ReleaseConfig::CargoToml(ref t) => { [INFO] [stderr] 108 | | assert_eq!(t,".\\cargo.toml"); [INFO] [stderr] 109 | | true [INFO] [stderr] 110 | | }, [INFO] [stderr] 111 | | _=> false [INFO] [stderr] 112 | | }); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 106 | let cargo = parsed.release.into_iter().find(|i| match *i { [INFO] [stderr] 107 | release::ReleaseConfig::CargoToml(ref t) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config_file.rs:131:17 [INFO] [stderr] | [INFO] [stderr] 131 | assert!(parsed.release.len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `parsed.release.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/repogit.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / match &self.last_tag { [INFO] [stderr] 14 | | &Some(ref tag) => Some(tag), [INFO] [stderr] 15 | | &None=>None [INFO] [stderr] 16 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 13 | match self.last_tag { [INFO] [stderr] 14 | Some(ref tag) => Some(tag), [INFO] [stderr] 15 | None=>None [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/version.rs:51:102 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn get_next_version(config: &config::VersionConfig, bump_behavior: VersionBumpBehavior, commits: &Vec, last_tag: Option<&str>, release: bool) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config_file.rs:45:48 [INFO] [stderr] | [INFO] [stderr] 45 | scm_type: self.repository_type.unwrap_or("git".to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "git".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config_file.rs:46:33 [INFO] [stderr] | [INFO] [stderr] 46 | path: self.root.unwrap_or(".".to_owned()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| ".".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/version.rs:52:8 [INFO] [stderr] | [INFO] [stderr] 52 | if commits.len() == 0 && release { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `commits.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/repogit.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / match &self.last_tag { [INFO] [stderr] 14 | | &Some(ref tag) => Some(tag), [INFO] [stderr] 15 | | &None=>None [INFO] [stderr] 16 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 13 | match self.last_tag { [INFO] [stderr] 14 | Some(ref tag) => Some(tag), [INFO] [stderr] 15 | None=>None [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/version.rs:92:71 [INFO] [stderr] | [INFO] [stderr] 92 | fn get_bump_behavior(config: &config::VersionConfig, commit_messages: &Vec ) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/version.rs:51:102 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn get_next_version(config: &config::VersionConfig, bump_behavior: VersionBumpBehavior, commits: &Vec, last_tag: Option<&str>, release: bool) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/version.rs:52:8 [INFO] [stderr] | [INFO] [stderr] 52 | if commits.len() == 0 && release { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `commits.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/version.rs:92:71 [INFO] [stderr] | [INFO] [stderr] 92 | fn get_bump_behavior(config: &config::VersionConfig, commit_messages: &Vec ) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use as_ref() instead [INFO] [stderr] --> src/lib.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | / match self.last_tag { [INFO] [stderr] 32 | | Some(ref tag) => Some(tag), [INFO] [stderr] 33 | | None=> None [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____________^ help: try this: `self.last_tag.as_ref()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_as_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_as_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/repogit.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / match &self.last_tag { [INFO] [stderr] 14 | | &Some(ref tag) => Some(tag), [INFO] [stderr] 15 | | &None=>None [INFO] [stderr] 16 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 13 | match self.last_tag { [INFO] [stderr] 14 | Some(ref tag) => Some(tag), [INFO] [stderr] 15 | None=>None [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config_file.rs:45:48 [INFO] [stderr] | [INFO] [stderr] 45 | scm_type: self.repository_type.unwrap_or("git".to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "git".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config_file.rs:46:33 [INFO] [stderr] | [INFO] [stderr] 46 | path: self.root.unwrap_or(".".to_owned()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| ".".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/release.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / match self { [INFO] [stderr] 17 | | &ReleaseConfig::CargoToml(ref cargo_path) => { [INFO] [stderr] 18 | | // -- get path [INFO] [stderr] 19 | | let full_path = Path::new(path).join(cargo_path); [INFO] [stderr] ... | [INFO] [stderr] 43 | | } [INFO] [stderr] 44 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 16 | match *self { [INFO] [stderr] 17 | ReleaseConfig::CargoToml(ref cargo_path) => { [INFO] [stderr] 18 | // -- get path [INFO] [stderr] 19 | let full_path = Path::new(path).join(cargo_path); [INFO] [stderr] 20 | [INFO] [stderr] 21 | let mut buffer = String::new(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/release.rs:36:20 [INFO] [stderr] | [INFO] [stderr] 36 | if output.stderr.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!output.stderr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/release.rs:39:20 [INFO] [stderr] | [INFO] [stderr] 39 | if output.stdout.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!output.stdout.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/version.rs:51:102 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn get_next_version(config: &config::VersionConfig, bump_behavior: VersionBumpBehavior, commits: &Vec, last_tag: Option<&str>, release: bool) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/version.rs:52:8 [INFO] [stderr] | [INFO] [stderr] 52 | if commits.len() == 0 && release { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `commits.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/version.rs:92:71 [INFO] [stderr] | [INFO] [stderr] 92 | fn get_bump_behavior(config: &config::VersionConfig, commit_messages: &Vec ) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config_file.rs:73:31 [INFO] [stderr] | [INFO] [stderr] 73 | const NO_ACTIONS_CONFIG: &'static str = "repository_type: git"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config_file.rs:74:24 [INFO] [stderr] | [INFO] [stderr] 74 | const MIN_CONFIG: &'static str = "cargo: .\\cargo.toml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config_file.rs:75:28 [INFO] [stderr] | [INFO] [stderr] 75 | const SCRIPTS_CONFIG: &'static str = r###" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config_file.rs:80:29 [INFO] [stderr] | [INFO] [stderr] 80 | const OVERRIDE_CONFIG: &'static str = r###"cargo: .\\cargo.toml [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/repogit.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / match &self.last_tag { [INFO] [stderr] 14 | | &Some(ref tag) => Some(tag), [INFO] [stderr] 15 | | &None=>None [INFO] [stderr] 16 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 13 | match self.last_tag { [INFO] [stderr] 14 | Some(ref tag) => Some(tag), [INFO] [stderr] 15 | None=>None [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config_file.rs:45:48 [INFO] [stderr] | [INFO] [stderr] 45 | scm_type: self.repository_type.unwrap_or("git".to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "git".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config_file.rs:46:33 [INFO] [stderr] | [INFO] [stderr] 46 | path: self.root.unwrap_or(".".to_owned()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| ".".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/config_file.rs:106:57 [INFO] [stderr] | [INFO] [stderr] 106 | let cargo = parsed.release.into_iter().find(|i| match i { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 107 | | &release::ReleaseConfig::CargoToml(ref t) => { [INFO] [stderr] 108 | | assert_eq!(t,".\\cargo.toml"); [INFO] [stderr] 109 | | true [INFO] [stderr] 110 | | }, [INFO] [stderr] 111 | | _=> false [INFO] [stderr] 112 | | }); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 106 | let cargo = parsed.release.into_iter().find(|i| match *i { [INFO] [stderr] 107 | release::ReleaseConfig::CargoToml(ref t) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config_file.rs:131:17 [INFO] [stderr] | [INFO] [stderr] 131 | assert!(parsed.release.len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `parsed.release.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/release.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / match self { [INFO] [stderr] 17 | | &ReleaseConfig::CargoToml(ref cargo_path) => { [INFO] [stderr] 18 | | // -- get path [INFO] [stderr] 19 | | let full_path = Path::new(path).join(cargo_path); [INFO] [stderr] ... | [INFO] [stderr] 43 | | } [INFO] [stderr] 44 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 16 | match *self { [INFO] [stderr] 17 | ReleaseConfig::CargoToml(ref cargo_path) => { [INFO] [stderr] 18 | // -- get path [INFO] [stderr] 19 | let full_path = Path::new(path).join(cargo_path); [INFO] [stderr] 20 | [INFO] [stderr] 21 | let mut buffer = String::new(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/release.rs:36:20 [INFO] [stderr] | [INFO] [stderr] 36 | if output.stderr.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!output.stderr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/release.rs:39:20 [INFO] [stderr] | [INFO] [stderr] 39 | if output.stdout.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!output.stdout.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/version.rs:51:102 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn get_next_version(config: &config::VersionConfig, bump_behavior: VersionBumpBehavior, commits: &Vec, last_tag: Option<&str>, release: bool) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/version.rs:52:8 [INFO] [stderr] | [INFO] [stderr] 52 | if commits.len() == 0 && release { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `commits.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/version.rs:92:71 [INFO] [stderr] | [INFO] [stderr] 92 | fn get_bump_behavior(config: &config::VersionConfig, commit_messages: &Vec ) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.17s [INFO] running `"docker" "inspect" "73e3ab34b59b42608a29278596c1eb2630c2916a5f2fd3048f792176d7d526e3"` [INFO] running `"docker" "rm" "-f" "73e3ab34b59b42608a29278596c1eb2630c2916a5f2fd3048f792176d7d526e3"` [INFO] [stdout] 73e3ab34b59b42608a29278596c1eb2630c2916a5f2fd3048f792176d7d526e3