[INFO] crate calamine 0.14.10 is already in cache [INFO] extracting crate calamine 0.14.10 into work/ex/clippy-test-run/sources/stable/reg/calamine/0.14.10 [INFO] extracting crate calamine 0.14.10 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/calamine/0.14.10 [INFO] validating manifest of calamine-0.14.10 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of calamine-0.14.10 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing calamine-0.14.10 [INFO] finished frobbing calamine-0.14.10 [INFO] frobbed toml for calamine-0.14.10 written to work/ex/clippy-test-run/sources/stable/reg/calamine/0.14.10/Cargo.toml [INFO] started frobbing calamine-0.14.10 [INFO] finished frobbing calamine-0.14.10 [INFO] frobbed toml for calamine-0.14.10 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/calamine/0.14.10/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting calamine-0.14.10 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/calamine/0.14.10:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d0ed91f6c0b34d06e5f55eb590f93c2c8091e50844492e23b97e497876512317 [INFO] running `"docker" "start" "-a" "d0ed91f6c0b34d06e5f55eb590f93c2c8091e50844492e23b97e497876512317"` [INFO] [stderr] Checking zip v0.5.0 [INFO] [stderr] Checking quick-xml v0.13.2 [INFO] [stderr] Checking calamine v0.14.10 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | sectors: sectors, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `sectors` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | fats: fats, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `fats` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:194:17 [INFO] [stderr] | [INFO] [stderr] 194 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:195:17 [INFO] [stderr] | [INFO] [stderr] 195 | sector_size: sector_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sector_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:196:17 [INFO] [stderr] | [INFO] [stderr] 196 | dir_len: dir_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `dir_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:197:17 [INFO] [stderr] | [INFO] [stderr] 197 | fat_len: fat_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `fat_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:198:17 [INFO] [stderr] | [INFO] [stderr] 198 | dir_start: dir_start, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dir_start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:199:17 [INFO] [stderr] | [INFO] [stderr] 199 | mini_fat_len: mini_fat_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mini_fat_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:200:17 [INFO] [stderr] | [INFO] [stderr] 200 | mini_fat_start: mini_fat_start, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mini_fat_start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:201:17 [INFO] [stderr] | [INFO] [stderr] 201 | difat_start: difat_start, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `difat_start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:220:13 [INFO] [stderr] | [INFO] [stderr] 220 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:221:13 [INFO] [stderr] | [INFO] [stderr] 221 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:284:13 [INFO] [stderr] | [INFO] [stderr] 284 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:285:13 [INFO] [stderr] | [INFO] [stderr] 285 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:286:13 [INFO] [stderr] | [INFO] [stderr] 286 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:418:13 [INFO] [stderr] | [INFO] [stderr] 418 | high_byte: high_byte, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `high_byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ods.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | sheets: sheets, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sheets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ods.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | metadata: metadata, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xls.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | vba: vba, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vba` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xls.rs:621:13 [INFO] [stderr] | [INFO] [stderr] 621 | cont: cont, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cont` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:384:13 [INFO] [stderr] | [INFO] [stderr] 384 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:524:13 [INFO] [stderr] | [INFO] [stderr] 524 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vba.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | modules: modules, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `modules` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vba.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | encoding: encoding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `encoding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vba.rs:385:13 [INFO] [stderr] | [INFO] [stderr] 385 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vba.rs:386:13 [INFO] [stderr] | [INFO] [stderr] 386 | stream_name: stream_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:258:13 [INFO] [stderr] | [INFO] [stderr] 258 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:259:13 [INFO] [stderr] | [INFO] [stderr] 259 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | sectors: sectors, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `sectors` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | fats: fats, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `fats` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:194:17 [INFO] [stderr] | [INFO] [stderr] 194 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:195:17 [INFO] [stderr] | [INFO] [stderr] 195 | sector_size: sector_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sector_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:196:17 [INFO] [stderr] | [INFO] [stderr] 196 | dir_len: dir_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `dir_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:197:17 [INFO] [stderr] | [INFO] [stderr] 197 | fat_len: fat_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `fat_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:198:17 [INFO] [stderr] | [INFO] [stderr] 198 | dir_start: dir_start, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dir_start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:199:17 [INFO] [stderr] | [INFO] [stderr] 199 | mini_fat_len: mini_fat_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mini_fat_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:200:17 [INFO] [stderr] | [INFO] [stderr] 200 | mini_fat_start: mini_fat_start, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mini_fat_start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:201:17 [INFO] [stderr] | [INFO] [stderr] 201 | difat_start: difat_start, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `difat_start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:220:13 [INFO] [stderr] | [INFO] [stderr] 220 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:221:13 [INFO] [stderr] | [INFO] [stderr] 221 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:284:13 [INFO] [stderr] | [INFO] [stderr] 284 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:285:13 [INFO] [stderr] | [INFO] [stderr] 285 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:286:13 [INFO] [stderr] | [INFO] [stderr] 286 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfb.rs:418:13 [INFO] [stderr] | [INFO] [stderr] 418 | high_byte: high_byte, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `high_byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ods.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | sheets: sheets, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sheets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ods.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | metadata: metadata, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xls.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | vba: vba, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vba` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xls.rs:621:13 [INFO] [stderr] | [INFO] [stderr] 621 | cont: cont, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cont` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:384:13 [INFO] [stderr] | [INFO] [stderr] 384 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:524:13 [INFO] [stderr] | [INFO] [stderr] 524 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vba.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | modules: modules, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `modules` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vba.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | encoding: encoding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `encoding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vba.rs:385:13 [INFO] [stderr] | [INFO] [stderr] 385 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vba.rs:386:13 [INFO] [stderr] | [INFO] [stderr] 386 | stream_name: stream_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:258:13 [INFO] [stderr] | [INFO] [stderr] 258 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:259:13 [INFO] [stderr] | [INFO] [stderr] 259 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/utils.rs:107:19 [INFO] [stderr] | [INFO] [stderr] 107 | pub const FTAB: [&'static str; FTAB_LEN] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cfb.rs:11:25 [INFO] [stderr] | [INFO] [stderr] 11 | const ENDOFCHAIN: u32 = 0xFFFFFFFE; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFE` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cfb.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | const FREESECT: u32 = 0xFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cfb.rs:13:31 [INFO] [stderr] | [INFO] [stderr] 13 | const RESERVED_SECTORS: u32 = 0xFFFFFFFA; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFA` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cfb.rs:149:47 [INFO] [stderr] | [INFO] [stderr] 149 | if read_slice::(buf.as_ref()) != 0xE11AB1A1E011CFD0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xE11A_B1A1_E011_CFD0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/ods.rs:21:18 [INFO] [stderr] | [INFO] [stderr] 21 | const MIMETYPE: &'static [u8] = b"application/vnd.oasis.opendocument.spreadsheet"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/xlsb.rs:199:35 [INFO] [stderr] | [INFO] [stderr] 199 | if rel_len != 0xFFFFFFFF { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/xlsb.rs:349:30 [INFO] [stderr] | [INFO] [stderr] 349 | if row > 0x00100000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/xlsb.rs:432:30 [INFO] [stderr] | [INFO] [stderr] 432 | if row > 0x00100000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/xlsx.rs:97:18 [INFO] [stderr] | [INFO] [stderr] 97 | _ => return Err(XlsxError::CellError(s.into())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(XlsxError::CellError(s.into()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/xlsx.rs:511:17 [INFO] [stderr] | [INFO] [stderr] 511 | / return Err(XlsxError::Unexpected( [INFO] [stderr] 512 | | "called read_value on a cell of type inlineStr", [INFO] [stderr] 513 | | )); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 511 | Err(XlsxError::Unexpected( [INFO] [stderr] 512 | "called read_value on a cell of type inlineStr", [INFO] [stderr] 513 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/xlsx.rs:519:17 [INFO] [stderr] | [INFO] [stderr] 519 | return Err(XlsxError::CellTAttribute(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(XlsxError::CellTAttribute(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:558:17 [INFO] [stderr] | [INFO] [stderr] 558 | / return Err(DeError::CellError { [INFO] [stderr] 559 | | err: err.clone(), [INFO] [stderr] 560 | | pos: self.pos, [INFO] [stderr] 561 | | }) [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 558 | Err(DeError::CellError { [INFO] [stderr] 559 | err: err.clone(), [INFO] [stderr] 560 | pos: self.pos, [INFO] [stderr] 561 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vba.rs:150:21 [INFO] [stderr] | [INFO] [stderr] 150 | None => return Err(VbaError::ModuleNotFound(name.into())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(VbaError::ModuleNotFound(name.into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vba.rs:286:18 [INFO] [stderr] | [INFO] [stderr] 286 | _ => return Err(VbaError::LibId), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(VbaError::LibId)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/utils.rs:107:19 [INFO] [stderr] | [INFO] [stderr] 107 | pub const FTAB: [&'static str; FTAB_LEN] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cfb.rs:11:25 [INFO] [stderr] | [INFO] [stderr] 11 | const ENDOFCHAIN: u32 = 0xFFFFFFFE; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFE` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cfb.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | const FREESECT: u32 = 0xFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cfb.rs:13:31 [INFO] [stderr] | [INFO] [stderr] 13 | const RESERVED_SECTORS: u32 = 0xFFFFFFFA; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFA` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cfb.rs:149:47 [INFO] [stderr] | [INFO] [stderr] 149 | if read_slice::(buf.as_ref()) != 0xE11AB1A1E011CFD0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xE11A_B1A1_E011_CFD0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/ods.rs:21:18 [INFO] [stderr] | [INFO] [stderr] 21 | const MIMETYPE: &'static [u8] = b"application/vnd.oasis.opendocument.spreadsheet"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/xlsb.rs:199:35 [INFO] [stderr] | [INFO] [stderr] 199 | if rel_len != 0xFFFFFFFF { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/xlsb.rs:349:30 [INFO] [stderr] | [INFO] [stderr] 349 | if row > 0x00100000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/xlsb.rs:432:30 [INFO] [stderr] | [INFO] [stderr] 432 | if row > 0x00100000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/xlsx.rs:97:18 [INFO] [stderr] | [INFO] [stderr] 97 | _ => return Err(XlsxError::CellError(s.into())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(XlsxError::CellError(s.into()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/xlsx.rs:511:17 [INFO] [stderr] | [INFO] [stderr] 511 | / return Err(XlsxError::Unexpected( [INFO] [stderr] 512 | | "called read_value on a cell of type inlineStr", [INFO] [stderr] 513 | | )); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 511 | Err(XlsxError::Unexpected( [INFO] [stderr] 512 | "called read_value on a cell of type inlineStr", [INFO] [stderr] 513 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/xlsx.rs:519:17 [INFO] [stderr] | [INFO] [stderr] 519 | return Err(XlsxError::CellTAttribute(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(XlsxError::CellTAttribute(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:558:17 [INFO] [stderr] | [INFO] [stderr] 558 | / return Err(DeError::CellError { [INFO] [stderr] 559 | | err: err.clone(), [INFO] [stderr] 560 | | pos: self.pos, [INFO] [stderr] 561 | | }) [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 558 | Err(DeError::CellError { [INFO] [stderr] 559 | err: err.clone(), [INFO] [stderr] 560 | pos: self.pos, [INFO] [stderr] 561 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vba.rs:150:21 [INFO] [stderr] | [INFO] [stderr] 150 | None => return Err(VbaError::ModuleNotFound(name.into())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(VbaError::ModuleNotFound(name.into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vba.rs:286:18 [INFO] [stderr] | [INFO] [stderr] 286 | _ => return Err(VbaError::LibId), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(VbaError::LibId)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: casting from `*const [u8]` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/utils.rs:18:43 [INFO] [stderr] | [INFO] [stderr] 18 | unsafe { ::std::slice::from_raw_parts(s as *const [u8] as *const u32, s.len() / 4) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const [u8]` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/utils.rs:18:43 [INFO] [stderr] | [INFO] [stderr] 18 | unsafe { ::std::slice::from_raw_parts(s as *const [u8] as *const u32, s.len() / 4) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cfb.rs:319:20 [INFO] [stderr] | [INFO] [stderr] 319 | found: s[0] as u16, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(s[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/ods.rs:146:6 [INFO] [stderr] | [INFO] [stderr] 146 | ) -> Result< [INFO] [stderr] | ______^ [INFO] [stderr] 147 | | ( [INFO] [stderr] 148 | | HashMap, Range)>, [INFO] [stderr] 149 | | Vec, [INFO] [stderr] ... | [INFO] [stderr] 152 | | OdsError, [INFO] [stderr] 153 | | > { [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ods.rs:268:50 [INFO] [stderr] | [INFO] [stderr] 268 | new_cells.extend_from_slice(&row[col_min..col_max + 1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `col_min..=col_max` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cfb.rs:319:20 [INFO] [stderr] | [INFO] [stderr] 319 | found: s[0] as u16, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(s[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/ods.rs:146:6 [INFO] [stderr] | [INFO] [stderr] 146 | ) -> Result< [INFO] [stderr] | ______^ [INFO] [stderr] 147 | | ( [INFO] [stderr] 148 | | HashMap, Range)>, [INFO] [stderr] 149 | | Vec, [INFO] [stderr] ... | [INFO] [stderr] 152 | | OdsError, [INFO] [stderr] 153 | | > { [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:251:50 [INFO] [stderr] | [INFO] [stderr] 251 | formulas.push(Cell::new((row as u32, col as u32), fmla)); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:251:62 [INFO] [stderr] | [INFO] [stderr] 251 | formulas.push(Cell::new((row as u32, col as u32), fmla)); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(col)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:287:15 [INFO] [stderr] | [INFO] [stderr] 287 | let row = read_u16(r) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(r))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:288:15 [INFO] [stderr] | [INFO] [stderr] 288 | let col = read_u16(&r[2..]) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&r[2..]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:328:19 [INFO] [stderr] | [INFO] [stderr] 328 | Ok(Cell::new((row as u32, col as u32), v)) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:328:31 [INFO] [stderr] | [INFO] [stderr] 328 | Ok(Cell::new((row as u32, col as u32), v)) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(col)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ods.rs:268:50 [INFO] [stderr] | [INFO] [stderr] 268 | new_cells.extend_from_slice(&row[col_min..col_max + 1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `col_min..=col_max` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:341:19 [INFO] [stderr] | [INFO] [stderr] 341 | Ok(Cell::new((row as u32, col as u32), rk_num(&r[6..10]))) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:341:31 [INFO] [stderr] | [INFO] [stderr] 341 | Ok(Cell::new((row as u32, col as u32), rk_num(&r[6..10]))) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(col)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:365:19 [INFO] [stderr] | [INFO] [stderr] 365 | let mut col = col_first as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(col_first)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:369:31 [INFO] [stderr] | [INFO] [stderr] 369 | cells.push(Cell::new((row as u32, col), rk_num(&rk[2..]))); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:383:17 [INFO] [stderr] | [INFO] [stderr] 383 | let v = (read_slice::(&v[4..]) >> 2) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(read_slice::(&v[4..]) >> 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:422:10 [INFO] [stderr] | [INFO] [stderr] 422 | (row as u32, col as u32), [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:422:22 [INFO] [stderr] | [INFO] [stderr] 422 | (row as u32, col as u32), [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(col)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/xls.rs:427:34 [INFO] [stderr] | [INFO] [stderr] 427 | fn parse_dimensions(r: &[u8]) -> Result<((u32, u32), (u32, u32)), XlsError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:430:13 [INFO] [stderr] | [INFO] [stderr] 430 | read_u16(&r[0..2]) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&r[0..2]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:431:13 [INFO] [stderr] | [INFO] [stderr] 431 | read_u16(&r[2..4]) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&r[2..4]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:432:13 [INFO] [stderr] | [INFO] [stderr] 432 | read_u16(&r[4..6]) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&r[4..6]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:433:13 [INFO] [stderr] | [INFO] [stderr] 433 | read_u16(&r[6..8]) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&r[6..8]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:438:13 [INFO] [stderr] | [INFO] [stderr] 438 | read_u16(&r[8..10]) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&r[8..10]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:439:13 [INFO] [stderr] | [INFO] [stderr] 439 | read_u16(&r[10..12]) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&r[10..12]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/xls.rs:554:37 [INFO] [stderr] | [INFO] [stderr] 554 | let _ = encoding.decode_to(&buf[1..*len + 1], *len, &mut s); [INFO] [stderr] | ^^^^^^^^^^^ help: use: `1..=*len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:642:25 [INFO] [stderr] | [INFO] [stderr] 642 | push_column(read_u16(&rgce[5..7]) as u32, &mut f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[5..7]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:644:39 [INFO] [stderr] | [INFO] [stderr] 644 | f.push_str(&format!("{}", read_u16(&rgce[3..5]) as u32 + 1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[3..5]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:653:25 [INFO] [stderr] | [INFO] [stderr] 653 | push_column(read_u16(&rgce[7..9]) as u32, &mut f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[7..9]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:655:39 [INFO] [stderr] | [INFO] [stderr] 655 | f.push_str(&format!("{}", read_u16(&rgce[3..5]) as u32 + 1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[3..5]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:658:25 [INFO] [stderr] | [INFO] [stderr] 658 | push_column(read_u16(&rgce[9..11]) as u32, &mut f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[9..11]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:660:39 [INFO] [stderr] | [INFO] [stderr] 660 | f.push_str(&format!("{}", read_u16(&rgce[5..7]) as u32 + 1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[5..7]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:698:29 [INFO] [stderr] | [INFO] [stderr] 698 | push_column(read_u16(&rgce[4..6]) as u32, &mut formula); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[4..6]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:700:49 [INFO] [stderr] | [INFO] [stderr] 700 | formula.push_str(&format!("{}", read_u16(&rgce[2..4]) as u32 + 1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[2..4]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:711:29 [INFO] [stderr] | [INFO] [stderr] 711 | push_column(read_u16(&rgce[6..8]) as u32, &mut formula); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[6..8]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:713:49 [INFO] [stderr] | [INFO] [stderr] 713 | formula.push_str(&format!("{}", read_u16(&rgce[2..4]) as u32 + 1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[2..4]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:716:29 [INFO] [stderr] | [INFO] [stderr] 716 | push_column(read_u16(&rgce[8..10]) as u32, &mut formula); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[8..10]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:718:49 [INFO] [stderr] | [INFO] [stderr] 718 | formula.push_str(&format!("{}", read_u16(&rgce[4..6]) as u32 + 1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[4..6]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:918:29 [INFO] [stderr] | [INFO] [stderr] 918 | push_column(col as u32, &mut formula); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(col)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:928:29 [INFO] [stderr] | [INFO] [stderr] 928 | push_column(read_u16(&rgce[4..6]) as u32, &mut formula); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[4..6]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:930:49 [INFO] [stderr] | [INFO] [stderr] 930 | formula.push_str(&format!("{}", read_u16(&rgce[0..2]) as u32 + 1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[0..2]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:933:29 [INFO] [stderr] | [INFO] [stderr] 933 | push_column(read_u16(&rgce[6..8]) as u32, &mut formula); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[6..8]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:935:49 [INFO] [stderr] | [INFO] [stderr] 935 | formula.push_str(&format!("{}", read_u16(&rgce[2..4]) as u32 + 1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[2..4]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:251:50 [INFO] [stderr] | [INFO] [stderr] 251 | formulas.push(Cell::new((row as u32, col as u32), fmla)); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:251:62 [INFO] [stderr] | [INFO] [stderr] 251 | formulas.push(Cell::new((row as u32, col as u32), fmla)); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(col)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:287:15 [INFO] [stderr] | [INFO] [stderr] 287 | let row = read_u16(r) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(r))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:288:15 [INFO] [stderr] | [INFO] [stderr] 288 | let col = read_u16(&r[2..]) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&r[2..]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:328:19 [INFO] [stderr] | [INFO] [stderr] 328 | Ok(Cell::new((row as u32, col as u32), v)) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:328:31 [INFO] [stderr] | [INFO] [stderr] 328 | Ok(Cell::new((row as u32, col as u32), v)) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(col)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:341:19 [INFO] [stderr] | [INFO] [stderr] 341 | Ok(Cell::new((row as u32, col as u32), rk_num(&r[6..10]))) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:341:31 [INFO] [stderr] | [INFO] [stderr] 341 | Ok(Cell::new((row as u32, col as u32), rk_num(&r[6..10]))) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(col)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:365:19 [INFO] [stderr] | [INFO] [stderr] 365 | let mut col = col_first as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(col_first)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:369:31 [INFO] [stderr] | [INFO] [stderr] 369 | cells.push(Cell::new((row as u32, col), rk_num(&rk[2..]))); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:383:17 [INFO] [stderr] | [INFO] [stderr] 383 | let v = (read_slice::(&v[4..]) >> 2) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(read_slice::(&v[4..]) >> 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:422:10 [INFO] [stderr] | [INFO] [stderr] 422 | (row as u32, col as u32), [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:422:22 [INFO] [stderr] | [INFO] [stderr] 422 | (row as u32, col as u32), [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(col)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/xls.rs:427:34 [INFO] [stderr] | [INFO] [stderr] 427 | fn parse_dimensions(r: &[u8]) -> Result<((u32, u32), (u32, u32)), XlsError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:430:13 [INFO] [stderr] | [INFO] [stderr] 430 | read_u16(&r[0..2]) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&r[0..2]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:431:13 [INFO] [stderr] | [INFO] [stderr] 431 | read_u16(&r[2..4]) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&r[2..4]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:432:13 [INFO] [stderr] | [INFO] [stderr] 432 | read_u16(&r[4..6]) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&r[4..6]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:433:13 [INFO] [stderr] | [INFO] [stderr] 433 | read_u16(&r[6..8]) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&r[6..8]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:438:13 [INFO] [stderr] | [INFO] [stderr] 438 | read_u16(&r[8..10]) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&r[8..10]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:439:13 [INFO] [stderr] | [INFO] [stderr] 439 | read_u16(&r[10..12]) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&r[10..12]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/xlsb.rs:314:33 [INFO] [stderr] | [INFO] [stderr] 314 | let v = (read_slice::(&buf[8..12]) >> 2) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(read_slice::(&buf[8..12]) >> 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/xls.rs:554:37 [INFO] [stderr] | [INFO] [stderr] 554 | let _ = encoding.decode_to(&buf[1..*len + 1], *len, &mut s); [INFO] [stderr] | ^^^^^^^^^^^ help: use: `1..=*len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:642:25 [INFO] [stderr] | [INFO] [stderr] 642 | push_column(read_u16(&rgce[5..7]) as u32, &mut f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[5..7]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:644:39 [INFO] [stderr] | [INFO] [stderr] 644 | f.push_str(&format!("{}", read_u16(&rgce[3..5]) as u32 + 1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[3..5]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:653:25 [INFO] [stderr] | [INFO] [stderr] 653 | push_column(read_u16(&rgce[7..9]) as u32, &mut f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[7..9]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:655:39 [INFO] [stderr] | [INFO] [stderr] 655 | f.push_str(&format!("{}", read_u16(&rgce[3..5]) as u32 + 1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[3..5]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:658:25 [INFO] [stderr] | [INFO] [stderr] 658 | push_column(read_u16(&rgce[9..11]) as u32, &mut f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[9..11]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:660:39 [INFO] [stderr] | [INFO] [stderr] 660 | f.push_str(&format!("{}", read_u16(&rgce[5..7]) as u32 + 1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[5..7]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/xlsb.rs:531:13 [INFO] [stderr] | [INFO] [stderr] 531 | (b & 0x7F) as u16 + (((self.read_u8()? & 0x7F) as u16) << 7) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(b & 0x7F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/xlsb.rs:531:34 [INFO] [stderr] | [INFO] [stderr] 531 | (b & 0x7F) as u16 + (((self.read_u8()? & 0x7F) as u16) << 7) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_u8()? & 0x7F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/xlsb.rs:533:13 [INFO] [stderr] | [INFO] [stderr] 533 | b as u16 [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:698:29 [INFO] [stderr] | [INFO] [stderr] 698 | push_column(read_u16(&rgce[4..6]) as u32, &mut formula); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[4..6]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:700:49 [INFO] [stderr] | [INFO] [stderr] 700 | formula.push_str(&format!("{}", read_u16(&rgce[2..4]) as u32 + 1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[2..4]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:711:29 [INFO] [stderr] | [INFO] [stderr] 711 | push_column(read_u16(&rgce[6..8]) as u32, &mut formula); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[6..8]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:713:49 [INFO] [stderr] | [INFO] [stderr] 713 | formula.push_str(&format!("{}", read_u16(&rgce[2..4]) as u32 + 1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[2..4]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:716:29 [INFO] [stderr] | [INFO] [stderr] 716 | push_column(read_u16(&rgce[8..10]) as u32, &mut formula); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[8..10]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:718:49 [INFO] [stderr] | [INFO] [stderr] 718 | formula.push_str(&format!("{}", read_u16(&rgce[4..6]) as u32 + 1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[4..6]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:918:29 [INFO] [stderr] | [INFO] [stderr] 918 | push_column(col as u32, &mut formula); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(col)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:928:29 [INFO] [stderr] | [INFO] [stderr] 928 | push_column(read_u16(&rgce[4..6]) as u32, &mut formula); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[4..6]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:930:49 [INFO] [stderr] | [INFO] [stderr] 930 | formula.push_str(&format!("{}", read_u16(&rgce[0..2]) as u32 + 1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[0..2]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:933:29 [INFO] [stderr] | [INFO] [stderr] 933 | push_column(read_u16(&rgce[6..8]) as u32, &mut formula); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[6..8]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xls.rs:935:49 [INFO] [stderr] | [INFO] [stderr] 935 | formula.push_str(&format!("{}", read_u16(&rgce[2..4]) as u32 + 1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[2..4]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xlsb.rs:628:29 [INFO] [stderr] | [INFO] [stderr] 628 | push_column(read_u16(&rgce[6..8]) as u32, &mut formula); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[6..8]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xlsb.rs:641:29 [INFO] [stderr] | [INFO] [stderr] 641 | push_column(read_u16(&rgce[10..12]) as u32, &mut formula); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[10..12]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xlsb.rs:646:29 [INFO] [stderr] | [INFO] [stderr] 646 | push_column(read_u16(&rgce[12..14]) as u32, &mut formula); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[12..14]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xlsb.rs:850:29 [INFO] [stderr] | [INFO] [stderr] 850 | push_column(col as u32, &mut formula); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(col)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xlsb.rs:860:29 [INFO] [stderr] | [INFO] [stderr] 860 | push_column(read_u16(&rgce[8..10]) as u32, &mut formula); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[8..10]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xlsb.rs:865:29 [INFO] [stderr] | [INFO] [stderr] 865 | push_column(read_u16(&rgce[10..12]) as u32, &mut formula); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[10..12]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/xlsb.rs:314:33 [INFO] [stderr] | [INFO] [stderr] 314 | let v = (read_slice::(&buf[8..12]) >> 2) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(read_slice::(&buf[8..12]) >> 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/xlsb.rs:531:13 [INFO] [stderr] | [INFO] [stderr] 531 | (b & 0x7F) as u16 + (((self.read_u8()? & 0x7F) as u16) << 7) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(b & 0x7F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/xlsb.rs:531:34 [INFO] [stderr] | [INFO] [stderr] 531 | (b & 0x7F) as u16 + (((self.read_u8()? & 0x7F) as u16) << 7) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_u8()? & 0x7F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/xlsb.rs:533:13 [INFO] [stderr] | [INFO] [stderr] 533 | b as u16 [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/xlsx.rs:550:39 [INFO] [stderr] | [INFO] [stderr] 550 | fn get_dimension(dimension: &[u8]) -> Result<((u32, u32), (u32, u32)), XlsxError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xlsb.rs:628:29 [INFO] [stderr] | [INFO] [stderr] 628 | push_column(read_u16(&rgce[6..8]) as u32, &mut formula); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[6..8]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xlsb.rs:641:29 [INFO] [stderr] | [INFO] [stderr] 641 | push_column(read_u16(&rgce[10..12]) as u32, &mut formula); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[10..12]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xlsb.rs:646:29 [INFO] [stderr] | [INFO] [stderr] 646 | push_column(read_u16(&rgce[12..14]) as u32, &mut formula); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[12..14]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xlsx.rs:572:24 [INFO] [stderr] | [INFO] [stderr] 572 | row += ((c - b'0') as u32) * pow; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(c - b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xlsx.rs:582:25 [INFO] [stderr] | [INFO] [stderr] 582 | col += ((c - b'A') as u32 + 1) * pow; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(c - b'A')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xlsx.rs:590:25 [INFO] [stderr] | [INFO] [stderr] 590 | col += ((c - b'a') as u32 + 1) * pow; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(c - b'a')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xlsb.rs:850:29 [INFO] [stderr] | [INFO] [stderr] 850 | push_column(col as u32, &mut formula); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(col)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xlsb.rs:860:29 [INFO] [stderr] | [INFO] [stderr] 860 | push_column(read_u16(&rgce[8..10]) as u32, &mut formula); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[8..10]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xlsb.rs:865:29 [INFO] [stderr] | [INFO] [stderr] 865 | push_column(read_u16(&rgce[10..12]) as u32, &mut formula); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_u16(&rgce[10..12]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/de.rs:215:9 [INFO] [stderr] | [INFO] [stderr] 215 | &self, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/xlsx.rs:550:39 [INFO] [stderr] | [INFO] [stderr] 550 | fn get_dimension(dimension: &[u8]) -> Result<((u32, u32), (u32, u32)), XlsxError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xlsx.rs:572:24 [INFO] [stderr] | [INFO] [stderr] 572 | row += ((c - b'0') as u32) * pow; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(c - b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xlsx.rs:582:25 [INFO] [stderr] | [INFO] [stderr] 582 | col += ((c - b'A') as u32 + 1) * pow; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(c - b'A')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xlsx.rs:590:25 [INFO] [stderr] | [INFO] [stderr] 590 | col += ((c - b'a') as u32 + 1) * pow; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(c - b'a')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/de.rs:215:9 [INFO] [stderr] | [INFO] [stderr] 215 | &self, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `calamine`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `calamine`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d0ed91f6c0b34d06e5f55eb590f93c2c8091e50844492e23b97e497876512317"` [INFO] running `"docker" "rm" "-f" "d0ed91f6c0b34d06e5f55eb590f93c2c8091e50844492e23b97e497876512317"` [INFO] [stdout] d0ed91f6c0b34d06e5f55eb590f93c2c8091e50844492e23b97e497876512317