[INFO] crate caf 0.1.0 is already in cache [INFO] extracting crate caf 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/caf/0.1.0 [INFO] extracting crate caf 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/caf/0.1.0 [INFO] validating manifest of caf-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of caf-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing caf-0.1.0 [INFO] finished frobbing caf-0.1.0 [INFO] frobbed toml for caf-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/caf/0.1.0/Cargo.toml [INFO] started frobbing caf-0.1.0 [INFO] finished frobbing caf-0.1.0 [INFO] frobbed toml for caf-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/caf/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting caf-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/caf/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f0883db276b4f1c8740dc6b1e3c3fb6edae31e0420571399b8bcde94d4e9f05c [INFO] running `"docker" "start" "-a" "f0883db276b4f1c8740dc6b1e3c3fb6edae31e0420571399b8bcde94d4e9f05c"` [INFO] [stderr] Checking caf v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chunks.rs:131:6 [INFO] [stderr] | [INFO] [stderr] 131 | sample_rate : sample_rate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sample_rate` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chunks.rs:188:6 [INFO] [stderr] | [INFO] [stderr] 188 | channel_layout_tag : channel_layout_tag, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `channel_layout_tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chunks.rs:189:6 [INFO] [stderr] | [INFO] [stderr] 189 | channel_bitmap : channel_bitmap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `channel_bitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:48:23 [INFO] [stderr] | [INFO] [stderr] 48 | Ok(CafChunkReader { rdr : rdr }) [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `rdr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:344:4 [INFO] [stderr] | [INFO] [stderr] 344 | ch_rdr : ch_rdr, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `ch_rdr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:345:4 [INFO] [stderr] | [INFO] [stderr] 345 | audio_desc : audio_desc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `audio_desc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:346:4 [INFO] [stderr] | [INFO] [stderr] 346 | packet_table : packet_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `packet_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:348:4 [INFO] [stderr] | [INFO] [stderr] 348 | edit_count : edit_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `edit_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:349:4 [INFO] [stderr] | [INFO] [stderr] 349 | audio_chunk_len : audio_chunk_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `audio_chunk_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chunks.rs:131:6 [INFO] [stderr] | [INFO] [stderr] 131 | sample_rate : sample_rate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sample_rate` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chunks.rs:188:6 [INFO] [stderr] | [INFO] [stderr] 188 | channel_layout_tag : channel_layout_tag, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `channel_layout_tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chunks.rs:189:6 [INFO] [stderr] | [INFO] [stderr] 189 | channel_bitmap : channel_bitmap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `channel_bitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:48:23 [INFO] [stderr] | [INFO] [stderr] 48 | Ok(CafChunkReader { rdr : rdr }) [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `rdr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:344:4 [INFO] [stderr] | [INFO] [stderr] 344 | ch_rdr : ch_rdr, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `ch_rdr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:345:4 [INFO] [stderr] | [INFO] [stderr] 345 | audio_desc : audio_desc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `audio_desc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:346:4 [INFO] [stderr] | [INFO] [stderr] 346 | packet_table : packet_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `packet_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:348:4 [INFO] [stderr] | [INFO] [stderr] 348 | edit_count : edit_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `edit_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:349:4 [INFO] [stderr] | [INFO] [stderr] 349 | audio_chunk_len : audio_chunk_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `audio_chunk_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: mistyped literal suffix [INFO] [stderr] --> src/enums.rs:39:46 [INFO] [stderr] | [INFO] [stderr] 39 | pub const UNIQUE_MATERIAL_IDENTIFIER :u32 = 0x75_6d_69_64; // "umid" [INFO] [stderr] | ^^^^^^^^^^^^^ help: did you mean to write: `0x0075_6d69_i64` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::mistyped_literal_suffixes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mistyped_literal_suffixes [INFO] [stderr] [INFO] [stderr] error: mistyped literal suffix [INFO] [stderr] --> src/enums.rs:40:32 [INFO] [stderr] | [INFO] [stderr] 40 | pub const USER_DEFINED :u32 = 0x75_75_69_64; // "uuid" [INFO] [stderr] | ^^^^^^^^^^^^^ help: did you mean to write: `0x0075_7569_i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mistyped_literal_suffixes [INFO] [stderr] [INFO] [stderr] error: mistyped literal suffix [INFO] [stderr] --> src/enums.rs:140:32 [INFO] [stderr] | [INFO] [stderr] 140 | pub const MPEG_LAYER_2 :u32 = 0x2e_6d_70_32; // ".mp2" [INFO] [stderr] | ^^^^^^^^^^^^^ help: did you mean to write: `0x002e_6d70_i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mistyped_literal_suffixes [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:238:3 [INFO] [stderr] | [INFO] [stderr] 238 | return CafPacketReader::from_chunk_reader(ch_rdr, filter_by); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CafPacketReader::from_chunk_reader(ch_rdr, filter_by)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:362:3 [INFO] [stderr] | [INFO] [stderr] 362 | return self.audio_desc.bytes_per_packet != 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.audio_desc.bytes_per_packet != 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:406:3 [INFO] [stderr] | [INFO] [stderr] 406 | return Ok(Some(arr)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some(arr))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:418:3 [INFO] [stderr] | [INFO] [stderr] 418 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: mistyped literal suffix [INFO] [stderr] --> src/enums.rs:39:46 [INFO] [stderr] | [INFO] [stderr] 39 | pub const UNIQUE_MATERIAL_IDENTIFIER :u32 = 0x75_6d_69_64; // "umid" [INFO] [stderr] | ^^^^^^^^^^^^^ help: did you mean to write: `0x0075_6d69_i64` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::mistyped_literal_suffixes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mistyped_literal_suffixes [INFO] [stderr] [INFO] [stderr] error: mistyped literal suffix [INFO] [stderr] --> src/enums.rs:40:32 [INFO] [stderr] | [INFO] [stderr] 40 | pub const USER_DEFINED :u32 = 0x75_75_69_64; // "uuid" [INFO] [stderr] | ^^^^^^^^^^^^^ help: did you mean to write: `0x0075_7569_i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mistyped_literal_suffixes [INFO] [stderr] [INFO] [stderr] error: mistyped literal suffix [INFO] [stderr] --> src/enums.rs:140:32 [INFO] [stderr] | [INFO] [stderr] 140 | pub const MPEG_LAYER_2 :u32 = 0x2e_6d_70_32; // ".mp2" [INFO] [stderr] | ^^^^^^^^^^^^^ help: did you mean to write: `0x002e_6d70_i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mistyped_literal_suffixes [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:238:3 [INFO] [stderr] | [INFO] [stderr] 238 | return CafPacketReader::from_chunk_reader(ch_rdr, filter_by); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CafPacketReader::from_chunk_reader(ch_rdr, filter_by)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:362:3 [INFO] [stderr] | [INFO] [stderr] 362 | return self.audio_desc.bytes_per_packet != 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.audio_desc.bytes_per_packet != 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:406:3 [INFO] [stderr] | [INFO] [stderr] 406 | return Ok(Some(arr)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some(arr))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:418:3 [INFO] [stderr] | [INFO] [stderr] 418 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `caf`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `caf`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "f0883db276b4f1c8740dc6b1e3c3fb6edae31e0420571399b8bcde94d4e9f05c"` [INFO] running `"docker" "rm" "-f" "f0883db276b4f1c8740dc6b1e3c3fb6edae31e0420571399b8bcde94d4e9f05c"` [INFO] [stdout] f0883db276b4f1c8740dc6b1e3c3fb6edae31e0420571399b8bcde94d4e9f05c