[INFO] crate caesium 0.1.0 is already in cache [INFO] extracting crate caesium 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/caesium/0.1.0 [INFO] extracting crate caesium 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/caesium/0.1.0 [INFO] validating manifest of caesium-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of caesium-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing caesium-0.1.0 [INFO] finished frobbing caesium-0.1.0 [INFO] frobbed toml for caesium-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/caesium/0.1.0/Cargo.toml [INFO] started frobbing caesium-0.1.0 [INFO] finished frobbing caesium-0.1.0 [INFO] frobbed toml for caesium-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/caesium/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting caesium-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/caesium/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2acdf81401a82c9b045894e4d6a2683dbeca5c01c37ea4eb8ad57225b5fa2f50 [INFO] running `"docker" "start" "-a" "2acdf81401a82c9b045894e4d6a2683dbeca5c01c37ea4eb8ad57225b5fa2f50"` [INFO] [stderr] Checking router v0.5.1 [INFO] [stderr] Checking caesium v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/authentication/openid.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | token_endpoint: token_endpoint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `token_endpoint` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/authentication/openid.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | userinfo_endpoint: userinfo_endpoint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `userinfo_endpoint` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/registry.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | cksum: cksum, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cksum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | storage: storage, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `storage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | authentication: authentication, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `authentication` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | caesium: caesium, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `caesium` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/authentication/openid.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | token_endpoint: token_endpoint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `token_endpoint` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/authentication/openid.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | userinfo_endpoint: userinfo_endpoint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `userinfo_endpoint` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/registry.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | cksum: cksum, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cksum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | storage: storage, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `storage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | authentication: authentication, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `authentication` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | caesium: caesium, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `caesium` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/modules/storage/file.rs:15:26 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn new(location: &String) -> FileCrateStorage { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/modules/storage/artifactory.rs:21:21 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn new(url: &String, api_key: &String) -> ArtifactoryCrateStorage { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/modules/storage/artifactory.rs:21:39 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn new(url: &String, api_key: &String) -> ArtifactoryCrateStorage { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 21 | pub fn new(url: &String, api_key: &str) -> ArtifactoryCrateStorage { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `api_key.clone()` to [INFO] [stderr] | [INFO] [stderr] 28 | api_key: api_key.to_string(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:87:33 [INFO] [stderr] | [INFO] [stderr] 87 | .unwrap_or("an anonymous user".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "an anonymous user".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/modules/storage/file.rs:15:26 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn new(location: &String) -> FileCrateStorage { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/modules/storage/artifactory.rs:21:21 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn new(url: &String, api_key: &String) -> ArtifactoryCrateStorage { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/modules/storage/artifactory.rs:21:39 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn new(url: &String, api_key: &String) -> ArtifactoryCrateStorage { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 21 | pub fn new(url: &String, api_key: &str) -> ArtifactoryCrateStorage { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `api_key.clone()` to [INFO] [stderr] | [INFO] [stderr] 28 | api_key: api_key.to_string(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:87:33 [INFO] [stderr] | [INFO] [stderr] 87 | .unwrap_or("an anonymous user".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "an anonymous user".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.75s [INFO] running `"docker" "inspect" "2acdf81401a82c9b045894e4d6a2683dbeca5c01c37ea4eb8ad57225b5fa2f50"` [INFO] running `"docker" "rm" "-f" "2acdf81401a82c9b045894e4d6a2683dbeca5c01c37ea4eb8ad57225b5fa2f50"` [INFO] [stdout] 2acdf81401a82c9b045894e4d6a2683dbeca5c01c37ea4eb8ad57225b5fa2f50