[INFO] crate caesarlib 0.2.0 is already in cache [INFO] extracting crate caesarlib 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/caesarlib/0.2.0 [INFO] extracting crate caesarlib 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/caesarlib/0.2.0 [INFO] validating manifest of caesarlib-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of caesarlib-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing caesarlib-0.2.0 [INFO] finished frobbing caesarlib-0.2.0 [INFO] frobbed toml for caesarlib-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/caesarlib/0.2.0/Cargo.toml [INFO] started frobbing caesarlib-0.2.0 [INFO] finished frobbing caesarlib-0.2.0 [INFO] frobbed toml for caesarlib-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/caesarlib/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting caesarlib-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/caesarlib/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4c2ef6a159237b7892db77bb0f5db4a9fc9acc7ee0787eb723537b07a971b58f [INFO] running `"docker" "start" "-a" "4c2ef6a159237b7892db77bb0f5db4a9fc9acc7ee0787eb723537b07a971b58f"` [INFO] [stderr] Checking caesarlib v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:33:21 [INFO] [stderr] | [INFO] [stderr] 33 | fn vec_shift(input: &Vec, start: usize, end: usize) -> String { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:33:21 [INFO] [stderr] | [INFO] [stderr] 33 | fn vec_shift(input: &Vec, start: usize, end: usize) -> String { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / match matches.is_present("RANDOM") { [INFO] [stderr] 45 | | true => { [INFO] [stderr] 46 | | result = rdm_encipher(input_text); [INFO] [stderr] 47 | | }, [INFO] [stderr] ... | [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 44 | if matches.is_present("RANDOM") { [INFO] [stderr] 45 | result = rdm_encipher(input_text); [INFO] [stderr] 46 | } else { [INFO] [stderr] 47 | let method = matches.value_of("METHOD").unwrap(); [INFO] [stderr] 48 | let parsed_offset = match matches.value_of("OFFSET").unwrap().parse::() { [INFO] [stderr] 49 | Ok(num) => num, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / match matches.is_present("RANDOM") { [INFO] [stderr] 45 | | true => { [INFO] [stderr] 46 | | result = rdm_encipher(input_text); [INFO] [stderr] 47 | | }, [INFO] [stderr] ... | [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 44 | if matches.is_present("RANDOM") { [INFO] [stderr] 45 | result = rdm_encipher(input_text); [INFO] [stderr] 46 | } else { [INFO] [stderr] 47 | let method = matches.value_of("METHOD").unwrap(); [INFO] [stderr] 48 | let parsed_offset = match matches.value_of("OFFSET").unwrap().parse::() { [INFO] [stderr] 49 | Ok(num) => num, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.92s [INFO] running `"docker" "inspect" "4c2ef6a159237b7892db77bb0f5db4a9fc9acc7ee0787eb723537b07a971b58f"` [INFO] running `"docker" "rm" "-f" "4c2ef6a159237b7892db77bb0f5db4a9fc9acc7ee0787eb723537b07a971b58f"` [INFO] [stdout] 4c2ef6a159237b7892db77bb0f5db4a9fc9acc7ee0787eb723537b07a971b58f