[INFO] crate cached_file_view 0.1.4 is already in cache [INFO] extracting crate cached_file_view 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/cached_file_view/0.1.4 [INFO] extracting crate cached_file_view 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cached_file_view/0.1.4 [INFO] validating manifest of cached_file_view-0.1.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cached_file_view-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cached_file_view-0.1.4 [INFO] finished frobbing cached_file_view-0.1.4 [INFO] frobbed toml for cached_file_view-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/cached_file_view/0.1.4/Cargo.toml [INFO] started frobbing cached_file_view-0.1.4 [INFO] finished frobbing cached_file_view-0.1.4 [INFO] frobbed toml for cached_file_view-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cached_file_view/0.1.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cached_file_view-0.1.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cached_file_view/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 697bfcac8891959ab40289933ead9461554b91f5c3bca82ed6054f0e5e813b3a [INFO] running `"docker" "start" "-a" "697bfcac8891959ab40289933ead9461554b91f5c3bca82ed6054f0e5e813b3a"` [INFO] [stderr] Checking cached_file_view v0.1.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:118:17 [INFO] [stderr] | [INFO] [stderr] 118 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:188:17 [INFO] [stderr] | [INFO] [stderr] 188 | start_offset: start_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:189:17 [INFO] [stderr] | [INFO] [stderr] 189 | end_offset: end_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `end_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:191:17 [INFO] [stderr] | [INFO] [stderr] 191 | buffers: buffers [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `buffers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:118:17 [INFO] [stderr] | [INFO] [stderr] 118 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:188:17 [INFO] [stderr] | [INFO] [stderr] 188 | start_offset: start_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:189:17 [INFO] [stderr] | [INFO] [stderr] 189 | end_offset: end_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `end_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:191:17 [INFO] [stderr] | [INFO] [stderr] 191 | buffers: buffers [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `buffers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/lib.rs:160:13 [INFO] [stderr] | [INFO] [stderr] 160 | / if inner.buffers.contains_key(&address) { [INFO] [stderr] 161 | | inner.file.seek(SeekFrom::Current(CHUNK_SIZE as i64))?; [INFO] [stderr] 162 | | let chunk = inner.buffers.get_mut(&address).unwrap(); [INFO] [stderr] 163 | | chunk.readers += 1; [INFO] [stderr] ... | [INFO] [stderr] 176 | | buffers.push(chunk); [INFO] [stderr] 177 | | } [INFO] [stderr] | |_____________^ help: consider using: `inner.buffers.entry(address)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/lib.rs:167:17 [INFO] [stderr] | [INFO] [stderr] 167 | inner.file.read(&mut buffer)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `cached_file_view`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/lib.rs:160:13 [INFO] [stderr] | [INFO] [stderr] 160 | / if inner.buffers.contains_key(&address) { [INFO] [stderr] 161 | | inner.file.seek(SeekFrom::Current(CHUNK_SIZE as i64))?; [INFO] [stderr] 162 | | let chunk = inner.buffers.get_mut(&address).unwrap(); [INFO] [stderr] 163 | | chunk.readers += 1; [INFO] [stderr] ... | [INFO] [stderr] 176 | | buffers.push(chunk); [INFO] [stderr] 177 | | } [INFO] [stderr] | |_____________^ help: consider using: `inner.buffers.entry(address)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/lib.rs:167:17 [INFO] [stderr] | [INFO] [stderr] 167 | inner.file.read(&mut buffer)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `cached_file_view`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "697bfcac8891959ab40289933ead9461554b91f5c3bca82ed6054f0e5e813b3a"` [INFO] running `"docker" "rm" "-f" "697bfcac8891959ab40289933ead9461554b91f5c3bca82ed6054f0e5e813b3a"` [INFO] [stdout] 697bfcac8891959ab40289933ead9461554b91f5c3bca82ed6054f0e5e813b3a