[INFO] crate cached 0.8.0 is already in cache [INFO] extracting crate cached 0.8.0 into work/ex/clippy-test-run/sources/stable/reg/cached/0.8.0 [INFO] extracting crate cached 0.8.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cached/0.8.0 [INFO] validating manifest of cached-0.8.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cached-0.8.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cached-0.8.0 [INFO] finished frobbing cached-0.8.0 [INFO] frobbed toml for cached-0.8.0 written to work/ex/clippy-test-run/sources/stable/reg/cached/0.8.0/Cargo.toml [INFO] started frobbing cached-0.8.0 [INFO] finished frobbing cached-0.8.0 [INFO] frobbed toml for cached-0.8.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cached/0.8.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cached-0.8.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cached/0.8.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a361b3669f7aa8d357665f0bba110d40c5242759eaa29325ea9ae3ba5c71b685 [INFO] running `"docker" "start" "-a" "a361b3669f7aa8d357665f0bba110d40c5242759eaa29325ea9ae3ba5c71b685"` [INFO] [stderr] Checking parking_lot v0.7.1 [INFO] [stderr] Checking once_cell v0.1.7 [INFO] [stderr] Checking cached v0.8.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stores.rs:225:13 [INFO] [stderr] | [INFO] [stderr] 225 | seconds: seconds, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `seconds` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stores.rs:236:13 [INFO] [stderr] | [INFO] [stderr] 236 | seconds: seconds, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `seconds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stores.rs:225:13 [INFO] [stderr] | [INFO] [stderr] 225 | seconds: seconds, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `seconds` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stores.rs:236:13 [INFO] [stderr] | [INFO] [stderr] 236 | seconds: seconds, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `seconds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `stores::UnboundCache` [INFO] [stderr] --> src/stores.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / pub fn new() -> UnboundCache { [INFO] [stderr] 29 | | UnboundCache { [INFO] [stderr] 30 | | store: HashMap::new(), [INFO] [stderr] 31 | | hits: 0, [INFO] [stderr] 32 | | misses: 0, [INFO] [stderr] 33 | | } [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 20 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/stores.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | / match self { [INFO] [stderr] 77 | | &Slot::Occupied(ref v) => Some(v), [INFO] [stderr] 78 | | &Slot::Empty => None, [INFO] [stderr] 79 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 76 | match *self { [INFO] [stderr] 77 | Slot::Occupied(ref v) => Some(v), [INFO] [stderr] 78 | Slot::Empty => None, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/stores.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | / match slot { [INFO] [stderr] 162 | | Slot::Empty => self.order.push_front(key), [INFO] [stderr] 163 | | _ => (), [INFO] [stderr] 164 | | } [INFO] [stderr] | |_________^ help: try this: `if let Slot::Empty = slot { self.order.push_front(key) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `stores::UnboundCache` [INFO] [stderr] --> src/stores.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / pub fn new() -> UnboundCache { [INFO] [stderr] 29 | | UnboundCache { [INFO] [stderr] 30 | | store: HashMap::new(), [INFO] [stderr] 31 | | hits: 0, [INFO] [stderr] 32 | | misses: 0, [INFO] [stderr] 33 | | } [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 20 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/stores.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | / match self { [INFO] [stderr] 77 | | &Slot::Occupied(ref v) => Some(v), [INFO] [stderr] 78 | | &Slot::Empty => None, [INFO] [stderr] 79 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 76 | match *self { [INFO] [stderr] 77 | Slot::Occupied(ref v) => Some(v), [INFO] [stderr] 78 | Slot::Empty => None, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/stores.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | / match slot { [INFO] [stderr] 162 | | Slot::Empty => self.order.push_front(key), [INFO] [stderr] 163 | | _ => (), [INFO] [stderr] 164 | | } [INFO] [stderr] | |_________^ help: try this: `if let Slot::Empty = slot { self.order.push_front(key) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> examples/kitchen_sink.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | return a * b; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `a * b` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> tests/cached.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | return a + &b; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `a + &b` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/cached.rs:253:28 [INFO] [stderr] | [INFO] [stderr] 253 | sleep(Duration::new(0, 500000)); [INFO] [stderr] | ^^^^^^ help: consider: `500_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.16s [INFO] running `"docker" "inspect" "a361b3669f7aa8d357665f0bba110d40c5242759eaa29325ea9ae3ba5c71b685"` [INFO] running `"docker" "rm" "-f" "a361b3669f7aa8d357665f0bba110d40c5242759eaa29325ea9ae3ba5c71b685"` [INFO] [stdout] a361b3669f7aa8d357665f0bba110d40c5242759eaa29325ea9ae3ba5c71b685