[INFO] crate cache_control 0.1.0 is already in cache [INFO] extracting crate cache_control 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/cache_control/0.1.0 [INFO] extracting crate cache_control 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cache_control/0.1.0 [INFO] validating manifest of cache_control-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cache_control-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cache_control-0.1.0 [INFO] finished frobbing cache_control-0.1.0 [INFO] frobbed toml for cache_control-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/cache_control/0.1.0/Cargo.toml [INFO] started frobbing cache_control-0.1.0 [INFO] finished frobbing cache_control-0.1.0 [INFO] frobbed toml for cache_control-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cache_control/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cache_control-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cache_control/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bb973dcf27384a727918c89a5a9057342fba5b5dc0a9c48f638fe04b6a85ecf3 [INFO] running `"docker" "start" "-a" "bb973dcf27384a727918c89a5a9057342fba5b5dc0a9c48f638fe04b6a85ecf3"` [INFO] [stderr] Checking cache_control v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:55:45 [INFO] [stderr] | [INFO] [stderr] 55 | let tokens: Vec<&str> = value.split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:57:52 [INFO] [stderr] | [INFO] [stderr] 57 | let key_value: Vec<&str> = token.split("=").map(|s| s.trim()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/lib.rs:67:28 [INFO] [stderr] | [INFO] [stderr] 67 | if let None = val { [INFO] [stderr] | _____________________- ^^^^ [INFO] [stderr] 68 | | return None; [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____________________- help: try this: `if val.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:72:28 [INFO] [stderr] | [INFO] [stderr] 72 | if let Err(_) = p_val { [INFO] [stderr] | _____________________- ^^^^^^ [INFO] [stderr] 73 | | return None; [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____________________- help: try this: `if p_val.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/lib.rs:78:28 [INFO] [stderr] | [INFO] [stderr] 78 | if let None = val { [INFO] [stderr] | _____________________- ^^^^ [INFO] [stderr] 79 | | return None; [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____________________- help: try this: `if val.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:83:28 [INFO] [stderr] | [INFO] [stderr] 83 | if let Err(_) = p_val { [INFO] [stderr] | _____________________- ^^^^^^ [INFO] [stderr] 84 | | return None; [INFO] [stderr] 85 | | } [INFO] [stderr] | |_____________________- help: try this: `if p_val.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/lib.rs:89:28 [INFO] [stderr] | [INFO] [stderr] 89 | if let None = val { [INFO] [stderr] | _____________________- ^^^^ [INFO] [stderr] 90 | | return None; [INFO] [stderr] 91 | | } [INFO] [stderr] | |_____________________- help: try this: `if val.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:94:28 [INFO] [stderr] | [INFO] [stderr] 94 | if let Err(_) = p_val { [INFO] [stderr] | _____________________- ^^^^^^ [INFO] [stderr] 95 | | return None; [INFO] [stderr] 96 | | } [INFO] [stderr] | |_____________________- help: try this: `if p_val.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:112:51 [INFO] [stderr] | [INFO] [stderr] 112 | let header_value: Vec<&str> = value.split(":").map(|s| s.trim()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:116:19 [INFO] [stderr] | [INFO] [stderr] 116 | let val = header_value.get(1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&header_value[1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:55:45 [INFO] [stderr] | [INFO] [stderr] 55 | let tokens: Vec<&str> = value.split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:57:52 [INFO] [stderr] | [INFO] [stderr] 57 | let key_value: Vec<&str> = token.split("=").map(|s| s.trim()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/lib.rs:67:28 [INFO] [stderr] | [INFO] [stderr] 67 | if let None = val { [INFO] [stderr] | _____________________- ^^^^ [INFO] [stderr] 68 | | return None; [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____________________- help: try this: `if val.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:72:28 [INFO] [stderr] | [INFO] [stderr] 72 | if let Err(_) = p_val { [INFO] [stderr] | _____________________- ^^^^^^ [INFO] [stderr] 73 | | return None; [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____________________- help: try this: `if p_val.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/lib.rs:78:28 [INFO] [stderr] | [INFO] [stderr] 78 | if let None = val { [INFO] [stderr] | _____________________- ^^^^ [INFO] [stderr] 79 | | return None; [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____________________- help: try this: `if val.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:83:28 [INFO] [stderr] | [INFO] [stderr] 83 | if let Err(_) = p_val { [INFO] [stderr] | _____________________- ^^^^^^ [INFO] [stderr] 84 | | return None; [INFO] [stderr] 85 | | } [INFO] [stderr] | |_____________________- help: try this: `if p_val.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/lib.rs:89:28 [INFO] [stderr] | [INFO] [stderr] 89 | if let None = val { [INFO] [stderr] | _____________________- ^^^^ [INFO] [stderr] 90 | | return None; [INFO] [stderr] 91 | | } [INFO] [stderr] | |_____________________- help: try this: `if val.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:94:28 [INFO] [stderr] | [INFO] [stderr] 94 | if let Err(_) = p_val { [INFO] [stderr] | _____________________- ^^^^^^ [INFO] [stderr] 95 | | return None; [INFO] [stderr] 96 | | } [INFO] [stderr] | |_____________________- help: try this: `if p_val.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:112:51 [INFO] [stderr] | [INFO] [stderr] 112 | let header_value: Vec<&str> = value.split(":").map(|s| s.trim()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:116:19 [INFO] [stderr] | [INFO] [stderr] 116 | let val = header_value.get(1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&header_value[1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.83s [INFO] running `"docker" "inspect" "bb973dcf27384a727918c89a5a9057342fba5b5dc0a9c48f638fe04b6a85ecf3"` [INFO] running `"docker" "rm" "-f" "bb973dcf27384a727918c89a5a9057342fba5b5dc0a9c48f638fe04b6a85ecf3"` [INFO] [stdout] bb973dcf27384a727918c89a5a9057342fba5b5dc0a9c48f638fe04b6a85ecf3