[INFO] crate cab 0.2.0 is already in cache [INFO] extracting crate cab 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/cab/0.2.0 [INFO] extracting crate cab 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cab/0.2.0 [INFO] validating manifest of cab-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cab-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cab-0.2.0 [INFO] finished frobbing cab-0.2.0 [INFO] frobbed toml for cab-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/cab/0.2.0/Cargo.toml [INFO] started frobbing cab-0.2.0 [INFO] finished frobbing cab-0.2.0 [INFO] frobbed toml for cab-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cab/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cab-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cab/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ba201426c1f7759b77d6a257bebd08ad31d4c93d68884194678b4226acb49941 [INFO] running `"docker" "start" "-a" "ba201426c1f7759b77d6a257bebd08ad31d4c93d68884194678b4226acb49941"` [INFO] [stderr] Checking lipsum v0.4.0 [INFO] [stderr] Checking cab v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/builder.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/builder.rs:319:16 [INFO] [stderr] | [INFO] [stderr] 319 | builder: builder, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `builder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/builder.rs:443:13 [INFO] [stderr] | [INFO] [stderr] 443 | folder_writer: folder_writer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `folder_writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/builder.rs:444:13 [INFO] [stderr] | [INFO] [stderr] 444 | file_builder: file_builder, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_builder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/builder.rs:515:16 [INFO] [stderr] | [INFO] [stderr] 515 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/builder.rs:516:16 [INFO] [stderr] | [INFO] [stderr] 516 | compressor: compressor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `compressor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/builder.rs:517:16 [INFO] [stderr] | [INFO] [stderr] 517 | folder_entry_offset: folder_entry_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `folder_entry_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/cabinet.rs:96:17 [INFO] [stderr] | [INFO] [stderr] 96 | num_data_blocks: num_data_blocks, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_data_blocks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/cabinet.rs:97:17 [INFO] [stderr] | [INFO] [stderr] 97 | compression_type: compression_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `compression_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/cabinet.rs:125:17 [INFO] [stderr] | [INFO] [stderr] 125 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/cabinet.rs:126:17 [INFO] [stderr] | [INFO] [stderr] 126 | datetime: datetime, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `datetime` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/cabinet.rs:127:17 [INFO] [stderr] | [INFO] [stderr] 127 | uncompressed_size: uncompressed_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `uncompressed_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/cabinet.rs:128:17 [INFO] [stderr] | [INFO] [stderr] 128 | uncompressed_offset: uncompressed_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `uncompressed_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/cabinet.rs:129:17 [INFO] [stderr] | [INFO] [stderr] 129 | attributes: attributes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attributes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/cabinet.rs:134:16 [INFO] [stderr] | [INFO] [stderr] 134 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/cabinet.rs:135:16 [INFO] [stderr] | [INFO] [stderr] 135 | cabinet_set_id: cabinet_set_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cabinet_set_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/cabinet.rs:136:16 [INFO] [stderr] | [INFO] [stderr] 136 | cabinet_set_index: cabinet_set_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cabinet_set_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/cabinet.rs:137:16 [INFO] [stderr] | [INFO] [stderr] 137 | data_reserve_size: data_reserve_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_reserve_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/cabinet.rs:139:16 [INFO] [stderr] | [INFO] [stderr] 139 | folders: folders, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `folders` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/cabinet.rs:180:20 [INFO] [stderr] | [INFO] [stderr] 180 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/cabinet.rs:423:13 [INFO] [stderr] | [INFO] [stderr] 423 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/cabinet.rs:424:13 [INFO] [stderr] | [INFO] [stderr] 424 | decompressor: decompressor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `decompressor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/cabinet.rs:426:13 [INFO] [stderr] | [INFO] [stderr] 426 | data_blocks: data_blocks, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_blocks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/internal/mszip.rs:191:9 [INFO] [stderr] | [INFO] [stderr] 191 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/builder.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/builder.rs:319:16 [INFO] [stderr] | [INFO] [stderr] 319 | builder: builder, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `builder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/builder.rs:443:13 [INFO] [stderr] | [INFO] [stderr] 443 | folder_writer: folder_writer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `folder_writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/builder.rs:444:13 [INFO] [stderr] | [INFO] [stderr] 444 | file_builder: file_builder, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_builder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/builder.rs:515:16 [INFO] [stderr] | [INFO] [stderr] 515 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/builder.rs:516:16 [INFO] [stderr] | [INFO] [stderr] 516 | compressor: compressor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `compressor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/builder.rs:517:16 [INFO] [stderr] | [INFO] [stderr] 517 | folder_entry_offset: folder_entry_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `folder_entry_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/cabinet.rs:96:17 [INFO] [stderr] | [INFO] [stderr] 96 | num_data_blocks: num_data_blocks, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_data_blocks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/cabinet.rs:97:17 [INFO] [stderr] | [INFO] [stderr] 97 | compression_type: compression_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `compression_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/cabinet.rs:125:17 [INFO] [stderr] | [INFO] [stderr] 125 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/cabinet.rs:126:17 [INFO] [stderr] | [INFO] [stderr] 126 | datetime: datetime, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `datetime` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/cabinet.rs:127:17 [INFO] [stderr] | [INFO] [stderr] 127 | uncompressed_size: uncompressed_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `uncompressed_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/cabinet.rs:128:17 [INFO] [stderr] | [INFO] [stderr] 128 | uncompressed_offset: uncompressed_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `uncompressed_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/cabinet.rs:129:17 [INFO] [stderr] | [INFO] [stderr] 129 | attributes: attributes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attributes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/cabinet.rs:134:16 [INFO] [stderr] | [INFO] [stderr] 134 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/cabinet.rs:135:16 [INFO] [stderr] | [INFO] [stderr] 135 | cabinet_set_id: cabinet_set_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cabinet_set_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/cabinet.rs:136:16 [INFO] [stderr] | [INFO] [stderr] 136 | cabinet_set_index: cabinet_set_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cabinet_set_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/cabinet.rs:137:16 [INFO] [stderr] | [INFO] [stderr] 137 | data_reserve_size: data_reserve_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_reserve_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/cabinet.rs:139:16 [INFO] [stderr] | [INFO] [stderr] 139 | folders: folders, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `folders` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/cabinet.rs:180:20 [INFO] [stderr] | [INFO] [stderr] 180 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/cabinet.rs:423:13 [INFO] [stderr] | [INFO] [stderr] 423 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/cabinet.rs:424:13 [INFO] [stderr] | [INFO] [stderr] 424 | decompressor: decompressor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `decompressor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/cabinet.rs:426:13 [INFO] [stderr] | [INFO] [stderr] 426 | data_blocks: data_blocks, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_blocks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/internal/mszip.rs:191:9 [INFO] [stderr] | [INFO] [stderr] 191 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/consts.rs:3:33 [INFO] [stderr] | [INFO] [stderr] 3 | pub const FILE_SIGNATURE: u32 = 0x4643534d; // "MSCF" stored little-endian [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4643_534d` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/consts.rs:8:37 [INFO] [stderr] | [INFO] [stderr] 8 | pub const MAX_TOTAL_CAB_SIZE: u32 = 0x7fffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/consts.rs:14:32 [INFO] [stderr] | [INFO] [stderr] 14 | pub const MAX_FILE_SIZE: u32 = 0x7fff8000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_8000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `internal::builder::CabinetBuilder` [INFO] [stderr] --> src/internal/builder.rs:142:5 [INFO] [stderr] | [INFO] [stderr] 142 | / pub fn new() -> CabinetBuilder { [INFO] [stderr] 143 | | CabinetBuilder { [INFO] [stderr] 144 | | folders: Vec::new(), [INFO] [stderr] 145 | | reserve_data: Vec::new(), [INFO] [stderr] 146 | | } [INFO] [stderr] 147 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 135 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/internal/builder.rs:300:34 [INFO] [stderr] | [INFO] [stderr] 300 | let mut current_offset = first_file_offset as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(first_file_offset)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/internal/builder.rs:335:46 [INFO] [stderr] | [INFO] [stderr] 335 | self.offset_within_folder += file.uncompressed_size as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(file.uncompressed_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/internal/builder.rs:358:48 [INFO] [stderr] | [INFO] [stderr] 358 | if self.offset_within_folder > (u32::MAX as u64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(u32::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/internal/builder.rs:405:40 [INFO] [stderr] | [INFO] [stderr] 405 | if cabinet_file_size > (consts::MAX_TOTAL_CAB_SIZE as u64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(consts::MAX_TOTAL_CAB_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/internal/builder.rs:463:48 [INFO] [stderr] | [INFO] [stderr] 463 | let max_bytes = (buf.len() as u64).min(remaining as u64) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(remaining)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/internal/builder.rs:496:29 [INFO] [stderr] | [INFO] [stderr] 496 | if current_offset > (consts::MAX_TOTAL_CAB_SIZE as u64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(consts::MAX_TOTAL_CAB_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/internal/builder.rs:532:37 [INFO] [stderr] | [INFO] [stderr] 532 | writer.seek(SeekFrom::Start(self.folder_entry_offset as u64))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.folder_entry_offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/internal/builder.rs:564:14 [INFO] [stderr] | [INFO] [stderr] 564 | ((compressed_size as u32) | ((uncompressed_size as u32) << 16)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(compressed_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/internal/builder.rs:564:42 [INFO] [stderr] | [INFO] [stderr] 564 | ((compressed_size as u32) | ((uncompressed_size as u32) << 16)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(uncompressed_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/internal/builder.rs:565:41 [INFO] [stderr] | [INFO] [stderr] 565 | let total_data_block_size = 8 + compressed_size as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(compressed_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/internal/cabinet.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | / let mut data_reserve_size = 0u8; [INFO] [stderr] 59 | | if (flags & consts::FLAG_RESERVE_PRESENT) != 0 { [INFO] [stderr] 60 | | header_reserve_size = reader.read_u16::()?; [INFO] [stderr] 61 | | folder_reserve_size = reader.read_u8()?; [INFO] [stderr] 62 | | data_reserve_size = reader.read_u8()?; [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let data_reserve_size = if (flags & consts::FLAG_RESERVE_PRESENT) != 0 { ..; reader.read_u8()? } else { 0u8 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/internal/cabinet.rs:103:37 [INFO] [stderr] | [INFO] [stderr] 103 | reader.seek(SeekFrom::Start(first_file_offset as u64))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(first_file_offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/internal/cabinet.rs:191:34 [INFO] [stderr] | [INFO] [stderr] 191 | let offset = file_entry.uncompressed_offset as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(file_entry.uncompressed_offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/internal/cabinet.rs:192:32 [INFO] [stderr] | [INFO] [stderr] 192 | let size = file_entry.uncompressed_size() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(file_entry.uncompressed_size())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/internal/cabinet.rs:401:26 [INFO] [stderr] | [INFO] [stderr] 401 | let mut offset = entry.first_data_block_offset as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(entry.first_data_block_offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/internal/cabinet.rs:404:35 [INFO] [stderr] | [INFO] [stderr] 404 | let compressed_size = reader.read_u16::()? as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(reader.read_u16::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/internal/cabinet.rs:405:37 [INFO] [stderr] | [INFO] [stderr] 405 | let uncompressed_size = reader.read_u16::()? as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(reader.read_u16::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/internal/cabinet.rs:408:27 [INFO] [stderr] | [INFO] [stderr] 408 | offset += 8 + data_reserve_size as u64 + compressed_size; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(data_reserve_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/internal/cabinet.rs:480:18 [INFO] [stderr] | [INFO] [stderr] 480 | ((compressed_size as u32) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(compressed_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/internal/cabinet.rs:481:22 [INFO] [stderr] | [INFO] [stderr] 481 | ((uncompressed_size as u32) << 16)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(uncompressed_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/internal/checksum.rs:37:31 [INFO] [stderr] | [INFO] [stderr] 37 | self.remainder |= (byte as u32) << self.remainder_shift; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/internal/ctype.rs:64:31 [INFO] [stderr] | [INFO] [stderr] 64 | pub(crate) fn to_bitfield(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/internal/datetime.rs:6:16 [INFO] [stderr] | [INFO] [stderr] 6 | let year = (date >> 9) as i32 + 1980; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(date >> 9)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/internal/datetime.rs:7:17 [INFO] [stderr] | [INFO] [stderr] 7 | let month = ((date >> 5) & 0xf) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((date >> 5) & 0xf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/internal/datetime.rs:8:15 [INFO] [stderr] | [INFO] [stderr] 8 | let day = (date & 0x1f) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(date & 0x1f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/internal/datetime.rs:13:16 [INFO] [stderr] | [INFO] [stderr] 13 | let hour = (time >> 11) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(time >> 11)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/internal/datetime.rs:14:18 [INFO] [stderr] | [INFO] [stderr] 14 | let minute = ((time >> 5) & 0x3f) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((time >> 5) & 0x3f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/internal/datetime.rs:15:22 [INFO] [stderr] | [INFO] [stderr] 15 | let second = 2 * (time & 0x1f) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(time & 0x1f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/internal/mszip.rs:77:14 [INFO] [stderr] | [INFO] [stderr] 77 | ((data[0] as u16) | ((data[1] as u16) << 8)) != MSZIP_SIGNATURE [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(data[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/internal/mszip.rs:77:34 [INFO] [stderr] | [INFO] [stderr] 77 | ((data[0] as u16) | ((data[1] as u16) << 8)) != MSZIP_SIGNATURE [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(data[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/checksum.rs:64:38 [INFO] [stderr] | [INFO] [stderr] 64 | assert_eq!(checksum.value(), 0x7f2e1a4c); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7f2e_1a4c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/checksum.rs:68:38 [INFO] [stderr] | [INFO] [stderr] 68 | assert_eq!(checksum.value(), 0x3509541a); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3509_541a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/checksum.rs:81:38 [INFO] [stderr] | [INFO] [stderr] 81 | assert_eq!(checksum.value(), 0x30a65abd); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x30a6_5abd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/consts.rs:3:33 [INFO] [stderr] | [INFO] [stderr] 3 | pub const FILE_SIGNATURE: u32 = 0x4643534d; // "MSCF" stored little-endian [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4643_534d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/consts.rs:8:37 [INFO] [stderr] | [INFO] [stderr] 8 | pub const MAX_TOTAL_CAB_SIZE: u32 = 0x7fffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/consts.rs:14:32 [INFO] [stderr] | [INFO] [stderr] 14 | pub const MAX_FILE_SIZE: u32 = 0x7fff8000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_8000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `internal::builder::CabinetBuilder` [INFO] [stderr] --> src/internal/builder.rs:142:5 [INFO] [stderr] | [INFO] [stderr] 142 | / pub fn new() -> CabinetBuilder { [INFO] [stderr] 143 | | CabinetBuilder { [INFO] [stderr] 144 | | folders: Vec::new(), [INFO] [stderr] 145 | | reserve_data: Vec::new(), [INFO] [stderr] 146 | | } [INFO] [stderr] 147 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 135 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/internal/builder.rs:300:34 [INFO] [stderr] | [INFO] [stderr] 300 | let mut current_offset = first_file_offset as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(first_file_offset)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/internal/builder.rs:335:46 [INFO] [stderr] | [INFO] [stderr] 335 | self.offset_within_folder += file.uncompressed_size as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(file.uncompressed_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/internal/builder.rs:358:48 [INFO] [stderr] | [INFO] [stderr] 358 | if self.offset_within_folder > (u32::MAX as u64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(u32::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/internal/builder.rs:405:40 [INFO] [stderr] | [INFO] [stderr] 405 | if cabinet_file_size > (consts::MAX_TOTAL_CAB_SIZE as u64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(consts::MAX_TOTAL_CAB_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/internal/builder.rs:463:48 [INFO] [stderr] | [INFO] [stderr] 463 | let max_bytes = (buf.len() as u64).min(remaining as u64) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(remaining)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/internal/builder.rs:496:29 [INFO] [stderr] | [INFO] [stderr] 496 | if current_offset > (consts::MAX_TOTAL_CAB_SIZE as u64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(consts::MAX_TOTAL_CAB_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/internal/builder.rs:532:37 [INFO] [stderr] | [INFO] [stderr] 532 | writer.seek(SeekFrom::Start(self.folder_entry_offset as u64))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.folder_entry_offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/internal/builder.rs:564:14 [INFO] [stderr] | [INFO] [stderr] 564 | ((compressed_size as u32) | ((uncompressed_size as u32) << 16)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(compressed_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/internal/builder.rs:564:42 [INFO] [stderr] | [INFO] [stderr] 564 | ((compressed_size as u32) | ((uncompressed_size as u32) << 16)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(uncompressed_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/internal/builder.rs:565:41 [INFO] [stderr] | [INFO] [stderr] 565 | let total_data_block_size = 8 + compressed_size as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(compressed_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/internal/cabinet.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | / let mut data_reserve_size = 0u8; [INFO] [stderr] 59 | | if (flags & consts::FLAG_RESERVE_PRESENT) != 0 { [INFO] [stderr] 60 | | header_reserve_size = reader.read_u16::()?; [INFO] [stderr] 61 | | folder_reserve_size = reader.read_u8()?; [INFO] [stderr] 62 | | data_reserve_size = reader.read_u8()?; [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let data_reserve_size = if (flags & consts::FLAG_RESERVE_PRESENT) != 0 { ..; reader.read_u8()? } else { 0u8 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/internal/cabinet.rs:103:37 [INFO] [stderr] | [INFO] [stderr] 103 | reader.seek(SeekFrom::Start(first_file_offset as u64))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(first_file_offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/internal/cabinet.rs:191:34 [INFO] [stderr] | [INFO] [stderr] 191 | let offset = file_entry.uncompressed_offset as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(file_entry.uncompressed_offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/internal/cabinet.rs:192:32 [INFO] [stderr] | [INFO] [stderr] 192 | let size = file_entry.uncompressed_size() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(file_entry.uncompressed_size())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/internal/cabinet.rs:401:26 [INFO] [stderr] | [INFO] [stderr] 401 | let mut offset = entry.first_data_block_offset as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(entry.first_data_block_offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/internal/cabinet.rs:404:35 [INFO] [stderr] | [INFO] [stderr] 404 | let compressed_size = reader.read_u16::()? as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(reader.read_u16::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/internal/cabinet.rs:405:37 [INFO] [stderr] | [INFO] [stderr] 405 | let uncompressed_size = reader.read_u16::()? as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(reader.read_u16::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/internal/cabinet.rs:408:27 [INFO] [stderr] | [INFO] [stderr] 408 | offset += 8 + data_reserve_size as u64 + compressed_size; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(data_reserve_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/internal/cabinet.rs:480:18 [INFO] [stderr] | [INFO] [stderr] 480 | ((compressed_size as u32) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(compressed_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/internal/cabinet.rs:481:22 [INFO] [stderr] | [INFO] [stderr] 481 | ((uncompressed_size as u32) << 16)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(uncompressed_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/internal/checksum.rs:37:31 [INFO] [stderr] | [INFO] [stderr] 37 | self.remainder |= (byte as u32) << self.remainder_shift; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/internal/ctype.rs:64:31 [INFO] [stderr] | [INFO] [stderr] 64 | pub(crate) fn to_bitfield(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/internal/datetime.rs:6:16 [INFO] [stderr] | [INFO] [stderr] 6 | let year = (date >> 9) as i32 + 1980; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(date >> 9)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/internal/datetime.rs:7:17 [INFO] [stderr] | [INFO] [stderr] 7 | let month = ((date >> 5) & 0xf) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((date >> 5) & 0xf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/internal/datetime.rs:8:15 [INFO] [stderr] | [INFO] [stderr] 8 | let day = (date & 0x1f) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(date & 0x1f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/internal/datetime.rs:13:16 [INFO] [stderr] | [INFO] [stderr] 13 | let hour = (time >> 11) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(time >> 11)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/internal/datetime.rs:14:18 [INFO] [stderr] | [INFO] [stderr] 14 | let minute = ((time >> 5) & 0x3f) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((time >> 5) & 0x3f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/internal/datetime.rs:15:22 [INFO] [stderr] | [INFO] [stderr] 15 | let second = 2 * (time & 0x1f) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(time & 0x1f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/internal/mszip.rs:77:14 [INFO] [stderr] | [INFO] [stderr] 77 | ((data[0] as u16) | ((data[1] as u16) << 8)) != MSZIP_SIGNATURE [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(data[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/internal/mszip.rs:77:34 [INFO] [stderr] | [INFO] [stderr] 77 | ((data[0] as u16) | ((data[1] as u16) << 8)) != MSZIP_SIGNATURE [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(data[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.85s [INFO] running `"docker" "inspect" "ba201426c1f7759b77d6a257bebd08ad31d4c93d68884194678b4226acb49941"` [INFO] running `"docker" "rm" "-f" "ba201426c1f7759b77d6a257bebd08ad31d4c93d68884194678b4226acb49941"` [INFO] [stdout] ba201426c1f7759b77d6a257bebd08ad31d4c93d68884194678b4226acb49941