[INFO] crate c_string 0.7.1-obsolete is already in cache [INFO] extracting crate c_string 0.7.1-obsolete into work/ex/clippy-test-run/sources/stable/reg/c_string/0.7.1-obsolete [INFO] extracting crate c_string 0.7.1-obsolete into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/c_string/0.7.1-obsolete [INFO] validating manifest of c_string-0.7.1-obsolete on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of c_string-0.7.1-obsolete on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing c_string-0.7.1-obsolete [INFO] finished frobbing c_string-0.7.1-obsolete [INFO] frobbed toml for c_string-0.7.1-obsolete written to work/ex/clippy-test-run/sources/stable/reg/c_string/0.7.1-obsolete/Cargo.toml [INFO] started frobbing c_string-0.7.1-obsolete [INFO] finished frobbing c_string-0.7.1-obsolete [INFO] frobbed toml for c_string-0.7.1-obsolete written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/c_string/0.7.1-obsolete/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting c_string-0.7.1-obsolete against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/c_string/0.7.1-obsolete:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9dcf2b57d82ad3c1ee2da8fa62edfed6217fa5593c08f91bc1638217ca95cbfd [INFO] running `"docker" "start" "-a" "9dcf2b57d82ad3c1ee2da8fa62edfed6217fa5593c08f91bc1638217ca95cbfd"` [INFO] [stderr] Checking c_string v0.7.1-obsolete (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/c_str.rs:178:24 [INFO] [stderr] | [INFO] [stderr] 178 | OwnedCString { ptr: ptr, dtor: dtor } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ptr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/c_str.rs:178:34 [INFO] [stderr] | [INFO] [stderr] 178 | OwnedCString { ptr: ptr, dtor: dtor } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dtor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/c_str.rs:178:24 [INFO] [stderr] | [INFO] [stderr] 178 | OwnedCString { ptr: ptr, dtor: dtor } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ptr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/c_str.rs:178:34 [INFO] [stderr] | [INFO] [stderr] 178 | OwnedCString { ptr: ptr, dtor: dtor } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dtor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/c_str.rs:537:5 [INFO] [stderr] | [INFO] [stderr] 537 | return ctr; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ctr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/c_str.rs:537:5 [INFO] [stderr] | [INFO] [stderr] 537 | return ctr; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ctr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_iter` on this type; consider implementing the `std::iter::FromIterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/c_str.rs:316:5 [INFO] [stderr] | [INFO] [stderr] 316 | / pub fn from_iter(iterable: I) -> Result [INFO] [stderr] 317 | | where I: IntoIterator [INFO] [stderr] 318 | | { [INFO] [stderr] 319 | | fn nul_error(mut collected: Vec, remaining: I) -> NulError [INFO] [stderr] ... | [INFO] [stderr] 392 | | Ok(CStrBuf { data: CStrData::Owned(vec) }) [INFO] [stderr] 393 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/c_str.rs:335:26 [INFO] [stderr] | [INFO] [stderr] 335 | for i in 0 .. len + 1 { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `0..=len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/c_str.rs:355:32 [INFO] [stderr] | [INFO] [stderr] 355 | vec.extend(buf[.. len + 1].iter().cloned()); [INFO] [stderr] | ^^^^^^^^^^ help: use: `..=len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/c_str.rs:401:5 [INFO] [stderr] | [INFO] [stderr] 401 | / pub fn from_str(s: &str) -> Result { [INFO] [stderr] 402 | | CStrBuf::from_iter(s.as_bytes().iter().cloned()) [INFO] [stderr] 403 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_iter` on this type; consider implementing the `std::iter::FromIterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/c_str.rs:316:5 [INFO] [stderr] | [INFO] [stderr] 316 | / pub fn from_iter(iterable: I) -> Result [INFO] [stderr] 317 | | where I: IntoIterator [INFO] [stderr] 318 | | { [INFO] [stderr] 319 | | fn nul_error(mut collected: Vec, remaining: I) -> NulError [INFO] [stderr] ... | [INFO] [stderr] 392 | | Ok(CStrBuf { data: CStrData::Owned(vec) }) [INFO] [stderr] 393 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/c_str.rs:335:26 [INFO] [stderr] | [INFO] [stderr] 335 | for i in 0 .. len + 1 { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `0..=len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/c_str.rs:355:32 [INFO] [stderr] | [INFO] [stderr] 355 | vec.extend(buf[.. len + 1].iter().cloned()); [INFO] [stderr] | ^^^^^^^^^^ help: use: `..=len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/c_str.rs:401:5 [INFO] [stderr] | [INFO] [stderr] 401 | / pub fn from_str(s: &str) -> Result { [INFO] [stderr] 402 | | CStrBuf::from_iter(s.as_bytes().iter().cloned()) [INFO] [stderr] 403 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/bench.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `c_string`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/tests.rs:29:14 [INFO] [stderr] | [INFO] [stderr] 29 | for i in (0 .. len) { [INFO] [stderr] | ^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `expected` [INFO] [stderr] --> tests/tests.rs:29:14 [INFO] [stderr] | [INFO] [stderr] 29 | for i in (0 .. len) { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 29 | for (i, ) in expected.iter().enumerate().take(len) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> tests/tests.rs:30:30 [INFO] [stderr] | [INFO] [stderr] 30 | let byte = unsafe { *buf.offset(i as isize) as u8 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `buf.add(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> tests/tests.rs:33:26 [INFO] [stderr] | [INFO] [stderr] 33 | let term = unsafe { *buf.offset(len as isize) as u8 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `buf.add(len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> tests/tests.rs:41:6 [INFO] [stderr] | [INFO] [stderr] 41 | *dup.offset(len as isize) = 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dup.add(len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "9dcf2b57d82ad3c1ee2da8fa62edfed6217fa5593c08f91bc1638217ca95cbfd"` [INFO] running `"docker" "rm" "-f" "9dcf2b57d82ad3c1ee2da8fa62edfed6217fa5593c08f91bc1638217ca95cbfd"` [INFO] [stdout] 9dcf2b57d82ad3c1ee2da8fa62edfed6217fa5593c08f91bc1638217ca95cbfd