[INFO] crate c_str_macro 1.0.2 is already in cache [INFO] extracting crate c_str_macro 1.0.2 into work/ex/clippy-test-run/sources/stable/reg/c_str_macro/1.0.2 [INFO] extracting crate c_str_macro 1.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/c_str_macro/1.0.2 [INFO] validating manifest of c_str_macro-1.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of c_str_macro-1.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing c_str_macro-1.0.2 [INFO] finished frobbing c_str_macro-1.0.2 [INFO] frobbed toml for c_str_macro-1.0.2 written to work/ex/clippy-test-run/sources/stable/reg/c_str_macro/1.0.2/Cargo.toml [INFO] started frobbing c_str_macro-1.0.2 [INFO] finished frobbing c_str_macro-1.0.2 [INFO] frobbed toml for c_str_macro-1.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/c_str_macro/1.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting c_str_macro-1.0.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/c_str_macro/1.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 10d984262f4b61dff91f56e286089eef94834449e281f39d3b032d21f23ece7e [INFO] running `"docker" "start" "-a" "10d984262f4b61dff91f56e286089eef94834449e281f39d3b032d21f23ece7e"` [INFO] [stderr] Checking c_str_macro v1.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: the loop variable `i` is used to index `expected` [INFO] [stderr] --> tests/tests.rs:19:14 [INFO] [stderr] | [INFO] [stderr] 19 | for i in 0 .. len { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 19 | for (i, ) in expected.iter().enumerate().take(len) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> tests/tests.rs:20:30 [INFO] [stderr] | [INFO] [stderr] 20 | let byte = unsafe { *buf.offset(i as isize) as u8 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `buf.add(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> tests/tests.rs:23:26 [INFO] [stderr] | [INFO] [stderr] 23 | let term = unsafe { *buf.offset(len as isize) as u8 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `buf.add(len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.19s [INFO] running `"docker" "inspect" "10d984262f4b61dff91f56e286089eef94834449e281f39d3b032d21f23ece7e"` [INFO] running `"docker" "rm" "-f" "10d984262f4b61dff91f56e286089eef94834449e281f39d3b032d21f23ece7e"` [INFO] [stdout] 10d984262f4b61dff91f56e286089eef94834449e281f39d3b032d21f23ece7e