[INFO] crate c4 0.1.0 is already in cache [INFO] extracting crate c4 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/c4/0.1.0 [INFO] extracting crate c4 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/c4/0.1.0 [INFO] validating manifest of c4-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of c4-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing c4-0.1.0 [INFO] finished frobbing c4-0.1.0 [INFO] frobbed toml for c4-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/c4/0.1.0/Cargo.toml [INFO] started frobbing c4-0.1.0 [INFO] finished frobbing c4-0.1.0 [INFO] frobbed toml for c4-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/c4/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting c4-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/c4/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 65650f817d5758bdb5be45c43dc1da09e3c97fc25110f109f3ab2ca9b4ca63ff [INFO] running `"docker" "start" "-a" "65650f817d5758bdb5be45c43dc1da09e3c97fc25110f109f3ab2ca9b4ca63ff"` [INFO] [stderr] Checking c4 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/generated.rs:599:20 [INFO] [stderr] | [INFO] [stderr] 599 | Err(ParseError{line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/generated.rs:599:20 [INFO] [stderr] | [INFO] [stderr] 599 | Err(ParseError{line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/generated.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | return (lineno, remaining + 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(lineno, remaining + 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `Value` [INFO] [stderr] --> src/parser/mod.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | pub enum Value { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_vec` [INFO] [stderr] --> src/parser/mod.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn from_vec(v: Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_str` [INFO] [stderr] --> src/parser/mod.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn from_str(s: &str) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_string` [INFO] [stderr] --> src/parser/mod.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn from_string(s: &String) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Property` [INFO] [stderr] --> src/parser/mod.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | struct Property { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/parser/mod.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn new(_id: String, _value: Value) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Rule` [INFO] [stderr] --> src/parser/mod.rs:35:1 [INFO] [stderr] | [INFO] [stderr] 35 | struct Rule { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Selector` [INFO] [stderr] --> src/parser/mod.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | struct Selector(Vec); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser/generated.rs:28:12 [INFO] [stderr] | [INFO] [stderr] 28 | if self.expected.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.expected.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/parser/generated.rs:185:59 [INFO] [stderr] | [INFO] [stderr] 185 | repeat_value.push(value); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 185 | repeat_value.push(()); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/parser/generated.rs:190:32 [INFO] [stderr] | [INFO] [stderr] 190 | if repeat_value.len() >= 1usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!repeat_value.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/parser/generated.rs:229:49 [INFO] [stderr] | [INFO] [stderr] 229 | Matched(pos, value) => Matched(pos, value), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 229 | Matched(pos, value) => Matched(pos, ()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/parser/generated.rs:257:49 [INFO] [stderr] | [INFO] [stderr] 257 | Matched(pos, value) => Matched(pos, value), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 257 | Matched(pos, value) => Matched(pos, ()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/generated.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | return (lineno, remaining + 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(lineno, remaining + 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/parser/generated.rs:321:61 [INFO] [stderr] | [INFO] [stderr] 321 | Matched(pos, value) => Matched(pos, value), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 321 | Matched(pos, value) => Matched(pos, ()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/parser/generated.rs:391:39 [INFO] [stderr] | [INFO] [stderr] 391 | repeat_value.push(value); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 391 | repeat_value.push(()); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/parser/generated.rs:396:12 [INFO] [stderr] | [INFO] [stderr] 396 | if repeat_value.len() >= 1usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!repeat_value.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/parser/generated.rs:424:49 [INFO] [stderr] | [INFO] [stderr] 424 | Matched(pos, value) => Matched(pos, value), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 424 | Matched(pos, value) => Matched(pos, ()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/parser/generated.rs:479:49 [INFO] [stderr] | [INFO] [stderr] 479 | Matched(pos, value) => Matched(pos, value), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 479 | Matched(pos, value) => Matched(pos, ()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/parser/generated.rs:508:49 [INFO] [stderr] | [INFO] [stderr] 508 | Matched(pos, value) => Matched(pos, value), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 508 | Matched(pos, value) => Matched(pos, ()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/parser/generated.rs:536:71 [INFO] [stderr] | [INFO] [stderr] 536 | repeat_value.push(value); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 536 | repeat_value.push(()); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/parser/generated.rs:541:44 [INFO] [stderr] | [INFO] [stderr] 541 | if repeat_value.len() >= 1usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!repeat_value.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/parser/generated.rs:566:49 [INFO] [stderr] | [INFO] [stderr] 566 | Matched(pos, value) => Matched(pos, value), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 566 | Matched(pos, value) => Matched(pos, ()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/parser/generated.rs:582:39 [INFO] [stderr] | [INFO] [stderr] 582 | repeat_value.push(value); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 582 | repeat_value.push(()); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/parser/generated.rs:587:12 [INFO] [stderr] | [INFO] [stderr] 587 | if repeat_value.len() >= 1usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!repeat_value.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/generated.rs:592:1 [INFO] [stderr] | [INFO] [stderr] 592 | / pub fn file<'input>(input: &'input str) -> ParseResult<()> { [INFO] [stderr] 593 | | let mut state = ParseState::new(); [INFO] [stderr] 594 | | match parse_file(input, &mut state, 0) { [INFO] [stderr] 595 | | Matched(pos, value) => { if pos == input.len() { return Ok(value) } } [INFO] [stderr] ... | [INFO] [stderr] 602 | | expected: state.expected,}) [INFO] [stderr] 603 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser/generated.rs:594:5 [INFO] [stderr] | [INFO] [stderr] 594 | / match parse_file(input, &mut state, 0) { [INFO] [stderr] 595 | | Matched(pos, value) => { if pos == input.len() { return Ok(value) } } [INFO] [stderr] 596 | | _ => { } [INFO] [stderr] 597 | | } [INFO] [stderr] | |_____^ help: try this: `if let Matched(pos, value) = parse_file(input, &mut state, 0) { if pos == input.len() { return Ok(value) } }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/parser/generated.rs:595:68 [INFO] [stderr] | [INFO] [stderr] 595 | Matched(pos, value) => { if pos == input.len() { return Ok(value) } } [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 595 | Matched(pos, value) => { if pos == input.len() { return Ok(()) } } [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/parser/mod.rs:19:27 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn from_string(s: &String) -> Self { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 19 | pub fn from_string(s: &str) -> Self { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `s.clone()` to [INFO] [stderr] | [INFO] [stderr] 20 | Value::Single(s.to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `Value` [INFO] [stderr] --> src/parser/mod.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | pub enum Value { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_vec` [INFO] [stderr] --> src/parser/mod.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn from_vec(v: Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_str` [INFO] [stderr] --> src/parser/mod.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn from_str(s: &str) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_string` [INFO] [stderr] --> src/parser/mod.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn from_string(s: &String) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Property` [INFO] [stderr] --> src/parser/mod.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | struct Property { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/parser/mod.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn new(_id: String, _value: Value) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Rule` [INFO] [stderr] --> src/parser/mod.rs:35:1 [INFO] [stderr] | [INFO] [stderr] 35 | struct Rule { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Selector` [INFO] [stderr] --> src/parser/mod.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | struct Selector(Vec); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser/generated.rs:28:12 [INFO] [stderr] | [INFO] [stderr] 28 | if self.expected.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.expected.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/parser/generated.rs:185:59 [INFO] [stderr] | [INFO] [stderr] 185 | repeat_value.push(value); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 185 | repeat_value.push(()); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/parser/generated.rs:190:32 [INFO] [stderr] | [INFO] [stderr] 190 | if repeat_value.len() >= 1usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!repeat_value.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/parser/generated.rs:229:49 [INFO] [stderr] | [INFO] [stderr] 229 | Matched(pos, value) => Matched(pos, value), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 229 | Matched(pos, value) => Matched(pos, ()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/parser/generated.rs:257:49 [INFO] [stderr] | [INFO] [stderr] 257 | Matched(pos, value) => Matched(pos, value), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 257 | Matched(pos, value) => Matched(pos, ()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/parser/generated.rs:321:61 [INFO] [stderr] | [INFO] [stderr] 321 | Matched(pos, value) => Matched(pos, value), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 321 | Matched(pos, value) => Matched(pos, ()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/parser/generated.rs:391:39 [INFO] [stderr] | [INFO] [stderr] 391 | repeat_value.push(value); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 391 | repeat_value.push(()); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/parser/generated.rs:396:12 [INFO] [stderr] | [INFO] [stderr] 396 | if repeat_value.len() >= 1usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!repeat_value.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/parser/generated.rs:424:49 [INFO] [stderr] | [INFO] [stderr] 424 | Matched(pos, value) => Matched(pos, value), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 424 | Matched(pos, value) => Matched(pos, ()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/parser/generated.rs:479:49 [INFO] [stderr] | [INFO] [stderr] 479 | Matched(pos, value) => Matched(pos, value), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 479 | Matched(pos, value) => Matched(pos, ()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/parser/generated.rs:508:49 [INFO] [stderr] | [INFO] [stderr] 508 | Matched(pos, value) => Matched(pos, value), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 508 | Matched(pos, value) => Matched(pos, ()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/parser/generated.rs:536:71 [INFO] [stderr] | [INFO] [stderr] 536 | repeat_value.push(value); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 536 | repeat_value.push(()); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/parser/generated.rs:541:44 [INFO] [stderr] | [INFO] [stderr] 541 | if repeat_value.len() >= 1usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!repeat_value.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/parser/generated.rs:566:49 [INFO] [stderr] | [INFO] [stderr] 566 | Matched(pos, value) => Matched(pos, value), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 566 | Matched(pos, value) => Matched(pos, ()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/parser/generated.rs:582:39 [INFO] [stderr] | [INFO] [stderr] 582 | repeat_value.push(value); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 582 | repeat_value.push(()); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/parser/generated.rs:587:12 [INFO] [stderr] | [INFO] [stderr] 587 | if repeat_value.len() >= 1usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!repeat_value.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/generated.rs:592:1 [INFO] [stderr] | [INFO] [stderr] 592 | / pub fn file<'input>(input: &'input str) -> ParseResult<()> { [INFO] [stderr] 593 | | let mut state = ParseState::new(); [INFO] [stderr] 594 | | match parse_file(input, &mut state, 0) { [INFO] [stderr] 595 | | Matched(pos, value) => { if pos == input.len() { return Ok(value) } } [INFO] [stderr] ... | [INFO] [stderr] 602 | | expected: state.expected,}) [INFO] [stderr] 603 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser/generated.rs:594:5 [INFO] [stderr] | [INFO] [stderr] 594 | / match parse_file(input, &mut state, 0) { [INFO] [stderr] 595 | | Matched(pos, value) => { if pos == input.len() { return Ok(value) } } [INFO] [stderr] 596 | | _ => { } [INFO] [stderr] 597 | | } [INFO] [stderr] | |_____^ help: try this: `if let Matched(pos, value) = parse_file(input, &mut state, 0) { if pos == input.len() { return Ok(value) } }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/parser/generated.rs:595:68 [INFO] [stderr] | [INFO] [stderr] 595 | Matched(pos, value) => { if pos == input.len() { return Ok(value) } } [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 595 | Matched(pos, value) => { if pos == input.len() { return Ok(()) } } [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/parser/mod.rs:19:27 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn from_string(s: &String) -> Self { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 19 | pub fn from_string(s: &str) -> Self { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `s.clone()` to [INFO] [stderr] | [INFO] [stderr] 20 | Value::Single(s.to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.94s [INFO] running `"docker" "inspect" "65650f817d5758bdb5be45c43dc1da09e3c97fc25110f109f3ab2ca9b4ca63ff"` [INFO] running `"docker" "rm" "-f" "65650f817d5758bdb5be45c43dc1da09e3c97fc25110f109f3ab2ca9b4ca63ff"` [INFO] [stdout] 65650f817d5758bdb5be45c43dc1da09e3c97fc25110f109f3ab2ca9b4ca63ff