[INFO] crate bytebuffer 0.2.1 is already in cache [INFO] extracting crate bytebuffer 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/bytebuffer/0.2.1 [INFO] extracting crate bytebuffer 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bytebuffer/0.2.1 [INFO] validating manifest of bytebuffer-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bytebuffer-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bytebuffer-0.2.1 [INFO] finished frobbing bytebuffer-0.2.1 [INFO] frobbed toml for bytebuffer-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/bytebuffer/0.2.1/Cargo.toml [INFO] started frobbing bytebuffer-0.2.1 [INFO] finished frobbing bytebuffer-0.2.1 [INFO] frobbed toml for bytebuffer-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bytebuffer/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bytebuffer-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bytebuffer/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fcc66ddf6454331d93cae099e713894ed965b2a49e045ec096f8ded6b49102d6 [INFO] running `"docker" "start" "-a" "fcc66ddf6454331d93cae099e713894ed965b2a49e045ec096f8ded6b49102d6"` [INFO] [stderr] Checking bytebuffer v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:388:43 [INFO] [stderr] | [INFO] [stderr] 388 | let bit = self.data[self.rpos] & (1 << 7 - self.rbit) != 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `1 << (7 - self.rbit)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:413:14 [INFO] [stderr] | [INFO] [stderr] 413 | ((if self.read_bit() { 1 } else { 0 }) << n - 1) | self.read_bits(n - 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(if self.read_bit() { 1 } else { 0 }) << (n - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:480:29 [INFO] [stderr] | [INFO] [stderr] 480 | self.write_bit((value >> n - 1) & 1 != 0); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `value >> (n - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:388:43 [INFO] [stderr] | [INFO] [stderr] 388 | let bit = self.data[self.rpos] & (1 << 7 - self.rbit) != 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `1 << (7 - self.rbit)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:413:14 [INFO] [stderr] | [INFO] [stderr] 413 | ((if self.read_bit() { 1 } else { 0 }) << n - 1) | self.read_bits(n - 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(if self.read_bit() { 1 } else { 0 }) << (n - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:480:29 [INFO] [stderr] | [INFO] [stderr] 480 | self.write_bit((value >> n - 1) & 1 != 0); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `value >> (n - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: item `ByteBuffer` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | / impl ByteBuffer { [INFO] [stderr] 16 | | /// Construct a new, empty, ByteBuffer [INFO] [stderr] 17 | | pub fn new() -> ByteBuffer { [INFO] [stderr] 18 | | ByteBuffer { [INFO] [stderr] ... | [INFO] [stderr] 485 | | } [INFO] [stderr] 486 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ByteBuffer` [INFO] [stderr] --> src/lib.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> ByteBuffer { [INFO] [stderr] 18 | | ByteBuffer { [INFO] [stderr] 19 | | data: vec![], [INFO] [stderr] 20 | | wpos: 0, [INFO] [stderr] ... | [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:214:9 [INFO] [stderr] | [INFO] [stderr] 214 | res.write(&self.data[range]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `bytebuffer`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: item `ByteBuffer` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | / impl ByteBuffer { [INFO] [stderr] 16 | | /// Construct a new, empty, ByteBuffer [INFO] [stderr] 17 | | pub fn new() -> ByteBuffer { [INFO] [stderr] 18 | | ByteBuffer { [INFO] [stderr] ... | [INFO] [stderr] 485 | | } [INFO] [stderr] 486 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ByteBuffer` [INFO] [stderr] --> src/lib.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> ByteBuffer { [INFO] [stderr] 18 | | ByteBuffer { [INFO] [stderr] 19 | | data: vec![], [INFO] [stderr] 20 | | wpos: 0, [INFO] [stderr] ... | [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:214:9 [INFO] [stderr] | [INFO] [stderr] 214 | res.write(&self.data[range]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `bytebuffer`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "fcc66ddf6454331d93cae099e713894ed965b2a49e045ec096f8ded6b49102d6"` [INFO] running `"docker" "rm" "-f" "fcc66ddf6454331d93cae099e713894ed965b2a49e045ec096f8ded6b49102d6"` [INFO] [stdout] fcc66ddf6454331d93cae099e713894ed965b2a49e045ec096f8ded6b49102d6