[INFO] crate butlerd 0.1.2 is already in cache [INFO] extracting crate butlerd 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/butlerd/0.1.2 [INFO] extracting crate butlerd 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/butlerd/0.1.2 [INFO] validating manifest of butlerd-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of butlerd-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing butlerd-0.1.2 [INFO] finished frobbing butlerd-0.1.2 [INFO] frobbed toml for butlerd-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/butlerd/0.1.2/Cargo.toml [INFO] started frobbing butlerd-0.1.2 [INFO] finished frobbing butlerd-0.1.2 [INFO] frobbed toml for butlerd-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/butlerd/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting butlerd-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/butlerd/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0a468d305b784b398d550bed2352aa2695aba15137237921b0f4a5fa30ecd905 [INFO] running `"docker" "start" "-a" "0a468d305b784b398d550bed2352aa2695aba15137237921b0f4a5fa30ecd905"` [INFO] [stderr] Checking butlerd v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:141:17 [INFO] [stderr] | [INFO] [stderr] 141 | secret: secret, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `secret` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:141:17 [INFO] [stderr] | [INFO] [stderr] 141 | secret: secret, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `secret` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:495:13 [INFO] [stderr] | [INFO] [stderr] 495 | game: game, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `game` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:496:13 [INFO] [stderr] | [INFO] [stderr] 496 | upload: upload, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `upload` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:495:13 [INFO] [stderr] | [INFO] [stderr] 495 | game: game, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `game` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:496:13 [INFO] [stderr] | [INFO] [stderr] 496 | upload: upload, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `upload` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:660:9 [INFO] [stderr] | [INFO] [stderr] 660 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:659:19 [INFO] [stderr] | [INFO] [stderr] 659 | let res = pres(ris); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:674:9 [INFO] [stderr] | [INFO] [stderr] 674 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:673:19 [INFO] [stderr] | [INFO] [stderr] 673 | let res = parse_r(ris, field); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:678:5 [INFO] [stderr] | [INFO] [stderr] 678 | return String::from(env::home_dir().unwrap().to_str().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from(env::home_dir().unwrap().to_str().unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:696:9 [INFO] [stderr] | [INFO] [stderr] 696 | / return Ok( [INFO] [stderr] 697 | | serde_json::from_str(&serde_json::to_string(&res.unwrap().result).unwrap()).unwrap(), [INFO] [stderr] 698 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 696 | Ok( [INFO] [stderr] 697 | serde_json::from_str(&serde_json::to_string(&res.unwrap().result).unwrap()).unwrap(), [INFO] [stderr] 698 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:702:13 [INFO] [stderr] | [INFO] [stderr] 702 | return Err(err.unwrap().error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(err.unwrap().error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:704:13 [INFO] [stderr] | [INFO] [stderr] 704 | / return Err(BError { [INFO] [stderr] 705 | | message: st, [INFO] [stderr] 706 | | code: -1, [INFO] [stderr] 707 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 704 | Err(BError { [INFO] [stderr] 705 | message: st, [INFO] [stderr] 706 | code: -1, [INFO] [stderr] 707 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:721:13 [INFO] [stderr] | [INFO] [stderr] 721 | return Ok(finish); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(finish)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:723:13 [INFO] [stderr] | [INFO] [stderr] 723 | / return Err(BError { [INFO] [stderr] 724 | | message: "Not Found".to_string(), [INFO] [stderr] 725 | | code: -2, [INFO] [stderr] 726 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 723 | Err(BError { [INFO] [stderr] 724 | message: "Not Found".to_string(), [INFO] [stderr] 725 | code: -2, [INFO] [stderr] 726 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:731:13 [INFO] [stderr] | [INFO] [stderr] 731 | return Err(err.unwrap().error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(err.unwrap().error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:733:13 [INFO] [stderr] | [INFO] [stderr] 733 | / return Err(BError { [INFO] [stderr] 734 | | message: st, [INFO] [stderr] 735 | | code: -1, [INFO] [stderr] 736 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 733 | Err(BError { [INFO] [stderr] 734 | message: st, [INFO] [stderr] 735 | code: -1, [INFO] [stderr] 736 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:660:9 [INFO] [stderr] | [INFO] [stderr] 660 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:659:19 [INFO] [stderr] | [INFO] [stderr] 659 | let res = pres(ris); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:674:9 [INFO] [stderr] | [INFO] [stderr] 674 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:673:19 [INFO] [stderr] | [INFO] [stderr] 673 | let res = parse_r(ris, field); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:678:5 [INFO] [stderr] | [INFO] [stderr] 678 | return String::from(env::home_dir().unwrap().to_str().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from(env::home_dir().unwrap().to_str().unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:696:9 [INFO] [stderr] | [INFO] [stderr] 696 | / return Ok( [INFO] [stderr] 697 | | serde_json::from_str(&serde_json::to_string(&res.unwrap().result).unwrap()).unwrap(), [INFO] [stderr] 698 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 696 | Ok( [INFO] [stderr] 697 | serde_json::from_str(&serde_json::to_string(&res.unwrap().result).unwrap()).unwrap(), [INFO] [stderr] 698 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:702:13 [INFO] [stderr] | [INFO] [stderr] 702 | return Err(err.unwrap().error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(err.unwrap().error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:704:13 [INFO] [stderr] | [INFO] [stderr] 704 | / return Err(BError { [INFO] [stderr] 705 | | message: st, [INFO] [stderr] 706 | | code: -1, [INFO] [stderr] 707 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 704 | Err(BError { [INFO] [stderr] 705 | message: st, [INFO] [stderr] 706 | code: -1, [INFO] [stderr] 707 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:721:13 [INFO] [stderr] | [INFO] [stderr] 721 | return Ok(finish); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(finish)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:723:13 [INFO] [stderr] | [INFO] [stderr] 723 | / return Err(BError { [INFO] [stderr] 724 | | message: "Not Found".to_string(), [INFO] [stderr] 725 | | code: -2, [INFO] [stderr] 726 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 723 | Err(BError { [INFO] [stderr] 724 | message: "Not Found".to_string(), [INFO] [stderr] 725 | code: -2, [INFO] [stderr] 726 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:731:13 [INFO] [stderr] | [INFO] [stderr] 731 | return Err(err.unwrap().error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(err.unwrap().error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:733:13 [INFO] [stderr] | [INFO] [stderr] 733 | / return Err(BError { [INFO] [stderr] 734 | | message: st, [INFO] [stderr] 735 | | code: -1, [INFO] [stderr] 736 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 733 | Err(BError { [INFO] [stderr] 734 | message: st, [INFO] [stderr] 735 | code: -1, [INFO] [stderr] 736 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:678:25 [INFO] [stderr] | [INFO] [stderr] 678 | return String::from(env::home_dir().unwrap().to_str().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::thread::sleep_ms': replaced by `std::thread::sleep` [INFO] [stderr] --> src/lib.rs:100:17 [INFO] [stderr] | [INFO] [stderr] 100 | ::std::thread::sleep_ms(250); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::thread::sleep_ms': replaced by `std::thread::sleep` [INFO] [stderr] --> src/lib.rs:546:13 [INFO] [stderr] | [INFO] [stderr] 546 | ::std::thread::sleep_ms(1000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:678:25 [INFO] [stderr] | [INFO] [stderr] 678 | return String::from(env::home_dir().unwrap().to_str().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::thread::sleep_ms': replaced by `std::thread::sleep` [INFO] [stderr] --> src/lib.rs:100:17 [INFO] [stderr] | [INFO] [stderr] 100 | ::std::thread::sleep_ms(250); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::thread::sleep_ms': replaced by `std::thread::sleep` [INFO] [stderr] --> src/lib.rs:546:13 [INFO] [stderr] | [INFO] [stderr] 546 | ::std::thread::sleep_ms(1000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `file` is never read [INFO] [stderr] --> src/lib.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | file = fs::File::create(log_path).unwrap(); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `b` is never read [INFO] [stderr] --> src/lib.rs:652:17 [INFO] [stderr] | [INFO] [stderr] 652 | let mut b = String::new(); [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `b` is never read [INFO] [stderr] --> src/lib.rs:666:17 [INFO] [stderr] | [INFO] [stderr] 666 | let mut b = String::new(); [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `file` is never read [INFO] [stderr] --> src/lib.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | file = fs::File::create(log_path).unwrap(); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `b` is never read [INFO] [stderr] --> src/lib.rs:652:17 [INFO] [stderr] | [INFO] [stderr] 652 | let mut b = String::new(); [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `b` is never read [INFO] [stderr] --> src/lib.rs:666:17 [INFO] [stderr] | [INFO] [stderr] 666 | let mut b = String::new(); [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: variant `i386` should have a camel case name such as `I386` [INFO] [stderr] --> src/Responses.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | i386, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant `i386` should have a camel case name such as `I386` [INFO] [stderr] --> src/Responses.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | i386, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `hyper::client::ResponseFuture` that must be used [INFO] [stderr] --> src/lib.rs:543:9 [INFO] [stderr] | [INFO] [stderr] 543 | self.hclient.request(request); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: futures do nothing unless polled [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:652:9 [INFO] [stderr] | [INFO] [stderr] 652 | / let mut b = String::new(); [INFO] [stderr] 653 | | if body.len() < 1 { [INFO] [stderr] 654 | | b = "{}".to_string(); [INFO] [stderr] 655 | | } else { [INFO] [stderr] 656 | | b = serde_json::to_string(&mp(body)).unwrap(); [INFO] [stderr] 657 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let b = if body.len() < 1 { "{}".to_string() } else { serde_json::to_string(&mp(body)).unwrap() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib.rs:653:12 [INFO] [stderr] | [INFO] [stderr] 653 | if body.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `body.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:666:9 [INFO] [stderr] | [INFO] [stderr] 666 | / let mut b = String::new(); [INFO] [stderr] 667 | | if body.len() < 1 { [INFO] [stderr] 668 | | b = "{}".to_string(); [INFO] [stderr] 669 | | } else { [INFO] [stderr] 670 | | b = serde_json::to_string(&mp(body)).unwrap(); [INFO] [stderr] 671 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let b = if body.len() < 1 { "{}".to_string() } else { serde_json::to_string(&mp(body)).unwrap() };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib.rs:667:12 [INFO] [stderr] | [INFO] [stderr] 667 | if body.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `body.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unused `hyper::client::ResponseFuture` that must be used [INFO] [stderr] --> src/lib.rs:543:9 [INFO] [stderr] | [INFO] [stderr] 543 | self.hclient.request(request); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: futures do nothing unless polled [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:652:9 [INFO] [stderr] | [INFO] [stderr] 652 | / let mut b = String::new(); [INFO] [stderr] 653 | | if body.len() < 1 { [INFO] [stderr] 654 | | b = "{}".to_string(); [INFO] [stderr] 655 | | } else { [INFO] [stderr] 656 | | b = serde_json::to_string(&mp(body)).unwrap(); [INFO] [stderr] 657 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let b = if body.len() < 1 { "{}".to_string() } else { serde_json::to_string(&mp(body)).unwrap() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib.rs:653:12 [INFO] [stderr] | [INFO] [stderr] 653 | if body.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `body.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:666:9 [INFO] [stderr] | [INFO] [stderr] 666 | / let mut b = String::new(); [INFO] [stderr] 667 | | if body.len() < 1 { [INFO] [stderr] 668 | | b = "{}".to_string(); [INFO] [stderr] 669 | | } else { [INFO] [stderr] 670 | | b = serde_json::to_string(&mp(body)).unwrap(); [INFO] [stderr] 671 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let b = if body.len() < 1 { "{}".to_string() } else { serde_json::to_string(&mp(body)).unwrap() };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib.rs:667:12 [INFO] [stderr] | [INFO] [stderr] 667 | if body.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `body.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/lib.rs:13:21 [INFO] [stderr] | [INFO] [stderr] 13 | const SSN_ID: i32 = 248620; [INFO] [stderr] | ^^^^^^ help: consider: `248_620` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/lib.rs:14:20 [INFO] [stderr] | [INFO] [stderr] 14 | const SOL_H: i32 = 283483; [INFO] [stderr] | ^^^^^^ help: consider: `283_483` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/lib.rs:15:22 [INFO] [stderr] | [INFO] [stderr] 15 | const LOCALH : i32 = 167215; [INFO] [stderr] | ^^^^^^ help: consider: `167_215` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/lib.rs:26:35 [INFO] [stderr] | [INFO] [stderr] 26 | let game = but.fetch_game(248620).unwrap(); [INFO] [stderr] | ^^^^^^ help: consider: `248_620` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/lib.rs:28:20 [INFO] [stderr] | [INFO] [stderr] 28 | assert_eq!(248620, game.id); [INFO] [stderr] | ^^^^^^ help: consider: `248_620` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> tests/lib.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | but.login_api_key(&key.unwrap().into_string().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/lib.rs:67:17 [INFO] [stderr] | [INFO] [stderr] 67 | assert!(locations.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!locations.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/lib.rs:75:17 [INFO] [stderr] | [INFO] [stderr] 75 | assert!(uploads.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!uploads.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> tests/lib.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | but.check_update(vec!["e97cd944-386d-4c6c-b1e9-76a3175f4ca9".to_string()]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 19.85s [INFO] running `"docker" "inspect" "0a468d305b784b398d550bed2352aa2695aba15137237921b0f4a5fa30ecd905"` [INFO] running `"docker" "rm" "-f" "0a468d305b784b398d550bed2352aa2695aba15137237921b0f4a5fa30ecd905"` [INFO] [stdout] 0a468d305b784b398d550bed2352aa2695aba15137237921b0f4a5fa30ecd905