[INFO] crate bus_writer 0.1.2 is already in cache [INFO] extracting crate bus_writer 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/bus_writer/0.1.2 [INFO] extracting crate bus_writer 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bus_writer/0.1.2 [INFO] validating manifest of bus_writer-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bus_writer-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bus_writer-0.1.2 [INFO] finished frobbing bus_writer-0.1.2 [INFO] frobbed toml for bus_writer-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/bus_writer/0.1.2/Cargo.toml [INFO] started frobbing bus_writer-0.1.2 [INFO] finished frobbing bus_writer-0.1.2 [INFO] frobbed toml for bus_writer-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bus_writer/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bus_writer-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bus_writer/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 74eaa1e523354bcaa65e0b54e913ae9613f5da8cb0e0bf74d3f910268eeffe5a [INFO] running `"docker" "start" "-a" "74eaa1e523354bcaa65e0b54e913ae9613f5da8cb0e0bf74d3f910268eeffe5a"` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] Checking bus v2.0.1 [INFO] [stderr] Checking bus_writer v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the slice [INFO] [stderr] --> src/writer.rs:100:50 [INFO] [stderr] | [INFO] [stderr] 100 | for (id, mut device) in destinations.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the slice [INFO] [stderr] --> src/verifier.rs:100:50 [INFO] [stderr] | [INFO] [stderr] 100 | for (id, mut device) in destinations.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the slice [INFO] [stderr] --> src/writer.rs:100:50 [INFO] [stderr] | [INFO] [stderr] 100 | for (id, mut device) in destinations.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the slice [INFO] [stderr] --> src/verifier.rs:100:50 [INFO] [stderr] | [INFO] [stderr] 100 | for (id, mut device) in destinations.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: unused import: `BufReader` [INFO] [stderr] --> examples/simple.rs:4:15 [INFO] [stderr] | [INFO] [stderr] 4 | use std::io::{BufReader, Cursor, Read}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `File` [INFO] [stderr] --> examples/simple.rs:5:21 [INFO] [stderr] | [INFO] [stderr] 5 | use std::fs::{self, File}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Read` [INFO] [stderr] --> examples/simple.rs:4:34 [INFO] [stderr] | [INFO] [stderr] 4 | use std::io::{BufReader, Cursor, Read}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> examples/simple.rs:9:48 [INFO] [stderr] | [INFO] [stderr] 9 | let data: Vec = [0u8; 1024 * 1024 * 5].into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> examples/simple.rs:10:37 [INFO] [stderr] | [INFO] [stderr] 10 | .zip([1u8; 1024 * 1024 * 5].into_iter()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> tests/writer.rs:9:48 [INFO] [stderr] | [INFO] [stderr] 9 | let data: Vec = [0u8; 1024 * 1024 * 5].into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> tests/writer.rs:10:37 [INFO] [stderr] | [INFO] [stderr] 10 | .zip([1u8; 1024 * 1024 * 5].into_iter()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1024` [INFO] [stderr] --> tests/writer.rs:13:34 [INFO] [stderr] | [INFO] [stderr] 13 | .fold(Vec::with_capacity(1 * 1024 * 1024), |mut acc, (&x, &y)| { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.75s [INFO] running `"docker" "inspect" "74eaa1e523354bcaa65e0b54e913ae9613f5da8cb0e0bf74d3f910268eeffe5a"` [INFO] running `"docker" "rm" "-f" "74eaa1e523354bcaa65e0b54e913ae9613f5da8cb0e0bf74d3f910268eeffe5a"` [INFO] [stdout] 74eaa1e523354bcaa65e0b54e913ae9613f5da8cb0e0bf74d3f910268eeffe5a