[INFO] crate burgundy 0.3.3 is already in cache [INFO] extracting crate burgundy 0.3.3 into work/ex/clippy-test-run/sources/stable/reg/burgundy/0.3.3 [INFO] extracting crate burgundy 0.3.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/burgundy/0.3.3 [INFO] validating manifest of burgundy-0.3.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of burgundy-0.3.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing burgundy-0.3.3 [INFO] finished frobbing burgundy-0.3.3 [INFO] frobbed toml for burgundy-0.3.3 written to work/ex/clippy-test-run/sources/stable/reg/burgundy/0.3.3/Cargo.toml [INFO] started frobbing burgundy-0.3.3 [INFO] finished frobbing burgundy-0.3.3 [INFO] frobbed toml for burgundy-0.3.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/burgundy/0.3.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting burgundy-0.3.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/burgundy/0.3.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 54d7afa088dd5f992c43ce5690acfe18f472375ad8bf22a2c537a86d8fd4097f [INFO] running `"docker" "start" "-a" "54d7afa088dd5f992c43ce5690acfe18f472375ad8bf22a2c537a86d8fd4097f"` [INFO] [stderr] Checking burgundy v0.3.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/request_information/headers.rs:21:16 [INFO] [stderr] | [INFO] [stderr] 21 | if let None = self.headers { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 22 | | self.headers = Some(Vec::new()); [INFO] [stderr] 23 | | } [INFO] [stderr] | |_________- help: try this: `if self.headers.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/request_information/query_builder.rs:36:12 [INFO] [stderr] | [INFO] [stderr] 36 | if query_str.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!query_str.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/request_information/query_builder.rs:55:12 [INFO] [stderr] | [INFO] [stderr] 55 | if query_str.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!query_str.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/request_information/query_builder.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | if let None = self.contents { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 66 | | let query = String::with_capacity(QUERY_STRING_START_SIZE); [INFO] [stderr] 67 | | self.contents = Some(query); [INFO] [stderr] 68 | | } [INFO] [stderr] | |_________- help: try this: `if self.contents.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/path.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | self.info.push_path_part(next); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/path.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | self.info.push_path_part_partial(next); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/path.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | self.info.add_query_param(key, value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/path.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | / match maybe_body { [INFO] [stderr] 97 | | Some(body) => { [INFO] [stderr] 98 | | match self.method { [INFO] [stderr] 99 | | method::Method::Get => { [INFO] [stderr] ... | [INFO] [stderr] 110 | | _ => {}, [INFO] [stderr] 111 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 96 | if let Some(body) = maybe_body { [INFO] [stderr] 97 | match self.method { [INFO] [stderr] 98 | method::Method::Get => { [INFO] [stderr] 99 | self.info.add_query_blob(body)?; [INFO] [stderr] 100 | }, [INFO] [stderr] 101 | _ => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/request_information/headers.rs:21:16 [INFO] [stderr] | [INFO] [stderr] 21 | if let None = self.headers { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 22 | | self.headers = Some(Vec::new()); [INFO] [stderr] 23 | | } [INFO] [stderr] | |_________- help: try this: `if self.headers.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/request_information/query_builder.rs:36:12 [INFO] [stderr] | [INFO] [stderr] 36 | if query_str.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!query_str.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/request_information/query_builder.rs:55:12 [INFO] [stderr] | [INFO] [stderr] 55 | if query_str.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!query_str.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/request_information/query_builder.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | if let None = self.contents { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 66 | | let query = String::with_capacity(QUERY_STRING_START_SIZE); [INFO] [stderr] 67 | | self.contents = Some(query); [INFO] [stderr] 68 | | } [INFO] [stderr] | |_________- help: try this: `if self.contents.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/request_information/query_builder.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | query.add(&"key", &"value"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/request_information/query_builder.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | query.add(&"key", &"value"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/request_information/query_builder.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | query.add(&"donkeyfy", &true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/request_information/query_builder.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | query.add(&"num_cats", &123); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/request_information/query_builder.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | query.add_blob(&blob); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/request_information/query_builder.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | query.add(&"donkeyfy", &true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/request_information/query_builder.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | query.add_blob(&blob); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/request_information/query_builder.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | query.add(&"num_cats", &123); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/path.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | self.info.push_path_part(next); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/path.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | self.info.push_path_part_partial(next); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/path.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | self.info.add_query_param(key, value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/path.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | / match maybe_body { [INFO] [stderr] 97 | | Some(body) => { [INFO] [stderr] 98 | | match self.method { [INFO] [stderr] 99 | | method::Method::Get => { [INFO] [stderr] ... | [INFO] [stderr] 110 | | _ => {}, [INFO] [stderr] 111 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 96 | if let Some(body) = maybe_body { [INFO] [stderr] 97 | match self.method { [INFO] [stderr] 98 | method::Method::Get => { [INFO] [stderr] 99 | self.info.add_query_blob(body)?; [INFO] [stderr] 100 | }, [INFO] [stderr] 101 | _ => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/domain.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | domain.query(&"type", &"donkeys"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/domain.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | domain.query(&"type", &"donkeys"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Github` [INFO] [stderr] --> examples/github.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> Self { [INFO] [stderr] 12 | | let mut domain = burgundy::Domain::new("https://api.github.com"); [INFO] [stderr] 13 | | domain.header( [INFO] [stderr] 14 | | &"User-Agent", [INFO] [stderr] ... | [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | impl Default for Github { [INFO] [stderr] 11 | fn default() -> Self { [INFO] [stderr] 12 | Self::new() [INFO] [stderr] 13 | } [INFO] [stderr] 14 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 15.16s [INFO] running `"docker" "inspect" "54d7afa088dd5f992c43ce5690acfe18f472375ad8bf22a2c537a86d8fd4097f"` [INFO] running `"docker" "rm" "-f" "54d7afa088dd5f992c43ce5690acfe18f472375ad8bf22a2c537a86d8fd4097f"` [INFO] [stdout] 54d7afa088dd5f992c43ce5690acfe18f472375ad8bf22a2c537a86d8fd4097f