[INFO] crate bundler 0.1.1 is already in cache [INFO] extracting crate bundler 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/bundler/0.1.1 [INFO] extracting crate bundler 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bundler/0.1.1 [INFO] validating manifest of bundler-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bundler-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bundler-0.1.1 [INFO] finished frobbing bundler-0.1.1 [INFO] frobbed toml for bundler-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/bundler/0.1.1/Cargo.toml [INFO] started frobbing bundler-0.1.1 [INFO] finished frobbing bundler-0.1.1 [INFO] frobbed toml for bundler-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bundler/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bundler-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bundler/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 820b5b2b0aaf5c0467521d51b5a7be75bc6131eb54f9418da14d992c0eebea04 [INFO] running `"docker" "start" "-a" "820b5b2b0aaf5c0467521d51b5a7be75bc6131eb54f9418da14d992c0eebea04"` [INFO] [stderr] Compiling serde v1.0.85 [INFO] [stderr] Compiling rustfmt v0.10.0 [INFO] [stderr] Checking difference v0.4.1 [INFO] [stderr] Checking strings v0.1.1 [INFO] [stderr] Checking syn v0.13.11 [INFO] [stderr] Checking goldenfile v0.5.1 [INFO] [stderr] Checking syntex_pos v0.59.1 [INFO] [stderr] Checking serde_json v1.0.37 [INFO] [stderr] Checking extprim v1.6.0 [INFO] [stderr] Checking toml v0.4.10 [INFO] [stderr] Checking syntex_errors v0.59.1 [INFO] [stderr] Checking syntex_syntax v0.59.1 [INFO] [stderr] Checking bundler v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:165:12 [INFO] [stderr] | [INFO] [stderr] 165 | if item.ident.to_string() == crate_name { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `*item.ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:174:12 [INFO] [stderr] | [INFO] [stderr] 174 | if el.value().ident.to_string() == segment { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*el.value().ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:184:16 [INFO] [stderr] | [INFO] [stderr] 184 | if path.ident.to_string() == first_segment { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `*path.ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:203:9 [INFO] [stderr] | [INFO] [stderr] 203 | let ref buf = result.1.first().expect("rustfmt returned no code").1; [INFO] [stderr] | ----^^^^^^^--------------------------------------------------------- help: try: `let buf = &result.1.first().expect("rustfmt returned no code").1;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:165:12 [INFO] [stderr] | [INFO] [stderr] 165 | if item.ident.to_string() == crate_name { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `*item.ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:174:12 [INFO] [stderr] | [INFO] [stderr] 174 | if el.value().ident.to_string() == segment { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*el.value().ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:184:16 [INFO] [stderr] | [INFO] [stderr] 184 | if path.ident.to_string() == first_segment { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `*path.ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:203:9 [INFO] [stderr] | [INFO] [stderr] 203 | let ref buf = result.1.first().expect("rustfmt returned no code").1; [INFO] [stderr] | ----^^^^^^^--------------------------------------------------------- help: try: `let buf = &result.1.first().expect("rustfmt returned no code").1;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/golden.rs:10:19 [INFO] [stderr] | [INFO] [stderr] 10 | const INPUT_DIR: &'static str = "tests/testdata/input"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/golden.rs:11:20 [INFO] [stderr] | [INFO] [stderr] 11 | const OUTPUT_DIR: &'static str = "tests/testdata/output"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 03s [INFO] running `"docker" "inspect" "820b5b2b0aaf5c0467521d51b5a7be75bc6131eb54f9418da14d992c0eebea04"` [INFO] running `"docker" "rm" "-f" "820b5b2b0aaf5c0467521d51b5a7be75bc6131eb54f9418da14d992c0eebea04"` [INFO] [stdout] 820b5b2b0aaf5c0467521d51b5a7be75bc6131eb54f9418da14d992c0eebea04