[INFO] crate build_details 0.1.2 is already in cache [INFO] extracting crate build_details 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/build_details/0.1.2 [INFO] extracting crate build_details 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/build_details/0.1.2 [INFO] validating manifest of build_details-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of build_details-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing build_details-0.1.2 [INFO] finished frobbing build_details-0.1.2 [INFO] frobbed toml for build_details-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/build_details/0.1.2/Cargo.toml [INFO] started frobbing build_details-0.1.2 [INFO] finished frobbing build_details-0.1.2 [INFO] frobbed toml for build_details-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/build_details/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting build_details-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/build_details/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] af88a7207ea0937ef39dc0229e057a831440748f0dab991303ec479568a8e4b3 [INFO] running `"docker" "start" "-a" "af88a7207ea0937ef39dc0229e057a831440748f0dab991303ec479568a8e4b3"` [INFO] [stderr] Checking phf_generator v0.7.24 [INFO] [stderr] Checking phf_codegen v0.7.24 [INFO] [stderr] Checking build_details v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:456:13 [INFO] [stderr] | [INFO] [stderr] 456 | write!(txt, " {:?},\n", item)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:456:13 [INFO] [stderr] | [INFO] [stderr] 456 | write!(txt, " {:?},\n", item)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:331:24 [INFO] [stderr] | [INFO] [stderr] 331 | None => Ok(format!("None")), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"None".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/lib.rs:346:5 [INFO] [stderr] | [INFO] [stderr] 346 | / pub fn new() -> Detail> { [INFO] [stderr] 347 | | // TODO: Touch build.rs to trigger a rebuild every time [INFO] [stderr] 348 | | [INFO] [stderr] 349 | | let secs = SystemTime::now() [INFO] [stderr] ... | [INFO] [stderr] 359 | | } [INFO] [stderr] 360 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:331:24 [INFO] [stderr] | [INFO] [stderr] 331 | None => Ok(format!("None")), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"None".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/lib.rs:346:5 [INFO] [stderr] | [INFO] [stderr] 346 | / pub fn new() -> Detail> { [INFO] [stderr] 347 | | // TODO: Touch build.rs to trigger a rebuild every time [INFO] [stderr] 348 | | [INFO] [stderr] 349 | | let secs = SystemTime::now() [INFO] [stderr] ... | [INFO] [stderr] 359 | | } [INFO] [stderr] 360 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.53s [INFO] running `"docker" "inspect" "af88a7207ea0937ef39dc0229e057a831440748f0dab991303ec479568a8e4b3"` [INFO] running `"docker" "rm" "-f" "af88a7207ea0937ef39dc0229e057a831440748f0dab991303ec479568a8e4b3"` [INFO] [stdout] af88a7207ea0937ef39dc0229e057a831440748f0dab991303ec479568a8e4b3