[INFO] crate build_compile 0.2.0 is already in cache [INFO] extracting crate build_compile 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/build_compile/0.2.0 [INFO] extracting crate build_compile 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/build_compile/0.2.0 [INFO] validating manifest of build_compile-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of build_compile-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing build_compile-0.2.0 [INFO] finished frobbing build_compile-0.2.0 [INFO] frobbed toml for build_compile-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/build_compile/0.2.0/Cargo.toml [INFO] started frobbing build_compile-0.2.0 [INFO] finished frobbing build_compile-0.2.0 [INFO] frobbed toml for build_compile-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/build_compile/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting build_compile-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/build_compile/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 74b9b8f9cb12d50ba2fa38eaa09eabe04dfa44f9c8e09af3d94d2acdb6ff51c6 [INFO] running `"docker" "start" "-a" "74b9b8f9cb12d50ba2fa38eaa09eabe04dfa44f9c8e09af3d94d2acdb6ff51c6"` [INFO] [stderr] Checking build_compile v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/filetext.rs:33:20 [INFO] [stderr] | [INFO] [stderr] 33 | FileText { path: path, input_str: input_str, newlines: newline_indices } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/filetext.rs:33:32 [INFO] [stderr] | [INFO] [stderr] 33 | FileText { path: path, input_str: input_str, newlines: newline_indices } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/filetext.rs:33:20 [INFO] [stderr] | [INFO] [stderr] 33 | FileText { path: path, input_str: input_str, newlines: newline_indices } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/filetext.rs:33:32 [INFO] [stderr] | [INFO] [stderr] 33 | FileText { path: path, input_str: input_str, newlines: newline_indices } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/filetext.rs:26:61 [INFO] [stderr] | [INFO] [stderr] 26 | .filter(|&(_, &b)| b == ('\n' as u8)) [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/filetext.rs:95:37 [INFO] [stderr] | [INFO] [stderr] 95 | let line_strs: Vec<_> = (start_line..end_line+1).map(|i| self.line_text(i)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(start_line..=end_line)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/filetext.rs:26:61 [INFO] [stderr] | [INFO] [stderr] 26 | .filter(|&(_, &b)| b == ('\n' as u8)) [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/filetext.rs:95:37 [INFO] [stderr] | [INFO] [stderr] 95 | let line_strs: Vec<_> = (start_line..end_line+1).map(|i| self.line_text(i)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(start_line..=end_line)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.98s [INFO] running `"docker" "inspect" "74b9b8f9cb12d50ba2fa38eaa09eabe04dfa44f9c8e09af3d94d2acdb6ff51c6"` [INFO] running `"docker" "rm" "-f" "74b9b8f9cb12d50ba2fa38eaa09eabe04dfa44f9c8e09af3d94d2acdb6ff51c6"` [INFO] [stdout] 74b9b8f9cb12d50ba2fa38eaa09eabe04dfa44f9c8e09af3d94d2acdb6ff51c6