[INFO] crate build 0.0.2 is already in cache [INFO] extracting crate build 0.0.2 into work/ex/clippy-test-run/sources/stable/reg/build/0.0.2 [INFO] extracting crate build 0.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/build/0.0.2 [INFO] validating manifest of build-0.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of build-0.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing build-0.0.2 [INFO] finished frobbing build-0.0.2 [INFO] frobbed toml for build-0.0.2 written to work/ex/clippy-test-run/sources/stable/reg/build/0.0.2/Cargo.toml [INFO] started frobbing build-0.0.2 [INFO] finished frobbing build-0.0.2 [INFO] frobbed toml for build-0.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/build/0.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting build-0.0.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/build/0.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 53bf67630ab0b4a1bd88b0a754519ae10afffcbee78283fa083eb62c47b6e707 [INFO] running `"docker" "start" "-a" "53bf67630ab0b4a1bd88b0a754519ae10afffcbee78283fa083eb62c47b6e707"` [INFO] [stderr] Checking build v0.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | attributes: attributes [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attributes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | attributes: attributes [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attributes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:28:21 [INFO] [stderr] | [INFO] [stderr] 28 | return enc.emit_struct_field("attributes", 2usize, |enc| -> _ { (* p_attributes).encode(enc) }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `enc.emit_struct_field("attributes", 2usize, |enc| -> _ { (* p_attributes).encode(enc) })` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | / return BuildDetailAttributes { [INFO] [stderr] 41 | | name: env!("CARGO_PKG_NAME"), [INFO] [stderr] 42 | | version: env!("CARGO_PKG_VERSION"), [INFO] [stderr] 43 | | homepage: env!("CARGO_PKG_HOMEPAGE"), [INFO] [stderr] 44 | | support: env!("CARGO_PKG_AUTHORS"), [INFO] [stderr] 45 | | description: env!("CARGO_PKG_DESCRIPTION") [INFO] [stderr] 46 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 40 | BuildDetailAttributes { [INFO] [stderr] 41 | name: env!("CARGO_PKG_NAME"), [INFO] [stderr] 42 | version: env!("CARGO_PKG_VERSION"), [INFO] [stderr] 43 | homepage: env!("CARGO_PKG_HOMEPAGE"), [INFO] [stderr] 44 | support: env!("CARGO_PKG_AUTHORS"), [INFO] [stderr] 45 | description: env!("CARGO_PKG_DESCRIPTION") [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | / return BuildBody { [INFO] [stderr] 51 | | _type: "build".to_string(), [INFO] [stderr] 52 | | id: 1, [INFO] [stderr] 53 | | attributes: attributes [INFO] [stderr] 54 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 50 | BuildBody { [INFO] [stderr] 51 | _type: "build".to_string(), [INFO] [stderr] 52 | id: 1, [INFO] [stderr] 53 | attributes: attributes [INFO] [stderr] 54 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | / return Build { [INFO] [stderr] 59 | | data: vec![body] [INFO] [stderr] 60 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 58 | Build { [INFO] [stderr] 59 | data: vec![body] [INFO] [stderr] 60 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | return payload; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `payload` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:28:21 [INFO] [stderr] | [INFO] [stderr] 28 | return enc.emit_struct_field("attributes", 2usize, |enc| -> _ { (* p_attributes).encode(enc) }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `enc.emit_struct_field("attributes", 2usize, |enc| -> _ { (* p_attributes).encode(enc) })` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | / return BuildDetailAttributes { [INFO] [stderr] 41 | | name: env!("CARGO_PKG_NAME"), [INFO] [stderr] 42 | | version: env!("CARGO_PKG_VERSION"), [INFO] [stderr] 43 | | homepage: env!("CARGO_PKG_HOMEPAGE"), [INFO] [stderr] 44 | | support: env!("CARGO_PKG_AUTHORS"), [INFO] [stderr] 45 | | description: env!("CARGO_PKG_DESCRIPTION") [INFO] [stderr] 46 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 40 | BuildDetailAttributes { [INFO] [stderr] 41 | name: env!("CARGO_PKG_NAME"), [INFO] [stderr] 42 | version: env!("CARGO_PKG_VERSION"), [INFO] [stderr] 43 | homepage: env!("CARGO_PKG_HOMEPAGE"), [INFO] [stderr] 44 | support: env!("CARGO_PKG_AUTHORS"), [INFO] [stderr] 45 | description: env!("CARGO_PKG_DESCRIPTION") [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | / return BuildBody { [INFO] [stderr] 51 | | _type: "build".to_string(), [INFO] [stderr] 52 | | id: 1, [INFO] [stderr] 53 | | attributes: attributes [INFO] [stderr] 54 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 50 | BuildBody { [INFO] [stderr] 51 | _type: "build".to_string(), [INFO] [stderr] 52 | id: 1, [INFO] [stderr] 53 | attributes: attributes [INFO] [stderr] 54 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | / return Build { [INFO] [stderr] 59 | | data: vec![body] [INFO] [stderr] 60 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 58 | Build { [INFO] [stderr] 59 | data: vec![body] [INFO] [stderr] 60 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | return payload; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `payload` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.78s [INFO] running `"docker" "inspect" "53bf67630ab0b4a1bd88b0a754519ae10afffcbee78283fa083eb62c47b6e707"` [INFO] running `"docker" "rm" "-f" "53bf67630ab0b4a1bd88b0a754519ae10afffcbee78283fa083eb62c47b6e707"` [INFO] [stdout] 53bf67630ab0b4a1bd88b0a754519ae10afffcbee78283fa083eb62c47b6e707