[INFO] crate bufkit-data 0.7.1 is already in cache [INFO] extracting crate bufkit-data 0.7.1 into work/ex/clippy-test-run/sources/stable/reg/bufkit-data/0.7.1 [INFO] extracting crate bufkit-data 0.7.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bufkit-data/0.7.1 [INFO] validating manifest of bufkit-data-0.7.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bufkit-data-0.7.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bufkit-data-0.7.1 [INFO] finished frobbing bufkit-data-0.7.1 [INFO] frobbed toml for bufkit-data-0.7.1 written to work/ex/clippy-test-run/sources/stable/reg/bufkit-data/0.7.1/Cargo.toml [INFO] started frobbing bufkit-data-0.7.1 [INFO] finished frobbing bufkit-data-0.7.1 [INFO] frobbed toml for bufkit-data-0.7.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bufkit-data/0.7.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bufkit-data-0.7.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bufkit-data/0.7.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4eb2d2372288fcc5fd43de49967eaa0bdabf6b2a996b270bc5bc66136f183758 [INFO] running `"docker" "start" "-a" "4eb2d2372288fcc5fd43de49967eaa0bdabf6b2a996b270bc5bc66136f183758"` [INFO] [stderr] Checking metfor v0.4.1 [INFO] [stderr] Checking optional v0.5.0 [INFO] [stderr] Compiling syn v0.15.26 [INFO] [stderr] Checking rusqlite v0.15.0 [INFO] [stderr] Checking sounding-base v0.8.1 [INFO] [stderr] Checking sounding-analysis v0.9.3 [INFO] [stderr] Checking sounding-bufkit v0.9.1 [INFO] [stderr] Compiling strum_macros v0.11.0 [INFO] [stderr] Checking bufkit-data v0.7.1 (/opt/crater/workdir) [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/archive.rs:105:10 [INFO] [stderr] | [INFO] [stderr] 105 | ) -> Result<(JoinHandle>, Receiver), BufkitDataErr> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/archive.rs:105:10 [INFO] [stderr] | [INFO] [stderr] 105 | ) -> Result<(JoinHandle>, Receiver), BufkitDataErr> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/archive.rs:777:21 [INFO] [stderr] | [INFO] [stderr] 777 | assert!(test_sites.iter().find(|st| **st == site).is_some()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|st| **st == site).is_some()` with `any(|st| **st == site)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 15.51s [INFO] running `"docker" "inspect" "4eb2d2372288fcc5fd43de49967eaa0bdabf6b2a996b270bc5bc66136f183758"` [INFO] running `"docker" "rm" "-f" "4eb2d2372288fcc5fd43de49967eaa0bdabf6b2a996b270bc5bc66136f183758"` [INFO] [stdout] 4eb2d2372288fcc5fd43de49967eaa0bdabf6b2a996b270bc5bc66136f183758