[INFO] crate buffoon 0.5.0 is already in cache [INFO] extracting crate buffoon 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/buffoon/0.5.0 [INFO] extracting crate buffoon 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/buffoon/0.5.0 [INFO] validating manifest of buffoon-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of buffoon-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing buffoon-0.5.0 [INFO] finished frobbing buffoon-0.5.0 [INFO] frobbed toml for buffoon-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/buffoon/0.5.0/Cargo.toml [INFO] started frobbing buffoon-0.5.0 [INFO] finished frobbing buffoon-0.5.0 [INFO] frobbed toml for buffoon-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/buffoon/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting buffoon-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/buffoon/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c7b2675c578cc9d0c03b42324c0d0ec4abafa8bcd170854ec33258f3ad39095e [INFO] running `"docker" "start" "-a" "c7b2675c578cc9d0c03b42324c0d0ec4abafa8bcd170854ec33258f3ad39095e"` [INFO] [stderr] Checking buffoon v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input_stream.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | InputStream { reader: reader } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input_stream.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | wire_type: wire_type [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `wire_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output_writer.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | nested: nested, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `nested` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output_writer.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | writer: writer [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input_stream.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | InputStream { reader: reader } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input_stream.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | wire_type: wire_type [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `wire_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output_writer.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | nested: nested, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `nested` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output_writer.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | writer: writer [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/input_stream.rs:220:5 [INFO] [stderr] | [INFO] [stderr] 220 | return unexpected_output("unexpected EOF"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `unexpected_output("unexpected EOF")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/input_stream.rs:104:17 [INFO] [stderr] | [INFO] [stderr] 104 | let mut buf = slice::from_raw_parts_mut(ret.as_mut_ptr(), len); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/input_stream.rs:59:24 [INFO] [stderr] | [INFO] [stderr] 59 | let bits = (byte & 0x7f) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(byte & 0x7f)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/input_stream.rs:77:45 [INFO] [stderr] | [INFO] [stderr] 77 | return self.read_exact(len).map(|ret| Some(ret)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/input_stream.rs:88:20 [INFO] [stderr] | [INFO] [stderr] 88 | if let None = try!(self.read_byte()) { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 2 | if match $ expr { [INFO] [stderr] 3 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 4 | :: Err ( err ) => { [INFO] [stderr] 5 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 6 | $ crate :: convert :: From :: from ( err ) ) } }.is_none() ) ; ( $ expr : expr , ) => ( [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/input_stream.rs:149:24 [INFO] [stderr] | [INFO] [stderr] 149 | if let Some(_) = try!(self.input.read_unsigned_varint()) { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 2 | if match $ expr { [INFO] [stderr] 3 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 4 | :: Err ( err ) => { [INFO] [stderr] 5 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 6 | $ crate :: convert :: From :: from ( err ) ) } }.is_some() ) ; ( $ expr : expr , ) => ( [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/output_stream.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | / match val { [INFO] [stderr] 44 | | Some(s) => try!(self.write_str_field(field, s.borrow())), [INFO] [stderr] 45 | | None => {} [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(s) = val { try!(self.write_str_field(field, s.borrow())) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/output_writer.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | try!(self.writer.write(bytes)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `serializer::Serializer` [INFO] [stderr] --> src/serializer.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> Serializer { [INFO] [stderr] 14 | | Serializer { [INFO] [stderr] 15 | | size: 0, [INFO] [stderr] 16 | | nested: Vec::new() [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn load<'a, M: LoadableMessage, R: io::Read>(reader: &mut R) -> io::Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `buffoon`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/input_stream.rs:220:5 [INFO] [stderr] | [INFO] [stderr] 220 | return unexpected_output("unexpected EOF"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `unexpected_output("unexpected EOF")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/input_stream.rs:104:17 [INFO] [stderr] | [INFO] [stderr] 104 | let mut buf = slice::from_raw_parts_mut(ret.as_mut_ptr(), len); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/input_stream.rs:59:24 [INFO] [stderr] | [INFO] [stderr] 59 | let bits = (byte & 0x7f) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(byte & 0x7f)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/input_stream.rs:77:45 [INFO] [stderr] | [INFO] [stderr] 77 | return self.read_exact(len).map(|ret| Some(ret)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/input_stream.rs:88:20 [INFO] [stderr] | [INFO] [stderr] 88 | if let None = try!(self.read_byte()) { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 2 | if match $ expr { [INFO] [stderr] 3 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 4 | :: Err ( err ) => { [INFO] [stderr] 5 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 6 | $ crate :: convert :: From :: from ( err ) ) } }.is_none() ) ; ( $ expr : expr , ) => ( [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/input_stream.rs:149:24 [INFO] [stderr] | [INFO] [stderr] 149 | if let Some(_) = try!(self.input.read_unsigned_varint()) { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 2 | if match $ expr { [INFO] [stderr] 3 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 4 | :: Err ( err ) => { [INFO] [stderr] 5 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 6 | $ crate :: convert :: From :: from ( err ) ) } }.is_some() ) ; ( $ expr : expr , ) => ( [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/output_stream.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | / match val { [INFO] [stderr] 44 | | Some(s) => try!(self.write_str_field(field, s.borrow())), [INFO] [stderr] 45 | | None => {} [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(s) = val { try!(self.write_str_field(field, s.borrow())) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/output_writer.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | try!(self.writer.write(bytes)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `serializer::Serializer` [INFO] [stderr] --> src/serializer.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> Serializer { [INFO] [stderr] 14 | | Serializer { [INFO] [stderr] 15 | | size: 0, [INFO] [stderr] 16 | | nested: Vec::new() [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn load<'a, M: LoadableMessage, R: io::Read>(reader: &mut R) -> io::Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `buffoon`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c7b2675c578cc9d0c03b42324c0d0ec4abafa8bcd170854ec33258f3ad39095e"` [INFO] running `"docker" "rm" "-f" "c7b2675c578cc9d0c03b42324c0d0ec4abafa8bcd170854ec33258f3ad39095e"` [INFO] [stdout] c7b2675c578cc9d0c03b42324c0d0ec4abafa8bcd170854ec33258f3ad39095e