[INFO] crate bucket_queue 2.0.0 is already in cache [INFO] extracting crate bucket_queue 2.0.0 into work/ex/clippy-test-run/sources/stable/reg/bucket_queue/2.0.0 [INFO] extracting crate bucket_queue 2.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bucket_queue/2.0.0 [INFO] validating manifest of bucket_queue-2.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bucket_queue-2.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bucket_queue-2.0.0 [INFO] finished frobbing bucket_queue-2.0.0 [INFO] frobbed toml for bucket_queue-2.0.0 written to work/ex/clippy-test-run/sources/stable/reg/bucket_queue/2.0.0/Cargo.toml [INFO] started frobbing bucket_queue-2.0.0 [INFO] finished frobbing bucket_queue-2.0.0 [INFO] frobbed toml for bucket_queue-2.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bucket_queue/2.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bucket_queue-2.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bucket_queue/2.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7d54035d0e43d3ffa34d5b358e03a1db224de37e7cf8be29e41c3653e09a1ec1 [INFO] running `"docker" "start" "-a" "7d54035d0e43d3ffa34d5b358e03a1db224de37e7cf8be29e41c3653e09a1ec1"` [INFO] [stderr] Checking bucket_queue v2.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/index/simple/mod.rs:70:60 [INFO] [stderr] | [INFO] [stderr] 70 | fn size_of_bucket(priority: usize, buckets: &Vec>) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Option]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/index/simple/mod.rs:78:61 [INFO] [stderr] | [INFO] [stderr] 78 | fn bucket_is_empty(priority: usize, buckets: &Vec>) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Option]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/index/simple/mod.rs:86:76 [INFO] [stderr] | [INFO] [stderr] 86 | fn set_new_min_and_max(&mut self, priority: usize, buckets: &Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Option]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/index/simple/mod.rs:98:51 [INFO] [stderr] | [INFO] [stderr] 98 | fn find_next_priority(iter: I, buckets: &Vec>) -> Option [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Option]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/index/mod.rs:8:60 [INFO] [stderr] | [INFO] [stderr] 8 | fn add(&mut self, priority: usize, buckets: &Vec>); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Option]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/index/mod.rs:9:63 [INFO] [stderr] | [INFO] [stderr] 9 | fn remove(&mut self, priority: usize, buckets: &Vec>); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Option]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/index/mod.rs:11:74 [INFO] [stderr] | [INFO] [stderr] 11 | fn added_n(&mut self, n: usize, priority: usize, buckets: &Vec>); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Option]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/index/mod.rs:12:76 [INFO] [stderr] | [INFO] [stderr] 12 | fn removed_n(&mut self, n: usize, priority: usize, buckets: &Vec>); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Option]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/deferred/bucket/mod.rs:47:33 [INFO] [stderr] | [INFO] [stderr] 47 | .get_or_insert_with(|| B::new_bucket()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `B::new_bucket` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `bucket_queue::BucketQueue` [INFO] [stderr] --> src/bucket_queue/mod.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> Self { [INFO] [stderr] 11 | | Self { buckets: Vec::new(), index: I::new() } [INFO] [stderr] 12 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | impl Default for bucket_queue::BucketQueue { [INFO] [stderr] 10 | fn default() -> Self { [INFO] [stderr] 11 | Self::new() [INFO] [stderr] 12 | } [INFO] [stderr] 13 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/bucket_queue/mod.rs:47:48 [INFO] [stderr] | [INFO] [stderr] 47 | self.grow(priority).get_or_insert_with(|| B::new_bucket()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `B::new_bucket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/index/simple/mod.rs:70:60 [INFO] [stderr] | [INFO] [stderr] 70 | fn size_of_bucket(priority: usize, buckets: &Vec>) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Option]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/index/simple/mod.rs:78:61 [INFO] [stderr] | [INFO] [stderr] 78 | fn bucket_is_empty(priority: usize, buckets: &Vec>) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Option]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/index/simple/mod.rs:86:76 [INFO] [stderr] | [INFO] [stderr] 86 | fn set_new_min_and_max(&mut self, priority: usize, buckets: &Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Option]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/index/simple/mod.rs:98:51 [INFO] [stderr] | [INFO] [stderr] 98 | fn find_next_priority(iter: I, buckets: &Vec>) -> Option [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Option]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/index/mod.rs:8:60 [INFO] [stderr] | [INFO] [stderr] 8 | fn add(&mut self, priority: usize, buckets: &Vec>); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Option]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/index/mod.rs:9:63 [INFO] [stderr] | [INFO] [stderr] 9 | fn remove(&mut self, priority: usize, buckets: &Vec>); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Option]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/index/mod.rs:11:74 [INFO] [stderr] | [INFO] [stderr] 11 | fn added_n(&mut self, n: usize, priority: usize, buckets: &Vec>); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Option]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/index/mod.rs:12:76 [INFO] [stderr] | [INFO] [stderr] 12 | fn removed_n(&mut self, n: usize, priority: usize, buckets: &Vec>); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Option]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/deferred/bucket/mod.rs:47:33 [INFO] [stderr] | [INFO] [stderr] 47 | .get_or_insert_with(|| B::new_bucket()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `B::new_bucket` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `bucket_queue::BucketQueue` [INFO] [stderr] --> src/bucket_queue/mod.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> Self { [INFO] [stderr] 11 | | Self { buckets: Vec::new(), index: I::new() } [INFO] [stderr] 12 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | impl Default for bucket_queue::BucketQueue { [INFO] [stderr] 10 | fn default() -> Self { [INFO] [stderr] 11 | Self::new() [INFO] [stderr] 12 | } [INFO] [stderr] 13 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/bucket_queue/mod.rs:47:48 [INFO] [stderr] | [INFO] [stderr] 47 | self.grow(priority).get_or_insert_with(|| B::new_bucket()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `B::new_bucket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.17s [INFO] running `"docker" "inspect" "7d54035d0e43d3ffa34d5b358e03a1db224de37e7cf8be29e41c3653e09a1ec1"` [INFO] running `"docker" "rm" "-f" "7d54035d0e43d3ffa34d5b358e03a1db224de37e7cf8be29e41c3653e09a1ec1"` [INFO] [stdout] 7d54035d0e43d3ffa34d5b358e03a1db224de37e7cf8be29e41c3653e09a1ec1