[INFO] crate btrfs-send-parse 0.1.0 is already in cache
[INFO] extracting crate btrfs-send-parse 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/btrfs-send-parse/0.1.0
[INFO] extracting crate btrfs-send-parse 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/btrfs-send-parse/0.1.0
[INFO] validating manifest of btrfs-send-parse-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of btrfs-send-parse-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing btrfs-send-parse-0.1.0
[INFO] finished frobbing btrfs-send-parse-0.1.0
[INFO] frobbed toml for btrfs-send-parse-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/btrfs-send-parse/0.1.0/Cargo.toml
[INFO] started frobbing btrfs-send-parse-0.1.0
[INFO] finished frobbing btrfs-send-parse-0.1.0
[INFO] frobbed toml for btrfs-send-parse-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/btrfs-send-parse/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting btrfs-send-parse-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/btrfs-send-parse/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ff36ac2f73cbe61c044ebb40b09605f65236851b8e148fc9c6b7563a31534d5c
[INFO] running `"docker" "start" "-a" "ff36ac2f73cbe61c044ebb40b09605f65236851b8e148fc9c6b7563a31534d5c"`
[INFO] [stderr]     Checking btrfs-send-parse v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:232:24
[INFO] [stderr]     |
[INFO] [stderr] 232 |         Ok(BtrfsReader{r: r, version: version})
[INFO] [stderr]     |                        ^^^^ help: replace it with: `r`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:232:30
[INFO] [stderr]     |
[INFO] [stderr] 232 |         Ok(BtrfsReader{r: r, version: version})
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^ help: replace it with: `version`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:377:44
[INFO] [stderr]     |
[INFO] [stderr] 377 |             tlv_data.entries.push(TLVEntry{key: key, value: data});
[INFO] [stderr]     |                                            ^^^^^^^^ help: replace it with: `key`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/lib.rs:397:17
[INFO] [stderr]     |
[INFO] [stderr] 397 |                 write!(f, "Write {{ path = {:?}, file_offset = {}, data_len = {} }}\n", w.path, w.file_offset, w.data.len()),   
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/lib.rs:398:18
[INFO] [stderr]     |
[INFO] [stderr] 398 |             _ => write!(f, "{:?}\n", self)
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:232:24
[INFO] [stderr]     |
[INFO] [stderr] 232 |         Ok(BtrfsReader{r: r, version: version})
[INFO] [stderr]     |                        ^^^^ help: replace it with: `r`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:232:30
[INFO] [stderr]     |
[INFO] [stderr] 232 |         Ok(BtrfsReader{r: r, version: version})
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^ help: replace it with: `version`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:377:44
[INFO] [stderr]     |
[INFO] [stderr] 377 |             tlv_data.entries.push(TLVEntry{key: key, value: data});
[INFO] [stderr]     |                                            ^^^^^^^^ help: replace it with: `key`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/lib.rs:397:17
[INFO] [stderr]     |
[INFO] [stderr] 397 |                 write!(f, "Write {{ path = {:?}, file_offset = {}, data_len = {} }}\n", w.path, w.file_offset, w.data.len()),   
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/lib.rs:398:18
[INFO] [stderr]     |
[INFO] [stderr] 398 |             _ => write!(f, "{:?}\n", self)
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:77:5
[INFO] [stderr]    |
[INFO] [stderr] 77 |     return Err(io::Error::new(io::ErrorKind::InvalidData, err));
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(io::Error::new(io::ErrorKind::InvalidData, err))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:77:5
[INFO] [stderr]    |
[INFO] [stderr] 77 |     return Err(io::Error::new(io::ErrorKind::InvalidData, err));
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(io::Error::new(io::ErrorKind::InvalidData, err))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:210:8
[INFO] [stderr]     |
[INFO] [stderr] 210 |     if buf.len() == 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:240:54
[INFO] [stderr]     |
[INFO] [stderr] 240 |             Some(cmd) => self.parse_command(cmd).map(|x| Some(x)),
[INFO] [stderr]     |                                                      ^^^^^^^^^^^ help: remove closure as shown: `Some`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 32
[INFO] [stderr]    --> src/lib.rs:244:5
[INFO] [stderr]     |
[INFO] [stderr] 244 | /     pub fn parse_command(&self, cmd: commands::Unknown) -> Result<Command> {
[INFO] [stderr] 245 | |         {
[INFO] [stderr] 246 | |             // println!("Parsing {}", cmd.header.cmd);
[INFO] [stderr] 247 | |             let t = &cmd.data;
[INFO] [stderr] ...   |
[INFO] [stderr] 346 | |         Ok(Command::Unknown(cmd))
[INFO] [stderr] 347 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:378:32
[INFO] [stderr]     |
[INFO] [stderr] 378 |             remaining -= 2*2 + len as u32;
[INFO] [stderr]     |                                ^^^^^^^^^^ help: try: `u32::from(len)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:210:8
[INFO] [stderr]     |
[INFO] [stderr] 210 |     if buf.len() == 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:240:54
[INFO] [stderr]     |
[INFO] [stderr] 240 |             Some(cmd) => self.parse_command(cmd).map(|x| Some(x)),
[INFO] [stderr]     |                                                      ^^^^^^^^^^^ help: remove closure as shown: `Some`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 32
[INFO] [stderr]    --> src/lib.rs:244:5
[INFO] [stderr]     |
[INFO] [stderr] 244 | /     pub fn parse_command(&self, cmd: commands::Unknown) -> Result<Command> {
[INFO] [stderr] 245 | |         {
[INFO] [stderr] 246 | |             // println!("Parsing {}", cmd.header.cmd);
[INFO] [stderr] 247 | |             let t = &cmd.data;
[INFO] [stderr] ...   |
[INFO] [stderr] 346 | |         Ok(Command::Unknown(cmd))
[INFO] [stderr] 347 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:378:32
[INFO] [stderr]     |
[INFO] [stderr] 378 |             remaining -= 2*2 + len as u32;
[INFO] [stderr]     |                                ^^^^^^^^^^ help: try: `u32::from(len)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.25s
[INFO] running `"docker" "inspect" "ff36ac2f73cbe61c044ebb40b09605f65236851b8e148fc9c6b7563a31534d5c"`
[INFO] running `"docker" "rm" "-f" "ff36ac2f73cbe61c044ebb40b09605f65236851b8e148fc9c6b7563a31534d5c"`
[INFO] [stdout] ff36ac2f73cbe61c044ebb40b09605f65236851b8e148fc9c6b7563a31534d5c