[INFO] crate btc-transaction-utils 0.4.0 is already in cache [INFO] extracting crate btc-transaction-utils 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/btc-transaction-utils/0.4.0 [INFO] extracting crate btc-transaction-utils 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/btc-transaction-utils/0.4.0 [INFO] validating manifest of btc-transaction-utils-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of btc-transaction-utils-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing btc-transaction-utils-0.4.0 [INFO] finished frobbing btc-transaction-utils-0.4.0 [INFO] frobbed toml for btc-transaction-utils-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/btc-transaction-utils/0.4.0/Cargo.toml [INFO] started frobbing btc-transaction-utils-0.4.0 [INFO] finished frobbing btc-transaction-utils-0.4.0 [INFO] frobbed toml for btc-transaction-utils-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/btc-transaction-utils/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting btc-transaction-utils-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/btc-transaction-utils/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6ccd41e2dc75082c7e929d126c95a38d666e97311684bb3adaeb715c2fa0714b [INFO] running `"docker" "start" "-a" "6ccd41e2dc75082c7e929d126c95a38d666e97311684bb3adaeb715c2fa0714b"` [INFO] [stderr] Checking bech32 v0.5.0 [INFO] [stderr] Compiling backtrace-sys v0.1.28 [INFO] [stderr] Compiling secp256k1 v0.11.6 [INFO] [stderr] Checking serde_str v0.1.0 [INFO] [stderr] Compiling display_derive v0.0.0 [INFO] [stderr] Checking bitcoin-bech32 v0.8.1 [INFO] [stderr] Checking backtrace v0.3.13 [INFO] [stderr] Checking failure v0.1.5 [INFO] [stderr] Checking bitcoin v0.15.1 [INFO] [stderr] Checking btc-transaction-utils v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/multisig.rs:117:53 [INFO] [stderr] | [INFO] [stderr] 117 | #![cfg_attr(feature = "cargo-clippy", allow(needless_pass_by_value))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/multisig.rs:117:53 [INFO] [stderr] | [INFO] [stderr] 117 | #![cfg_attr(feature = "cargo-clippy", allow(needless_pass_by_value))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/multisig.rs:117:53 [INFO] [stderr] | [INFO] [stderr] 117 | #![cfg_attr(feature = "cargo-clippy", allow(needless_pass_by_value))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/p2wpk.rs:172:27 [INFO] [stderr] | [INFO] [stderr] 172 | sequence: 0xFFFFFFFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/p2wsh.rs:182:27 [INFO] [stderr] | [INFO] [stderr] 182 | sequence: 0xFFFFFFFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/multisig.rs:117:53 [INFO] [stderr] | [INFO] [stderr] 117 | #![cfg_attr(feature = "cargo-clippy", allow(needless_pass_by_value))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/p2wsh.rs:149:24 [INFO] [stderr] | [INFO] [stderr] 149 | let keypairs = (0..total_count) [INFO] [stderr] | ________________________^ [INFO] [stderr] 150 | | .into_iter() [INFO] [stderr] | |________________________^ help: consider removing `.into_iter()`: `(0..total_count)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.52s [INFO] running `"docker" "inspect" "6ccd41e2dc75082c7e929d126c95a38d666e97311684bb3adaeb715c2fa0714b"` [INFO] running `"docker" "rm" "-f" "6ccd41e2dc75082c7e929d126c95a38d666e97311684bb3adaeb715c2fa0714b"` [INFO] [stdout] 6ccd41e2dc75082c7e929d126c95a38d666e97311684bb3adaeb715c2fa0714b