[INFO] crate bspl 1.0.0 is already in cache [INFO] extracting crate bspl 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/bspl/1.0.0 [INFO] extracting crate bspl 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bspl/1.0.0 [INFO] validating manifest of bspl-1.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bspl-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bspl-1.0.0 [INFO] finished frobbing bspl-1.0.0 [INFO] frobbed toml for bspl-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/bspl/1.0.0/Cargo.toml [INFO] started frobbing bspl-1.0.0 [INFO] finished frobbing bspl-1.0.0 [INFO] frobbed toml for bspl-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bspl/1.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bspl-1.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bspl/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 45a87dc84529cf15228fae0cecf038b6bbef001dd0ea1beb497d7336a3caa395 [INFO] running `"docker" "start" "-a" "45a87dc84529cf15228fae0cecf038b6bbef001dd0ea1beb497d7336a3caa395"` [INFO] [stderr] Checking bspl v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:35:52 [INFO] [stderr] | [INFO] [stderr] 35 | Token::Operator(ref new_token_name) => self.operators.get(&new_token_name).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.operators[&new_token_name]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:40:52 [INFO] [stderr] | [INFO] [stderr] 40 | Token::Operator(ref top_token_name) => self.operators.get(&top_token_name).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.operators[&top_token_name]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/parser.rs:53:50 [INFO] [stderr] | [INFO] [stderr] 53 | while let Some(&(position, ref token)) = token_iterator.next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `for &(position, ref token) in token_iterator { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/parser.rs:64:21 [INFO] [stderr] | [INFO] [stderr] 64 | / loop { [INFO] [stderr] 65 | | match stack.last() { [INFO] [stderr] 66 | | Some(&(_, Token::Operator(_))) => { [INFO] [stderr] 67 | | if self.lower_precedence(&token, &stack.last().unwrap().1) { [INFO] [stderr] ... | [INFO] [stderr] 74 | | } [INFO] [stderr] 75 | | } [INFO] [stderr] | |_____________________^ help: try: `while let Some(&(_, Token::Operator(_))) = stack.last() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/evaluator.rs:11:25 [INFO] [stderr] | [INFO] [stderr] 11 | fn is_keyword(variable: &String) -> Option<&str> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/evaluator.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if keyword.to_string() == variable.to_lowercase() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `*keyword` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/evaluator.rs:63:36 [INFO] [stderr] | [INFO] [stderr] 63 | let function = self.functions.get(&op).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.functions[&op]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:35:52 [INFO] [stderr] | [INFO] [stderr] 35 | Token::Operator(ref new_token_name) => self.operators.get(&new_token_name).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.operators[&new_token_name]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:40:52 [INFO] [stderr] | [INFO] [stderr] 40 | Token::Operator(ref top_token_name) => self.operators.get(&top_token_name).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.operators[&top_token_name]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/parser.rs:53:50 [INFO] [stderr] | [INFO] [stderr] 53 | while let Some(&(position, ref token)) = token_iterator.next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `for &(position, ref token) in token_iterator { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/parser.rs:64:21 [INFO] [stderr] | [INFO] [stderr] 64 | / loop { [INFO] [stderr] 65 | | match stack.last() { [INFO] [stderr] 66 | | Some(&(_, Token::Operator(_))) => { [INFO] [stderr] 67 | | if self.lower_precedence(&token, &stack.last().unwrap().1) { [INFO] [stderr] ... | [INFO] [stderr] 74 | | } [INFO] [stderr] 75 | | } [INFO] [stderr] | |_____________________^ help: try: `while let Some(&(_, Token::Operator(_))) = stack.last() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/evaluator.rs:11:25 [INFO] [stderr] | [INFO] [stderr] 11 | fn is_keyword(variable: &String) -> Option<&str> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/evaluator.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if keyword.to_string() == variable.to_lowercase() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `*keyword` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/evaluator.rs:63:36 [INFO] [stderr] | [INFO] [stderr] 63 | let function = self.functions.get(&op).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.functions[&op]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.79s [INFO] running `"docker" "inspect" "45a87dc84529cf15228fae0cecf038b6bbef001dd0ea1beb497d7336a3caa395"` [INFO] running `"docker" "rm" "-f" "45a87dc84529cf15228fae0cecf038b6bbef001dd0ea1beb497d7336a3caa395"` [INFO] [stdout] 45a87dc84529cf15228fae0cecf038b6bbef001dd0ea1beb497d7336a3caa395