[INFO] crate bsdiff 0.1.3 is already in cache [INFO] extracting crate bsdiff 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/bsdiff/0.1.3 [INFO] extracting crate bsdiff 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bsdiff/0.1.3 [INFO] validating manifest of bsdiff-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bsdiff-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bsdiff-0.1.3 [INFO] finished frobbing bsdiff-0.1.3 [INFO] frobbed toml for bsdiff-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/bsdiff/0.1.3/Cargo.toml [INFO] started frobbing bsdiff-0.1.3 [INFO] finished frobbing bsdiff-0.1.3 [INFO] frobbed toml for bsdiff-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bsdiff/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bsdiff-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bsdiff/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ee540c0dee071c02e1de69a82c5492e503bfdbcc7481e00fadcbde58a18ed56a [INFO] running `"docker" "start" "-a" "ee540c0dee071c02e1de69a82c5492e503bfdbcc7481e00fadcbde58a18ed56a"` [INFO] [stderr] Checking bsdiff v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/diff.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | let mut x: isize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/diff.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | let mut x: isize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:79:16 [INFO] [stderr] | [INFO] [stderr] 79 | if !(k < start + len) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `k >= start + len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:86:20 [INFO] [stderr] | [INFO] [stderr] 86 | if !(k + i < start + len) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `k + i >= start + len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:103:20 [INFO] [stderr] | [INFO] [stderr] 103 | if !(i < j) { [INFO] [stderr] | ^^^^^^^^ help: try: `i >= j` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:120:16 [INFO] [stderr] | [INFO] [stderr] 120 | if !(i < start + len) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i >= start + len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:137:16 [INFO] [stderr] | [INFO] [stderr] 137 | if !(i < jj) { [INFO] [stderr] | ^^^^^^^^^ help: try: `i >= jj` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:155:16 [INFO] [stderr] | [INFO] [stderr] 155 | if !(jj + j < kk) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `jj + j >= kk` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:172:16 [INFO] [stderr] | [INFO] [stderr] 172 | if !(i < kk - jj) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i >= kk - jj` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop5` [INFO] [stderr] --> src/diff.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | / 'loop5: loop { [INFO] [stderr] 155 | | if !(jj + j < kk) { [INFO] [stderr] 156 | | break; [INFO] [stderr] 157 | | } [INFO] [stderr] ... | [INFO] [stderr] 165 | | } [INFO] [stderr] 166 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop2` [INFO] [stderr] --> src/diff.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | / 'loop2: loop { [INFO] [stderr] 120 | | if !(i < start + len) { [INFO] [stderr] 121 | | break; [INFO] [stderr] 122 | | } [INFO] [stderr] ... | [INFO] [stderr] 129 | | i = i + 1isize; [INFO] [stderr] 130 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop9` [INFO] [stderr] --> src/diff.rs:171:9 [INFO] [stderr] | [INFO] [stderr] 171 | / 'loop9: loop { [INFO] [stderr] 172 | | if !(i < kk - jj) { [INFO] [stderr] 173 | | break; [INFO] [stderr] 174 | | } [INFO] [stderr] 175 | | V[*I.offset(jj + i) as usize] = kk - 1isize; [INFO] [stderr] 176 | | i = i + 1isize; [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop34` [INFO] [stderr] --> src/diff.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | / 'loop34: loop { [INFO] [stderr] 86 | | if !(k + i < start + len) { [INFO] [stderr] 87 | | break; [INFO] [stderr] 88 | | } [INFO] [stderr] ... | [INFO] [stderr] 99 | | i = i + 1isize; [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop36` [INFO] [stderr] --> src/diff.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | / 'loop36: loop { [INFO] [stderr] 103 | | if !(i < j) { [INFO] [stderr] 104 | | break; [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | V[*I.offset(k + i) as usize] = k + j - 1isize; [INFO] [stderr] 107 | | i = i + 1isize; [INFO] [stderr] 108 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop4` [INFO] [stderr] --> src/diff.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | / 'loop4: loop { [INFO] [stderr] 137 | | if !(i < jj) { [INFO] [stderr] 138 | | break; [INFO] [stderr] 139 | | } [INFO] [stderr] ... | [INFO] [stderr] 152 | | } [INFO] [stderr] 153 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop31` [INFO] [stderr] --> src/diff.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | / 'loop31: loop { [INFO] [stderr] 79 | | if !(k < start + len) { [INFO] [stderr] 80 | | break; [INFO] [stderr] 81 | | } [INFO] [stderr] ... | [INFO] [stderr] 112 | | k = k + j; [INFO] [stderr] 113 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:97:21 [INFO] [stderr] | [INFO] [stderr] 97 | j = j + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `j += 1isize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:99:17 [INFO] [stderr] | [INFO] [stderr] 99 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:107:17 [INFO] [stderr] | [INFO] [stderr] 107 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | k = k + j; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `k += j` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:124:17 [INFO] [stderr] | [INFO] [stderr] 124 | jj = jj + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `jj += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:127:17 [INFO] [stderr] | [INFO] [stderr] 127 | kk = kk + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `kk += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | jj = jj + start; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `jj += start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | kk = kk + jj; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `kk += jj` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:141:17 [INFO] [stderr] | [INFO] [stderr] 141 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:146:17 [INFO] [stderr] | [INFO] [stderr] 146 | j = j + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `j += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:151:17 [INFO] [stderr] | [INFO] [stderr] 151 | k = k + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `k += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:159:17 [INFO] [stderr] | [INFO] [stderr] 159 | j = j + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `j += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:164:17 [INFO] [stderr] | [INFO] [stderr] 164 | k = k + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `k += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:194:12 [INFO] [stderr] | [INFO] [stderr] 194 | if !(i < 256isize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i >= 256isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:202:12 [INFO] [stderr] | [INFO] [stderr] 202 | if !(i < oldsize) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i >= oldsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:212:12 [INFO] [stderr] | [INFO] [stderr] 212 | if !(i < 256isize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i >= 256isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:222:12 [INFO] [stderr] | [INFO] [stderr] 222 | if !(i > 0isize) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i <= 0isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:231:12 [INFO] [stderr] | [INFO] [stderr] 231 | if !(i < oldsize) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i >= oldsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:245:12 [INFO] [stderr] | [INFO] [stderr] 245 | if !(i < oldsize) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i >= oldsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:254:12 [INFO] [stderr] | [INFO] [stderr] 254 | if !(i < 256isize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i >= 256isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:265:12 [INFO] [stderr] | [INFO] [stderr] 265 | if !(*I.offset(0isize) != -(oldsize + 1isize)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*I.offset(0isize) == -(oldsize + 1isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:271:16 [INFO] [stderr] | [INFO] [stderr] 271 | if !(i < oldsize + 1isize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i >= oldsize + 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:294:12 [INFO] [stderr] | [INFO] [stderr] 294 | if !(i < oldsize + 1isize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i >= oldsize + 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop17` [INFO] [stderr] --> src/diff.rs:293:5 [INFO] [stderr] | [INFO] [stderr] 293 | / 'loop17: loop { [INFO] [stderr] 294 | | if !(i < oldsize + 1isize) { [INFO] [stderr] 295 | | break; [INFO] [stderr] 296 | | } [INFO] [stderr] 297 | | *I.offset(V[i as usize]) = i; [INFO] [stderr] 298 | | i = i + 1isize; [INFO] [stderr] 299 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop11` [INFO] [stderr] --> src/diff.rs:244:5 [INFO] [stderr] | [INFO] [stderr] 244 | / 'loop11: loop { [INFO] [stderr] 245 | | if !(i < oldsize) { [INFO] [stderr] 246 | | break; [INFO] [stderr] 247 | | } [INFO] [stderr] 248 | | V[i as usize] = buckets[*old.offset(i) as (usize)]; [INFO] [stderr] 249 | | i = i + 1isize; [INFO] [stderr] 250 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop5` [INFO] [stderr] --> src/diff.rs:211:5 [INFO] [stderr] | [INFO] [stderr] 211 | / 'loop5: loop { [INFO] [stderr] 212 | | if !(i < 256isize) { [INFO] [stderr] 213 | | break; [INFO] [stderr] 214 | | } [INFO] [stderr] ... | [INFO] [stderr] 218 | | i = i + 1isize; [INFO] [stderr] 219 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop7` [INFO] [stderr] --> src/diff.rs:221:5 [INFO] [stderr] | [INFO] [stderr] 221 | / 'loop7: loop { [INFO] [stderr] 222 | | if !(i > 0isize) { [INFO] [stderr] 223 | | break; [INFO] [stderr] 224 | | } [INFO] [stderr] 225 | | buckets[i as (usize)] = buckets[(i - 1isize) as (usize)]; [INFO] [stderr] 226 | | i = i - 1isize; [INFO] [stderr] 227 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop15` [INFO] [stderr] --> src/diff.rs:264:5 [INFO] [stderr] | [INFO] [stderr] 264 | / 'loop15: loop { [INFO] [stderr] 265 | | if !(*I.offset(0isize) != -(oldsize + 1isize)) { [INFO] [stderr] 266 | | break; [INFO] [stderr] 267 | | } [INFO] [stderr] ... | [INFO] [stderr] 290 | | h = h + h; [INFO] [stderr] 291 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop13` [INFO] [stderr] --> src/diff.rs:253:5 [INFO] [stderr] | [INFO] [stderr] 253 | / 'loop13: loop { [INFO] [stderr] 254 | | if !(i < 256isize) { [INFO] [stderr] 255 | | break; [INFO] [stderr] 256 | | } [INFO] [stderr] ... | [INFO] [stderr] 260 | | i = i + 1isize; [INFO] [stderr] 261 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop9` [INFO] [stderr] --> src/diff.rs:230:5 [INFO] [stderr] | [INFO] [stderr] 230 | / 'loop9: loop { [INFO] [stderr] 231 | | if !(i < oldsize) { [INFO] [stderr] 232 | | break; [INFO] [stderr] 233 | | } [INFO] [stderr] ... | [INFO] [stderr] 240 | | i = i + 1isize; [INFO] [stderr] 241 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop1` [INFO] [stderr] --> src/diff.rs:193:5 [INFO] [stderr] | [INFO] [stderr] 193 | / 'loop1: loop { [INFO] [stderr] 194 | | if !(i < 256isize) { [INFO] [stderr] 195 | | break; [INFO] [stderr] 196 | | } [INFO] [stderr] 197 | | buckets[i as (usize)] = 0isize; [INFO] [stderr] 198 | | i = i + 1isize; [INFO] [stderr] 199 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop3` [INFO] [stderr] --> src/diff.rs:201:5 [INFO] [stderr] | [INFO] [stderr] 201 | / 'loop3: loop { [INFO] [stderr] 202 | | if !(i < oldsize) { [INFO] [stderr] 203 | | break; [INFO] [stderr] 204 | | } [INFO] [stderr] ... | [INFO] [stderr] 208 | | i = i + 1isize; [INFO] [stderr] 209 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop22` [INFO] [stderr] --> src/diff.rs:270:9 [INFO] [stderr] | [INFO] [stderr] 270 | / 'loop22: loop { [INFO] [stderr] 271 | | if !(i < oldsize + 1isize) { [INFO] [stderr] 272 | | break; [INFO] [stderr] 273 | | } [INFO] [stderr] ... | [INFO] [stderr] 285 | | } [INFO] [stderr] 286 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:198:9 [INFO] [stderr] | [INFO] [stderr] 198 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:207:9 [INFO] [stderr] | [INFO] [stderr] 207 | *_lhs = *_lhs + _rhs as (isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*_lhs += _rhs as (isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:208:9 [INFO] [stderr] | [INFO] [stderr] 208 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:217:9 [INFO] [stderr] | [INFO] [stderr] 217 | *_lhs = *_lhs + _rhs; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*_lhs += _rhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:218:9 [INFO] [stderr] | [INFO] [stderr] 218 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:226:9 [INFO] [stderr] | [INFO] [stderr] 226 | i = i - 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i -= 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:237:23 [INFO] [stderr] | [INFO] [stderr] 237 | *_lhs = *_lhs + _rhs as (isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*_lhs += _rhs as (isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:240:9 [INFO] [stderr] | [INFO] [stderr] 240 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:249:9 [INFO] [stderr] | [INFO] [stderr] 249 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:260:9 [INFO] [stderr] | [INFO] [stderr] 260 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:275:17 [INFO] [stderr] | [INFO] [stderr] 275 | len = len - *I.offset(i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `len -= *I.offset(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:283:17 [INFO] [stderr] | [INFO] [stderr] 283 | i = i + len; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `i += len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:298:9 [INFO] [stderr] | [INFO] [stderr] 298 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop1` [INFO] [stderr] --> src/diff.rs:309:5 [INFO] [stderr] | [INFO] [stderr] 309 | / 'loop1: loop { [INFO] [stderr] 310 | | if !(i < oldsize && (i < newsize)) { [INFO] [stderr] 311 | | break; [INFO] [stderr] 312 | | } [INFO] [stderr] ... | [INFO] [stderr] 316 | | i = i + 1isize; [INFO] [stderr] 317 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:313:12 [INFO] [stderr] | [INFO] [stderr] 313 | if *old.offset(i) as (i32) != *new.offset(i) as (i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*old.offset(i))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:313:39 [INFO] [stderr] | [INFO] [stderr] 313 | if *old.offset(i) as (i32) != *new.offset(i) as (i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*new.offset(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:316:9 [INFO] [stderr] | [INFO] [stderr] 316 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/diff.rs:321:1 [INFO] [stderr] | [INFO] [stderr] 321 | / unsafe fn search(mut I: *const isize, [INFO] [stderr] 322 | | mut old: *const u8, [INFO] [stderr] 323 | | mut oldsize: isize, [INFO] [stderr] 324 | | mut new: *const u8, [INFO] [stderr] ... | [INFO] [stderr] 361 | | } [INFO] [stderr] 362 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/diff.rs:365:5 [INFO] [stderr] | [INFO] [stderr] 365 | / let mut y: isize; [INFO] [stderr] 366 | | if x < 0isize { [INFO] [stderr] 367 | | y = -x; [INFO] [stderr] 368 | | } else { [INFO] [stderr] 369 | | y = x; [INFO] [stderr] 370 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let y = if x < 0isize { -x } else { x };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:372:5 [INFO] [stderr] | [INFO] [stderr] 372 | y = y - *buf.offset(0isize) as (isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(0isize) as (isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:373:5 [INFO] [stderr] | [INFO] [stderr] 373 | y = y / 256isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:375:5 [INFO] [stderr] | [INFO] [stderr] 375 | y = y - *buf.offset(1isize) as (isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(1isize) as (isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:376:5 [INFO] [stderr] | [INFO] [stderr] 376 | y = y / 256isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:378:5 [INFO] [stderr] | [INFO] [stderr] 378 | y = y - *buf.offset(2isize) as (isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(2isize) as (isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:379:5 [INFO] [stderr] | [INFO] [stderr] 379 | y = y / 256isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:381:5 [INFO] [stderr] | [INFO] [stderr] 381 | y = y - *buf.offset(3isize) as (isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(3isize) as (isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:382:5 [INFO] [stderr] | [INFO] [stderr] 382 | y = y / 256isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:384:5 [INFO] [stderr] | [INFO] [stderr] 384 | y = y - *buf.offset(4isize) as (isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(4isize) as (isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:385:5 [INFO] [stderr] | [INFO] [stderr] 385 | y = y / 256isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:387:5 [INFO] [stderr] | [INFO] [stderr] 387 | y = y - *buf.offset(5isize) as (isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(5isize) as (isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:388:5 [INFO] [stderr] | [INFO] [stderr] 388 | y = y / 256isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:390:5 [INFO] [stderr] | [INFO] [stderr] 390 | y = y - *buf.offset(6isize) as (isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(6isize) as (isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:391:5 [INFO] [stderr] | [INFO] [stderr] 391 | y = y / 256isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:396:18 [INFO] [stderr] | [INFO] [stderr] 396 | *_lhs = (*_lhs as (i32) | _rhs) as (u8); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(*_lhs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:453:12 [INFO] [stderr] | [INFO] [stderr] 453 | if !(scan < req.newsize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `scan >= req.newsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:462:16 [INFO] [stderr] | [INFO] [stderr] 462 | if !(scan < req.newsize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `scan >= req.newsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:474:20 [INFO] [stderr] | [INFO] [stderr] 474 | if !(scsc < scan + len) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `scsc >= scan + len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:508:16 [INFO] [stderr] | [INFO] [stderr] 508 | if !(s * 2isize - i > Sf * 2isize - lenf) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s * 2isize - i <= Sf * 2isize - lenf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:540:20 [INFO] [stderr] | [INFO] [stderr] 540 | if !(i < overlap) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i >= overlap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:570:16 [INFO] [stderr] | [INFO] [stderr] 570 | if !(i < lenf) { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i >= lenf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:581:16 [INFO] [stderr] | [INFO] [stderr] 581 | if !(i < scan - lenb - (lastscan + lenf)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i >= scan - lenb - (lastscan + lenf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop17` [INFO] [stderr] --> src/diff.rs:519:13 [INFO] [stderr] | [INFO] [stderr] 519 | / 'loop17: loop { [INFO] [stderr] 520 | | if !(scan >= lastscan + i && (pos >= i)) { [INFO] [stderr] 521 | | break; [INFO] [stderr] 522 | | } [INFO] [stderr] ... | [INFO] [stderr] 530 | | i = i + 1isize; [INFO] [stderr] 531 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop5` [INFO] [stderr] --> src/diff.rs:461:9 [INFO] [stderr] | [INFO] [stderr] 461 | / 'loop5: loop { [INFO] [stderr] 462 | | if !(scan < req.newsize) { [INFO] [stderr] 463 | | break; [INFO] [stderr] 464 | | } [INFO] [stderr] ... | [INFO] [stderr] 491 | | scan = scan + 1isize; [INFO] [stderr] 492 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop7` [INFO] [stderr] --> src/diff.rs:473:13 [INFO] [stderr] | [INFO] [stderr] 473 | / 'loop7: loop { [INFO] [stderr] 474 | | if !(scsc < scan + len) { [INFO] [stderr] 475 | | break; [INFO] [stderr] 476 | | } [INFO] [stderr] ... | [INFO] [stderr] 482 | | scsc = scsc + 1isize; [INFO] [stderr] 483 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop20` [INFO] [stderr] --> src/diff.rs:539:13 [INFO] [stderr] | [INFO] [stderr] 539 | / 'loop20: loop { [INFO] [stderr] 540 | | if !(i < overlap) { [INFO] [stderr] 541 | | break; [INFO] [stderr] 542 | | } [INFO] [stderr] ... | [INFO] [stderr] 555 | | i = i + 1isize; [INFO] [stderr] 556 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop2` [INFO] [stderr] --> src/diff.rs:452:5 [INFO] [stderr] | [INFO] [stderr] 452 | / 'loop2: loop { [INFO] [stderr] 453 | | if !(scan < req.newsize) { [INFO] [stderr] 454 | | break; [INFO] [stderr] 455 | | } [INFO] [stderr] ... | [INFO] [stderr] 593 | | lastoffset = pos - scan; [INFO] [stderr] 594 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop27` [INFO] [stderr] --> src/diff.rs:580:9 [INFO] [stderr] | [INFO] [stderr] 580 | / 'loop27: loop { [INFO] [stderr] 581 | | if !(i < scan - lenb - (lastscan + lenf)) { [INFO] [stderr] 582 | | break; [INFO] [stderr] 583 | | } [INFO] [stderr] 584 | | *buffer.offset(i) = *req.new.offset(lastscan + lenf + i); [INFO] [stderr] 585 | | i = i + 1isize; [INFO] [stderr] 586 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop14` [INFO] [stderr] --> src/diff.rs:500:9 [INFO] [stderr] | [INFO] [stderr] 500 | / 'loop14: loop { [INFO] [stderr] 501 | | if !(lastscan + i < scan && (lastpos + i < req.oldsize)) { [INFO] [stderr] 502 | | break; [INFO] [stderr] 503 | | } [INFO] [stderr] ... | [INFO] [stderr] 512 | | lenf = i; [INFO] [stderr] 513 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop24` [INFO] [stderr] --> src/diff.rs:569:9 [INFO] [stderr] | [INFO] [stderr] 569 | / 'loop24: loop { [INFO] [stderr] 570 | | if !(i < lenf) { [INFO] [stderr] 571 | | break; [INFO] [stderr] 572 | | } [INFO] [stderr] ... | [INFO] [stderr] 576 | | i = i + 1isize; [INFO] [stderr] 577 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:458:13 [INFO] [stderr] | [INFO] [stderr] 458 | scan = scan + len; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `scan += len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:478:22 [INFO] [stderr] | [INFO] [stderr] 478 | (*req.old.offset(scsc + lastoffset) as (i32) == [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.old.offset(scsc + lastoffset))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:479:21 [INFO] [stderr] | [INFO] [stderr] 479 | *req.new.offset(scsc) as (i32)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.new.offset(scsc))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:480:21 [INFO] [stderr] | [INFO] [stderr] 480 | oldscore = oldscore + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `oldscore += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:482:17 [INFO] [stderr] | [INFO] [stderr] 482 | scsc = scsc + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `scsc += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:488:18 [INFO] [stderr] | [INFO] [stderr] 488 | (*req.old.offset(scan + lastoffset) as (i32) == *req.new.offset(scan) as (i32)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.old.offset(scan + lastoffset))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:488:65 [INFO] [stderr] | [INFO] [stderr] 488 | (*req.old.offset(scan + lastoffset) as (i32) == *req.new.offset(scan) as (i32)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.new.offset(scan))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:489:17 [INFO] [stderr] | [INFO] [stderr] 489 | oldscore = oldscore - 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `oldscore -= 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:491:13 [INFO] [stderr] | [INFO] [stderr] 491 | scan = scan + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `scan += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:504:16 [INFO] [stderr] | [INFO] [stderr] 504 | if *req.old.offset(lastpos + i) as (i32) == *req.new.offset(lastscan + i) as (i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.old.offset(lastpos + i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:504:57 [INFO] [stderr] | [INFO] [stderr] 504 | if *req.old.offset(lastpos + i) as (i32) == *req.new.offset(lastscan + i) as (i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.new.offset(lastscan + i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:505:17 [INFO] [stderr] | [INFO] [stderr] 505 | s = s + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `s += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:507:13 [INFO] [stderr] | [INFO] [stderr] 507 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:523:20 [INFO] [stderr] | [INFO] [stderr] 523 | if *req.old.offset(pos - i) as (i32) == *req.new.offset(scan - i) as (i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.old.offset(pos - i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:523:57 [INFO] [stderr] | [INFO] [stderr] 523 | if *req.old.offset(pos - i) as (i32) == *req.new.offset(scan - i) as (i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.new.offset(scan - i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:524:21 [INFO] [stderr] | [INFO] [stderr] 524 | s = s + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `s += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:530:17 [INFO] [stderr] | [INFO] [stderr] 530 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:543:20 [INFO] [stderr] | [INFO] [stderr] 543 | if *req.new.offset(lastscan + lenf - overlap + i) as (i32) == [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.new.offset(lastscan + lenf - overlap + i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:544:21 [INFO] [stderr] | [INFO] [stderr] 544 | *req.old.offset(lastpos + lenf - overlap + i) as (i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.old.offset(lastpos + lenf - overlap + i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:545:21 [INFO] [stderr] | [INFO] [stderr] 545 | s = s + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `s += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:547:20 [INFO] [stderr] | [INFO] [stderr] 547 | if *req.new.offset(scan - lenb + i) as (i32) == [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.new.offset(scan - lenb + i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:548:21 [INFO] [stderr] | [INFO] [stderr] 548 | *req.old.offset(pos - lenb + i) as (i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.old.offset(pos - lenb + i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:549:21 [INFO] [stderr] | [INFO] [stderr] 549 | s = s - 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `s -= 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:555:17 [INFO] [stderr] | [INFO] [stderr] 555 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:557:13 [INFO] [stderr] | [INFO] [stderr] 557 | lenf = lenf + (lens - overlap); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lenf += (lens - overlap)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:558:13 [INFO] [stderr] | [INFO] [stderr] 558 | lenb = lenb - lens; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `lenb -= lens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:573:34 [INFO] [stderr] | [INFO] [stderr] 573 | *buffer.offset(i) = (*req.new.offset(lastscan + i) as (i32) - [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.new.offset(lastscan + i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:574:37 [INFO] [stderr] | [INFO] [stderr] 574 | *req.old.offset(lastpos + i) as (i32)) as [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.old.offset(lastpos + i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:576:13 [INFO] [stderr] | [INFO] [stderr] 576 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:585:13 [INFO] [stderr] | [INFO] [stderr] 585 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `ctrl`. [INFO] [stderr] --> src/patch.rs:47:18 [INFO] [stderr] | [INFO] [stderr] 47 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 47 | for in &mut ctrl { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/patch.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | y = (buf[7] as (i32) & 0x7Fi32) as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buf[7] as (i32) & 0x7Fi32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/patch.rs:92:10 [INFO] [stderr] | [INFO] [stderr] 92 | y = (buf[7] as (i32) & 0x7Fi32) as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(buf[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | y = y * 256; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | y = y + buf[6] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[6] as (i64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/patch.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | y = y + buf[6] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(buf[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | y = y * 256; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | y = y + buf[5] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[5] as (i64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/patch.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | y = y + buf[5] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(buf[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | y = y * 256; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | y = y + buf[4] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[4] as (i64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/patch.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | y = y + buf[4] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(buf[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | y = y * 256; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | y = y + buf[3] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[3] as (i64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/patch.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | y = y + buf[3] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(buf[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | y = y * 256; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | y = y + buf[2] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[2] as (i64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/patch.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | y = y + buf[2] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(buf[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | y = y * 256; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | y = y + buf[1] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[1] as (i64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/patch.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | y = y + buf[1] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | y = y * 256; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | y = y + buf[0] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[0] as (i64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/patch.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | y = y + buf[0] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/patch.rs:107:8 [INFO] [stderr] | [INFO] [stderr] 107 | if buf[7] as (i32) & 0x80i32 != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(buf[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:79:16 [INFO] [stderr] | [INFO] [stderr] 79 | if !(k < start + len) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `k >= start + len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:86:20 [INFO] [stderr] | [INFO] [stderr] 86 | if !(k + i < start + len) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `k + i >= start + len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:103:20 [INFO] [stderr] | [INFO] [stderr] 103 | if !(i < j) { [INFO] [stderr] | ^^^^^^^^ help: try: `i >= j` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:120:16 [INFO] [stderr] | [INFO] [stderr] 120 | if !(i < start + len) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i >= start + len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:137:16 [INFO] [stderr] | [INFO] [stderr] 137 | if !(i < jj) { [INFO] [stderr] | ^^^^^^^^^ help: try: `i >= jj` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:155:16 [INFO] [stderr] | [INFO] [stderr] 155 | if !(jj + j < kk) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `jj + j >= kk` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:172:16 [INFO] [stderr] | [INFO] [stderr] 172 | if !(i < kk - jj) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i >= kk - jj` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop5` [INFO] [stderr] --> src/diff.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | / 'loop5: loop { [INFO] [stderr] 155 | | if !(jj + j < kk) { [INFO] [stderr] 156 | | break; [INFO] [stderr] 157 | | } [INFO] [stderr] ... | [INFO] [stderr] 165 | | } [INFO] [stderr] 166 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop2` [INFO] [stderr] --> src/diff.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | / 'loop2: loop { [INFO] [stderr] 120 | | if !(i < start + len) { [INFO] [stderr] 121 | | break; [INFO] [stderr] 122 | | } [INFO] [stderr] ... | [INFO] [stderr] 129 | | i = i + 1isize; [INFO] [stderr] 130 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop9` [INFO] [stderr] --> src/diff.rs:171:9 [INFO] [stderr] | [INFO] [stderr] 171 | / 'loop9: loop { [INFO] [stderr] 172 | | if !(i < kk - jj) { [INFO] [stderr] 173 | | break; [INFO] [stderr] 174 | | } [INFO] [stderr] 175 | | V[*I.offset(jj + i) as usize] = kk - 1isize; [INFO] [stderr] 176 | | i = i + 1isize; [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop34` [INFO] [stderr] --> src/diff.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | / 'loop34: loop { [INFO] [stderr] 86 | | if !(k + i < start + len) { [INFO] [stderr] 87 | | break; [INFO] [stderr] 88 | | } [INFO] [stderr] ... | [INFO] [stderr] 99 | | i = i + 1isize; [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop36` [INFO] [stderr] --> src/diff.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | / 'loop36: loop { [INFO] [stderr] 103 | | if !(i < j) { [INFO] [stderr] 104 | | break; [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | V[*I.offset(k + i) as usize] = k + j - 1isize; [INFO] [stderr] 107 | | i = i + 1isize; [INFO] [stderr] 108 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop4` [INFO] [stderr] --> src/diff.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | / 'loop4: loop { [INFO] [stderr] 137 | | if !(i < jj) { [INFO] [stderr] 138 | | break; [INFO] [stderr] 139 | | } [INFO] [stderr] ... | [INFO] [stderr] 152 | | } [INFO] [stderr] 153 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop31` [INFO] [stderr] --> src/diff.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | / 'loop31: loop { [INFO] [stderr] 79 | | if !(k < start + len) { [INFO] [stderr] 80 | | break; [INFO] [stderr] 81 | | } [INFO] [stderr] ... | [INFO] [stderr] 112 | | k = k + j; [INFO] [stderr] 113 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:97:21 [INFO] [stderr] | [INFO] [stderr] 97 | j = j + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `j += 1isize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:99:17 [INFO] [stderr] | [INFO] [stderr] 99 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:107:17 [INFO] [stderr] | [INFO] [stderr] 107 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | k = k + j; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `k += j` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:124:17 [INFO] [stderr] | [INFO] [stderr] 124 | jj = jj + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `jj += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:127:17 [INFO] [stderr] | [INFO] [stderr] 127 | kk = kk + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `kk += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | jj = jj + start; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `jj += start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | kk = kk + jj; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `kk += jj` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:141:17 [INFO] [stderr] | [INFO] [stderr] 141 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:146:17 [INFO] [stderr] | [INFO] [stderr] 146 | j = j + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `j += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:151:17 [INFO] [stderr] | [INFO] [stderr] 151 | k = k + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `k += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:159:17 [INFO] [stderr] | [INFO] [stderr] 159 | j = j + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `j += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:164:17 [INFO] [stderr] | [INFO] [stderr] 164 | k = k + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `k += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:194:12 [INFO] [stderr] | [INFO] [stderr] 194 | if !(i < 256isize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i >= 256isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:202:12 [INFO] [stderr] | [INFO] [stderr] 202 | if !(i < oldsize) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i >= oldsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:212:12 [INFO] [stderr] | [INFO] [stderr] 212 | if !(i < 256isize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i >= 256isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:222:12 [INFO] [stderr] | [INFO] [stderr] 222 | if !(i > 0isize) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i <= 0isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:231:12 [INFO] [stderr] | [INFO] [stderr] 231 | if !(i < oldsize) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i >= oldsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:245:12 [INFO] [stderr] | [INFO] [stderr] 245 | if !(i < oldsize) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i >= oldsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:254:12 [INFO] [stderr] | [INFO] [stderr] 254 | if !(i < 256isize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i >= 256isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:265:12 [INFO] [stderr] | [INFO] [stderr] 265 | if !(*I.offset(0isize) != -(oldsize + 1isize)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*I.offset(0isize) == -(oldsize + 1isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:271:16 [INFO] [stderr] | [INFO] [stderr] 271 | if !(i < oldsize + 1isize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i >= oldsize + 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:294:12 [INFO] [stderr] | [INFO] [stderr] 294 | if !(i < oldsize + 1isize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i >= oldsize + 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop17` [INFO] [stderr] --> src/diff.rs:293:5 [INFO] [stderr] | [INFO] [stderr] 293 | / 'loop17: loop { [INFO] [stderr] 294 | | if !(i < oldsize + 1isize) { [INFO] [stderr] 295 | | break; [INFO] [stderr] 296 | | } [INFO] [stderr] 297 | | *I.offset(V[i as usize]) = i; [INFO] [stderr] 298 | | i = i + 1isize; [INFO] [stderr] 299 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop11` [INFO] [stderr] --> src/diff.rs:244:5 [INFO] [stderr] | [INFO] [stderr] 244 | / 'loop11: loop { [INFO] [stderr] 245 | | if !(i < oldsize) { [INFO] [stderr] 246 | | break; [INFO] [stderr] 247 | | } [INFO] [stderr] 248 | | V[i as usize] = buckets[*old.offset(i) as (usize)]; [INFO] [stderr] 249 | | i = i + 1isize; [INFO] [stderr] 250 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop5` [INFO] [stderr] --> src/diff.rs:211:5 [INFO] [stderr] | [INFO] [stderr] 211 | / 'loop5: loop { [INFO] [stderr] 212 | | if !(i < 256isize) { [INFO] [stderr] 213 | | break; [INFO] [stderr] 214 | | } [INFO] [stderr] ... | [INFO] [stderr] 218 | | i = i + 1isize; [INFO] [stderr] 219 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop7` [INFO] [stderr] --> src/diff.rs:221:5 [INFO] [stderr] | [INFO] [stderr] 221 | / 'loop7: loop { [INFO] [stderr] 222 | | if !(i > 0isize) { [INFO] [stderr] 223 | | break; [INFO] [stderr] 224 | | } [INFO] [stderr] 225 | | buckets[i as (usize)] = buckets[(i - 1isize) as (usize)]; [INFO] [stderr] 226 | | i = i - 1isize; [INFO] [stderr] 227 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop15` [INFO] [stderr] --> src/diff.rs:264:5 [INFO] [stderr] | [INFO] [stderr] 264 | / 'loop15: loop { [INFO] [stderr] 265 | | if !(*I.offset(0isize) != -(oldsize + 1isize)) { [INFO] [stderr] 266 | | break; [INFO] [stderr] 267 | | } [INFO] [stderr] ... | [INFO] [stderr] 290 | | h = h + h; [INFO] [stderr] 291 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop13` [INFO] [stderr] --> src/diff.rs:253:5 [INFO] [stderr] | [INFO] [stderr] 253 | / 'loop13: loop { [INFO] [stderr] 254 | | if !(i < 256isize) { [INFO] [stderr] 255 | | break; [INFO] [stderr] 256 | | } [INFO] [stderr] ... | [INFO] [stderr] 260 | | i = i + 1isize; [INFO] [stderr] 261 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop9` [INFO] [stderr] --> src/diff.rs:230:5 [INFO] [stderr] | [INFO] [stderr] 230 | / 'loop9: loop { [INFO] [stderr] 231 | | if !(i < oldsize) { [INFO] [stderr] 232 | | break; [INFO] [stderr] 233 | | } [INFO] [stderr] ... | [INFO] [stderr] 240 | | i = i + 1isize; [INFO] [stderr] 241 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop1` [INFO] [stderr] --> src/diff.rs:193:5 [INFO] [stderr] | [INFO] [stderr] 193 | / 'loop1: loop { [INFO] [stderr] 194 | | if !(i < 256isize) { [INFO] [stderr] 195 | | break; [INFO] [stderr] 196 | | } [INFO] [stderr] 197 | | buckets[i as (usize)] = 0isize; [INFO] [stderr] 198 | | i = i + 1isize; [INFO] [stderr] 199 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop3` [INFO] [stderr] --> src/diff.rs:201:5 [INFO] [stderr] | [INFO] [stderr] 201 | / 'loop3: loop { [INFO] [stderr] 202 | | if !(i < oldsize) { [INFO] [stderr] 203 | | break; [INFO] [stderr] 204 | | } [INFO] [stderr] ... | [INFO] [stderr] 208 | | i = i + 1isize; [INFO] [stderr] 209 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop22` [INFO] [stderr] --> src/diff.rs:270:9 [INFO] [stderr] | [INFO] [stderr] 270 | / 'loop22: loop { [INFO] [stderr] 271 | | if !(i < oldsize + 1isize) { [INFO] [stderr] 272 | | break; [INFO] [stderr] 273 | | } [INFO] [stderr] ... | [INFO] [stderr] 285 | | } [INFO] [stderr] 286 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:198:9 [INFO] [stderr] | [INFO] [stderr] 198 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:207:9 [INFO] [stderr] | [INFO] [stderr] 207 | *_lhs = *_lhs + _rhs as (isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*_lhs += _rhs as (isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:208:9 [INFO] [stderr] | [INFO] [stderr] 208 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:217:9 [INFO] [stderr] | [INFO] [stderr] 217 | *_lhs = *_lhs + _rhs; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*_lhs += _rhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:218:9 [INFO] [stderr] | [INFO] [stderr] 218 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:226:9 [INFO] [stderr] | [INFO] [stderr] 226 | i = i - 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i -= 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:237:23 [INFO] [stderr] | [INFO] [stderr] 237 | *_lhs = *_lhs + _rhs as (isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*_lhs += _rhs as (isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:240:9 [INFO] [stderr] | [INFO] [stderr] 240 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:249:9 [INFO] [stderr] | [INFO] [stderr] 249 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:260:9 [INFO] [stderr] | [INFO] [stderr] 260 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:275:17 [INFO] [stderr] | [INFO] [stderr] 275 | len = len - *I.offset(i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `len -= *I.offset(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:283:17 [INFO] [stderr] | [INFO] [stderr] 283 | i = i + len; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `i += len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:298:9 [INFO] [stderr] | [INFO] [stderr] 298 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop1` [INFO] [stderr] --> src/diff.rs:309:5 [INFO] [stderr] | [INFO] [stderr] 309 | / 'loop1: loop { [INFO] [stderr] 310 | | if !(i < oldsize && (i < newsize)) { [INFO] [stderr] 311 | | break; [INFO] [stderr] 312 | | } [INFO] [stderr] ... | [INFO] [stderr] 316 | | i = i + 1isize; [INFO] [stderr] 317 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:313:12 [INFO] [stderr] | [INFO] [stderr] 313 | if *old.offset(i) as (i32) != *new.offset(i) as (i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*old.offset(i))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:313:39 [INFO] [stderr] | [INFO] [stderr] 313 | if *old.offset(i) as (i32) != *new.offset(i) as (i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*new.offset(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:316:9 [INFO] [stderr] | [INFO] [stderr] 316 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/diff.rs:321:1 [INFO] [stderr] | [INFO] [stderr] 321 | / unsafe fn search(mut I: *const isize, [INFO] [stderr] 322 | | mut old: *const u8, [INFO] [stderr] 323 | | mut oldsize: isize, [INFO] [stderr] 324 | | mut new: *const u8, [INFO] [stderr] ... | [INFO] [stderr] 361 | | } [INFO] [stderr] 362 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/diff.rs:365:5 [INFO] [stderr] | [INFO] [stderr] 365 | / let mut y: isize; [INFO] [stderr] 366 | | if x < 0isize { [INFO] [stderr] 367 | | y = -x; [INFO] [stderr] 368 | | } else { [INFO] [stderr] 369 | | y = x; [INFO] [stderr] 370 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let y = if x < 0isize { -x } else { x };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:372:5 [INFO] [stderr] | [INFO] [stderr] 372 | y = y - *buf.offset(0isize) as (isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(0isize) as (isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:373:5 [INFO] [stderr] | [INFO] [stderr] 373 | y = y / 256isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:375:5 [INFO] [stderr] | [INFO] [stderr] 375 | y = y - *buf.offset(1isize) as (isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(1isize) as (isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:376:5 [INFO] [stderr] | [INFO] [stderr] 376 | y = y / 256isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:378:5 [INFO] [stderr] | [INFO] [stderr] 378 | y = y - *buf.offset(2isize) as (isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(2isize) as (isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:379:5 [INFO] [stderr] | [INFO] [stderr] 379 | y = y / 256isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:381:5 [INFO] [stderr] | [INFO] [stderr] 381 | y = y - *buf.offset(3isize) as (isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(3isize) as (isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:382:5 [INFO] [stderr] | [INFO] [stderr] 382 | y = y / 256isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:384:5 [INFO] [stderr] | [INFO] [stderr] 384 | y = y - *buf.offset(4isize) as (isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(4isize) as (isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:385:5 [INFO] [stderr] | [INFO] [stderr] 385 | y = y / 256isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:387:5 [INFO] [stderr] | [INFO] [stderr] 387 | y = y - *buf.offset(5isize) as (isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(5isize) as (isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:388:5 [INFO] [stderr] | [INFO] [stderr] 388 | y = y / 256isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:390:5 [INFO] [stderr] | [INFO] [stderr] 390 | y = y - *buf.offset(6isize) as (isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(6isize) as (isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:391:5 [INFO] [stderr] | [INFO] [stderr] 391 | y = y / 256isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:396:18 [INFO] [stderr] | [INFO] [stderr] 396 | *_lhs = (*_lhs as (i32) | _rhs) as (u8); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(*_lhs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:453:12 [INFO] [stderr] | [INFO] [stderr] 453 | if !(scan < req.newsize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `scan >= req.newsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:462:16 [INFO] [stderr] | [INFO] [stderr] 462 | if !(scan < req.newsize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `scan >= req.newsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:474:20 [INFO] [stderr] | [INFO] [stderr] 474 | if !(scsc < scan + len) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `scsc >= scan + len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:508:16 [INFO] [stderr] | [INFO] [stderr] 508 | if !(s * 2isize - i > Sf * 2isize - lenf) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s * 2isize - i <= Sf * 2isize - lenf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:540:20 [INFO] [stderr] | [INFO] [stderr] 540 | if !(i < overlap) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i >= overlap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:570:16 [INFO] [stderr] | [INFO] [stderr] 570 | if !(i < lenf) { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i >= lenf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:581:16 [INFO] [stderr] | [INFO] [stderr] 581 | if !(i < scan - lenb - (lastscan + lenf)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i >= scan - lenb - (lastscan + lenf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop17` [INFO] [stderr] --> src/diff.rs:519:13 [INFO] [stderr] | [INFO] [stderr] 519 | / 'loop17: loop { [INFO] [stderr] 520 | | if !(scan >= lastscan + i && (pos >= i)) { [INFO] [stderr] 521 | | break; [INFO] [stderr] 522 | | } [INFO] [stderr] ... | [INFO] [stderr] 530 | | i = i + 1isize; [INFO] [stderr] 531 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop5` [INFO] [stderr] --> src/diff.rs:461:9 [INFO] [stderr] | [INFO] [stderr] 461 | / 'loop5: loop { [INFO] [stderr] 462 | | if !(scan < req.newsize) { [INFO] [stderr] 463 | | break; [INFO] [stderr] 464 | | } [INFO] [stderr] ... | [INFO] [stderr] 491 | | scan = scan + 1isize; [INFO] [stderr] 492 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop7` [INFO] [stderr] --> src/diff.rs:473:13 [INFO] [stderr] | [INFO] [stderr] 473 | / 'loop7: loop { [INFO] [stderr] 474 | | if !(scsc < scan + len) { [INFO] [stderr] 475 | | break; [INFO] [stderr] 476 | | } [INFO] [stderr] ... | [INFO] [stderr] 482 | | scsc = scsc + 1isize; [INFO] [stderr] 483 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop20` [INFO] [stderr] --> src/diff.rs:539:13 [INFO] [stderr] | [INFO] [stderr] 539 | / 'loop20: loop { [INFO] [stderr] 540 | | if !(i < overlap) { [INFO] [stderr] 541 | | break; [INFO] [stderr] 542 | | } [INFO] [stderr] ... | [INFO] [stderr] 555 | | i = i + 1isize; [INFO] [stderr] 556 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop2` [INFO] [stderr] --> src/diff.rs:452:5 [INFO] [stderr] | [INFO] [stderr] 452 | / 'loop2: loop { [INFO] [stderr] 453 | | if !(scan < req.newsize) { [INFO] [stderr] 454 | | break; [INFO] [stderr] 455 | | } [INFO] [stderr] ... | [INFO] [stderr] 593 | | lastoffset = pos - scan; [INFO] [stderr] 594 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop27` [INFO] [stderr] --> src/diff.rs:580:9 [INFO] [stderr] | [INFO] [stderr] 580 | / 'loop27: loop { [INFO] [stderr] 581 | | if !(i < scan - lenb - (lastscan + lenf)) { [INFO] [stderr] 582 | | break; [INFO] [stderr] 583 | | } [INFO] [stderr] 584 | | *buffer.offset(i) = *req.new.offset(lastscan + lenf + i); [INFO] [stderr] 585 | | i = i + 1isize; [INFO] [stderr] 586 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop14` [INFO] [stderr] --> src/diff.rs:500:9 [INFO] [stderr] | [INFO] [stderr] 500 | / 'loop14: loop { [INFO] [stderr] 501 | | if !(lastscan + i < scan && (lastpos + i < req.oldsize)) { [INFO] [stderr] 502 | | break; [INFO] [stderr] 503 | | } [INFO] [stderr] ... | [INFO] [stderr] 512 | | lenf = i; [INFO] [stderr] 513 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop24` [INFO] [stderr] --> src/diff.rs:569:9 [INFO] [stderr] | [INFO] [stderr] 569 | / 'loop24: loop { [INFO] [stderr] 570 | | if !(i < lenf) { [INFO] [stderr] 571 | | break; [INFO] [stderr] 572 | | } [INFO] [stderr] ... | [INFO] [stderr] 576 | | i = i + 1isize; [INFO] [stderr] 577 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:458:13 [INFO] [stderr] | [INFO] [stderr] 458 | scan = scan + len; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `scan += len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:478:22 [INFO] [stderr] | [INFO] [stderr] 478 | (*req.old.offset(scsc + lastoffset) as (i32) == [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.old.offset(scsc + lastoffset))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:479:21 [INFO] [stderr] | [INFO] [stderr] 479 | *req.new.offset(scsc) as (i32)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.new.offset(scsc))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:480:21 [INFO] [stderr] | [INFO] [stderr] 480 | oldscore = oldscore + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `oldscore += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:482:17 [INFO] [stderr] | [INFO] [stderr] 482 | scsc = scsc + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `scsc += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:488:18 [INFO] [stderr] | [INFO] [stderr] 488 | (*req.old.offset(scan + lastoffset) as (i32) == *req.new.offset(scan) as (i32)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.old.offset(scan + lastoffset))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:488:65 [INFO] [stderr] | [INFO] [stderr] 488 | (*req.old.offset(scan + lastoffset) as (i32) == *req.new.offset(scan) as (i32)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.new.offset(scan))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:489:17 [INFO] [stderr] | [INFO] [stderr] 489 | oldscore = oldscore - 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `oldscore -= 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:491:13 [INFO] [stderr] | [INFO] [stderr] 491 | scan = scan + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `scan += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:504:16 [INFO] [stderr] | [INFO] [stderr] 504 | if *req.old.offset(lastpos + i) as (i32) == *req.new.offset(lastscan + i) as (i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.old.offset(lastpos + i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:504:57 [INFO] [stderr] | [INFO] [stderr] 504 | if *req.old.offset(lastpos + i) as (i32) == *req.new.offset(lastscan + i) as (i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.new.offset(lastscan + i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:505:17 [INFO] [stderr] | [INFO] [stderr] 505 | s = s + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `s += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:507:13 [INFO] [stderr] | [INFO] [stderr] 507 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:523:20 [INFO] [stderr] | [INFO] [stderr] 523 | if *req.old.offset(pos - i) as (i32) == *req.new.offset(scan - i) as (i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.old.offset(pos - i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:523:57 [INFO] [stderr] | [INFO] [stderr] 523 | if *req.old.offset(pos - i) as (i32) == *req.new.offset(scan - i) as (i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.new.offset(scan - i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:524:21 [INFO] [stderr] | [INFO] [stderr] 524 | s = s + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `s += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:530:17 [INFO] [stderr] | [INFO] [stderr] 530 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:543:20 [INFO] [stderr] | [INFO] [stderr] 543 | if *req.new.offset(lastscan + lenf - overlap + i) as (i32) == [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.new.offset(lastscan + lenf - overlap + i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:544:21 [INFO] [stderr] | [INFO] [stderr] 544 | *req.old.offset(lastpos + lenf - overlap + i) as (i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.old.offset(lastpos + lenf - overlap + i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:545:21 [INFO] [stderr] | [INFO] [stderr] 545 | s = s + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `s += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:547:20 [INFO] [stderr] | [INFO] [stderr] 547 | if *req.new.offset(scan - lenb + i) as (i32) == [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.new.offset(scan - lenb + i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:548:21 [INFO] [stderr] | [INFO] [stderr] 548 | *req.old.offset(pos - lenb + i) as (i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.old.offset(pos - lenb + i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:549:21 [INFO] [stderr] | [INFO] [stderr] 549 | s = s - 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `s -= 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:555:17 [INFO] [stderr] | [INFO] [stderr] 555 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:557:13 [INFO] [stderr] | [INFO] [stderr] 557 | lenf = lenf + (lens - overlap); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lenf += (lens - overlap)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:558:13 [INFO] [stderr] | [INFO] [stderr] 558 | lenb = lenb - lens; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `lenb -= lens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:573:34 [INFO] [stderr] | [INFO] [stderr] 573 | *buffer.offset(i) = (*req.new.offset(lastscan + i) as (i32) - [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.new.offset(lastscan + i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:574:37 [INFO] [stderr] | [INFO] [stderr] 574 | *req.old.offset(lastpos + i) as (i32)) as [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.old.offset(lastpos + i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:576:13 [INFO] [stderr] | [INFO] [stderr] 576 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:585:13 [INFO] [stderr] | [INFO] [stderr] 585 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `ctrl`. [INFO] [stderr] --> src/patch.rs:47:18 [INFO] [stderr] | [INFO] [stderr] 47 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 47 | for in &mut ctrl { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/patch.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | y = (buf[7] as (i32) & 0x7Fi32) as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buf[7] as (i32) & 0x7Fi32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/patch.rs:92:10 [INFO] [stderr] | [INFO] [stderr] 92 | y = (buf[7] as (i32) & 0x7Fi32) as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(buf[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | y = y * 256; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | y = y + buf[6] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[6] as (i64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/patch.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | y = y + buf[6] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(buf[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | y = y * 256; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | y = y + buf[5] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[5] as (i64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/patch.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | y = y + buf[5] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(buf[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | y = y * 256; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | y = y + buf[4] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[4] as (i64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/patch.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | y = y + buf[4] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(buf[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | y = y * 256; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | y = y + buf[3] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[3] as (i64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/patch.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | y = y + buf[3] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(buf[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | y = y * 256; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | y = y + buf[2] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[2] as (i64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/patch.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | y = y + buf[2] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(buf[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | y = y * 256; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | y = y + buf[1] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[1] as (i64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/patch.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | y = y + buf[1] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | y = y * 256; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | y = y + buf[0] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[0] as (i64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/patch.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | y = y + buf[0] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/patch.rs:107:8 [INFO] [stderr] | [INFO] [stderr] 107 | if buf[7] as (i32) & 0x80i32 != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(buf[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.60s [INFO] running `"docker" "inspect" "ee540c0dee071c02e1de69a82c5492e503bfdbcc7481e00fadcbde58a18ed56a"` [INFO] running `"docker" "rm" "-f" "ee540c0dee071c02e1de69a82c5492e503bfdbcc7481e00fadcbde58a18ed56a"` [INFO] [stdout] ee540c0dee071c02e1de69a82c5492e503bfdbcc7481e00fadcbde58a18ed56a