[INFO] crate brotli2 0.3.2 is already in cache [INFO] extracting crate brotli2 0.3.2 into work/ex/clippy-test-run/sources/stable/reg/brotli2/0.3.2 [INFO] extracting crate brotli2 0.3.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/brotli2/0.3.2 [INFO] validating manifest of brotli2-0.3.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of brotli2-0.3.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing brotli2-0.3.2 [INFO] finished frobbing brotli2-0.3.2 [INFO] frobbed toml for brotli2-0.3.2 written to work/ex/clippy-test-run/sources/stable/reg/brotli2/0.3.2/Cargo.toml [INFO] started frobbing brotli2-0.3.2 [INFO] finished frobbing brotli2-0.3.2 [INFO] frobbed toml for brotli2-0.3.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/brotli2/0.3.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting brotli2-0.3.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/brotli2/0.3.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7f32b9d11555dabc7d2045864dfdb67b01929f0ed5067fe6bb21f62f06546d87 [INFO] running `"docker" "start" "-a" "7f32b9d11555dabc7d2045864dfdb67b01929f0ed5067fe6bb21f62f06546d87"` [INFO] [stderr] Checking brotli2 v0.3.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/raw.rs:95:26 [INFO] [stderr] | [INFO] [stderr] 95 | Decompress { state: state } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/raw.rs:204:24 [INFO] [stderr] | [INFO] [stderr] 204 | Compress { state: state } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bufread.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bufread.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/write.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/write.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/raw.rs:95:26 [INFO] [stderr] | [INFO] [stderr] 95 | Decompress { state: state } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/raw.rs:204:24 [INFO] [stderr] | [INFO] [stderr] 204 | Compress { state: state } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bufread.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bufread.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/write.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/write.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `raw::Decompress` [INFO] [stderr] --> src/raw.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | / pub fn new() -> Decompress { [INFO] [stderr] 92 | | unsafe { [INFO] [stderr] 93 | | let state = brotli_sys::BrotliDecoderCreateInstance(None, None, 0 as *mut _); [INFO] [stderr] 94 | | assert!(!state.is_null()); [INFO] [stderr] 95 | | Decompress { state: state } [INFO] [stderr] 96 | | } [INFO] [stderr] 97 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 88 | impl Default for raw::Decompress { [INFO] [stderr] 89 | fn default() -> Self { [INFO] [stderr] 90 | Self::new() [INFO] [stderr] 91 | } [INFO] [stderr] 92 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/raw.rs:93:77 [INFO] [stderr] | [INFO] [stderr] 93 | let state = brotli_sys::BrotliDecoderCreateInstance(None, None, 0 as *mut _); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `raw::Compress` [INFO] [stderr] --> src/raw.rs:199:5 [INFO] [stderr] | [INFO] [stderr] 199 | / pub fn new() -> Compress { [INFO] [stderr] 200 | | unsafe { [INFO] [stderr] 201 | | let state = brotli_sys::BrotliEncoderCreateInstance(None, None, 0 as *mut _); [INFO] [stderr] 202 | | assert!(!state.is_null()); [INFO] [stderr] ... | [INFO] [stderr] 205 | | } [INFO] [stderr] 206 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 197 | impl Default for raw::Compress { [INFO] [stderr] 198 | fn default() -> Self { [INFO] [stderr] 199 | Self::new() [INFO] [stderr] 200 | } [INFO] [stderr] 201 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/raw.rs:201:77 [INFO] [stderr] | [INFO] [stderr] 201 | let state = brotli_sys::BrotliEncoderCreateInstance(None, None, 0 as *mut _); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/raw.rs:300:86 [INFO] [stderr] | [INFO] [stderr] 300 | } else if unsafe { brotli_sys::BrotliEncoderHasMoreOutput(self.state) } == 1 { [INFO] [stderr] | ______________________________________________________________________________________^ [INFO] [stderr] 301 | | CoStatus::Unfinished [INFO] [stderr] 302 | | } else if op == CompressOp::Finish && [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/raw.rs:298:37 [INFO] [stderr] | [INFO] [stderr] 298 | } else if available_in != 0 { [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 299 | | CoStatus::Unfinished [INFO] [stderr] 300 | | } else if unsafe { brotli_sys::BrotliEncoderHasMoreOutput(self.state) } == 1 { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bufread.rs:117:37 [INFO] [stderr] | [INFO] [stderr] 117 | self.err = Some(err.clone().into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `err.clone()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bufread.rs:206:41 [INFO] [stderr] | [INFO] [stderr] 206 | self.err = Some(err.clone().into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `err.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `CompressParams` [INFO] [stderr] --> src/lib.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | / pub fn new() -> CompressParams { [INFO] [stderr] 72 | | CompressParams { [INFO] [stderr] 73 | | mode: brotli_sys::BROTLI_DEFAULT_MODE, [INFO] [stderr] 74 | | quality: brotli_sys::BROTLI_DEFAULT_QUALITY, [INFO] [stderr] ... | [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 56 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | self.lgblock.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.lgblock` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | self.lgwin.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.lgwin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `brotli2`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/write.rs:300:38 [INFO] [stderr] | [INFO] [stderr] 300 | let s = repeat("12345").take(100000).collect::(); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/write.rs:304:32 [INFO] [stderr] | [INFO] [stderr] 304 | assert_eq!(data.len(), 500005); [INFO] [stderr] | ^^^^^^ help: consider: `500_005` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/raw.rs:462:17 [INFO] [stderr] | [INFO] [stderr] 462 | let mut input = &mut &b"hello!"[..]; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/raw.rs:472:17 [INFO] [stderr] | [INFO] [stderr] 472 | let mut input = &mut &b"hel"[..]; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/raw.rs:475:17 [INFO] [stderr] | [INFO] [stderr] 475 | let mut input = &mut &b"lo!"[..]; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `raw::Decompress` [INFO] [stderr] --> src/raw.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | / pub fn new() -> Decompress { [INFO] [stderr] 92 | | unsafe { [INFO] [stderr] 93 | | let state = brotli_sys::BrotliDecoderCreateInstance(None, None, 0 as *mut _); [INFO] [stderr] 94 | | assert!(!state.is_null()); [INFO] [stderr] 95 | | Decompress { state: state } [INFO] [stderr] 96 | | } [INFO] [stderr] 97 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 88 | impl Default for raw::Decompress { [INFO] [stderr] 89 | fn default() -> Self { [INFO] [stderr] 90 | Self::new() [INFO] [stderr] 91 | } [INFO] [stderr] 92 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/raw.rs:93:77 [INFO] [stderr] | [INFO] [stderr] 93 | let state = brotli_sys::BrotliDecoderCreateInstance(None, None, 0 as *mut _); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `raw::Compress` [INFO] [stderr] --> src/raw.rs:199:5 [INFO] [stderr] | [INFO] [stderr] 199 | / pub fn new() -> Compress { [INFO] [stderr] 200 | | unsafe { [INFO] [stderr] 201 | | let state = brotli_sys::BrotliEncoderCreateInstance(None, None, 0 as *mut _); [INFO] [stderr] 202 | | assert!(!state.is_null()); [INFO] [stderr] ... | [INFO] [stderr] 205 | | } [INFO] [stderr] 206 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 197 | impl Default for raw::Compress { [INFO] [stderr] 198 | fn default() -> Self { [INFO] [stderr] 199 | Self::new() [INFO] [stderr] 200 | } [INFO] [stderr] 201 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/raw.rs:201:77 [INFO] [stderr] | [INFO] [stderr] 201 | let state = brotli_sys::BrotliEncoderCreateInstance(None, None, 0 as *mut _); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/raw.rs:300:86 [INFO] [stderr] | [INFO] [stderr] 300 | } else if unsafe { brotli_sys::BrotliEncoderHasMoreOutput(self.state) } == 1 { [INFO] [stderr] | ______________________________________________________________________________________^ [INFO] [stderr] 301 | | CoStatus::Unfinished [INFO] [stderr] 302 | | } else if op == CompressOp::Finish && [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/raw.rs:298:37 [INFO] [stderr] | [INFO] [stderr] 298 | } else if available_in != 0 { [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 299 | | CoStatus::Unfinished [INFO] [stderr] 300 | | } else if unsafe { brotli_sys::BrotliEncoderHasMoreOutput(self.state) } == 1 { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bufread.rs:117:37 [INFO] [stderr] | [INFO] [stderr] 117 | self.err = Some(err.clone().into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `err.clone()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bufread.rs:206:41 [INFO] [stderr] | [INFO] [stderr] 206 | self.err = Some(err.clone().into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `err.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/read.rs:149:27 [INFO] [stderr] | [INFO] [stderr] 149 | result.extend(v.iter().map(|x| *x)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `v.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/write.rs:312:9 [INFO] [stderr] | [INFO] [stderr] 312 | c.write(b"").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `CompressParams` [INFO] [stderr] --> src/lib.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | / pub fn new() -> CompressParams { [INFO] [stderr] 72 | | CompressParams { [INFO] [stderr] 73 | | mode: brotli_sys::BROTLI_DEFAULT_MODE, [INFO] [stderr] 74 | | quality: brotli_sys::BROTLI_DEFAULT_QUALITY, [INFO] [stderr] ... | [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 56 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | self.lgblock.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.lgblock` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | self.lgwin.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.lgwin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `brotli2`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "7f32b9d11555dabc7d2045864dfdb67b01929f0ed5067fe6bb21f62f06546d87"` [INFO] running `"docker" "rm" "-f" "7f32b9d11555dabc7d2045864dfdb67b01929f0ed5067fe6bb21f62f06546d87"` [INFO] [stdout] 7f32b9d11555dabc7d2045864dfdb67b01929f0ed5067fe6bb21f62f06546d87