[INFO] crate broadword 0.2.2 is already in cache [INFO] extracting crate broadword 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/broadword/0.2.2 [INFO] extracting crate broadword 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/broadword/0.2.2 [INFO] validating manifest of broadword-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of broadword-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing broadword-0.2.2 [INFO] finished frobbing broadword-0.2.2 [INFO] frobbed toml for broadword-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/broadword/0.2.2/Cargo.toml [INFO] started frobbing broadword-0.2.2 [INFO] finished frobbing broadword-0.2.2 [INFO] frobbed toml for broadword-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/broadword/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting broadword-0.2.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/broadword/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] de2bbe738f44ce5575e72f829de32d7e6c071250687d201a2bf928714c60a9d3 [INFO] running `"docker" "start" "-a" "de2bbe738f44ce5575e72f829de32d7e6c071250687d201a2bf928714c60a9d3"` [INFO] [stderr] Checking broadword v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | let l = r - ((s << 8).wrapping_shr(b as u32) & 0xFF); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:376:10 [INFO] [stderr] | [INFO] [stderr] 376 | e: u64, f: u64, g: u64, h: u64) -> u64 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:376:18 [INFO] [stderr] | [INFO] [stderr] 376 | e: u64, f: u64, g: u64, h: u64) -> u64 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:376:26 [INFO] [stderr] | [INFO] [stderr] 376 | e: u64, f: u64, g: u64, h: u64) -> u64 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:376:34 [INFO] [stderr] | [INFO] [stderr] 376 | e: u64, f: u64, g: u64, h: u64) -> u64 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:382:10 [INFO] [stderr] | [INFO] [stderr] 382 | e: u8, f: u8, g: u8, h: u8) -> u64 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:382:17 [INFO] [stderr] | [INFO] [stderr] 382 | e: u8, f: u8, g: u8, h: u8) -> u64 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:382:24 [INFO] [stderr] | [INFO] [stderr] 382 | e: u8, f: u8, g: u8, h: u8) -> u64 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:382:31 [INFO] [stderr] | [INFO] [stderr] 382 | e: u8, f: u8, g: u8, h: u8) -> u64 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:394:10 [INFO] [stderr] | [INFO] [stderr] 394 | e: i8, f: i8, g: i8, h: i8) -> u64 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:394:17 [INFO] [stderr] | [INFO] [stderr] 394 | e: i8, f: i8, g: i8, h: i8) -> u64 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:394:24 [INFO] [stderr] | [INFO] [stderr] 394 | e: i8, f: i8, g: i8, h: i8) -> u64 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:394:31 [INFO] [stderr] | [INFO] [stderr] 394 | e: i8, f: i8, g: i8, h: i8) -> u64 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | let l = r - ((s << 8).wrapping_shr(b as u32) & 0xFF); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:376:10 [INFO] [stderr] | [INFO] [stderr] 376 | e: u64, f: u64, g: u64, h: u64) -> u64 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:376:18 [INFO] [stderr] | [INFO] [stderr] 376 | e: u64, f: u64, g: u64, h: u64) -> u64 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:376:26 [INFO] [stderr] | [INFO] [stderr] 376 | e: u64, f: u64, g: u64, h: u64) -> u64 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:376:34 [INFO] [stderr] | [INFO] [stderr] 376 | e: u64, f: u64, g: u64, h: u64) -> u64 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:382:10 [INFO] [stderr] | [INFO] [stderr] 382 | e: u8, f: u8, g: u8, h: u8) -> u64 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:382:17 [INFO] [stderr] | [INFO] [stderr] 382 | e: u8, f: u8, g: u8, h: u8) -> u64 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:382:24 [INFO] [stderr] | [INFO] [stderr] 382 | e: u8, f: u8, g: u8, h: u8) -> u64 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:382:31 [INFO] [stderr] | [INFO] [stderr] 382 | e: u8, f: u8, g: u8, h: u8) -> u64 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:394:10 [INFO] [stderr] | [INFO] [stderr] 394 | e: i8, f: i8, g: i8, h: i8) -> u64 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:394:17 [INFO] [stderr] | [INFO] [stderr] 394 | e: i8, f: i8, g: i8, h: i8) -> u64 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:394:24 [INFO] [stderr] | [INFO] [stderr] 394 | e: i8, f: i8, g: i8, h: i8) -> u64 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:394:31 [INFO] [stderr] | [INFO] [stderr] 394 | e: i8, f: i8, g: i8, h: i8) -> u64 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:248:9 [INFO] [stderr] | [INFO] [stderr] 248 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/lib.rs:375:5 [INFO] [stderr] | [INFO] [stderr] 375 | / fn b(a: u64, b: u64, c: u64, d: u64, [INFO] [stderr] 376 | | e: u64, f: u64, g: u64, h: u64) -> u64 { [INFO] [stderr] 377 | | (a << 63) | (b << 55) | (c << 47) | (d << 39) | [INFO] [stderr] 378 | | (e << 31) | (f << 23) | (g << 15) | (h << 7) [INFO] [stderr] 379 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/lib.rs:381:5 [INFO] [stderr] | [INFO] [stderr] 381 | / fn u(a: u8, b: u8, c: u8, d: u8, [INFO] [stderr] 382 | | e: u8, f: u8, g: u8, h: u8) -> u64 { [INFO] [stderr] 383 | | ((a as u64) << 56) [INFO] [stderr] 384 | | | ((b as u64) << 48) [INFO] [stderr] ... | [INFO] [stderr] 390 | | | (h as u64) [INFO] [stderr] 391 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:383:10 [INFO] [stderr] | [INFO] [stderr] 383 | ((a as u64) << 56) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(a)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:384:20 [INFO] [stderr] | [INFO] [stderr] 384 | | ((b as u64) << 48) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:385:20 [INFO] [stderr] | [INFO] [stderr] 385 | | ((c as u64) << 40) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:386:20 [INFO] [stderr] | [INFO] [stderr] 386 | | ((d as u64) << 32) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:387:20 [INFO] [stderr] | [INFO] [stderr] 387 | | ((e as u64) << 24) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:388:20 [INFO] [stderr] | [INFO] [stderr] 388 | | ((f as u64) << 16) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:389:20 [INFO] [stderr] | [INFO] [stderr] 389 | | ((g as u64) << 8) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:390:19 [INFO] [stderr] | [INFO] [stderr] 390 | | (h as u64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/lib.rs:393:5 [INFO] [stderr] | [INFO] [stderr] 393 | / fn i(a: i8, b: i8, c: i8, d: i8, [INFO] [stderr] 394 | | e: i8, f: i8, g: i8, h: i8) -> u64 { [INFO] [stderr] 395 | | u(a as u8, b as u8, c as u8, d as u8, [INFO] [stderr] 396 | | e as u8, f as u8, g as u8, h as u8) [INFO] [stderr] 397 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.78s [INFO] running `"docker" "inspect" "de2bbe738f44ce5575e72f829de32d7e6c071250687d201a2bf928714c60a9d3"` [INFO] running `"docker" "rm" "-f" "de2bbe738f44ce5575e72f829de32d7e6c071250687d201a2bf928714c60a9d3"` [INFO] [stdout] de2bbe738f44ce5575e72f829de32d7e6c071250687d201a2bf928714c60a9d3