[INFO] crate brev 0.1.14 is already in cache [INFO] extracting crate brev 0.1.14 into work/ex/clippy-test-run/sources/stable/reg/brev/0.1.14 [INFO] extracting crate brev 0.1.14 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/brev/0.1.14 [INFO] validating manifest of brev-0.1.14 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of brev-0.1.14 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing brev-0.1.14 [INFO] finished frobbing brev-0.1.14 [INFO] frobbed toml for brev-0.1.14 written to work/ex/clippy-test-run/sources/stable/reg/brev/0.1.14/Cargo.toml [INFO] started frobbing brev-0.1.14 [INFO] finished frobbing brev-0.1.14 [INFO] frobbed toml for brev-0.1.14 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/brev/0.1.14/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting brev-0.1.14 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/brev/0.1.14:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 345e328bacf8eceebe4ea7b448a4f8325e494891872bcb3f5481d3290257a126 [INFO] running `"docker" "start" "-a" "345e328bacf8eceebe4ea7b448a4f8325e494891872bcb3f5481d3290257a126"` [INFO] [stderr] Checking brev v0.1.14 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:47:3 [INFO] [stderr] | [INFO] [stderr] 47 | return (tmp, path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(tmp, path)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:35:3 [INFO] [stderr] | [INFO] [stderr] 35 | env::home_dir().unwrap_or_else( [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:47:3 [INFO] [stderr] | [INFO] [stderr] 47 | return (tmp, path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(tmp, path)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:35:3 [INFO] [stderr] | [INFO] [stderr] 35 | env::home_dir().unwrap_or_else( [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:137:27 [INFO] [stderr] | [INFO] [stderr] 137 | for path in paths.split(":") { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:137:27 [INFO] [stderr] | [INFO] [stderr] 137 | for path in paths.split(":") { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:202:12 [INFO] [stderr] | [INFO] [stderr] 3 | | //! which is great, but sometimes you just want to get in [INFO] [stderr] | |________________________________________________________- help: try this: `if $ dst . write_fmt ( format_args_nl ! ( $ ( $ arg ) * ) ).is_err()` [INFO] [stderr] ... [INFO] [stderr] 202 | if let Err(_) = writeln!(&mut std::io::stderr(), $($arg)*) { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/tests.rs:54:3 [INFO] [stderr] | [INFO] [stderr] 54 | die!(""); [INFO] [stderr] | --------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:202:12 [INFO] [stderr] | [INFO] [stderr] 3 | | //! which is great, but sometimes you just want to get in [INFO] [stderr] | |________________________________________________________- help: try this: `if $ dst . write_fmt ( format_args_nl ! ( $ ( $ arg ) * ) ).is_err()` [INFO] [stderr] ... [INFO] [stderr] 202 | if let Err(_) = writeln!(&mut std::io::stderr(), $($arg)*) { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/tests.rs:55:3 [INFO] [stderr] | [INFO] [stderr] 55 | die!("{} {} {}", 1, 2, 3); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.88s [INFO] running `"docker" "inspect" "345e328bacf8eceebe4ea7b448a4f8325e494891872bcb3f5481d3290257a126"` [INFO] running `"docker" "rm" "-f" "345e328bacf8eceebe4ea7b448a4f8325e494891872bcb3f5481d3290257a126"` [INFO] [stdout] 345e328bacf8eceebe4ea7b448a4f8325e494891872bcb3f5481d3290257a126