[INFO] crate breakpad-symbols 0.1.1 is already in cache [INFO] extracting crate breakpad-symbols 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/breakpad-symbols/0.1.1 [INFO] extracting crate breakpad-symbols 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/breakpad-symbols/0.1.1 [INFO] validating manifest of breakpad-symbols-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of breakpad-symbols-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing breakpad-symbols-0.1.1 [INFO] finished frobbing breakpad-symbols-0.1.1 [INFO] frobbed toml for breakpad-symbols-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/breakpad-symbols/0.1.1/Cargo.toml [INFO] started frobbing breakpad-symbols-0.1.1 [INFO] finished frobbing breakpad-symbols-0.1.1 [INFO] frobbed toml for breakpad-symbols-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/breakpad-symbols/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting breakpad-symbols-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/breakpad-symbols/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cbe05f385845403c40c44d6382c41d8a4babba51bf361261b6e52c644a7b5b77 [INFO] running `"docker" "start" "-a" "cbe05f385845403c40c44d6382c41d8a4babba51bf361261b6e52c644a7b5b77"` [INFO] [stderr] Checking minidump-common v0.1.0 [INFO] [stderr] Checking range-map v0.1.5 [INFO] [stderr] Checking breakpad-symbols v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sym_file/parser.rs:315:9 [INFO] [stderr] | [INFO] [stderr] 315 | files: files, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `files` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sym_file/parser.rs:316:9 [INFO] [stderr] | [INFO] [stderr] 316 | publics: publics, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `publics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:177:32 [INFO] [stderr] | [INFO] [stderr] 177 | SimpleSymbolSupplier { paths : paths } [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `paths` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:229:13 [INFO] [stderr] | [INFO] [stderr] 229 | instruction: instruction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instruction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sym_file/parser.rs:315:9 [INFO] [stderr] | [INFO] [stderr] 315 | files: files, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `files` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sym_file/parser.rs:316:9 [INFO] [stderr] | [INFO] [stderr] 316 | publics: publics, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `publics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:177:32 [INFO] [stderr] | [INFO] [stderr] 177 | SimpleSymbolSupplier { paths : paths } [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `paths` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:229:13 [INFO] [stderr] | [INFO] [stderr] 229 | instruction: instruction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instruction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:32:1 [INFO] [stderr] | [INFO] [stderr] 32 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sym_file/mod.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:32:1 [INFO] [stderr] | [INFO] [stderr] 32 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sym_file/parser.rs:509:18 [INFO] [stderr] | [INFO] [stderr] 509 | address: 0xdeadf00d, rules: "some rules".to_string() [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_f00d` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sym_file/parser.rs:518:18 [INFO] [stderr] | [INFO] [stderr] 518 | address: 0xbadf00d, rules: "init rules".to_string() [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x0bad_f00d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sym_file/parser.rs:530:35 [INFO] [stderr] | [INFO] [stderr] 530 | init: CFIRules { address: 0xbadf00d, rules: "init rules".to_string() }, [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x0bad_f00d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sym_file/parser.rs:533:33 [INFO] [stderr] | [INFO] [stderr] 533 | CFIRules { address: 0xdeadbeef, rules: "more rules".to_string() }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sym_file/parser.rs:534:33 [INFO] [stderr] | [INFO] [stderr] 534 | CFIRules { address: 0xdeadf00d, rules: "some rules".to_string() }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_f00d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sym_file/parser.rs:653:46 [INFO] [stderr] | [INFO] [stderr] 653 | init: CFIRules { address: 0xbadf00d, rules: "init rules".to_string() }, [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x0bad_f00d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sym_file/parser.rs:656:44 [INFO] [stderr] | [INFO] [stderr] 656 | CFIRules { address: 0xdeadbeef, rules: "more rules".to_string() }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sym_file/parser.rs:657:44 [INFO] [stderr] | [INFO] [stderr] 657 | CFIRules { address: 0xdeadf00d, rules: "some rules".to_string() }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_f00d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sym_file/mod.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sym_file/mod.rs:86:44 [INFO] [stderr] | [INFO] [stderr] 86 | assert_eq!(sym.find_nearest_public(0xFFFFFFFF).unwrap().name, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sym_file/parser.rs:144:67 [INFO] [stderr] | [INFO] [stderr] 144 | Some((Range::new(l.address, l.address + l.size as u64 - 1), l)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(l.size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/sym_file/parser.rs:272:1 [INFO] [stderr] | [INFO] [stderr] 272 | / fn symbol_file_from_lines<'a>(lines : Vec>) -> SymbolFile [INFO] [stderr] 273 | | { [INFO] [stderr] 274 | | let mut files = HashMap::new(); [INFO] [stderr] 275 | | let mut publics = vec!(); [INFO] [stderr] ... | [INFO] [stderr] 329 | | } [INFO] [stderr] 330 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sym_file/types.rs:75:49 [INFO] [stderr] | [INFO] [stderr] 75 | Range::new(self.address, self.address + self.size as u64 - 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(self.size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sym_file/types.rs:101:59 [INFO] [stderr] | [INFO] [stderr] 101 | Range::new(self.init.address, self.init.address + self.size as u64 - 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(self.size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sym_file/types.rs:148:49 [INFO] [stderr] | [INFO] [stderr] 148 | Range::new(self.address, self.address + self.size as u64 - 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(self.size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:184:17 [INFO] [stderr] | [INFO] [stderr] 184 | for ref path in self.paths.iter() { [INFO] [stderr] | ^^^^^^^^ ----------------- help: try: `let path = &self.paths.iter();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:349:13 [INFO] [stderr] | [INFO] [stderr] 349 | / match res { [INFO] [stderr] 350 | | &SymbolResult::Ok(ref sym) => sym.fill_symbol(module, frame), [INFO] [stderr] 351 | | _ => {}, [INFO] [stderr] 352 | | } [INFO] [stderr] | |_____________^ help: try this: `if let &SymbolResult::Ok(ref sym) = res { sym.fill_symbol(module, frame) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:349:13 [INFO] [stderr] | [INFO] [stderr] 349 | / match res { [INFO] [stderr] 350 | | &SymbolResult::Ok(ref sym) => sym.fill_symbol(module, frame), [INFO] [stderr] 351 | | _ => {}, [INFO] [stderr] 352 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 349 | match *res { [INFO] [stderr] 350 | SymbolResult::Ok(ref sym) => sym.fill_symbol(module, frame), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sym_file/parser.rs:144:67 [INFO] [stderr] | [INFO] [stderr] 144 | Some((Range::new(l.address, l.address + l.size as u64 - 1), l)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(l.size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/sym_file/parser.rs:272:1 [INFO] [stderr] | [INFO] [stderr] 272 | / fn symbol_file_from_lines<'a>(lines : Vec>) -> SymbolFile [INFO] [stderr] 273 | | { [INFO] [stderr] 274 | | let mut files = HashMap::new(); [INFO] [stderr] 275 | | let mut publics = vec!(); [INFO] [stderr] ... | [INFO] [stderr] 329 | | } [INFO] [stderr] 330 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 50 [INFO] [stderr] --> src/sym_file/parser.rs:540:1 [INFO] [stderr] | [INFO] [stderr] 540 | / fn test_parse_symbol_bytes() { [INFO] [stderr] 541 | | let bytes = &b"MODULE Linux x86 D3096ED481217FD4C16B29CD9BC208BA0 firefox-bin [INFO] [stderr] 542 | | INFO blah blah blah [INFO] [stderr] 543 | | FILE 0 foo.c [INFO] [stderr] ... | [INFO] [stderr] 659 | | }); [INFO] [stderr] 660 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/sym_file/parser.rs:562:16 [INFO] [stderr] | [INFO] [stderr] 562 | assert_eq!(sym.files.get(&0).unwrap(), "foo.c"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&sym.files[&0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/sym_file/parser.rs:563:16 [INFO] [stderr] | [INFO] [stderr] 563 | assert_eq!(sym.files.get(&100).unwrap(), "bar.c"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&sym.files[&100]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sym_file/types.rs:75:49 [INFO] [stderr] | [INFO] [stderr] 75 | Range::new(self.address, self.address + self.size as u64 - 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(self.size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sym_file/types.rs:101:59 [INFO] [stderr] | [INFO] [stderr] 101 | Range::new(self.init.address, self.init.address + self.size as u64 - 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(self.size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sym_file/types.rs:148:49 [INFO] [stderr] | [INFO] [stderr] 148 | Range::new(self.address, self.address + self.size as u64 - 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(self.size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:184:17 [INFO] [stderr] | [INFO] [stderr] 184 | for ref path in self.paths.iter() { [INFO] [stderr] | ^^^^^^^^ ----------------- help: try: `let path = &self.paths.iter();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:349:13 [INFO] [stderr] | [INFO] [stderr] 349 | / match res { [INFO] [stderr] 350 | | &SymbolResult::Ok(ref sym) => sym.fill_symbol(module, frame), [INFO] [stderr] 351 | | _ => {}, [INFO] [stderr] 352 | | } [INFO] [stderr] | |_____________^ help: try this: `if let &SymbolResult::Ok(ref sym) = res { sym.fill_symbol(module, frame) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:349:13 [INFO] [stderr] | [INFO] [stderr] 349 | / match res { [INFO] [stderr] 350 | | &SymbolResult::Ok(ref sym) => sym.fill_symbol(module, frame), [INFO] [stderr] 351 | | _ => {}, [INFO] [stderr] 352 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 349 | match *res { [INFO] [stderr] 350 | SymbolResult::Ok(ref sym) => sym.fill_symbol(module, frame), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.46s [INFO] running `"docker" "inspect" "cbe05f385845403c40c44d6382c41d8a4babba51bf361261b6e52c644a7b5b77"` [INFO] running `"docker" "rm" "-f" "cbe05f385845403c40c44d6382c41d8a4babba51bf361261b6e52c644a7b5b77"` [INFO] [stdout] cbe05f385845403c40c44d6382c41d8a4babba51bf361261b6e52c644a7b5b77