[INFO] crate breakpad 0.1.0 is already in cache [INFO] extracting crate breakpad 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/breakpad/0.1.0 [INFO] extracting crate breakpad 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/breakpad/0.1.0 [INFO] validating manifest of breakpad-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of breakpad-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing breakpad-0.1.0 [INFO] finished frobbing breakpad-0.1.0 [INFO] frobbed toml for breakpad-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/breakpad/0.1.0/Cargo.toml [INFO] started frobbing breakpad-0.1.0 [INFO] finished frobbing breakpad-0.1.0 [INFO] frobbed toml for breakpad-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/breakpad/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting breakpad-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/breakpad/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 72038ebf07ce8a14165c5238028ecbdc63eb1d54a204dd6ca0da01b2db78a38f [INFO] running `"docker" "start" "-a" "72038ebf07ce8a14165c5238028ecbdc63eb1d54a204dd6ca0da01b2db78a38f"` [INFO] [stderr] Compiling breakpad v0.1.0 (/opt/crater/workdir) [INFO] [stderr] Checking uuid v0.5.1 [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/processor.rs:332:13 [INFO] [stderr] | [INFO] [stderr] 332 | mem::transmute(slice) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(slice as *const [*const processor::StackFrame] as *const [&processor::StackFrame])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/processor.rs:378:25 [INFO] [stderr] | [INFO] [stderr] 378 | let formatted = match self { [INFO] [stderr] | _________________________^ [INFO] [stderr] 379 | | &ProcessResult::Ok => "Dump processed successfully", [INFO] [stderr] 380 | | &ProcessResult::MinidumpNotFound => "Minidump file was not found", [INFO] [stderr] 381 | | &ProcessResult::NoMinidumpHeader => "Minidump file had no header", [INFO] [stderr] ... | [INFO] [stderr] 388 | | &ProcessResult::SymbolSupplierInterrupted => "Processing was interrupted (not fatal)", [INFO] [stderr] 389 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 378 | let formatted = match *self { [INFO] [stderr] 379 | ProcessResult::Ok => "Dump processed successfully", [INFO] [stderr] 380 | ProcessResult::MinidumpNotFound => "Minidump file was not found", [INFO] [stderr] 381 | ProcessResult::NoMinidumpHeader => "Minidump file had no header", [INFO] [stderr] 382 | ProcessResult::ErrorNoThreadList => "Minidump file has no thread list", [INFO] [stderr] 383 | ProcessResult::ErrorGettingThread => "Error getting one thread's data", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/processor.rs:492:13 [INFO] [stderr] | [INFO] [stderr] 492 | mem::transmute(slice) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(slice as *const [*const processor::CallStack] as *const [&processor::CallStack])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/processor.rs:332:13 [INFO] [stderr] | [INFO] [stderr] 332 | mem::transmute(slice) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(slice as *const [*const processor::StackFrame] as *const [&processor::StackFrame])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/processor.rs:378:25 [INFO] [stderr] | [INFO] [stderr] 378 | let formatted = match self { [INFO] [stderr] | _________________________^ [INFO] [stderr] 379 | | &ProcessResult::Ok => "Dump processed successfully", [INFO] [stderr] 380 | | &ProcessResult::MinidumpNotFound => "Minidump file was not found", [INFO] [stderr] 381 | | &ProcessResult::NoMinidumpHeader => "Minidump file had no header", [INFO] [stderr] ... | [INFO] [stderr] 388 | | &ProcessResult::SymbolSupplierInterrupted => "Processing was interrupted (not fatal)", [INFO] [stderr] 389 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 378 | let formatted = match *self { [INFO] [stderr] 379 | ProcessResult::Ok => "Dump processed successfully", [INFO] [stderr] 380 | ProcessResult::MinidumpNotFound => "Minidump file was not found", [INFO] [stderr] 381 | ProcessResult::NoMinidumpHeader => "Minidump file had no header", [INFO] [stderr] 382 | ProcessResult::ErrorNoThreadList => "Minidump file has no thread list", [INFO] [stderr] 383 | ProcessResult::ErrorGettingThread => "Error getting one thread's data", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/processor.rs:492:13 [INFO] [stderr] | [INFO] [stderr] 492 | mem::transmute(slice) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(slice as *const [*const processor::CallStack] as *const [&processor::CallStack])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> tests/common/mod.rs:51:45 [INFO] [stderr] | [INFO] [stderr] 51 | let snapshot = load_file(snapshot_path).unwrap_or("".into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> tests/common/mod.rs:51:45 [INFO] [stderr] | [INFO] [stderr] 51 | let snapshot = load_file(snapshot_path).unwrap_or("".into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.65s [INFO] running `"docker" "inspect" "72038ebf07ce8a14165c5238028ecbdc63eb1d54a204dd6ca0da01b2db78a38f"` [INFO] running `"docker" "rm" "-f" "72038ebf07ce8a14165c5238028ecbdc63eb1d54a204dd6ca0da01b2db78a38f"` [INFO] [stdout] 72038ebf07ce8a14165c5238028ecbdc63eb1d54a204dd6ca0da01b2db78a38f