[INFO] crate bracket_parse 0.1.3 is already in cache [INFO] extracting crate bracket_parse 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/bracket_parse/0.1.3 [INFO] extracting crate bracket_parse 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bracket_parse/0.1.3 [INFO] validating manifest of bracket_parse-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bracket_parse-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bracket_parse-0.1.3 [INFO] finished frobbing bracket_parse-0.1.3 [INFO] frobbed toml for bracket_parse-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/bracket_parse/0.1.3/Cargo.toml [INFO] started frobbing bracket_parse-0.1.3 [INFO] finished frobbing bracket_parse-0.1.3 [INFO] frobbed toml for bracket_parse-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bracket_parse/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bracket_parse-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bracket_parse/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 264c0db594bead6d100647db68740e335a4fb85f4b83b5356753bd66e8bc82c7 [INFO] running `"docker" "start" "-a" "264c0db594bead6d100647db68740e335a4fb85f4b83b5356753bd66e8bc82c7"` [INFO] [stderr] Checking bracket_parse v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/tail.rs:71:30 [INFO] [stderr] | [INFO] [stderr] 71 | Tail::Rest(v)=>v.into_iter(), [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/tail.rs:72:30 [INFO] [stderr] | [INFO] [stderr] 72 | _=>EMPTY_B_SLICE.into_iter(), [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:93:12 [INFO] [stderr] | [INFO] [stderr] 93 | if curr.len() >0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!curr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:110:12 [INFO] [stderr] | [INFO] [stderr] 110 | if s.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:217:5 [INFO] [stderr] | [INFO] [stderr] 217 | / pub fn head<'a>(&'a self)->&'a Bracket{ [INFO] [stderr] 218 | | match self{ [INFO] [stderr] 219 | | Bracket::Branch(v)=>match v.len(){ [INFO] [stderr] 220 | | 0 => &EMPTY_BRACKET, [INFO] [stderr] ... | [INFO] [stderr] 224 | | } [INFO] [stderr] 225 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:227:5 [INFO] [stderr] | [INFO] [stderr] 227 | / pub fn tail<'a>(&'a self)->Tail<'a>{ [INFO] [stderr] 228 | | match self{ [INFO] [stderr] 229 | | Bracket::Branch(v)=>match v.len(){ [INFO] [stderr] 230 | | 0|1 =>Tail::Empty, [INFO] [stderr] ... | [INFO] [stderr] 234 | | } [INFO] [stderr] 235 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:237:5 [INFO] [stderr] | [INFO] [stderr] 237 | / pub fn tail_n<'a>(&'a self,n:usize)->Tail<'a>{ [INFO] [stderr] 238 | | match self{ [INFO] [stderr] 239 | | Bracket::Branch(v)=>{ [INFO] [stderr] 240 | | if v.len() <= n { [INFO] [stderr] ... | [INFO] [stderr] 246 | | } [INFO] [stderr] 247 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:249:5 [INFO] [stderr] | [INFO] [stderr] 249 | / pub fn tail_h<'a>(&'a self, n:usize)->&'a Bracket{ [INFO] [stderr] 250 | | match self{ [INFO] [stderr] 251 | | Bracket::Branch(v)=>{ [INFO] [stderr] 252 | | if v.len() <= n{ [INFO] [stderr] ... | [INFO] [stderr] 258 | | } [INFO] [stderr] 259 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:261:5 [INFO] [stderr] | [INFO] [stderr] 261 | / pub fn head_tail<'a>(&'a self)->(&'a Bracket,Tail<'a>){ [INFO] [stderr] 262 | | (self.head(),self.tail()) [INFO] [stderr] 263 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:265:5 [INFO] [stderr] | [INFO] [stderr] 265 | / pub fn match_str<'a>(&'a self)->&'a str{ [INFO] [stderr] 266 | | match self { [INFO] [stderr] 267 | | Bracket::Leaf(ref s)=>s.as_ref(), [INFO] [stderr] 268 | | _=>"", [INFO] [stderr] 269 | | } [INFO] [stderr] 270 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `bracket_parse`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/tail.rs:71:30 [INFO] [stderr] | [INFO] [stderr] 71 | Tail::Rest(v)=>v.into_iter(), [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/tail.rs:72:30 [INFO] [stderr] | [INFO] [stderr] 72 | _=>EMPTY_B_SLICE.into_iter(), [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:93:12 [INFO] [stderr] | [INFO] [stderr] 93 | if curr.len() >0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!curr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:110:12 [INFO] [stderr] | [INFO] [stderr] 110 | if s.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:217:5 [INFO] [stderr] | [INFO] [stderr] 217 | / pub fn head<'a>(&'a self)->&'a Bracket{ [INFO] [stderr] 218 | | match self{ [INFO] [stderr] 219 | | Bracket::Branch(v)=>match v.len(){ [INFO] [stderr] 220 | | 0 => &EMPTY_BRACKET, [INFO] [stderr] ... | [INFO] [stderr] 224 | | } [INFO] [stderr] 225 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:227:5 [INFO] [stderr] | [INFO] [stderr] 227 | / pub fn tail<'a>(&'a self)->Tail<'a>{ [INFO] [stderr] 228 | | match self{ [INFO] [stderr] 229 | | Bracket::Branch(v)=>match v.len(){ [INFO] [stderr] 230 | | 0|1 =>Tail::Empty, [INFO] [stderr] ... | [INFO] [stderr] 234 | | } [INFO] [stderr] 235 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:237:5 [INFO] [stderr] | [INFO] [stderr] 237 | / pub fn tail_n<'a>(&'a self,n:usize)->Tail<'a>{ [INFO] [stderr] 238 | | match self{ [INFO] [stderr] 239 | | Bracket::Branch(v)=>{ [INFO] [stderr] 240 | | if v.len() <= n { [INFO] [stderr] ... | [INFO] [stderr] 246 | | } [INFO] [stderr] 247 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:249:5 [INFO] [stderr] | [INFO] [stderr] 249 | / pub fn tail_h<'a>(&'a self, n:usize)->&'a Bracket{ [INFO] [stderr] 250 | | match self{ [INFO] [stderr] 251 | | Bracket::Branch(v)=>{ [INFO] [stderr] 252 | | if v.len() <= n{ [INFO] [stderr] ... | [INFO] [stderr] 258 | | } [INFO] [stderr] 259 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:261:5 [INFO] [stderr] | [INFO] [stderr] 261 | / pub fn head_tail<'a>(&'a self)->(&'a Bracket,Tail<'a>){ [INFO] [stderr] 262 | | (self.head(),self.tail()) [INFO] [stderr] 263 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:265:5 [INFO] [stderr] | [INFO] [stderr] 265 | / pub fn match_str<'a>(&'a self)->&'a str{ [INFO] [stderr] 266 | | match self { [INFO] [stderr] 267 | | Bracket::Leaf(ref s)=>s.as_ref(), [INFO] [stderr] 268 | | _=>"", [INFO] [stderr] 269 | | } [INFO] [stderr] 270 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `bracket_parse`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "264c0db594bead6d100647db68740e335a4fb85f4b83b5356753bd66e8bc82c7"` [INFO] running `"docker" "rm" "-f" "264c0db594bead6d100647db68740e335a4fb85f4b83b5356753bd66e8bc82c7"` [INFO] [stdout] 264c0db594bead6d100647db68740e335a4fb85f4b83b5356753bd66e8bc82c7