[INFO] crate bpfjit 0.1.1 is already in cache [INFO] extracting crate bpfjit 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/bpfjit/0.1.1 [INFO] extracting crate bpfjit 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bpfjit/0.1.1 [INFO] validating manifest of bpfjit-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bpfjit-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bpfjit-0.1.1 [INFO] finished frobbing bpfjit-0.1.1 [INFO] frobbed toml for bpfjit-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/bpfjit/0.1.1/Cargo.toml [INFO] started frobbing bpfjit-0.1.1 [INFO] finished frobbing bpfjit-0.1.1 [INFO] frobbed toml for bpfjit-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bpfjit/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bpfjit-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bpfjit/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0f46bcf822b0779113493c806dfe02f2afa4c8381cdde791850ab24082dff9c4 [INFO] running `"docker" "start" "-a" "0f46bcf822b0779113493c806dfe02f2afa4c8381cdde791850ab24082dff9c4"` [INFO] [stderr] Compiling bpfjit v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'gcc::Config': gcc::Config has been renamed to gcc::Build [INFO] [stderr] --> build.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | gcc::Config::new() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'gcc::Build::new': crate has been renamed to `cc`, the `gcc` name is not maintained [INFO] [stderr] --> build.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | gcc::Config::new() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: src/bpf_jit_machdep.c: In function 'emit_length': [INFO] [stderr] warning: src/bpf_jit_machdep.c:65:52: warning: unused parameter 'value' [-Wunused-parameter] [INFO] [stderr] warning: emit_length(bpf_bin_stream *stream, __unused u_int value, u_int len) [INFO] [stderr] warning: ^~~~~ [INFO] [stderr] warning: src/bpf_jit_machdep.c: In function 'bpf_jit_compile': [INFO] [stderr] warning: src/bpf_jit_machdep.c:614:4: warning: implicit declaration of function 'perror' [-Wimplicit-function-declaration] [INFO] [stderr] warning: perror("fuck"); [INFO] [stderr] warning: ^~~~~~ [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:73:43 [INFO] [stderr] | [INFO] [stderr] 73 | bpf_insn { code: 0x28, jt: 0, jf: 0, k: 0x0000000c }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_000c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:74:43 [INFO] [stderr] | [INFO] [stderr] 74 | bpf_insn { code: 0x15, jt: 8, jf: 0, k: 0x000086dd }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_86dd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:75:43 [INFO] [stderr] | [INFO] [stderr] 75 | bpf_insn { code: 0x15, jt: 0, jf: 7, k: 0x00000800 }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:76:43 [INFO] [stderr] | [INFO] [stderr] 76 | bpf_insn { code: 0x30, jt: 0, jf: 0, k: 0x00000017 }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0017` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:77:43 [INFO] [stderr] | [INFO] [stderr] 77 | bpf_insn { code: 0x15, jt: 0, jf: 5, k: 0x00000006 }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0006` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:78:43 [INFO] [stderr] | [INFO] [stderr] 78 | bpf_insn { code: 0x20, jt: 0, jf: 0, k: 0x0000001a }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_001a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:79:43 [INFO] [stderr] | [INFO] [stderr] 79 | bpf_insn { code: 0x15, jt: 2, jf: 0, k: 0xb9321902 }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xb932_1902` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:80:43 [INFO] [stderr] | [INFO] [stderr] 80 | bpf_insn { code: 0x20, jt: 0, jf: 0, k: 0x0000001e }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_001e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:81:43 [INFO] [stderr] | [INFO] [stderr] 81 | bpf_insn { code: 0x15, jt: 0, jf: 1, k: 0xb9321902 }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xb932_1902` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:82:42 [INFO] [stderr] | [INFO] [stderr] 82 | bpf_insn { code: 0x6, jt: 0, jf: 0, k: 0x0000ffff }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:83:42 [INFO] [stderr] | [INFO] [stderr] 83 | bpf_insn { code: 0x6, jt: 0, jf: 0, k: 0x00000000 }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:111:43 [INFO] [stderr] | [INFO] [stderr] 111 | bpf_insn { code: 0x28, jt: 0, jf: 0, k: 0x0000000c }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_000c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:112:43 [INFO] [stderr] | [INFO] [stderr] 112 | bpf_insn { code: 0x15, jt: 8, jf: 0, k: 0x000086dd }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_86dd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:113:43 [INFO] [stderr] | [INFO] [stderr] 113 | bpf_insn { code: 0x15, jt: 0, jf: 7, k: 0x00000800 }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:114:43 [INFO] [stderr] | [INFO] [stderr] 114 | bpf_insn { code: 0x30, jt: 0, jf: 0, k: 0x00000017 }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0017` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:115:43 [INFO] [stderr] | [INFO] [stderr] 115 | bpf_insn { code: 0x15, jt: 0, jf: 5, k: 0x00000006 }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0006` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:116:43 [INFO] [stderr] | [INFO] [stderr] 116 | bpf_insn { code: 0x20, jt: 0, jf: 0, k: 0x0000001a }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_001a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:117:43 [INFO] [stderr] | [INFO] [stderr] 117 | bpf_insn { code: 0x15, jt: 2, jf: 0, k: 0xb9321902 }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xb932_1902` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:118:43 [INFO] [stderr] | [INFO] [stderr] 118 | bpf_insn { code: 0x20, jt: 0, jf: 0, k: 0x0000001e }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_001e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:119:43 [INFO] [stderr] | [INFO] [stderr] 119 | bpf_insn { code: 0x15, jt: 0, jf: 1, k: 0xb9321902 }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xb932_1902` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:120:42 [INFO] [stderr] | [INFO] [stderr] 120 | bpf_insn { code: 0x6, jt: 0, jf: 0, k: 0x0000ffff }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:121:42 [INFO] [stderr] | [INFO] [stderr] 121 | bpf_insn { code: 0x6, jt: 0, jf: 0, k: 0x00000000 }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/lib.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | assert!(jit_filter.matched(&packet) == true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `jit_filter.matched(&packet)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/lib.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | assert!(cloned_filter.matched(&packet) == true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `cloned_filter.matched(&packet)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.68s [INFO] running `"docker" "inspect" "0f46bcf822b0779113493c806dfe02f2afa4c8381cdde791850ab24082dff9c4"` [INFO] running `"docker" "rm" "-f" "0f46bcf822b0779113493c806dfe02f2afa4c8381cdde791850ab24082dff9c4"` [INFO] [stdout] 0f46bcf822b0779113493c806dfe02f2afa4c8381cdde791850ab24082dff9c4