[INFO] crate boxxy 0.8.0 is already in cache [INFO] extracting crate boxxy 0.8.0 into work/ex/clippy-test-run/sources/stable/reg/boxxy/0.8.0 [INFO] extracting crate boxxy 0.8.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/boxxy/0.8.0 [INFO] validating manifest of boxxy-0.8.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of boxxy-0.8.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing boxxy-0.8.0 [INFO] finished frobbing boxxy-0.8.0 [INFO] frobbed toml for boxxy-0.8.0 written to work/ex/clippy-test-run/sources/stable/reg/boxxy/0.8.0/Cargo.toml [INFO] started frobbing boxxy-0.8.0 [INFO] finished frobbing boxxy-0.8.0 [INFO] frobbed toml for boxxy-0.8.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/boxxy/0.8.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting boxxy-0.8.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/boxxy/0.8.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8233473111e96e7130df5e06ca5668e95e8b50060508f316aefb62659fcc5fe2 [INFO] running `"docker" "start" "-a" "8233473111e96e7130df5e06ca5668e95e8b50060508f316aefb62659fcc5fe2"` [INFO] [stderr] Checking rustls v0.13.1 [INFO] [stderr] Checking caps v0.3.0 [INFO] [stderr] Checking hyper v0.12.23 [INFO] [stderr] Checking tokio-rustls v0.7.2 [INFO] [stderr] Checking hyper-rustls v0.14.0 [INFO] [stderr] Checking boxxy v0.8.0 (/opt/crater/workdir) [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/busybox/disk/ls.rs:99:24 [INFO] [stderr] | [INFO] [stderr] 99 | Some(paths) => paths.into_iter().collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `paths` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/busybox/disk/ls.rs:99:24 [INFO] [stderr] | [INFO] [stderr] 99 | Some(paths) => paths.into_iter().collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `paths` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> examples/ipc-listener.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | w.write(&buf[..n]).expect("write"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> examples/ipc-listener.rs:93:14 [INFO] [stderr] | [INFO] [stderr] 93 | let fd = f.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `f` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> examples/ipc-listener.rs:95:14 [INFO] [stderr] | [INFO] [stderr] 95 | let fd = f.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `boxxy`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> examples/objdump.rs:37:20 [INFO] [stderr] | [INFO] [stderr] 37 | let encoding = match matches.occurrences_of("hex") > 0 { [INFO] [stderr] | ____________________^ [INFO] [stderr] 38 | | true => Encoding::Hex, [INFO] [stderr] 39 | | false => Encoding::Base64, [INFO] [stderr] 40 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if matches.occurrences_of("hex") > 0 { Encoding::Hex } else { Encoding::Base64 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> examples/fingerprint.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / for cert in certs { [INFO] [stderr] 21 | | let fingerprint = { [INFO] [stderr] 22 | | let mut h = crypto::sha2::Sha256::new(); [INFO] [stderr] 23 | | h.input(&cert.0); [INFO] [stderr] ... | [INFO] [stderr] 33 | | break; [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `boxxy`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "8233473111e96e7130df5e06ca5668e95e8b50060508f316aefb62659fcc5fe2"` [INFO] running `"docker" "rm" "-f" "8233473111e96e7130df5e06ca5668e95e8b50060508f316aefb62659fcc5fe2"` [INFO] [stdout] 8233473111e96e7130df5e06ca5668e95e8b50060508f316aefb62659fcc5fe2