[INFO] crate box2d 0.0.2 is already in cache [INFO] extracting crate box2d 0.0.2 into work/ex/clippy-test-run/sources/stable/reg/box2d/0.0.2 [INFO] extracting crate box2d 0.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/box2d/0.0.2 [INFO] validating manifest of box2d-0.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of box2d-0.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing box2d-0.0.2 [INFO] finished frobbing box2d-0.0.2 [INFO] frobbed toml for box2d-0.0.2 written to work/ex/clippy-test-run/sources/stable/reg/box2d/0.0.2/Cargo.toml [INFO] started frobbing box2d-0.0.2 [INFO] finished frobbing box2d-0.0.2 [INFO] frobbed toml for box2d-0.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/box2d/0.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting box2d-0.0.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/box2d/0.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] db8517f491d4e30490eda767a70726769d542390bb24b90516b675464d7d82c6 [INFO] running `"docker" "start" "-a" "db8517f491d4e30490eda767a70726769d542390bb24b90516b675464d7d82c6"` [INFO] [stderr] Checking box2d v0.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:11:16 [INFO] [stderr] | [INFO] [stderr] 11 | return Vec2 {x: x, y: y} [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:11:22 [INFO] [stderr] | [INFO] [stderr] 11 | return Vec2 {x: x, y: y} [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world.rs:20:17 [INFO] [stderr] | [INFO] [stderr] 20 | return World{ gravity: gravity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `gravity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/body.rs:35:16 [INFO] [stderr] | [INFO] [stderr] 35 | return Body{ id: id, shape: body_def.shape, body_type: body_def.body_type, position: body_def.position, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collision/collider_result.rs:10:31 [INFO] [stderr] | [INFO] [stderr] 10 | return ColliderResult{manifold: manifold, is_colliding: is_colliding}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `manifold` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collision/collider_result.rs:10:51 [INFO] [stderr] | [INFO] [stderr] 10 | return ColliderResult{manifold: manifold, is_colliding: is_colliding}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_colliding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collision/circle_circle_collider.rs:14:38 [INFO] [stderr] | [INFO] [stderr] 14 | return CircleCircleCollider{ pair: pair } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pair` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collision/circle_line_collider.rs:14:36 [INFO] [stderr] | [INFO] [stderr] 14 | return CircleLineCollider{ pair: pair } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pair` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collision/circle_chain_line_collider.rs:14:41 [INFO] [stderr] | [INFO] [stderr] 14 | return CircleChainLineCollider{ pair: pair } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pair` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collision/polygon_polygon_collider.rs:14:40 [INFO] [stderr] | [INFO] [stderr] 14 | return PolygonPolygonCollider{ pair: pair } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pair` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/manifold.rs:14:26 [INFO] [stderr] | [INFO] [stderr] 14 | return Manifold{ body_a: body_a, body_b: body_b, normal: normal, penetration: penetration }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `body_a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/manifold.rs:14:42 [INFO] [stderr] | [INFO] [stderr] 14 | return Manifold{ body_a: body_a, body_b: body_b, normal: normal, penetration: penetration }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `body_b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/manifold.rs:14:58 [INFO] [stderr] | [INFO] [stderr] 14 | return Manifold{ body_a: body_a, body_b: body_b, normal: normal, penetration: penetration }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `normal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/manifold.rs:14:74 [INFO] [stderr] | [INFO] [stderr] 14 | return Manifold{ body_a: body_a, body_b: body_b, normal: normal, penetration: penetration }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `penetration` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:11:16 [INFO] [stderr] | [INFO] [stderr] 11 | return Vec2 {x: x, y: y} [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:11:22 [INFO] [stderr] | [INFO] [stderr] 11 | return Vec2 {x: x, y: y} [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world.rs:20:17 [INFO] [stderr] | [INFO] [stderr] 20 | return World{ gravity: gravity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `gravity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/body.rs:35:16 [INFO] [stderr] | [INFO] [stderr] 35 | return Body{ id: id, shape: body_def.shape, body_type: body_def.body_type, position: body_def.position, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collision/collider_result.rs:10:31 [INFO] [stderr] | [INFO] [stderr] 10 | return ColliderResult{manifold: manifold, is_colliding: is_colliding}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `manifold` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collision/collider_result.rs:10:51 [INFO] [stderr] | [INFO] [stderr] 10 | return ColliderResult{manifold: manifold, is_colliding: is_colliding}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_colliding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collision/circle_circle_collider.rs:14:38 [INFO] [stderr] | [INFO] [stderr] 14 | return CircleCircleCollider{ pair: pair } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pair` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collision/circle_line_collider.rs:14:36 [INFO] [stderr] | [INFO] [stderr] 14 | return CircleLineCollider{ pair: pair } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pair` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collision/circle_chain_line_collider.rs:14:41 [INFO] [stderr] | [INFO] [stderr] 14 | return CircleChainLineCollider{ pair: pair } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pair` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collision/polygon_polygon_collider.rs:14:40 [INFO] [stderr] | [INFO] [stderr] 14 | return PolygonPolygonCollider{ pair: pair } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pair` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/manifold.rs:14:26 [INFO] [stderr] | [INFO] [stderr] 14 | return Manifold{ body_a: body_a, body_b: body_b, normal: normal, penetration: penetration }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `body_a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/manifold.rs:14:42 [INFO] [stderr] | [INFO] [stderr] 14 | return Manifold{ body_a: body_a, body_b: body_b, normal: normal, penetration: penetration }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `body_b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/manifold.rs:14:58 [INFO] [stderr] | [INFO] [stderr] 14 | return Manifold{ body_a: body_a, body_b: body_b, normal: normal, penetration: penetration }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `normal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/manifold.rs:14:74 [INFO] [stderr] | [INFO] [stderr] 14 | return Manifold{ body_a: body_a, body_b: body_b, normal: normal, penetration: penetration }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `penetration` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math.rs:11:3 [INFO] [stderr] | [INFO] [stderr] 11 | return Vec2 {x: x, y: y} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec2 {x: x, y: y}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math.rs:15:3 [INFO] [stderr] | [INFO] [stderr] 15 | return Vec2 {x: 0.0, y: 0.0} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec2 {x: 0.0, y: 0.0}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math.rs:24:3 [INFO] [stderr] | [INFO] [stderr] 24 | return self.x * o.x + self.y * o.y; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.x * o.x + self.y * o.y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math.rs:28:3 [INFO] [stderr] | [INFO] [stderr] 28 | return f32::sqrt(self.x * self.x + self.y * self.y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `f32::sqrt(self.x * self.x + self.y * self.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math.rs:32:3 [INFO] [stderr] | [INFO] [stderr] 32 | return Vec2 {x: self.x * n, y: self.y * n}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec2 {x: self.x * n, y: self.y * n}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math.rs:36:3 [INFO] [stderr] | [INFO] [stderr] 36 | return Vec2 {x: self.x / n, y: self.y / n}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec2 {x: self.x / n, y: self.y / n}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math.rs:44:3 [INFO] [stderr] | [INFO] [stderr] 44 | return self.divide(length); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.divide(length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math.rs:52:3 [INFO] [stderr] | [INFO] [stderr] 52 | return Vec2::new(self.x + _rhs.x, self.y + _rhs.y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec2::new(self.x + _rhs.x, self.y + _rhs.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math.rs:60:3 [INFO] [stderr] | [INFO] [stderr] 60 | return Vec2::new(self.x - _rhs.x, self.y - _rhs.y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec2::new(self.x - _rhs.x, self.y - _rhs.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/world.rs:20:3 [INFO] [stderr] | [INFO] [stderr] 20 | return World{ gravity: gravity, [INFO] [stderr] | _________^ [INFO] [stderr] 21 | | broad_phase: Box::new(DefaultBroadPhase::new()), [INFO] [stderr] 22 | | narrow_phase: Box::new(DefaultNarrowPhase::new()), [INFO] [stderr] 23 | | bodies: Vec::new() } [INFO] [stderr] | |________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 20 | World{ gravity: gravity, [INFO] [stderr] 21 | broad_phase: Box::new(DefaultBroadPhase::new()), [INFO] [stderr] 22 | narrow_phase: Box::new(DefaultNarrowPhase::new()), [INFO] [stderr] 23 | bodies: Vec::new() } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this looks like an `else if` but the `else` is missing [INFO] [stderr] --> src/world.rs:87:18 [INFO] [stderr] | [INFO] [stderr] 87 | } if body_b.mass != 0.0 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::suspicious_else_formatting)] on by default [INFO] [stderr] = note: to remove this lint, add the missing `else` or add a new line before the second `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/body.rs:35:3 [INFO] [stderr] | [INFO] [stderr] 35 | return Body{ id: id, shape: body_def.shape, body_type: body_def.body_type, position: body_def.position, [INFO] [stderr] | _________^ [INFO] [stderr] 36 | | velocity: body_def.velocity, restitution: body_def.restitution, mass: body_def.mass, gravity_scale: body_def.gravity_scale}; [INFO] [stderr] | |________________________________________________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 35 | Body{ id: id, shape: body_def.shape, body_type: body_def.body_type, position: body_def.position, [INFO] [stderr] 36 | velocity: body_def.velocity, restitution: body_def.restitution, mass: body_def.mass, gravity_scale: body_def.gravity_scale} [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/shape/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod shape; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/collision/collider_result.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | return ColliderResult{manifold: manifold, is_colliding: is_colliding}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ColliderResult{manifold: manifold, is_colliding: is_colliding}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/collision/collider_result.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | return ColliderResult{manifold: None, is_colliding: false}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ColliderResult{manifold: None, is_colliding: false}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/collision/circle_circle_collider.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | return CircleCircleCollider{ pair: pair } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CircleCircleCollider{ pair: pair }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/collision/circle_circle_collider.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | return self.pair.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.pair.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/collision/circle_line_collider.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | return CircleLineCollider{ pair: pair } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CircleLineCollider{ pair: pair }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/collision/circle_line_collider.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | return self.pair.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.pair.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/collision/circle_line_collider.rs:55:17 [INFO] [stderr] | [INFO] [stderr] 55 | return ColliderResult::new_empty_false(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ColliderResult::new_empty_false()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/collision/circle_line_collider.rs:49:68 [INFO] [stderr] | [INFO] [stderr] 49 | let offset = distance_vector.normal().multiply((radius - distance_vector.length())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/collision/circle_line_collider.rs:49:68 [INFO] [stderr] | [INFO] [stderr] 49 | let offset = distance_vector.normal().multiply((radius - distance_vector.length())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/collision/circle_chain_line_collider.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | return CircleChainLineCollider{ pair: pair } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CircleChainLineCollider{ pair: pair }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/collision/circle_chain_line_collider.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | return self.pair.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.pair.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/collision/circle_chain_line_collider.rs:64:17 [INFO] [stderr] | [INFO] [stderr] 64 | return ColliderResult::new_empty_false(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ColliderResult::new_empty_false()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/collision/circle_chain_line_collider.rs:57:74 [INFO] [stderr] | [INFO] [stderr] 57 | let offset = closest_line_distance.normal().multiply((radius - closest_line_distance.length())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/collision/circle_chain_line_collider.rs:57:74 [INFO] [stderr] | [INFO] [stderr] 57 | let offset = closest_line_distance.normal().multiply((radius - closest_line_distance.length())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::super::math::Vec2` [INFO] [stderr] --> src/collision/polygon_polygon_collider.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use super::super::math::Vec2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::super::manifold::Manifold` [INFO] [stderr] --> src/collision/polygon_polygon_collider.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use super::super::manifold::Manifold; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/collision/polygon_polygon_collider.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | return PolygonPolygonCollider{ pair: pair } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `PolygonPolygonCollider{ pair: pair }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/collision/polygon_polygon_collider.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | return self.pair.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.pair.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/collision/polygon_polygon_collider.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | return ColliderResult::new_empty_false(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ColliderResult::new_empty_false()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/manifold.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | return Manifold{ body_a: body_a, body_b: body_b, normal: normal, penetration: penetration }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Manifold{ body_a: body_a, body_b: body_b, normal: normal, penetration: penetration }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/default_broad_phase.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | return pairs; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `pairs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/default_broad_phase.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | return DefaultBroadPhase [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DefaultBroadPhase` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/default_narrow_phase.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | return c_results; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `c_results` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/default_narrow_phase.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | return DefaultNarrowPhase [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DefaultNarrowPhase` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this looks like an `else if` but the `else` is missing [INFO] [stderr] --> src/default_collision_resolution.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | } if body_b.mass != 0.0 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, add the missing `else` or add a new line before the second `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/default_collision_resolution.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | return DefaultCollisionResolution [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DefaultCollisionResolution` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: value assigned to `correction` is never read [INFO] [stderr] --> src/world.rs:96:25 [INFO] [stderr] | [INFO] [stderr] 96 | let mut correction = Vec2::new(0.0, 0.0); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `closest_point` is never read [INFO] [stderr] --> src/collision/circle_line_collider.rs:36:25 [INFO] [stderr] | [INFO] [stderr] 36 | let mut closest_point = Vec2::new(0.0, 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `closest_point` is never read [INFO] [stderr] --> src/collision/circle_chain_line_collider.rs:39:29 [INFO] [stderr] | [INFO] [stderr] 39 | let mut closest_point = Vec2::new(0.0, 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `points_a` [INFO] [stderr] --> src/collision/polygon_polygon_collider.rs:26:35 [INFO] [stderr] | [INFO] [stderr] 26 | (PolygonShape{points: points_a}, PolygonShape{points: points_b}) => { [INFO] [stderr] | ^^^^^^^^ help: consider using `_points_a` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `points_b` [INFO] [stderr] --> src/collision/polygon_polygon_collider.rs:26:67 [INFO] [stderr] | [INFO] [stderr] 26 | (PolygonShape{points: points_a}, PolygonShape{points: points_b}) => { [INFO] [stderr] | ^^^^^^^^ help: consider using `_points_b` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `correction` is never read [INFO] [stderr] --> src/default_collision_resolution.rs:42:25 [INFO] [stderr] | [INFO] [stderr] 42 | let mut correction = Vec2::new(0.0, 0.0); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `gravity` [INFO] [stderr] --> src/world.rs:12:2 [INFO] [stderr] | [INFO] [stderr] 12 | gravity: Vec2, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `DefaultCollisionResolution` [INFO] [stderr] --> src/default_collision_resolution.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | pub struct DefaultCollisionResolution; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/default_collision_resolution.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn new() -> DefaultCollisionResolution { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math.rs:11:3 [INFO] [stderr] | [INFO] [stderr] 11 | return Vec2 {x: x, y: y} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec2 {x: x, y: y}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math.rs:15:3 [INFO] [stderr] | [INFO] [stderr] 15 | return Vec2 {x: 0.0, y: 0.0} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec2 {x: 0.0, y: 0.0}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math.rs:24:3 [INFO] [stderr] | [INFO] [stderr] 24 | return self.x * o.x + self.y * o.y; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.x * o.x + self.y * o.y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math.rs:28:3 [INFO] [stderr] | [INFO] [stderr] 28 | return f32::sqrt(self.x * self.x + self.y * self.y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `f32::sqrt(self.x * self.x + self.y * self.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math.rs:32:3 [INFO] [stderr] | [INFO] [stderr] 32 | return Vec2 {x: self.x * n, y: self.y * n}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec2 {x: self.x * n, y: self.y * n}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math.rs:36:3 [INFO] [stderr] | [INFO] [stderr] 36 | return Vec2 {x: self.x / n, y: self.y / n}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec2 {x: self.x / n, y: self.y / n}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math.rs:44:3 [INFO] [stderr] | [INFO] [stderr] 44 | return self.divide(length); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.divide(length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math.rs:52:3 [INFO] [stderr] | [INFO] [stderr] 52 | return Vec2::new(self.x + _rhs.x, self.y + _rhs.y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec2::new(self.x + _rhs.x, self.y + _rhs.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math.rs:60:3 [INFO] [stderr] | [INFO] [stderr] 60 | return Vec2::new(self.x - _rhs.x, self.y - _rhs.y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec2::new(self.x - _rhs.x, self.y - _rhs.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/world.rs:20:3 [INFO] [stderr] | [INFO] [stderr] 20 | return World{ gravity: gravity, [INFO] [stderr] | _________^ [INFO] [stderr] 21 | | broad_phase: Box::new(DefaultBroadPhase::new()), [INFO] [stderr] 22 | | narrow_phase: Box::new(DefaultNarrowPhase::new()), [INFO] [stderr] 23 | | bodies: Vec::new() } [INFO] [stderr] | |________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 20 | World{ gravity: gravity, [INFO] [stderr] 21 | broad_phase: Box::new(DefaultBroadPhase::new()), [INFO] [stderr] 22 | narrow_phase: Box::new(DefaultNarrowPhase::new()), [INFO] [stderr] 23 | bodies: Vec::new() } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this looks like an `else if` but the `else` is missing [INFO] [stderr] --> src/world.rs:87:18 [INFO] [stderr] | [INFO] [stderr] 87 | } if body_b.mass != 0.0 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::suspicious_else_formatting)] on by default [INFO] [stderr] = note: to remove this lint, add the missing `else` or add a new line before the second `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/body.rs:35:3 [INFO] [stderr] | [INFO] [stderr] 35 | return Body{ id: id, shape: body_def.shape, body_type: body_def.body_type, position: body_def.position, [INFO] [stderr] | _________^ [INFO] [stderr] 36 | | velocity: body_def.velocity, restitution: body_def.restitution, mass: body_def.mass, gravity_scale: body_def.gravity_scale}; [INFO] [stderr] | |________________________________________________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 35 | Body{ id: id, shape: body_def.shape, body_type: body_def.body_type, position: body_def.position, [INFO] [stderr] 36 | velocity: body_def.velocity, restitution: body_def.restitution, mass: body_def.mass, gravity_scale: body_def.gravity_scale} [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/shape/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod shape; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/collision/collider_result.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | return ColliderResult{manifold: manifold, is_colliding: is_colliding}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ColliderResult{manifold: manifold, is_colliding: is_colliding}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/collision/collider_result.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | return ColliderResult{manifold: None, is_colliding: false}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ColliderResult{manifold: None, is_colliding: false}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/collision/circle_circle_collider.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | return CircleCircleCollider{ pair: pair } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CircleCircleCollider{ pair: pair }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/collision/circle_circle_collider.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | return self.pair.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.pair.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/collision/circle_line_collider.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | return CircleLineCollider{ pair: pair } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CircleLineCollider{ pair: pair }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/collision/circle_line_collider.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | return self.pair.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.pair.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/collision/circle_line_collider.rs:55:17 [INFO] [stderr] | [INFO] [stderr] 55 | return ColliderResult::new_empty_false(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ColliderResult::new_empty_false()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/collision/circle_line_collider.rs:49:68 [INFO] [stderr] | [INFO] [stderr] 49 | let offset = distance_vector.normal().multiply((radius - distance_vector.length())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/collision/circle_line_collider.rs:49:68 [INFO] [stderr] | [INFO] [stderr] 49 | let offset = distance_vector.normal().multiply((radius - distance_vector.length())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/collision/circle_chain_line_collider.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | return CircleChainLineCollider{ pair: pair } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CircleChainLineCollider{ pair: pair }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/collision/circle_chain_line_collider.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | return self.pair.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.pair.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/collision/circle_chain_line_collider.rs:64:17 [INFO] [stderr] | [INFO] [stderr] 64 | return ColliderResult::new_empty_false(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ColliderResult::new_empty_false()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/collision/circle_chain_line_collider.rs:57:74 [INFO] [stderr] | [INFO] [stderr] 57 | let offset = closest_line_distance.normal().multiply((radius - closest_line_distance.length())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/collision/circle_chain_line_collider.rs:57:74 [INFO] [stderr] | [INFO] [stderr] 57 | let offset = closest_line_distance.normal().multiply((radius - closest_line_distance.length())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::super::math::Vec2` [INFO] [stderr] --> src/collision/polygon_polygon_collider.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use super::super::math::Vec2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::super::manifold::Manifold` [INFO] [stderr] --> src/collision/polygon_polygon_collider.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use super::super::manifold::Manifold; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/collision/polygon_polygon_collider.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | return PolygonPolygonCollider{ pair: pair } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `PolygonPolygonCollider{ pair: pair }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/collision/polygon_polygon_collider.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | return self.pair.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.pair.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/collision/polygon_polygon_collider.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | return ColliderResult::new_empty_false(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ColliderResult::new_empty_false()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/manifold.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | return Manifold{ body_a: body_a, body_b: body_b, normal: normal, penetration: penetration }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Manifold{ body_a: body_a, body_b: body_b, normal: normal, penetration: penetration }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/default_broad_phase.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | return pairs; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `pairs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/default_broad_phase.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | return DefaultBroadPhase [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DefaultBroadPhase` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/default_narrow_phase.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | return c_results; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `c_results` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/default_narrow_phase.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | return DefaultNarrowPhase [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DefaultNarrowPhase` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this looks like an `else if` but the `else` is missing [INFO] [stderr] --> src/default_collision_resolution.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | } if body_b.mass != 0.0 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, add the missing `else` or add a new line before the second `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/default_collision_resolution.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | return DefaultCollisionResolution [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DefaultCollisionResolution` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: variable `timeStep` should have a snake case name such as `time_step` [INFO] [stderr] --> src/world.rs:36:25 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn step(&mut self, timeStep: f32) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/world.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | match result.manifold { [INFO] [stderr] | _________________^ [INFO] [stderr] 48 | | Some(ref manifold) => { [INFO] [stderr] 49 | | manifolds.push((*manifold).clone()); [INFO] [stderr] 50 | | }, [INFO] [stderr] ... | [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 47 | if let Some(ref manifold) = result.manifold { [INFO] [stderr] 48 | manifolds.push((*manifold).clone()); [INFO] [stderr] 49 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variable `timeStep` should have a snake case name such as `time_step` [INFO] [stderr] --> src/body.rs:38:30 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn integrate(&mut self, timeStep: f32) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/collision/collider_factory.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | let ref a_shape = a_body.shape; [INFO] [stderr] | ----^^^^^^^^^^^---------------- help: try: `let a_shape = &a_body.shape;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/collision/collider_factory.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | let ref b_shape = b_body.shape; [INFO] [stderr] | ----^^^^^^^^^^^---------------- help: try: `let b_shape = &b_body.shape;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/broad_phase.rs:4:27 [INFO] [stderr] | [INFO] [stderr] 4 | fn run(&self, bodies: &Vec) -> Vec<(Body, Body)>; [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Body]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/narrow_phase.rs:5:28 [INFO] [stderr] | [INFO] [stderr] 5 | fn run(&self, results: &Vec<(Body, Body)>) -> Vec; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[(Body, Body)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/collision_resolution.rs:4:48 [INFO] [stderr] | [INFO] [stderr] 4 | fn resolve_collisions(&mut self, manifold: &Vec); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Manifold]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: value assigned to `correction` is never read [INFO] [stderr] --> src/world.rs:96:25 [INFO] [stderr] | [INFO] [stderr] 96 | let mut correction = Vec2::new(0.0, 0.0); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `closest_point` is never read [INFO] [stderr] --> src/collision/circle_line_collider.rs:36:25 [INFO] [stderr] | [INFO] [stderr] 36 | let mut closest_point = Vec2::new(0.0, 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `closest_point` is never read [INFO] [stderr] --> src/collision/circle_chain_line_collider.rs:39:29 [INFO] [stderr] | [INFO] [stderr] 39 | let mut closest_point = Vec2::new(0.0, 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `points_a` [INFO] [stderr] --> src/collision/polygon_polygon_collider.rs:26:35 [INFO] [stderr] | [INFO] [stderr] 26 | (PolygonShape{points: points_a}, PolygonShape{points: points_b}) => { [INFO] [stderr] | ^^^^^^^^ help: consider using `_points_a` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `points_b` [INFO] [stderr] --> src/collision/polygon_polygon_collider.rs:26:67 [INFO] [stderr] | [INFO] [stderr] 26 | (PolygonShape{points: points_a}, PolygonShape{points: points_b}) => { [INFO] [stderr] | ^^^^^^^^ help: consider using `_points_b` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `correction` is never read [INFO] [stderr] --> src/default_collision_resolution.rs:42:25 [INFO] [stderr] | [INFO] [stderr] 42 | let mut correction = Vec2::new(0.0, 0.0); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `gravity` [INFO] [stderr] --> src/world.rs:12:2 [INFO] [stderr] | [INFO] [stderr] 12 | gravity: Vec2, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `DefaultCollisionResolution` [INFO] [stderr] --> src/default_collision_resolution.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | pub struct DefaultCollisionResolution; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/default_collision_resolution.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn new() -> DefaultCollisionResolution { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `timeStep` should have a snake case name such as `time_step` [INFO] [stderr] --> src/world.rs:36:25 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn step(&mut self, timeStep: f32) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/world.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | match result.manifold { [INFO] [stderr] | _________________^ [INFO] [stderr] 48 | | Some(ref manifold) => { [INFO] [stderr] 49 | | manifolds.push((*manifold).clone()); [INFO] [stderr] 50 | | }, [INFO] [stderr] ... | [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 47 | if let Some(ref manifold) = result.manifold { [INFO] [stderr] 48 | manifolds.push((*manifold).clone()); [INFO] [stderr] 49 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variable `timeStep` should have a snake case name such as `time_step` [INFO] [stderr] --> src/body.rs:38:30 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn integrate(&mut self, timeStep: f32) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/collision/collider_factory.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | let ref a_shape = a_body.shape; [INFO] [stderr] | ----^^^^^^^^^^^---------------- help: try: `let a_shape = &a_body.shape;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/collision/collider_factory.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | let ref b_shape = b_body.shape; [INFO] [stderr] | ----^^^^^^^^^^^---------------- help: try: `let b_shape = &b_body.shape;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/broad_phase.rs:4:27 [INFO] [stderr] | [INFO] [stderr] 4 | fn run(&self, bodies: &Vec) -> Vec<(Body, Body)>; [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Body]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/narrow_phase.rs:5:28 [INFO] [stderr] | [INFO] [stderr] 5 | fn run(&self, results: &Vec<(Body, Body)>) -> Vec; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[(Body, Body)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/collision_resolution.rs:4:48 [INFO] [stderr] | [INFO] [stderr] 4 | fn resolve_collisions(&mut self, manifold: &Vec); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Manifold]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.86s [INFO] running `"docker" "inspect" "db8517f491d4e30490eda767a70726769d542390bb24b90516b675464d7d82c6"` [INFO] running `"docker" "rm" "-f" "db8517f491d4e30490eda767a70726769d542390bb24b90516b675464d7d82c6"` [INFO] [stdout] db8517f491d4e30490eda767a70726769d542390bb24b90516b675464d7d82c6