[INFO] crate bounds 0.5.0 is already in cache [INFO] extracting crate bounds 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/bounds/0.5.0 [INFO] extracting crate bounds 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bounds/0.5.0 [INFO] validating manifest of bounds-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bounds-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bounds-0.5.0 [INFO] finished frobbing bounds-0.5.0 [INFO] frobbed toml for bounds-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/bounds/0.5.0/Cargo.toml [INFO] started frobbing bounds-0.5.0 [INFO] finished frobbing bounds-0.5.0 [INFO] frobbed toml for bounds-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bounds/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bounds-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bounds/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dd99a57de47472b763b05ed5543782a85ce482f0dff97ba00ff501b9fac6e988 [INFO] running `"docker" "start" "-a" "dd99a57de47472b763b05ed5543782a85ce482f0dff97ba00ff501b9fac6e988"` [INFO] [stderr] Checking bounds v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:350:5 [INFO] [stderr] | [INFO] [stderr] 350 | return Comparison::Intersects; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Comparison::Intersects` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:312:13 [INFO] [stderr] | [INFO] [stderr] 312 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 313 | | if a.value >= y.value { return Comparison::Greater; } [INFO] [stderr] 314 | | } [INFO] [stderr] | |_____________________^ help: try: `if a.value >= y.value { return Comparison::Greater; }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:319:13 [INFO] [stderr] | [INFO] [stderr] 319 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 320 | | if b.value <= x.value { return Comparison::Less; } [INFO] [stderr] 321 | | } [INFO] [stderr] | |_____________________^ help: try: `if b.value <= x.value { return Comparison::Less; }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/lib.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | if self.bound_type == BoundType::Inclusive { [INFO] [stderr] | _________________^ [INFO] [stderr] 68 | | true [INFO] [stderr] 69 | | } else { [INFO] [stderr] 70 | | false [INFO] [stderr] 71 | | } [INFO] [stderr] | |_________________^ help: you can reduce it to: `self.bound_type == BoundType::Inclusive` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/lib.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | if self.bound_type == BoundType::Inclusive { [INFO] [stderr] | _________________^ [INFO] [stderr] 89 | | true [INFO] [stderr] 90 | | } else { [INFO] [stderr] 91 | | false [INFO] [stderr] 92 | | } [INFO] [stderr] | |_________________^ help: you can reduce it to: `self.bound_type == BoundType::Inclusive` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:328:5 [INFO] [stderr] | [INFO] [stderr] 328 | if let &Some(ref x) = x { [INFO] [stderr] | _________________^ [INFO] [stderr] 329 | | match x.bound_type { [INFO] [stderr] 330 | | BoundType::Inclusive => { [INFO] [stderr] 331 | | if a < &x.value { return Comparison::Less; } [INFO] [stderr] ... | [INFO] [stderr] 336 | | } [INFO] [stderr] 337 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 328 | if let Some(ref x) = *x { [INFO] [stderr] | ^^^^^^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:331:11 [INFO] [stderr] | [INFO] [stderr] 331 | if a < &x.value { return Comparison::Less; } [INFO] [stderr] | ^^^^-------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `x.value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:334:11 [INFO] [stderr] | [INFO] [stderr] 334 | if a <= &x.value { return Comparison::Less; } [INFO] [stderr] | ^^^^^-------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `x.value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:339:5 [INFO] [stderr] | [INFO] [stderr] 339 | if let &Some(ref y) = y { [INFO] [stderr] | _________________^ [INFO] [stderr] 340 | | match y.bound_type { [INFO] [stderr] 341 | | BoundType::Inclusive => { [INFO] [stderr] 342 | | if a > &y.value { return Comparison::Greater; } [INFO] [stderr] ... | [INFO] [stderr] 347 | | } [INFO] [stderr] 348 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 339 | if let Some(ref y) = *y { [INFO] [stderr] | ^^^^^^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:342:11 [INFO] [stderr] | [INFO] [stderr] 342 | if a > &y.value { return Comparison::Greater; } [INFO] [stderr] | ^^^^-------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `y.value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:345:11 [INFO] [stderr] | [INFO] [stderr] 345 | if a >= &y.value { return Comparison::Greater; } [INFO] [stderr] | ^^^^^-------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `y.value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:350:5 [INFO] [stderr] | [INFO] [stderr] 350 | return Comparison::Intersects; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Comparison::Intersects` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:312:13 [INFO] [stderr] | [INFO] [stderr] 312 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 313 | | if a.value >= y.value { return Comparison::Greater; } [INFO] [stderr] 314 | | } [INFO] [stderr] | |_____________________^ help: try: `if a.value >= y.value { return Comparison::Greater; }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:319:13 [INFO] [stderr] | [INFO] [stderr] 319 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 320 | | if b.value <= x.value { return Comparison::Less; } [INFO] [stderr] 321 | | } [INFO] [stderr] | |_____________________^ help: try: `if b.value <= x.value { return Comparison::Less; }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/lib.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | if self.bound_type == BoundType::Inclusive { [INFO] [stderr] | _________________^ [INFO] [stderr] 68 | | true [INFO] [stderr] 69 | | } else { [INFO] [stderr] 70 | | false [INFO] [stderr] 71 | | } [INFO] [stderr] | |_________________^ help: you can reduce it to: `self.bound_type == BoundType::Inclusive` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/lib.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | if self.bound_type == BoundType::Inclusive { [INFO] [stderr] | _________________^ [INFO] [stderr] 89 | | true [INFO] [stderr] 90 | | } else { [INFO] [stderr] 91 | | false [INFO] [stderr] 92 | | } [INFO] [stderr] | |_________________^ help: you can reduce it to: `self.bound_type == BoundType::Inclusive` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:328:5 [INFO] [stderr] | [INFO] [stderr] 328 | if let &Some(ref x) = x { [INFO] [stderr] | _________________^ [INFO] [stderr] 329 | | match x.bound_type { [INFO] [stderr] 330 | | BoundType::Inclusive => { [INFO] [stderr] 331 | | if a < &x.value { return Comparison::Less; } [INFO] [stderr] ... | [INFO] [stderr] 336 | | } [INFO] [stderr] 337 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 328 | if let Some(ref x) = *x { [INFO] [stderr] | ^^^^^^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:331:11 [INFO] [stderr] | [INFO] [stderr] 331 | if a < &x.value { return Comparison::Less; } [INFO] [stderr] | ^^^^-------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `x.value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:334:11 [INFO] [stderr] | [INFO] [stderr] 334 | if a <= &x.value { return Comparison::Less; } [INFO] [stderr] | ^^^^^-------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `x.value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:339:5 [INFO] [stderr] | [INFO] [stderr] 339 | if let &Some(ref y) = y { [INFO] [stderr] | _________________^ [INFO] [stderr] 340 | | match y.bound_type { [INFO] [stderr] 341 | | BoundType::Inclusive => { [INFO] [stderr] 342 | | if a > &y.value { return Comparison::Greater; } [INFO] [stderr] ... | [INFO] [stderr] 347 | | } [INFO] [stderr] 348 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 339 | if let Some(ref y) = *y { [INFO] [stderr] | ^^^^^^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:342:11 [INFO] [stderr] | [INFO] [stderr] 342 | if a > &y.value { return Comparison::Greater; } [INFO] [stderr] | ^^^^-------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `y.value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:345:11 [INFO] [stderr] | [INFO] [stderr] 345 | if a >= &y.value { return Comparison::Greater; } [INFO] [stderr] | ^^^^^-------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `y.value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 35 [INFO] [stderr] --> src/lib.rs:366:1 [INFO] [stderr] | [INFO] [stderr] 366 | / fn test_intersection() { [INFO] [stderr] 367 | | assert!(Bounds::Exact(42).intersects(&Bounds::Exact(42))); [INFO] [stderr] 368 | | assert!(!Bounds::Exact(42).intersects(&Bounds::Exact(0))); [INFO] [stderr] 369 | | assert!(Bounds::Exact(1).intersects(&Bounds::range(Bound::inclusive(1), Bound::inclusive(3)))); [INFO] [stderr] ... | [INFO] [stderr] 418 | | assert!(Bounds::::from(..).intersects(&Bounds::from(..))); [INFO] [stderr] 419 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.15s [INFO] running `"docker" "inspect" "dd99a57de47472b763b05ed5543782a85ce482f0dff97ba00ff501b9fac6e988"` [INFO] running `"docker" "rm" "-f" "dd99a57de47472b763b05ed5543782a85ce482f0dff97ba00ff501b9fac6e988"` [INFO] [stdout] dd99a57de47472b763b05ed5543782a85ce482f0dff97ba00ff501b9fac6e988