[INFO] crate borrow-bag 1.0.0 is already in cache [INFO] extracting crate borrow-bag 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/borrow-bag/1.0.0 [INFO] extracting crate borrow-bag 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/borrow-bag/1.0.0 [INFO] validating manifest of borrow-bag-1.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of borrow-bag-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing borrow-bag-1.0.0 [INFO] finished frobbing borrow-bag-1.0.0 [INFO] frobbed toml for borrow-bag-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/borrow-bag/1.0.0/Cargo.toml [INFO] started frobbing borrow-bag-1.0.0 [INFO] finished frobbing borrow-bag-1.0.0 [INFO] frobbed toml for borrow-bag-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/borrow-bag/1.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting borrow-bag-1.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/borrow-bag/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 73f1848908a428771967831293f23b68d467e7e87c104494f0da2157f19f7f50 [INFO] running `"docker" "start" "-a" "73f1848908a428771967831293f23b68d467e7e87c104494f0da2157f19f7f50"` [INFO] [stderr] Compiling borrow-bag v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `BorrowBag<()>` [INFO] [stderr] --> src/lib.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | / pub fn new() -> Self { [INFO] [stderr] 66 | | BorrowBag { v: () } [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 59 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `add` on this type; consider implementing the `std::ops::Add` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | / pub fn add(self, t: T) -> (BorrowBag, Handle) [INFO] [stderr] 90 | | where [INFO] [stderr] 91 | | V: Append, [INFO] [stderr] 92 | | { [INFO] [stderr] 93 | | let (v, handle) = Append::append(self.v, t); [INFO] [stderr] 94 | | (BorrowBag { v }, handle) [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/lib.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | drop(handle); // Otherwise it's unused. [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::drop_copy)] on by default [INFO] [stderr] note: argument has type handle::Handle [INFO] [stderr] --> src/lib.rs:112:14 [INFO] [stderr] | [INFO] [stderr] 112 | drop(handle); // Otherwise it's unused. [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `borrow-bag`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let list =` [INFO] [stderr] --> src/append.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | let list = (); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/append.rs:86:55 [INFO] [stderr] | [INFO] [stderr] 86 | let (list, _): ((u8, ()), Handle) = list.append(1u8); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 86 | let (list, _): ((u8, ()), Handle) = ().append(1u8); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `BorrowBag<()>` [INFO] [stderr] --> src/lib.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | / pub fn new() -> Self { [INFO] [stderr] 66 | | BorrowBag { v: () } [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 59 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `add` on this type; consider implementing the `std::ops::Add` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | / pub fn add(self, t: T) -> (BorrowBag, Handle) [INFO] [stderr] 90 | | where [INFO] [stderr] 91 | | V: Append, [INFO] [stderr] 92 | | { [INFO] [stderr] 93 | | let (v, handle) = Append::append(self.v, t); [INFO] [stderr] 94 | | (BorrowBag { v }, handle) [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/lib.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | drop(handle); // Otherwise it's unused. [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::drop_copy)] on by default [INFO] [stderr] note: argument has type handle::Handle [INFO] [stderr] --> src/lib.rs:112:14 [INFO] [stderr] | [INFO] [stderr] 112 | drop(handle); // Otherwise it's unused. [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `borrow-bag`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "73f1848908a428771967831293f23b68d467e7e87c104494f0da2157f19f7f50"` [INFO] running `"docker" "rm" "-f" "73f1848908a428771967831293f23b68d467e7e87c104494f0da2157f19f7f50"` [INFO] [stdout] 73f1848908a428771967831293f23b68d467e7e87c104494f0da2157f19f7f50