[INFO] crate bom 0.1.2 is already in cache [INFO] extracting crate bom 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/bom/0.1.2 [INFO] extracting crate bom 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bom/0.1.2 [INFO] validating manifest of bom-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bom-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bom-0.1.2 [INFO] finished frobbing bom-0.1.2 [INFO] frobbed toml for bom-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/bom/0.1.2/Cargo.toml [INFO] started frobbing bom-0.1.2 [INFO] finished frobbing bom-0.1.2 [INFO] frobbed toml for bom-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bom/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bom-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bom/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1442f2ccc1620be6df3f800fb60938807ba22d9db9df85a7491f2773d6b7c937 [INFO] running `"docker" "start" "-a" "1442f2ccc1620be6df3f800fb60938807ba22d9db9df85a7491f2773d6b7c937"` [INFO] [stderr] Checking bom v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:218:13 [INFO] [stderr] | [INFO] [stderr] 218 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:231:13 [INFO] [stderr] | [INFO] [stderr] 231 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:244:13 [INFO] [stderr] | [INFO] [stderr] 244 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:218:13 [INFO] [stderr] | [INFO] [stderr] 218 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:231:13 [INFO] [stderr] | [INFO] [stderr] 231 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:244:13 [INFO] [stderr] | [INFO] [stderr] 244 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/commands.rs:248:11 [INFO] [stderr] | [INFO] [stderr] 248 | if(n.to_string() == target_ignore_file_name) { continue; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:26:15 [INFO] [stderr] | [INFO] [stderr] 26 | if(!bom_path.exists()) {fs::create_dir(bom_path);} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:34:7 [INFO] [stderr] | [INFO] [stderr] 34 | if(!&boilerplates_path.exists()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:38:7 [INFO] [stderr] | [INFO] [stderr] 38 | if(!&global_ignore_path.exists()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:47:20 [INFO] [stderr] | [INFO] [stderr] 47 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 48 | | if arg_target_project_path == "." { [INFO] [stderr] 49 | | target_project_path = boilerplates_path.join(env::current_dir().unwrap().as_path().file_name().unwrap()); [INFO] [stderr] 50 | | } else { [INFO] [stderr] 51 | | target_project_path = boilerplates_path.join(Path::new(arg_target_project_path).file_name().unwrap()); [INFO] [stderr] 52 | | } [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 47 | } else if arg_target_project_path == "." { [INFO] [stderr] 48 | target_project_path = boilerplates_path.join(env::current_dir().unwrap().as_path().file_name().unwrap()); [INFO] [stderr] 49 | } else { [INFO] [stderr] 50 | target_project_path = boilerplates_path.join(Path::new(arg_target_project_path).file_name().unwrap()); [INFO] [stderr] 51 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:23:11 [INFO] [stderr] | [INFO] [stderr] 23 | match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/commands.rs:248:11 [INFO] [stderr] | [INFO] [stderr] 248 | if(n.to_string() == target_ignore_file_name) { continue; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:26:15 [INFO] [stderr] | [INFO] [stderr] 26 | if(!bom_path.exists()) {fs::create_dir(bom_path);} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:34:7 [INFO] [stderr] | [INFO] [stderr] 34 | if(!&boilerplates_path.exists()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:38:7 [INFO] [stderr] | [INFO] [stderr] 38 | if(!&global_ignore_path.exists()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:47:20 [INFO] [stderr] | [INFO] [stderr] 47 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 48 | | if arg_target_project_path == "." { [INFO] [stderr] 49 | | target_project_path = boilerplates_path.join(env::current_dir().unwrap().as_path().file_name().unwrap()); [INFO] [stderr] 50 | | } else { [INFO] [stderr] 51 | | target_project_path = boilerplates_path.join(Path::new(arg_target_project_path).file_name().unwrap()); [INFO] [stderr] 52 | | } [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 47 | } else if arg_target_project_path == "." { [INFO] [stderr] 48 | target_project_path = boilerplates_path.join(env::current_dir().unwrap().as_path().file_name().unwrap()); [INFO] [stderr] 49 | } else { [INFO] [stderr] 50 | target_project_path = boilerplates_path.join(Path::new(arg_target_project_path).file_name().unwrap()); [INFO] [stderr] 51 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:23:11 [INFO] [stderr] | [INFO] [stderr] 23 | match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `global_ignore_file_names` is never read [INFO] [stderr] --> src/commands.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | let mut global_ignore_file_names: Vec = vec![]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `v` is never read [INFO] [stderr] --> src/commands.rs:183:13 [INFO] [stderr] | [INFO] [stderr] 183 | let mut v: Vec = vec![]; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `v` is never read [INFO] [stderr] --> src/commands.rs:201:13 [INFO] [stderr] | [INFO] [stderr] 201 | let mut v: Vec = vec![]; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `v` is never read [INFO] [stderr] --> src/commands.rs:229:13 [INFO] [stderr] | [INFO] [stderr] 229 | let mut v: Vec = vec![]; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `err` [INFO] [stderr] --> src/main.rs:57:25 [INFO] [stderr] | [INFO] [stderr] 57 | Err(err) => {}, [INFO] [stderr] | ^^^ help: consider using `_err` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/commands.rs:10:93 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn add(relative_target_project_path: &Path, full_target_path: &Path, ignore_file_names: &Vec, global_ignore_path: &str) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/commands.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | write!(screen, "{}", termion::cursor::Restore); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/commands.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | write!(screen, "{}", termion::clear::AfterCursor); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/commands.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | write!(screen, "{}", termion::cursor::Save); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/commands.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | write!(screen, "{}{}", termion::cursor::Restore, termion::cursor::Down(1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `projects` [INFO] [stderr] --> src/commands.rs:116:14 [INFO] [stderr] | [INFO] [stderr] 116 | for i in 0..projects.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 116 | for (i, ) in projects.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/commands.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | write!(screen, "{}", termion::cursor::Down(1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/commands.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | write!(screen, "{}", termion::cursor::Save); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/commands.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | write!(screen, "{}", termion::cursor::Right(4)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/commands.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | write!(screen, "{}", termion::cursor::Restore); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/commands.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | write!(screen, "{}", termion::cursor::Up(projects.len() as u16 + 1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/commands.rs:130:5 [INFO] [stderr] | [INFO] [stderr] 130 | write!(screen, "{}", termion::cursor::Save); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/commands.rs:248:12 [INFO] [stderr] | [INFO] [stderr] 248 | if(n.to_string() == target_ignore_file_name) { continue; } [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 43 [INFO] [stderr] --> src/main.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | / fn main() { [INFO] [stderr] 18 | | let matches = cli::build_cli().get_matches(); [INFO] [stderr] 19 | | let boilerplates_path; [INFO] [stderr] 20 | | let global_ignore_path; [INFO] [stderr] ... | [INFO] [stderr] 247 | | [INFO] [stderr] 248 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: value assigned to `global_ignore_file_names` is never read [INFO] [stderr] --> src/commands.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | let mut global_ignore_file_names: Vec = vec![]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `v` is never read [INFO] [stderr] --> src/commands.rs:183:13 [INFO] [stderr] | [INFO] [stderr] 183 | let mut v: Vec = vec![]; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `v` is never read [INFO] [stderr] --> src/commands.rs:201:13 [INFO] [stderr] | [INFO] [stderr] 201 | let mut v: Vec = vec![]; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `v` is never read [INFO] [stderr] --> src/commands.rs:229:13 [INFO] [stderr] | [INFO] [stderr] 229 | let mut v: Vec = vec![]; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `err` [INFO] [stderr] --> src/main.rs:57:25 [INFO] [stderr] | [INFO] [stderr] 57 | Err(err) => {}, [INFO] [stderr] | ^^^ help: consider using `_err` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:26:37 [INFO] [stderr] | [INFO] [stderr] 26 | if(!bom_path.exists()) {fs::create_dir(bom_path);} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | fs::create_dir(&boilerplates_path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | fs::File::create(&global_ignore_path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:84:12 [INFO] [stderr] | [INFO] [stderr] 84 | if let Some(_) = matches.subcommand_matches("ls") { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 85 | | println!("\nBoilerplate List\n"); [INFO] [stderr] 86 | | [INFO] [stderr] 87 | | commands::list(&boilerplates_path).unwrap(); [INFO] [stderr] 88 | | print!("\n"); [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____- help: try this: `if matches.subcommand_matches("ls").is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:215:16 [INFO] [stderr] | [INFO] [stderr] 215 | if let Some(_) = matches.subcommand_matches("ls") { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 216 | | println!("\n Global ignore files\n"); [INFO] [stderr] 217 | | commands::ignore_list(&global_ignore_path).unwrap(); [INFO] [stderr] 218 | | print!("\n"); [INFO] [stderr] 219 | | } [INFO] [stderr] | |_________- help: try this: `if matches.subcommand_matches("ls").is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/commands.rs:10:93 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn add(relative_target_project_path: &Path, full_target_path: &Path, ignore_file_names: &Vec, global_ignore_path: &str) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/commands.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | write!(screen, "{}", termion::cursor::Restore); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/commands.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | write!(screen, "{}", termion::clear::AfterCursor); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/commands.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | write!(screen, "{}", termion::cursor::Save); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/commands.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | write!(screen, "{}{}", termion::cursor::Restore, termion::cursor::Down(1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `projects` [INFO] [stderr] --> src/commands.rs:116:14 [INFO] [stderr] | [INFO] [stderr] 116 | for i in 0..projects.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 116 | for (i, ) in projects.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/commands.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | write!(screen, "{}", termion::cursor::Down(1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/commands.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | write!(screen, "{}", termion::cursor::Save); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/commands.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | write!(screen, "{}", termion::cursor::Right(4)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/commands.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | write!(screen, "{}", termion::cursor::Restore); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/commands.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | write!(screen, "{}", termion::cursor::Up(projects.len() as u16 + 1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/commands.rs:130:5 [INFO] [stderr] | [INFO] [stderr] 130 | write!(screen, "{}", termion::cursor::Save); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/commands.rs:248:12 [INFO] [stderr] | [INFO] [stderr] 248 | if(n.to_string() == target_ignore_file_name) { continue; } [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 43 [INFO] [stderr] --> src/main.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | / fn main() { [INFO] [stderr] 18 | | let matches = cli::build_cli().get_matches(); [INFO] [stderr] 19 | | let boilerplates_path; [INFO] [stderr] 20 | | let global_ignore_path; [INFO] [stderr] ... | [INFO] [stderr] 247 | | [INFO] [stderr] 248 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:26:37 [INFO] [stderr] | [INFO] [stderr] 26 | if(!bom_path.exists()) {fs::create_dir(bom_path);} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | fs::create_dir(&boilerplates_path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | fs::File::create(&global_ignore_path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:84:12 [INFO] [stderr] | [INFO] [stderr] 84 | if let Some(_) = matches.subcommand_matches("ls") { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 85 | | println!("\nBoilerplate List\n"); [INFO] [stderr] 86 | | [INFO] [stderr] 87 | | commands::list(&boilerplates_path).unwrap(); [INFO] [stderr] 88 | | print!("\n"); [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____- help: try this: `if matches.subcommand_matches("ls").is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:215:16 [INFO] [stderr] | [INFO] [stderr] 215 | if let Some(_) = matches.subcommand_matches("ls") { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 216 | | println!("\n Global ignore files\n"); [INFO] [stderr] 217 | | commands::ignore_list(&global_ignore_path).unwrap(); [INFO] [stderr] 218 | | print!("\n"); [INFO] [stderr] 219 | | } [INFO] [stderr] | |_________- help: try this: `if matches.subcommand_matches("ls").is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.15s [INFO] running `"docker" "inspect" "1442f2ccc1620be6df3f800fb60938807ba22d9db9df85a7491f2773d6b7c937"` [INFO] running `"docker" "rm" "-f" "1442f2ccc1620be6df3f800fb60938807ba22d9db9df85a7491f2773d6b7c937"` [INFO] [stdout] 1442f2ccc1620be6df3f800fb60938807ba22d9db9df85a7491f2773d6b7c937